[01:14:25] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Do some data integrity digging - https://phabricator.wikimedia.org/T212271 (Eileenmcnaughton) [01:15:05] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Do some data integrity digging - https://phabricator.wikimedia.org/T212271 (Eileenmcnaughton) [01:33:12] Fundraising Sprint XML ate my homework, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Make a copy of endowment thank you email in civi - https://phabricator.wikimedia.org/T211797 (MBeat33) I see the Endowment@ option in the dropdown, thank you [07:25:45] Fundraising Sprint Sasquatches can't find us either, Fundraising Sprint They Live, Fundraising Sprint USB stands for underhanded socket bureaucracy, Fundraising Sprint Vestigial tails shoot from the hip, and 5 others: Benevity import errors - https://phabricator.wikimedia.org/T204008 (Eileenmcnaug... [07:27:29] Fundraising Sprint Window dressing is mostly olive oil, Fundraising Sprint XML ate my homework, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: See if we can improve save time for our top donors - https://phabricator.wikimedia.org/T208816 (Eileenmcnaughton) @LeanneS shou... [07:28:56] Fundraising Sprint Window dressing is mostly olive oil, Fundraising Sprint XML ate my homework, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: hand update civi thank you email with current text - https://phabricator.wikimedia.org/T209895 (Eileenmcnaughton) Open→R... [07:30:31] Fundraising Sprint Window dressing is mostly olive oil, Fundraising Sprint XML ate my homework, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: slow loading of contribution tab when many contributions for a contact - https://phabricator.wikimedia.org/T209415 (Eileenmcnaughton) We've deployed... [07:34:12] Fundraising Sprint Sasquatches can't find us either, Fundraising Sprint They Live, Fundraising Sprint USB stands for underhanded socket bureaucracy, Fundraising Sprint Vestigial tails shoot from the hip, and 4 others: Fix performance issue on activities whe... - https://phabricator.wikimedia.org/T204908 [07:34:54] Fundraising Sprint Window dressing is mostly olive oil, Fundraising Sprint XML ate my homework, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-backlog-cleanup-Q3_2017-18: find another way to compile the donor list for the annual report - https://phabricator.wikimedia.org/T118822 (Eilee... [10:52:28] PROBLEM - check_puppetrun on frdb1001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 9 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-client] [10:57:28] PROBLEM - check_puppetrun on frdb1001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 14 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-client] [11:02:26] RECOVERY - check_puppetrun on frdb1001 is OK: OK: Puppet is currently enabled, last run 4 minutes ago with 0 failures [12:25:58] (CR) Thiemo Kreuz (WMDE): [C: +2] Call static function statically [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/479964 (owner: Reedy) [12:56:45] (CR) jerkins-bot: [V: -1] Call static function statically [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/479964 (owner: Reedy) [13:39:11] (PS13) Ejegg: Use ct_id to find completed, avoid race [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/312563 (https://phabricator.wikimedia.org/T143945) [13:51:34] (CR) Ejegg: [C: +2] Add 'forever' to subject line for endowment emails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/480667 (https://phabricator.wikimedia.org/T211797) (owner: Eileen) [13:56:30] (Merged) jenkins-bot: Add 'forever' to subject line for endowment emails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/480667 (https://phabricator.wikimedia.org/T211797) (owner: Eileen) [15:38:39] Fundraising-Backlog: Sort out fr-tech work phone situation - https://phabricator.wikimedia.org/T207511 (cwdent) [15:38:41] Fundraising-Backlog, fundraising-tech-ops: Create icinga alert for connectivity to Ingenico Connect endpoint - https://phabricator.wikimedia.org/T212252 (cwdent) [16:36:47] fundraising-tech-ops: reenable mdadm checkarray on civi1001 after 20181202 - https://phabricator.wikimedia.org/T210786 (Jgreen) Open→Resolved This is restored to normal config. [16:41:08] Wikimedia-Fundraising, Mobile-Content-Service, Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog, Reading-Infrastructure-Team-Backlog (Kanban): Run English 2018 fundraising on apps - https://phabricator.wikimedia.org/T209801 (schoenbaechler) Hey @Mholloway or @JoeWalsh, quickly checkin... [16:46:03] Wikimedia-Fundraising, Mobile-Content-Service, Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog, Reading-Infrastructure-Team-Backlog (Kanban): Run English 2018 fundraising on apps - https://phabricator.wikimedia.org/T209801 (JoeWalsh) @schoenbaechler confirmed, the banners will come d... [17:08:26] (PS1) Ejegg: Clean up duplicate transactions added by PayPal audit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/480795 (https://phabricator.wikimedia.org/T209294) [17:15:12] fr-tech ^^^ seems to do the trick to clean up the duplicate PayPal donations caused by the audit script [17:15:44] I notice there are a few more lately where DonationInterface sends paypal_ec and the listener deduced paypal [17:15:58] so... there might be more to clean up, but I'll treat that as a different ticket [17:17:38] sounds good ejegg, looking now [17:18:02] thanks! [17:21:07] ejegg, I'm curious why you'd have a condition for 'orig' as a clause in the ON statement on line 4678 [17:21:20] should that be a WHERE condition [17:21:35] the other two look ok [17:21:41] jgleeson: it works either way [17:22:14] ah ok [17:22:19] I just liked it in the ON statement to clarify right in the join that I want to split out the two gateways [17:27:36] was just reading up on the ON restrictions (if any) and looks like it's good as you say [17:27:47] taken from dev.mysql.com - The conditional_expr used with ON is any conditional expression of the form that can be used in a WHERE clause. Generally, the ON clause serves for conditions that specify how to join tables, and the WHERE clause restricts which rows to include in the result set. [17:28:24] generally, meaning not exclusively - is how I read that [17:29:29] yeah [17:29:57] there have been a couple times that I really needed to put some restriction in the ON and not in the WHERE, but I forget [17:30:10] I think involving left joins [17:30:18] (CR) Jgleeson: [V: +2 C: +2] "SQL looks good to me!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/480795 (https://phabricator.wikimedia.org/T209294) (owner: Ejegg) [17:30:54] jgleeson: thanks for the double-vote of confidence! But we ususally leave the V+2 to jenkins [17:31:20] (CR) Jgleeson: [V: +1 C: +2] Clean up duplicate transactions added by PayPal audit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/480795 (https://phabricator.wikimedia.org/T209294) (owner: Ejegg) [17:31:27] sorry! [17:31:37] normally it's hidden right? [17:31:46] I just clicked on autopilot [17:35:02] (Merged) jenkins-bot: Clean up duplicate transactions added by PayPal audit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/480795 (https://phabricator.wikimedia.org/T209294) (owner: Ejegg) [17:59:24] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/480807 [17:59:40] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/480807 (owner: Ejegg) [18:00:23] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/480807 (owner: Ejegg) [18:09:19] !log updated fundraising CiviCRM from 8e18485697 to d5c3d5fd17 [18:09:20] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [18:35:35] fr-tech bad situation - we actually have been exporting stale data for 2 days now - anyone want to help figure out the quickest way to get another export out the door? [18:36:06] ejegg: exporting where? [18:36:14] AndyRussG: sorry, context [18:36:14] Ah from civi? [18:36:19] yeah how did that happen? [18:36:24] Silverpop (IBM) mailing list export [18:36:41] so the 'build export file' process is hitting duplicate contact IDs in the staging table [18:37:07] ejegg: what do we do with that export? what's the practical upshot? [18:37:10] and the following job just uploads whatever was the latest data [18:37:21] AndyRussG: send hundreds of thousands of emails asking for donations, [18:37:34] people getting re-emailed with my final final final e-mail? [18:37:35] potentially to people who have given since the last successful export [18:38:05] hrmmm right [18:38:08] so, the staging table should still be intact, which will let us find the contact IDs that occur more than once [18:38:27] maybe there's a data integrity issue in Civi right now letting ppl have two primary emails? [18:38:32] looking [18:38:42] ejegg, would that also relate to eileens end of day email [18:38:58] jgleeson: err, yep, guess soi [18:39:00] so [18:39:15] s/relate/explain/ [18:40:16] so this is in the frdev db server, database 'silverpop' if you want to follow along [18:40:52] the silverpop_export_staging table doesn't have a unique constraint on contact_id, but the silverpop_export table does [18:42:25] select contact_id, count(*) from silverpop_export_staging group by contact_id having count(*) > 1; [18:42:30] phew, it's just one contact_id [18:43:15] and yes, they ended up with two primary email addresses [18:44:19] ok, fixed that [18:44:28] nice! [18:44:42] but we'll want to follow up to figure out how that happened [18:45:00] and also make sure we don't fall back to uploading stale data when the export job fails [18:56:05] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: how did CID=6220811 end up with two primary emails? - https://phabricator.wikimedia.org/T212331 (Ejegg) [18:56:47] Fundraising-Backlog, FR-Email: When bulk email export fails, don't upload stale data - https://phabricator.wikimedia.org/T212332 (Ejegg) [19:24:33] Fundraising-Backlog: Sort out fr-tech work phone situation - https://phabricator.wikimedia.org/T207511 (Dzahn) So... first the technical part: the "notification method" is configured with each individual contact. If a specific user wants to use "notify-by-sms" and not just "by-email" that is up to them, jus... [19:28:19] Fundraising-Backlog: Sort out fr-tech work phone situation - https://phabricator.wikimedia.org/T207511 (Dzahn) So i would say this can be seen completely unrelated from "SRE or not" and even from specific services. You can change any contact (user) to paging if you want to, that can be one member of your con... [19:29:02] Fundraising-Backlog, monitoring: Sort out fr-tech work phone situation - https://phabricator.wikimedia.org/T207511 (Dzahn) [19:32:05] Fundraising-Backlog, monitoring: Sort out fr-tech work phone situation - https://phabricator.wikimedia.org/T207511 (Dzahn) Oh and final comment about the personal vs. work phone thing. There is such a thing as work phones if you get pages and if you want to.You would request those from OIT though. (Zende... [19:34:36] XenoRyet and mepps are we doing our mid-sprint checkin? [19:34:45] no ejegg, see email [19:34:51] oops, sorry! [19:34:59] just as well, I'm eating... [19:35:43] breaking for a little bit, back later. mepps if I don't speak to you again before the holidays, hope you have a great break and all the best for you and the family! [19:36:10] You too jgleeson! [21:20:43] ejegg: hmmm I didn't actually have fpm installed, at least not the deb package [21:22:32] AndyRussG: ok, I guess it depends which module your web server is loading then [21:22:56] must be that yea [21:23:10] Mmm I'm installing fpm just for the fun of it tho [21:28:09] gonna head back downtown - back in a bit [21:40:12] Yeah I didn't do anything special to get to php 7.2, just some Debian package magic [22:30:45] (PS1) Eileen: Add check to prevent invalid sql when nothing to delte [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/480878 [22:57:23] (CR) Ejegg: [C: +2] Add check to prevent invalid sql when nothing to delte [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/480878 (owner: Eileen) [23:01:30] (Merged) jenkins-bot: Add check to prevent invalid sql when nothing to delte [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/480878 (owner: Eileen) [23:10:34] Fundraising-Backlog, Analytics, Analytics-Kanban, User-Elukey: Return to real time banner impressions in Druid - https://phabricator.wikimedia.org/T203669 (Nuria) Per our conversation in standup we are going to kill the job that imports from kafka directly and use eventlogging to druid, there wer... [23:20:08] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/480883 [23:20:26] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/480883 (owner: Eileen) [23:21:05] (Merged) jenkins-bot: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/480883 (owner: Eileen) [23:21:36] !log civicrm revision changed from d5c3d5fd17 to 9d727e4708, config revision is 0f94a475b7 [23:21:37] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log