[00:28:25] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Upgrade CiviCRM to latest version now codefreeze is over - https://phabricator.wikimedia.org/T212825 (Eileenmcnaughton) [03:33:00] (CR) Ejegg: [C: +2] Fix indiscriminate showing (and forgetting) of payment tokens. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/481661 (https://phabricator.wikimedia.org/T212705) (owner: Eileen) [03:33:07] (CR) Ejegg: [C: +2] Disable job to process smashpig recurring. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/481692 (https://phabricator.wikimedia.org/T212727) (owner: Eileen) [03:37:07] (Merged) jenkins-bot: Fix indiscriminate showing (and forgetting) of payment tokens. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/481661 (https://phabricator.wikimedia.org/T212705) (owner: Eileen) [03:38:29] (Merged) jenkins-bot: Disable job to process smashpig recurring. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/481692 (https://phabricator.wikimedia.org/T212727) (owner: Eileen) [14:31:10] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/482026 [14:31:14] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/482026 (owner: Ejegg) [14:32:11] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/482026 (owner: Ejegg) [14:46:10] Fundraising-Backlog, Analytics, Analytics-Kanban, Patch-For-Review, User-Elukey: Return to real time banner impressions in Druid - https://phabricator.wikimedia.org/T203669 (Nuria) Code merged, if @JAllemandou closes job we can close this ticket [15:14:23] (PS1) Umherirrender: Adjust param doc for CentralNotice::getCNSessionVar [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/482038 [15:14:48] !log updated Fundraising CiviCRM from b33dcd3c94 to bcb4b7a7d1 [15:14:49] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [15:17:17] (CR) jerkins-bot: [V: -1] Adjust param doc for CentralNotice::getCNSessionVar [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/482038 (owner: Umherirrender) [15:17:35] (CR) jerkins-bot: [V: -1] Adjust param doc for CentralNotice::getCNSessionVar [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/482038 (owner: Umherirrender) [15:30:04] Fundraising Sprint XML ate my homework, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review, Unplanned-Sprint-Work: Civi Forget Me error? - https://phabricator.wikimedia.org/T212705 (Ejegg) OK, the fix is deployed. But if the donor has an active recurring donation, we need to... [16:04:58] (PS1) Ejegg: Add refundPayment API call for Ingenico PaymentProvider [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/482062 (https://phabricator.wikimedia.org/T212727) [16:05:15] fr-tech ^^^ is the first step for automating refunds in the new Ingenico API [16:05:21] anyone want to review it? [16:35:49] (CR) AndyRussG: "Thanks so much for figuring this out and fixing it!!!!!! Just a few tiny nit-picks :)" (3 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/481091 (https://phabricator.wikimedia.org/T208570) (owner: Ejegg) [16:55:03] (PS5) Ejegg: Mock requestIdleCallback in kvStore test [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/481091 (https://phabricator.wikimedia.org/T208570) [16:55:46] thanks for the CR, AndyRussG ! [17:01:43] ejegg: :) thank u [17:03:44] (CR) Ejegg: Mock requestIdleCallback in kvStore test (3 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/481091 (https://phabricator.wikimedia.org/T208570) (owner: Ejegg) [17:05:43] cstone: do you want to add yourself to some fr-tech projects here? https://www.mediawiki.org/wiki/Git/Reviewers [17:06:10] there's a bot that reads that page and automatically adds you to relevant patches in gerrit [17:06:22] so they show up on your main review screen [17:07:18] ah okay cool [17:07:35] sometimes the bot breaks, but it seems to be happy lately [17:14:14] (CR) AndyRussG: [C: +2] "Great, thanks!!! :)" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/481091 (https://phabricator.wikimedia.org/T208570) (owner: Ejegg) [17:20:00] (Merged) jenkins-bot: Mock requestIdleCallback in kvStore test [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/481091 (https://phabricator.wikimedia.org/T208570) (owner: Ejegg) [17:20:56] ejegg: wikibugs or reviewer-bot? I think I have access so if the bot dies you can ping me to restart it [17:21:17] I think I'm on wikibugs, not on Reviewer Bot though [17:21:49] Hauskatze: reviewer-bot seems to die when it hits certain gerrit errors [17:21:59] like when an account is disabled but still listed on the page [17:22:16] I think I saw that happening in the past, yes [17:22:26] ususally i can just edit the page to make it work again, but sometimes I won't notice for a while [17:22:30] Merjlin van Deen is it's owner iirc [17:22:37] and get frustrated when nobody CRs my patches :) [17:22:47] don't we all? :) [17:22:50] ah yeah, he's pretty responsive on his talk page [17:23:10] btw I got new security alerts for fundraising/.* repos, shall I write them in a task? [17:23:10] * AndyRussG hides [17:23:15] some are tagged 'critical' [17:23:32] Hauskatze: sure, that'd be great. Hopefully it's just dev-dependencies that we don't install [17:23:49] actually, I can probably see them myself at github [17:23:51] looking... [17:24:01] Okay. I'll fetch the email and write a private task. I can add you and AndyRussG I guess? [17:24:11] * Hauskatze waits then [17:24:17] Hauskatze: sure of course! [17:24:25] super [17:24:50] hmm, nothing showing up in my notifications. Hauskatze, would you mind pasting them into a security or nda task? [17:25:06] oh yeah, private task with us is good too [17:25:09] Sure. I can create a private security ticket [17:25:19] I cannot NDA because I don't have it [17:25:30] nor I can use acl*wmf-fr space either [17:28:12] * Hauskatze writting the task [17:28:35] It can take a while. I am finishing a brief [17:30:54] thanks so much! [17:36:41] (PS1) Ejegg: Peg event-stream version to latest non-bugged [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/482083 [17:39:22] (CR) Umherirrender: "recheck" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/482038 (owner: Umherirrender) [17:39:59] (PS2) AndyRussG: Adjust param doc for CentralNotice::getCNSessionVar [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/482038 (owner: Umherirrender) [17:40:34] (CR) AndyRussG: "Rebased after fix for flapping test. Thanks!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/482038 (owner: Umherirrender) [17:43:31] Hauskatze: I think I have a fix for the alert on fundraising-dash [17:43:35] https://gerrit.wikimedia.org/r/482083 [17:43:47] if that's the only one, there's no need for the ticket! [17:44:26] this is one of them, yes [17:44:32] but there are more [17:45:24] (CR) jenkins-bot: Mock requestIdleCallback in kvStore test [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/481091 (https://phabricator.wikimedia.org/T208570) (owner: Ejegg) [17:45:53] (CR) Umherirrender: "Yeah!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/482038 (owner: Umherirrender) [17:59:54] ejegg|afk / AndyRussG -- https://phabricator.wikimedia.org/T212877 [17:59:57] enjoy :) [18:00:33] Hauskatze: thanks much! [18:03:14] (PS3) AndyRussG: build: Update eslint and stylelint configs [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/479731 (owner: Esanders) [18:04:00] (CR) AndyRussG: "(Rebased to follow fix for flapping test.)" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/479731 (owner: Esanders) [18:04:38] (PS5) AndyRussG: Have wgNoticeProjects default to [] [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/471662 (https://phabricator.wikimedia.org/T208694) (owner: MacFan4000) [18:05:06] (CR) AndyRussG: "(Rebased to follow fix for flapping test.)" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/471662 (https://phabricator.wikimedia.org/T208694) (owner: MacFan4000) [18:06:16] (PS3) AndyRussG: Alphabetize hooks in extension.json [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/481040 (owner: Ejegg) [18:06:22] (CR) AndyRussG: "(Rebased to follow fix for flapping test.)" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/481040 (owner: Ejegg) [18:07:14] (PS2) AndyRussG: Add revision tag to CN admin edits [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/481099 (https://phabricator.wikimedia.org/T209795) (owner: Ejegg) [18:08:07] (CR) AndyRussG: "(Rebased to follow fix for flapping test.)" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/481099 (https://phabricator.wikimedia.org/T209795) (owner: Ejegg) [18:09:16] (PS5) AndyRussG: Don't re-protect banner if it's already protected [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/478257 (https://phabricator.wikimedia.org/T210983) (owner: Ejegg) [18:09:21] (CR) AndyRussG: "(Rebased to follow fix for flapping test.)" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/478257 (https://phabricator.wikimedia.org/T210983) (owner: Ejegg) [18:10:19] (PS4) AndyRussG: Make autoprotection log reason localisable [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/475126 (https://phabricator.wikimedia.org/T210102) (owner: MarcoAurelio) [18:10:24] (CR) AndyRussG: "(Rebased to follow fix for flapping test.)" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/475126 (https://phabricator.wikimedia.org/T210102) (owner: MarcoAurelio) [18:17:13] Fundraising-Backlog, fundraising-tech-ops: Create read-only user for civicrm devdb on staging - https://phabricator.wikimedia.org/T212745 (cwdent) @Eileenmcnaughton sure, looking at the grants, would that be just select on dev_*? [18:38:04] Wikimedia-Fundraising-CiviCRM, Continuous-Integration-Infrastructure (Slipway): Migrate wikimedia-fundraising-civicrm to a Docker container - https://phabricator.wikimedia.org/T210287 (greg) [18:38:55] new CentralNotice deploy to wmf_deploy soon? [19:04:57] Hauskatze definitely!!! [21:06:20] Fundraising-Backlog, fundraising-tech-ops: Create read-only user for civicrm devdb on staging - https://phabricator.wikimedia.org/T212745 (Eileenmcnaughton) @cwdent yep [21:08:18] Fundraising Sprint XML ate my homework, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review, Unplanned-Sprint-Work: Civi Forget Me error? - https://phabricator.wikimedia.org/T212705 (Eileenmcnaughton) @Ejegg we only delete some fields ` 'email' => '', 'billing_f... [21:57:17] fr-tech anyone have a minute to review the first patch for the refunds? We should probably do those ASAP [22:02:31] Fundraising Sprint XML ate my homework, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review, Unplanned-Sprint-Work: Civi Forget Me error? - https://phabricator.wikimedia.org/T212705 (Ejegg) OK, we DO send the donor's first & last name and email in the API call for each instal... [22:04:00] (CR) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/482161 (owner: L10n-bot) [22:04:09] Fundraising Sprint XML ate my homework, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review, Unplanned-Sprint-Work: Civi Forget Me error? - https://phabricator.wikimedia.org/T212705 (Eileenmcnaughton) @Ejegg we don't really need to delete those given we retain name data - I t... [22:22:06] (PS2) Ejegg: Add createRefund API call for Ingenico PaymentProvider [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/482062 (https://phabricator.wikimedia.org/T212727) [22:29:12] (PS3) Ejegg: Add createRefund API call for Ingenico PaymentProvider [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/482062 (https://phabricator.wikimedia.org/T212727) [22:45:19] (PS1) Ejegg: Add approveRefund API call [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/482235 (https://phabricator.wikimedia.org/T212727) [22:45:42] (CR) jerkins-bot: [V: -1] Add approveRefund API call [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/482235 (https://phabricator.wikimedia.org/T212727) (owner: Ejegg) [23:05:00] (PS1) Ejegg: WIP batch refund script for Ingenico [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/482239 (https://phabricator.wikimedia.org/T212727) [23:05:17] (CR) jerkins-bot: [V: -1] WIP batch refund script for Ingenico [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/482239 (https://phabricator.wikimedia.org/T212727) (owner: Ejegg) [23:43:55] Fundraising-Backlog, Fr-backlog-cleanup-Q3_2017-18, Zero: Disable fundraising banners for zero rated devices - https://phabricator.wikimedia.org/T105816 (MaxSem)