[00:28:26] (CR) Ejegg: [C: +2] Remove INSERT IGNORE and add ON DUPLICATE KEY UPDATE when building the silverpop_export table. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/483314 (owner: Cstone) [00:28:50] (Merged) jenkins-bot: Remove INSERT IGNORE and add ON DUPLICATE KEY UPDATE when building the silverpop_export table. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/483314 (owner: Cstone) [00:44:12] (PS1) Cstone: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/483319 [00:44:47] (CR) Cstone: [C: +2] Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/483319 (owner: Cstone) [00:44:54] (Merged) jenkins-bot: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/483319 (owner: Cstone) [00:56:40] !log updated fundraising tools from 5f44d9dd43 to da82ed111d [00:56:41] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:50:04] Fundraising Sprint A 2019, Fundraising-Backlog, Fr-Ingenico-integration_2017-18: Renew Ingenico production API key - https://phabricator.wikimedia.org/T213216 (Ejegg) On the Ingenico configuration site (https://account.ingenico.com/) we need to click 'API keys' on the left menu, then 'Request API key... [01:55:48] Fundraising Sprint A 2019, Fundraising-Backlog, Fr-Ingenico-integration_2017-18: Renew Ingenico production API key - https://phabricator.wikimedia.org/T213216 (Ejegg) This is done for this year. Since they're only valid for a year, we might think about generating a new on in June or something, so we... [02:29:01] (PS2) Ejegg: PayPal audit: stop shadowing 'queue' from outer scope [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/480538 [02:30:01] (PS3) Ejegg: Delete parser for obsolete audit format [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/454733 [04:14:33] foks: You about? [04:14:41] ya [04:14:52] I just got back to SF from the UK though, so am knackered [04:14:55] but ask away [04:15:09] foks: Actually I just want to show off [04:15:23] oh heh [04:15:25] go for it [04:15:29] foks: I am confident enough that I can now officially say I can code. [04:15:36] I've built this from scratch [04:15:37] Woo!! [04:15:52] https://codepen.io/josephseddon/full/maGWLB [04:16:13] Nice one, dude! [04:17:43] foks: built it in 2 hours with nothing but me and my noggin [04:17:57] Seddon, one tweak - where it says \"cnotice-message\">\n

\"" you have an extra quote at the end [04:18:15] foks: actually i just caught that! :D [04:18:16] instead of

\"" use

" [04:18:23] ha ;) [04:18:26] great minds [04:18:31] you can also use [04:18:34] \t [04:18:36] instead of a tab [04:18:43] (I think, anyway :P ) [04:18:55] oh, you're using four spaces [04:19:02] never mind then :P [04:19:13] This is pretty nifty tho!! [04:19:56] foks: I've definitely had the ability to do this before but never the confidence. I've been doing a web dev course on my compsci masters and handed it in on tuesday [04:20:11] ah nice :) [04:20:21] yeah doing little side things like this really helps pick it up [04:20:46] I was talking about doing this early today and rather than waiting and more importantly sleeping I was like.... fuck it. Lets have a go the concept sounds simple enough [04:21:08] yeah [04:22:30] So yeah. Ending the day on a real positive [04:22:39] and its something I can organically work on over time [04:31:28] yeah man [09:37:32] pcoombe: looky looky - https://codepen.io/josephseddon/full/maGWLB [11:57:32] ooh, that's nifty [12:03:19] pcoombe: It'll be really useful for community members [12:03:50] I need to add in some more functionality [12:04:16] but yeah should be really useful for community people [12:06:24] Seddon: You may want to look into template literals https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals, not supported in IE but it would simplify the code a bit and make it easier to add new features [12:10:57] pcoombe: who cares about IE these days :P [13:06:46] pcoombe: thanks for letting me know about those template literals!! [13:06:55] pcoombe: makes things HUGELY easier [13:08:10] Yeah, I only learned about them last week. They are really helpful for multiline strings [15:07:08] pcoombe: New version https://codepen.io/josephseddon/full/JwawwX now lets you select 1 or two lines of text and options for different types of logo ratios [15:07:36] Next will be a "Is your banner multilingual" [16:51:10] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Epic: Host CentralNotice banners on a dedicated and restricted by default namespace, with proper content model - https://phabricator.wikimedia.org/T213455 (MarcoAurelio) [16:51:32] well just don't hang me for that ^ :) [16:55:47] fr-tech: I dropped the ball on keeping the calendar up to date, but I assume everyone is ok having standup after the staff community time meeting, as per usual? [17:01:45] XenoRyet: I'm meeting up with my wife right after - I'll have to skip it then [17:02:53] Hmm... How many of the rest of us are interested in staff community time? I always like to see what gets said, but we could bail out of it ten mins early if that works for everyone. [17:24:55] wow, erikab ! [17:25:09] congratulations [17:25:44] congratulations erikab!!! <3 [17:27:30] Indeed, congrats, that's awesome! [17:29:38] ^ [17:32:17] ? [17:34:17] XenoRyet: all good [17:36:07] Hauskatze: heh no worries, it's been proposed a few times over the years, and should be done [17:36:35] also btw we ended up delaying the deployment of CentralNotice backlogged changes because of an apparent error [17:36:46] it should go out on next week's train [17:36:50] well, just in case... keep the noose out of my neck :D [17:37:06] In the end the error wasn't ours, but we missed the train this week as a reasult [17:37:38] It's not just merging into wmf_deploy I understand, right? [17:37:45] You'll need a scap [17:38:55] Fundraising Sprint A 2019, Fundraising Sprint Window dressing is mostly olive oil, Fundraising Sprint XML ate my homework, Fundraising-Backlog, and 3 others: Ingenico Connect hosted checkouts - using broken URL? - https://phabricator.wikimedia.org/T210893 (Ejegg) @mepps one patch to add logging i... [17:40:07] (CR) Ejegg: "looks like the tests need an update to match?" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/482356 (owner: Eileen) [17:40:58] Fundraising Sprint A 2019, Fundraising Sprint XML ate my homework, Fundraising-Backlog, Fr-Ingenico-integration_2017-18, Patch-For-Review: currency mismatch between Ingenico Connect & Civi - https://phabricator.wikimedia.org/T211024 (Ejegg) @Eileenmcnaughton No, I think these are actually sep... [17:41:27] Hauskatze: it's ust merging into wmf_deploy accumulated stuff in Master. WRT scap, release engineers will take care of that, as part of the train deploy [18:52:05] (CR) AndyRussG: [C: +2] Alphabetize hooks in extension.json [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/481040 (owner: Ejegg) [19:00:04] (Merged) jenkins-bot: Alphabetize hooks in extension.json [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/481040 (owner: Ejegg) [19:10:21] (CR) jenkins-bot: Alphabetize hooks in extension.json [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/481040 (owner: Ejegg) [21:22:45] (Abandoned) Ejegg: WIP refactor dedupe [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/394433 (owner: Ejegg) [21:22:58] (Abandoned) Ejegg: WIP more Silverpop export refactor [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/394466 (owner: Ejegg) [21:23:19] (Abandoned) Ejegg: WIP further refactor [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/394494 (owner: Ejegg) [22:16:37] ejegg|brb: Just checked with lego [22:16:44] You definitely don't need track=1 and defaultbranch [22:16:58] Pick one (I suggest track=1 like we try and use everywhere else because it's just easier) [22:23:37] Reedy: ah, thanks! Will update that [22:25:08] Fundraising Sprint A 2019, Fundraising-Backlog, Security: Upgrade PaymentsWiki to Mediawiki 1.31 (new LTS) - https://phabricator.wikimedia.org/T184460 (Ejegg) p:Triage→Normal a:Ejegg [22:48:00] Fundraising Sprint A 2019, Fundraising-Backlog: Upgrade PaymentsWiki to Mediawiki 1.31 (new LTS) - https://phabricator.wikimedia.org/T184460 (Legoktm) [23:19:21] (PS1) Ejegg: Merge branch 'REL1_31' into fundraising/REL1_31 [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/483626 [23:36:13] (PS2) Ejegg: Merge branch 'REL1_31' into fundraising/REL1_31 [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/483626 [23:37:23] (CR) jerkins-bot: [V: -1] Merge branch 'REL1_31' into fundraising/REL1_31 [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/483626 (owner: Ejegg) [23:39:48] (PS1) Ejegg: Add Wikimedia Endowment logos [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/483632 (https://phabricator.wikimedia.org/T203603) [23:39:51] (PS1) Ejegg: Replace Endowment logos with transparent versions [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/483633 (https://phabricator.wikimedia.org/T203603) [23:39:54] (PS1) Ejegg: variant config for full redirect [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/483634