[00:00:23] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Issue with Engage reconciliation report - https://phabricator.wikimedia.org/T213877 (LeanneS) [00:14:23] eileen i am now, sort of [00:14:35] thanks for calling out that i'm not using statuses appropriately [00:15:09] (hmm I’m not one to call that out!) [00:15:09] mepps: just a question from my email that was not obvious [00:15:15] given Tim’s contract should finish on 22 Jan but we will not implement / test by then [00:15:31] is there a way to handle him having some hours for stuff from that [00:15:43] he could ‘hold some back’ rather than do them all by then [00:15:54] but I don’t know we can handle that managerially [00:16:32] ie. do I just say ‘use all the contracted hours & if we need more help when we test we’ll figure out how to deal with that' [00:16:47] or ‘keep 10 hours up your sleeve for future support’ when we test [12:38:28] fundraising-tech-ops, MediaWiki-extensions-CentralNotice: wmf_deploy updated but not merged and deployed into .12 - https://phabricator.wikimedia.org/T213915 (Reedy) [12:40:06] fundraising-tech-ops, MediaWiki-extensions-CentralNotice: wmf_deploy updated but not merged and deployed into .12 - https://phabricator.wikimedia.org/T213915 (Reedy) p:Triage→High [15:07:49] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: wmf_deploy updated but not merged and deployed into .12 - https://phabricator.wikimedia.org/T213915 (cwdent) [16:13:32] fr-tech any news for scrum of scrums? [16:13:44] AndyRussG: anything we should say about the wmf_deploy branch? [16:15:08] ejegg: hmmm no news that I can think of... You could mention that we merged stuff in, I guess, and will fix the process soon, since it continues to be a headache for deployers, maybe? [16:26:01] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Window dressing is mostly olive oil, Fundraising Sprint XML ate my homework, Fundraising-Backlog, and 3 others: CentralNotice protects CentralNotice templates endlessly each time ... - https://phabricator.wikimedia.org/T210983 [16:29:24] ejegg: the new stuff should hit Meta today [16:30:15] I think there was a bit of a headache for deployers this morning during the European SWAT [16:42:12] ejegg: Hi! I'm not sure if you still use FundraisingTranslateWorkflow? [16:42:39] awight: Yes, we haven't touched that bit [16:42:40] I would love to put a wooden stake through that thing. [16:43:40] Right, so it's just one extra bit of control over who gets 'publish' state transation rights? [16:44:02] *transition [16:44:28] Yeah I think it should be handled by a patch to Extension:Translate [16:44:32] so the idea would be to add a generic version of that [16:44:35] yah, exactly [16:44:37] :) [16:44:52] I might grab that, lemme look for a task... [16:44:52] are you volunteering to make that patch? :) [16:45:16] hehe, I'd be thrilled to do any CR / sheparding associated work [16:45:18] hehe as long as I can bathe in its ghost's ectoplasm once vanquished [16:45:49] visions of a taxidermied slimer [16:47:40] the language in this channel is like 75% less colorful since awight stopped hanging around [16:48:09] cwd and like 75% less language :( [16:48:50] Fundraising-Backlog, MediaWiki-extensions-Translate, Technical-Debt: Replace and deprecate FundraisingTranslateWorkflow hack - https://phabricator.wikimedia.org/T213943 (awight) [16:49:34] aww I have a whole basin of textual diarrhea on hand if you need it [16:50:35] ejegg: did you notice https://phabricator.wikimedia.org/T213915 ? [16:50:49] i don't know what a cactus token means [16:51:12] > mediawiki-core/extensions/Translate/extension.json does not exist! [16:51:17] harr [16:52:25] thus opens the tin of spammed worms [16:57:26] heh, that it's a pain in the butt? [16:57:42] awight: oh boy, old school [17:02:45] morning XenoRyet [17:02:56] mornin' [17:09:55] awight: I think Translate was not migrated yet [17:10:07] to extension registration [17:10:16] it's one of the complicated leftovers [17:10:36] apparently too many hooks and stuff [17:12:21] LarryTheCat: +1 luckily it's not a big deal to just `include`, but still surprising that it isn't migrated [17:13:45] awight: I've been helping migrating the 'easy' ones, but Translate is not. Plus being unable to use Vagrant makes me depend on others for testing, so I don't know if what I did worked until someone was kind enough to test the conversions for me. So I stopped working in that area. I think there's a Task though. [17:14:37] https://tools.wmflabs.org/extreg-wos/ <-- pending to convert [17:15:44] LarryTheCat: Hopefully you don't feel an obligation--you're still volunteering, right? Thank you for the migrations! [17:16:24] and T87985 is the relevant task which has a patch for review [17:16:24] T87985: Convert Translate to use extension registration - https://phabricator.wikimedia.org/T87985 [17:17:08] awight: well, I am no longer doing ExtReg stuff. The remaining extensions are either too complex for me or have been unmaintained for ages that it's better to just archive them. [17:17:40] perhaps "no longer" is not very accurate as I take a look from time to time but certainly it's not my main area of work anymore [17:17:50] :) compulsive helping of others [17:18:38] oh nice, extension-wip.json is coming along [17:20:14] Fundraising Sprint A series of unfortunate event handlers, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: Incorrect protection reason for non-source-language version of translatable banner messages - https://phabricator.wikimedia.org/T213565 (AndyRussG) >>! In T213565#... [17:22:03] extension-wip? [17:22:21] or extension-whip (whip-sound).json :P [17:22:30] LarryTheCat: looks like someone is building up an extension.json file over various patches this time around [17:22:43] aha [17:23:07] well, useful extensions will get converted eventually or they'll stop working in the newest releases iirc [17:37:54] for sure [17:38:29] Fundraising-Backlog, fundraising-tech-ops: Update SciPy on frdev1001 - https://phabricator.wikimedia.org/T213948 (Pcoombe) [17:41:16] Fundraising-Backlog: Update fundraising analysis tools to use Python 3 - https://phabricator.wikimedia.org/T213949 (Pcoombe) p:Triage→Low [17:44:06] * awight peeks into "ffs" directory in E:Translate [17:44:24] lol "AppleFFS" "JavaFFS" [17:44:36] both you and me, buddy. [17:50:01] Anyone feel like pasting me the current $wgFundraisingTranslateWorkflowPagePatterns [17:50:11] and $wgFundraisingTranslateWorkflowPublishRight [18:35:05] awight: hi! thanks for checking that out!! It is pretty messy out there [18:35:11] One sec, lemme empty my clipboard first [18:36:04] dstrine: I think we need to prioritize T136904... Also T213915 could come into the sprink [18:36:05] T136904: Spike: Plan reforms of the CentralNotice deployment branch - https://phabricator.wikimedia.org/T136904 [18:36:05] T213915: wmf_deploy updated but not merged and deployed into .12 - https://phabricator.wikimedia.org/T213915 [18:36:19] if u agree [18:37:31] AndyRussG: who all need to be involved with those? [18:39:25] dstrine: the spike should be explored together with ops and releng [18:39:47] The new one, just related to today's deploy, I'm just checking out now, should be quick [18:41:26] This feels like more of a tech lead decision. If the team is willing to take it on then ok. This doesn't feel like a call a product owner can make. [18:41:38] I'm ok with it as long as the team feels they can take it on [18:42:26] dstrine: basically we cause headaches all the time for CN deploys because as things stand today CN deploy procedure is a special snowflake [18:42:41] regardless of who really digs into the technical details, it needs to be fixed [18:43:10] FR I think would have the final say, or close to that, on most of the requirements [18:44:14] ops and releng need to guide us on how to get what we need in terms of control over deployment, in a way that doesn't complicate things for them as much as what we have now [18:44:43] ejegg: ^ ? [18:45:46] AndyRussG: oops, i should be |food [18:45:56] lemme get back to you shortly! [18:45:57] enjoy! no worries :) [18:46:19] awight: I don't see those vars anywhere in MW config repo, so they must be just the default from extension.json [18:46:24] "config": { [18:46:26] "FundraisingTranslateWorkflowPagePatterns": [ [18:46:28] "|^page-Fundraising/|" [18:46:30] ], [18:46:32] "FundraisingTranslateWorkflowPublishRight": "translate-manage" [18:46:34] }, [18:46:36] also, hi! [18:47:31] AndyRussG: Hi! Thanks for that, and nice to see it's nothing too sensitive. [19:02:25] awight: yeee, here u can see the current rights/groups layout: https://meta.wikimedia.org/wiki/Special:ListGroupRights [19:09:42] Having a hard time finding which pages this affects... [19:10:20] ok there we go? https://meta.wikimedia.org/wiki/Fundraising/Translation [19:10:56] So this should be one of the restricted translations? https://meta.wikimedia.org/wiki/Fundraising/Translation/Thank_you_page [19:11:27] awight: btw it might be a tad borked, I had trouble getting things set locally [19:11:50] Hard to imagine a sturdy subclass like that could be acting up ;-) [19:15:26] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: wmf_deploy updated but not merged and deployed into .12 - https://phabricator.wikimedia.org/T213915 (AndyRussG) Work on fixing the CentralNotice deployment mechanism has been put off time after time. We really, really need to... [19:15:45] awight: actually a pretty brilliant hack [19:20:48] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: wmf_deploy updated but not merged and deployed into .12 - https://phabricator.wikimedia.org/T213915 (Reedy) You just need to update the git sub module for CN on deploy1001 and sync it :) [19:38:01] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: wmf_deploy updated but not merged and deployed into .12 - https://phabricator.wikimedia.org/T213915 (AndyRussG) >>! In T213915#4885571, @Reedy wrote: > You just need to update the git sub module for CN on deploy1001 and sync i... [19:46:19] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: wmf_deploy updated but not merged and deployed into .12 - https://phabricator.wikimedia.org/T213915 (Reedy) Shouldn’t need that. It’s already in the core branch as that’s tracking wmf_deploy... [20:10:18] (PS1) Ejegg: Guard against duplicate WmfFramework alias [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/484757 [20:10:32] mepps|ish / XenoRyet ^^^ [20:12:18] AndyRussG: What do you think about us moving fundraising messages to their own namespace on metawiki? [20:13:15] awight: yee actually all CN stuff should move [20:13:30] and also we should re-design the whole Admin UI [20:13:33] that's right, now I remember! [20:13:36] and clean up the backend code [20:13:37] hehe [20:13:54] a game of tech debt chicken. [20:13:57] basically those are the main blocks of tech (including usability) debt [20:14:10] hahaha great way to put it ;p [20:14:24] I guess we can tackle it one chunk at a time [20:14:29] we'll get those chickens one day! [20:14:35] one "wing" at a time eh [20:14:38] I'd be happiest going first through a UI redesign [20:14:40] first [20:14:49] at least through mock-ups [20:14:50] totally [20:15:05] though a roadmap for all those points would be nice [20:16:00] (CR) XenoRyet: [C: +2] Guard against duplicate WmfFramework alias [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/484757 (owner: Ejegg) [20:17:47] (CR) jerkins-bot: [V: -1] Guard against duplicate WmfFramework alias [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/484757 (owner: Ejegg) [20:17:53] huh [20:18:21] oops, those composer bits shouldn't be part of the patch! [20:19:11] (CR) jerkins-bot: [V: -1] Guard against duplicate WmfFramework alias [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/484757 (owner: Ejegg) [20:19:15] Fundraising-Backlog, MediaWiki-extensions-Translate, Technical-Debt: Add per-namespace rights restrictions to publish translations - https://phabricator.wikimedia.org/T213943 (awight) [20:20:13] AndyRussG: ^ I think that's a small enough bit of work. Is it the right approach, though? Or should we try for an even smaller change, like porting the feature as-is from FundraisingTranslateWorkflow [20:20:46] (PS2) Ejegg: Guard against duplicate WmfFramework alias [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/484757 [20:21:45] I'm not sure if we can use the group configuration from https://www.mediawiki.org/wiki/Help:Extension:Translate/Group_configuration, though. [20:22:48] Getting the idea that E:Translate has a split personality since its TWN duties are different than on other wikis. [20:24:01] This is also reminding me that fr-tech-debt isn't usually a weekend thing, it always takes complex negotiations with various stakeholders :) [20:25:27] Actually Translate is used that way by other software projects too [20:25:46] Only CentralNotice is exceptional in that it creates its own kind of message group [20:26:17] Having both page translation and file (code) translation is relatively common [20:27:27] awight: have you seen the new page protection stuff btw? we now protect draft translatable messages with banner-protect right, and published/source language translatable messages with the centralnotice-admin right [20:28:44] awight: we probably want to keep uniform protections on FR and non-Fr stuff, I think? [20:30:36] awight and AndyRussG: so, the pages protected by that extension aren't centralnotice-related, right? [20:33:55] ejegg: isn't it just the translatable messages created by banners? [20:34:18] AndyRussG: Oh, I thought it was mainly the TY message [20:34:59] are the CN messages all prefixed with fundraising- ? [20:35:25] ejegg: nope [20:36:04] thanks, Nemo_bis! I hadn't seen that, but it sounds like exactly what is in order for FundraisingTranslateWorkflow. [20:37:02] ejegg: no... maybe I'm dead wrong! I'll have to look again at that code........... [20:37:34] ejegg: what TY message is on the main production sites? [20:37:52] AndyRussG: the TY email is up on meta [20:37:59] so volunteers can translate it [20:38:12] ejegg: hmmmmmmmm ok I didn't even know that 8p [20:38:15] https://meta.wikimedia.org/wiki/Fundraising/Translation/Thank_you_email_20171019 [20:38:21] ejegg: awight: in a minute I have to run to kid pickup [20:44:42] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: wmf_deploy updated but not merged and deployed into .12 - https://phabricator.wikimedia.org/T213915 (Reedy) Oh, sorry. I thought you wanted to deploy the new version Not checked the hashes, but looks right if you don’t want t... [20:45:05] btw CN update deployed now to Meta, looks fine: https://meta.wikimedia.org/w/index.php?title=Special:Version [20:57:13] oh nice [20:57:19] we'll see how it goes :) [21:18:10] ejegg: yeah, FundraisingTranslateWorkflow only protects messages from metawiki:Fundraising* pages, not involved in CN. That might be a separate permissions thing enforced directly by the message group implementation in CentralNotice? [21:24:44] Fundraising-Backlog, DBA: Remove frimpressions db from prod mysql - https://phabricator.wikimedia.org/T213973 (cwdent) [21:27:04] awight: oh you might know about that too ^ [21:49:57] Fundraising-Backlog, DBA: Remove frimpressions db from prod mysql - https://phabricator.wikimedia.org/T213973 (awight) How many rows are in the tables? There should be a timestamp column, often `ts`, to query. It's probably worth keeping an archival dump if it might be real data. [21:55:48] awight ejegg well I've been in a state of horrible incorrectness regarding my whole understanding of that extension. I never noticed that regex, no wonder it never seemed to work like I expected 8p 8p [21:55:56] * AndyRussG|ish blushes [21:56:00] * AndyRussG|ish hides [21:56:19] :) [21:56:52] * AndyRussG|ish throws laptop out the window [21:56:54] jk [21:57:15] no no, it's the extension we're throwing out the window! [22:14:08] (PS1) Awight: Remove long-deprecated code [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/484779 [22:14:52] * awight is almost surprised that worked [22:15:19] sometimes i wonder if they made the X1 fold flat just to make it tempting to throw [22:15:36] someone's on a cleaning spree! [22:15:47] (CR) jerkins-bot: [V: -1] Remove long-deprecated code [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/484779 (owner: Awight) [22:16:41] Something fishy is afoot with https://phabricator.wikimedia.org/diffusion/ECNO/browse/wmf_deploy/CentralNotice.hooks.php$72 [22:16:50] (CR) jerkins-bot: [V: -1] Remove long-deprecated code [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/484779 (owner: Awight) [22:16:56] shouldn't that just be the configured $wgCentralNoticeMessageProtectRight everywhere? [22:17:01] and not the string literal [22:19:38] awight: heh, that's actually new deprecated code [22:20:17] I should have made that 'in a year' into a date [22:22:01] oops! don't know why I zeroed in on it [22:22:35] (PS2) Awight: [DNM] Remove long-deprecated code [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/484779 [22:27:48] old unused banner preview feature is calling [22:33:46] * awight swivels lasers [22:35:11] AndyRussG|ish: this one? https://phabricator.wikimedia.org/diffusion/ECNO/browse/wmf_deploy/TemplatePager.php$93 [22:35:57] awight: mebbe? I think something in the banner form and also admin UI JS [22:36:06] IIRC there may even be a Phab task [22:36:51] good point :) https://phabricator.wikimedia.org/T161907 [22:38:28] yeee [22:43:18] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Technical-Debt: CentralNotice should declare its PHP classes under a new namespace - https://phabricator.wikimedia.org/T147360 (awight) [22:44:19] UwU [23:11:27] (PS1) Awight: [WIP] Remove unused banner preview support [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/484784 (https://phabricator.wikimedia.org/T161907) [23:45:08] When you add a CN {{{message}}} to banner text, remind me where I click to edit e.g. MediaWiki:Centralnotice-banner2-foomessage [23:48:33] Is that special UI for editing CN messages still a thing? [23:49:38] oh and I'm recalling we have to save twice maybe in order to see the messages [23:49:52] there it is. [23:53:05] awight: yep.... also filed as a Fab task [23:55:20] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, I18n: CentralNotice should respect language fallbacks - https://phabricator.wikimedia.org/T34482 (DStrine)