[00:01:50] (PS2) Awight: Remove unused banner preview support [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/484784 (https://phabricator.wikimedia.org/T161907) [00:03:35] Fundraising-Backlog, Fr-CentralNotice-Translation-Bugs, MediaWiki-extensions-CentralNotice, MediaWiki-extensions-Translate: Change (centralnotice-preview-all-template-translations) link target - https://phabricator.wikimedia.org/T158508 (awight) I've dropped this field set from https://gerrit.wik... [00:04:08] Fundraising-Backlog, Fr-CentralNotice-Translation-Bugs, MediaWiki-extensions-CentralNotice, MediaWiki-extensions-Translate: Discuss new features to facility CentralNotice message translation - https://phabricator.wikimedia.org/T158508 (awight) [00:04:24] Fundraising-Backlog, Fr-CentralNotice-Translation-Bugs, MediaWiki-extensions-CentralNotice, MediaWiki-extensions-Translate: Discuss new features to facilitate CentralNotice message translation - https://phabricator.wikimedia.org/T158508 (awight) [00:06:46] (PS3) Awight: Remove unused banner preview support [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/484784 (https://phabricator.wikimedia.org/T161907) [00:09:23] awight: btw if you're interested in some urgent cleanup, one irksome issue is this mess of Translate extension queries: https://logstash.wikimedia.org/goto/7203b093034cfd8dd9b871314b3b5c32 [00:09:42] There were a couple patches suggested to prevent CN from triggering that [00:09:51] only one got merged [00:10:32] Here's the other [00:10:34] https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CentralNotice/+/459843/ [00:10:43] That sounds like real work, hold just one minute there :) [00:10:45] It seems CN is not the only one that triggers that mess [00:11:01] hahah ok right sorry [00:11:10] I thought it might be a fun mystery to dive into 8p [00:11:16] I tried for a bit but couldn't get it [00:14:02] (PS4) Awight: Remove unused banner preview support [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/484784 (https://phabricator.wikimedia.org/T161907) [00:14:36] ^ done fooling around with that one [00:14:39] i think. [00:14:59] awight: thx!!!! :) [00:15:19] hrm don't thank me until you've opened the package [00:15:43] it's just a tube of chapstick wrapped in a pile of cardboard [00:17:55] AndyRussG: Is https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CentralNotice/+/459843/ meant to fix some of the weird delays in rendering translation messages? [00:18:48] awight: it was meant to fix the issue mentioned above, which was the accused but innocent cause of such delays [00:18:54] but the massive query issue persists [00:19:23] or at least, did until recently. It might even go away after today's train, I think it didn't tho [00:19:37] The change was suggested by Nikerabbit [00:20:20] A wee fix of the patch is needed as per comments, see also commit message [00:20:42] Not also that no one I know has tested locally what the effect of the change would really be [00:21:05] Because of lack of understanding and local setups that don't mirror production for the translate extension [00:21:17] and also 'cause the massive queries only probably happen when the Translate db is all full up [00:21:35] So what it really needs is someone to understand what's going on, and _really_ test the patch 8p [00:21:59] I wasted some time trying to dive in but just hit my head on the bottom of the wading pool [00:25:27] (CR) Awight: [C: -1] "I think this patch is meant to call `run` rather than `insertIntoJobQueue`? This might be problematic, since it subverts the $wgTranslate" (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/459843 (owner: Mepps) [00:26:51] Nice. I only started peeking, but description of the issue seems spot-on to me. [00:28:22] The sane thing would be to stick to insertIntoJobQueue, and rely on Nikerabbit to disable $wgTranslateDelayedMessageIndexRebuild once the issue is resolved on the Translate side. But I think that's already happening by default, when the message is updated. [00:28:59] Probably means that we just can't rely on the index rebuild when reloading the page. What's all being pulled from that index, anyway? [00:31:55] Fundraising Sprint A series of unfortunate event handlers, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: wmf_deploy updated but not merged and deployed into .12 - https://phabricator.wikimedia.org/T213915 (AndyRussG) a:AndyRussG [00:33:16] AndyRussG: Is it possible that we're getting messed up by the custom caching in Banner::getMessageFieldsFromCache, and nada mas? [00:34:19] awight: arg sorry I'm just about to revert to non-work for a bit 8p... Apologies for pointing you to something and running away! I can look later!!! Thx!!!! [00:34:36] Exactly what I was hoping for, no worries <3 [00:35:19] 8p [00:35:40] kid needs 'puter for this horrendous online study app [00:35:46] and dishies are calling [00:36:11] gotta redirect dns for YouTube and Instagram first [00:36:28] awight: thx again, great to have your help on this stuff!!! tty soon [00:38:55] O_O that's hilarious [00:39:29] Those kids are going to work around your DNS one day and it's gonna get real with hiding SSH keys :p [00:41:02] (PS1) Awight: Don't use custom caching for the banner message fields [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/484809 (https://phabricator.wikimedia.org/T72939) [00:42:12] Not that my kids are old enough yet, but I like adjusting QoS on the router to throttle the crap out of the offending services. [00:42:22] I grew up in the 56k era. Feel my pain. [00:50:29] Fundraising-Backlog, MediaWiki-extensions-Translate, Technical-Debt: Add per-namespace rights restrictions to publish translations - https://phabricator.wikimedia.org/T213943 (awight) My lazy update: I think we can do this without implementing anything new. All we have to do is rely on a namespace-b... [02:50:19] RECOVERY - check_gcsip on payments1001 is OK: HTTP OK: HTTP/1.1 200 OK - 343 bytes in 0.112 second response time [02:51:09] RECOVERY - check_gcsip on payments1003 is OK: HTTP OK: HTTP/1.1 200 OK - 343 bytes in 0.112 second response time [02:51:15] RECOVERY - check_gcsip on payments1002 is OK: HTTP OK: HTTP/1.1 200 OK - 343 bytes in 0.112 second response time [03:23:09] PROBLEM - check_gcsip on payments1003 is CRITICAL: CRITICAL - Socket timeout after 121 seconds [03:23:15] PROBLEM - check_gcsip on payments1002 is CRITICAL: CRITICAL - Socket timeout after 121 seconds [03:24:09] PROBLEM - check_gcsip on payments1004 is CRITICAL: CRITICAL - Socket timeout after 121 seconds [03:26:09] RECOVERY - check_gcsip on payments1003 is OK: HTTP OK: HTTP/1.1 200 OK - 343 bytes in 0.113 second response time [03:26:13] RECOVERY - check_gcsip on payments1002 is OK: HTTP OK: HTTP/1.1 200 OK - 343 bytes in 0.116 second response time [03:27:09] RECOVERY - check_gcsip on payments1004 is OK: HTTP OK: HTTP/1.1 200 OK - 343 bytes in 0.117 second response time [03:52:20] PROBLEM - check_gcsip on payments1001 is CRITICAL: CRITICAL - Socket timeout after 121 seconds [03:53:10] PROBLEM - check_gcsip on payments1003 is CRITICAL: CRITICAL - Socket timeout after 121 seconds [03:53:14] PROBLEM - check_gcsip on payments1002 is CRITICAL: CRITICAL - Socket timeout after 121 seconds [03:54:10] PROBLEM - check_gcsip on payments1004 is CRITICAL: CRITICAL - Socket timeout after 121 seconds [03:56:10] RECOVERY - check_gcsip on payments1003 is OK: HTTP OK: HTTP/1.1 200 OK - 343 bytes in 0.121 second response time [03:56:14] RECOVERY - check_gcsip on payments1002 is OK: HTTP OK: HTTP/1.1 200 OK - 343 bytes in 0.123 second response time [03:57:10] RECOVERY - check_gcsip on payments1004 is OK: HTTP OK: HTTP/1.1 200 OK - 343 bytes in 0.157 second response time [04:00:14] RECOVERY - check_gcsip on payments1001 is OK: HTTP OK: HTTP/1.1 200 OK - 343 bytes in 0.150 second response time [06:41:29] Fundraising-Backlog, DBA: Remove frimpressions db from prod mysql - https://phabricator.wikimedia.org/T213973 (Marostegui) Where is this database? I cannot find it on the misc masters. ` root@cumin1001:~# for i in db1063 db1065 db1072 db1073; do mysql.py -h$i -e "show databases like '%fr%'";done root@cum... [06:45:20] Fundraising-Backlog, DBA: Remove frimpressions db from prod mysql - https://phabricator.wikimedia.org/T213973 (jcrespo) It should be on m2: https://wikitech.wikimedia.org/wiki/MariaDB/misc#Current_schemas_2 [06:47:33] Fundraising-Backlog, DBA: Remove frimpressions db from prod mysql - https://phabricator.wikimedia.org/T213973 (Marostegui) So looks like it is only on codfw hosts, which indicates it is not really in use: ` root@cumin1001:/home/marostegui# for i in db1065 db1117:3322 db2044 db2078:3322; do echo $i; mysql... [06:51:58] Fundraising-Backlog, DBA: Remove frimpressions db from prod mysql - https://phabricator.wikimedia.org/T213973 (jcrespo) our backup systems has this bug where empty dbs are not recovered, maybe it is an empty and was deleted by accident (with no data loss?). [06:52:36] Fundraising-Backlog, DBA: Remove frimpressions db from prod mysql - https://phabricator.wikimedia.org/T213973 (Marostegui) it is empty actually ` root@db2044:/srv/sqldata/frimpressions# ls -lh total 4.0K -rw-rw---- 1 mysql mysql 54 Jun 4 2014 db.opt ` [06:53:57] Fundraising-Backlog, DBA: Remove frimpressions db from prod mysql - https://phabricator.wikimedia.org/T213973 (jcrespo) awight - do you need its contents? Maybe it was archived in the past, we would have to do some research about that. [07:30:16] Fundraising-Backlog, DBA: Remove frimpressions db from prod mysql - https://phabricator.wikimedia.org/T213973 (Marostegui) I think this database was just created but never actually populated: T83011#908236 [08:37:17] PROBLEM - check_gcsip on payments1001 is CRITICAL: CRITICAL - Socket timeout after 121 seconds [08:40:19] RECOVERY - check_gcsip on payments1001 is OK: HTTP OK: HTTP/1.1 200 OK - 343 bytes in 0.116 second response time [08:42:52] (CR) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/484887 (owner: L10n-bot) [09:42:19] PROBLEM - check_gcsip on payments1001 is CRITICAL: CRITICAL - Socket timeout after 121 seconds [09:45:19] RECOVERY - check_gcsip on payments1001 is OK: HTTP OK: HTTP/1.1 200 OK - 343 bytes in 0.153 second response time [13:42:57] Fundraising-Backlog, MediaWiki-extensions-Translate, Technical-Debt: Add per-namespace rights restrictions to publish translations - https://phabricator.wikimedia.org/T213943 (Nikerabbit) > All we have to do is rely on a namespace-based message group, and configure the group with: Just to clarify, y... [14:20:33] Fundraising-Backlog, DBA: Remove frimpressions db from prod mysql - https://phabricator.wikimedia.org/T213973 (Marostegui) Open→Resolved a:Marostegui I have dropped this empty database and updated documentation. [14:22:57] (CR) Nikerabbit: [C: -1] "> Patch Set 2: Code-Review-1" (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/459843 (owner: Mepps) [16:33:15] (PS1) Cstone: Add geolocation from ip address if no country is given [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/485052 [16:34:37] (CR) jerkins-bot: [V: -1] Add geolocation from ip address if no country is given [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/485052 (owner: Cstone) [16:39:11] yay cstone! [16:39:29] haha I messed up some spacing though fixing that now [16:39:56] ah sure, easy to fix [16:40:13] if you want to run that check locally, you can run 'composer test' [16:43:31] is there special sets of rules to set with that? it seems to be mad at the entire file [16:49:56] oh weird [16:53:22] oh, one other thing: to link the patch with the phab ticket, we usually add a line at the bottom of the commit message like this: [16:53:48] bug: T211454 [16:53:49] T211454: GatewayFormChooser should geolocate when country is not in URL - https://phabricator.wikimedia.org/T211454 [16:54:06] or rather Bug: 211454 [16:54:15] heh, thanks stashbot [16:54:20] ack [16:54:21] (PS2) Cstone: Add geolocation from ip address if no country is given [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/485052 [16:54:25] sorry, capital B [16:54:31] and a T before the number [16:54:34] like this: [16:54:39] Bug: T211454 [16:55:23] ah okay [16:57:14] (CR) jerkins-bot: [V: -1] Add geolocation from ip address if no country is given [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/485052 (owner: Cstone) [17:08:19] (PS3) Cstone: Add geolocation from ip address if no country is given [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/485052 (https://phabricator.wikimedia.org/T211454) [17:17:21] Fundraising-Backlog, DBA: Remove frimpressions db from prod mysql - https://phabricator.wikimedia.org/T213973 (cwdent) @Marostegui @jcrespo thanks! [17:24:46] ooops [17:59:25] Fundraising-Backlog, fundraising-tech-ops: Update SciPy on frdev1001 - https://phabricator.wikimedia.org/T213948 (cwdent) @pcoombe unfortunately the available versions on Jessie (current OS) and Stretch (upcoming OS) are both old (0.14 and 0.18 respectively). Buster (2 OS versions out) has 1.0 but that'... [18:19:30] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Window dressing is mostly olive oil, Fundraising Sprint XML ate my homework, Fundraising-Backlog: Contribution Tracking breakdown and planning - https://phabricator.wikimedia.org/T211057 (DStrine) From our meeting today... [19:22:44] fr-tech the icinga alerts are from testing stuff? [19:25:01] AndyRussG: which ones? [19:26:07] the gcsip ones? [19:26:43] Those are actual issues connecting to Ingenico [19:27:11] we also got some failmails from smashpig on the payments servers detailing timeouts connecting during real donation attempts [19:28:05] back in a bit! [19:31:49] ejegg|afk: ah okok thx! [19:54:32] (CR) AndyRussG: "Almost there!!!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/481099 (https://phabricator.wikimedia.org/T209795) (owner: Ejegg) [20:39:13] (PS1) Ejegg: Don't embed dropdown triangle in CSS [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/485091 [20:43:02] fr-tech ^^^ needs review to get the data: image out of our CSS [20:43:20] it's breaking the CSP header that Jeff_Green's got on the PHP7 box [20:43:39] if we can merge that, ops can go ahead with the PHP7 rollout across the frontend! [20:44:38] I'll take a look [21:02:38] (PS6) Ejegg: Add revision tag to CN admin edits [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/481099 (https://phabricator.wikimedia.org/T209795) [21:02:47] (CR) XenoRyet: [C: -1] "The triangle isn't showing for me in FF or Chrome. I'll try to figure out why." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/485091 (owner: Ejegg) [21:03:34] Fundraising-Backlog, fundraising-tech-ops: Update SciPy on frdev1001 - https://phabricator.wikimedia.org/T213948 (Pcoombe) Actually looking into it v0.18.0 does fix the main bug which affects us (in the Mann-Whitney statistical test). So that would be great if an update to Stretch is planned soon anyway? [21:10:21] Fundraising Sprint A series of unfortunate event handlers, Fundraising-Backlog, Recurring-Donations, FR-Email: Reduce recurring TY emails - https://phabricator.wikimedia.org/T213209 (Pcoombe) Before this happens we'll need to change this footer text which appears in the banners: > If you make a r... [21:11:00] (CR) Ejegg: "OK AndyRussG, I updated the translation tag name. Thanks for tracking down the rule on i18n message names!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/481099 (https://phabricator.wikimedia.org/T209795) (owner: Ejegg) [21:26:23] (CR) XenoRyet: "My issue might be a weird file synching thing on my end. Code looks fine, if someone else can take a look and confirm the thing shows up." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/485091 (owner: Ejegg) [21:30:04] XenoRyet: have you cleared cache / force-reloaded? [21:30:09] it's definitely loading the file for me [21:30:30] I tried inspecting the element and it's using the file path for the background, not the data uri [21:31:00] Let me try clearing the cache. The file is definitely there, but it's giving a 404 [21:35:33] Fundraising Sprint A series of unfortunate event handlers, Fundraising-Backlog, Recurring-Donations, FR-Email: Reduce recurring TY emails - https://phabricator.wikimedia.org/T213209 (MBeat33) Thanks, @Pcoombe for catching that. I would suggest: //If you make a recurring monthly donation, you wil... [21:39:30] ejegg: It's still not working for me, but I can't imagine why. Is anyone else around to just give it a quick try? [21:39:48] I can give it a try [21:40:03] you're just ssh-tunneling and port forwarding right? [21:40:24] Na, I pulled the patch to my local repo and was trying it there. [21:40:46] oh, hmm. I don't have any way of testing that. [21:41:35] cstone: You have DonationInterface set up right? Want to take a quick look at this patch? [21:41:50] XenoRyet: want to screenshare? [21:42:25] i think so I can try [21:42:55] cstone: lmk if you have any issue getting the patch locally to review [21:44:10] cstone: This is the one, in case you haven't already found it in backscroll: https://gerrit.wikimedia.org/r/485091 [21:45:22] That's a little weird. Inspecting the element, the URL it's trying to load is http://payments.wiki.local.wmftest.net:8080/w/extensions/DonationInterface/gateway_forms/includes/triangle.svg?ccca4 [21:45:43] though even just triangle.svg gets a 404 too, depsite the fact that the file is there. [21:45:43] where would the dropdown triangle be [21:45:50] On the state field. [21:45:56] ah okay [21:46:00] on the donation form. [21:47:40] You can also just start making a donation on production if you want to see what it currently looks like. [21:48:10] ok im not sure what I did but I getting all the errors and nothing is loading [21:48:15] investigating that [21:48:45] that ?ccca4 is a cache-busting trick by resourceloader, I think [21:49:55] cstone: if you wanna debug via screenshare, I'm available [21:50:33] yeah sure somehow my payments wiki isnt even loading [21:52:34] I suppose I'll jump on too, just so you folks can see what I'm seeing. [21:53:02] usual hangout? [21:53:03] cstone: i'm in the usual hangout [22:12:44] Fundraising Sprint A series of unfortunate event handlers, Fundraising-Backlog, Recurring-Donations, FR-Email: Reduce recurring TY emails - https://phabricator.wikimedia.org/T213209 (CCogdill_WMF) So that is actually included in the paragraph we're adding in the body of the email. Can we remove i... [22:13:06] XenoRyet|food / cstone: OK, so for some reason it's serving that includes directory out of the main wiki's DonationInterface extension [22:13:23] if I copy the file to /vagrant/mediawiki/mediawiki/extensions/DonationInterface/gateway_forms/includes it does show up [22:13:34] so, trying to understand what's messed up with the site config [22:16:33] since it's just a vagrant config error, any chance you can merge the patch? [22:17:43] sorry, trying to rush too much here. I'll figure out that vagrant config [23:11:41] argh, this mediawiki multiversion thing is complicated [23:12:03] XenoRyet: want to try updating the version of DonationInterface in the main wiki to the same patch? [23:12:20] i.e. the one in /vagrant/mediawiki/mediawiki/extensions/DonationInterface/\ [23:12:28] err, minus that backslash [23:12:30] Yea, was just doing that. [23:12:39] Just done actually. Triangle looks fine. [23:12:42] woot [23:12:47] (CR) XenoRyet: [C: +2] Don't embed dropdown triangle in CSS [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/485091 (owner: Ejegg) [23:12:51] thanks! [23:12:59] No worries [23:13:49] (Merged) jenkins-bot: Don't embed dropdown triangle in CSS [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/485091 (owner: Ejegg) [23:14:28] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/485124 [23:14:37] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/485124 (owner: Ejegg) [23:22:12] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/485125 [23:22:46] Fundraising-Backlog, fundraising-tech-ops: Re-image frdev1001 to stretch - https://phabricator.wikimedia.org/T214115 (cwdent) [23:24:30] (CR) jerkins-bot: [V: -1] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/485125 (owner: Ejegg) [23:25:13] Fundraising-Backlog, fundraising-tech-ops: Update SciPy on frdev1001 - https://phabricator.wikimedia.org/T213948 (cwdent) @Pcoombe yes indeed, I made a subtask for that for tracking and to remind myself. [23:28:29] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/485124 (owner: Ejegg) [23:30:18] (CR) Ejegg: [C: +2] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/485125 (owner: Ejegg) [23:43:38] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/485125 (owner: Ejegg)