[17:54:33] <jdlrobson>	 hey.. there's a big bug in https://meta.wikimedia.org/wiki/Special:CentralNoticeBanners/edit/stewnoms_mobile which is flooding our client side error tracking pipeline. How do I work out who is responsible for that campaign and can make the required edit?
[17:54:45] <jdlrobson>	 Seddon: ^ can you help?
[17:57:44] <jdlrobson>	 i reported here as well: https://meta.wikimedia.org/wiki/Talk:CentralNotice#stewnoms_mobile_is_throwing_JavaScript_errors_on_mobile
[17:57:57] <jdlrobson>	 i know exactly how to fix this but I can't edit banners even with my staff account it seems :/
[17:58:32] <AndyRussG>	 jdlrobson: hi! I can check it out
[17:58:44] <jdlrobson>	 thanks AndyRussG
[17:58:48] <jdlrobson>	 it seems to be looking for this.log
[17:58:52] <jdlrobson>	 but there is no log function
[17:59:10] <jdlrobson>	 maybe mw.log or mw.track?
[17:59:55] <AndyRussG>	 jdlrobson: hmmm no idea, I can dive in in about 5 min
[18:00:14] <jdlrobson>	 at minimum we need to change return this.log to just a plain return
[18:00:29] <jdlrobson>	 or add an empty log function to fill later
[18:16:35] <AndyRussG>	 jdlrobson: that's an odd bit of js
[18:25:09] <AndyRussG>	 jdlrobson: looks like the campaign has been up since the 15h, but the pageviews it gets has been getting turned up https://meta.wikimedia.org/wiki/Special:CentralNoticeLogs?log_type=campaignSettings&startDate=&startDate_timestamp=&endDate=&endDate_timestamp=&campaign=Steward+elections+2019&user=&centralnoticesubmit=Apply+filters
[18:25:32] <jdlrobson>	 https://grafana.wikimedia.org/d/000000566/reading-web-dashboard?orgId=1&panelId=15&fullscreen&from=now-7d&to=now < fixing the error should show an immediate drop in errors on this graph
[18:27:22] <AndyRussG>	 I have no idea what the this.log was expected to do
[18:28:11] <AndyRussG>	 I think I'll just send it to the console for now, and fix the error that was actually preventing the banner from showing on mobile
[18:28:22] <AndyRussG>	 either that, or I should just disable it
[18:28:30] <jdlrobson>	 So can we remove it? I'm actually off today but I wanted to get this addressed since usually we see 90k errors an hour  but since the campaign started we're getting 200-300k an hour. So the quicker we get a hot fix out the better. We can use mw.log here
[18:30:56] <AndyRussG>	 jdlrobson: yeah, I just removed it from the campaign. It wasn't showing the banners at all on mobile in fact
[18:31:23] <AndyRussG>	 It should take maybe 10 minutes max (or whatever the RL cache time is these days) to stop showing
[18:31:29] <jdlrobson>	 it needs to be fixed in the JS
[18:31:47] <jdlrobson>	 some code relating to the banner is cached in the HTML I believe
[18:32:00] <jdlrobson>	 so best to also change that log line as well
[18:33:12] <jdlrobson>	 (i just hit the issue on Japanese wiki)
[18:33:52] <jdlrobson>	 also will protect us if it accidentally gets turned on again
[18:33:55] <AndyRussG>	 Yeah the JS has at least two errors, but I'd like to consult with the campaign authors. The list of banners available are in a dynamic php-based RL module. Now that I removed it from the campaign, CN won't include it as an option to show, so won't load it, as soon as the new RL module goes out
[18:34:29] <AndyRussG>	 I'll make sure the JS is fixed today, and meanwhile will keep an eye on it to make sure it isn't re-enabled
[18:34:39] <jdlrobson>	 . The banner has a in-banner JavaScript so it is only displayed to administrators. If you have any ideas how to fix that issue for mobile and you're willing to help in resolving it, please be my guest. If I can help with anything too, please let me know. Thank you,
[18:34:46] <jdlrobson>	 ^ AndyRussG that's the purpose of it
[18:34:51] <jdlrobson>	 https://meta.wikimedia.org/wiki/Talk:CentralNotice#stewnoms_mobile_is_throwing_JavaScript_errors_on_mobile
[18:35:11] <AndyRussG>	 jdlrobson: yep
[18:38:10] <jdlrobson>	 errors are not going down just yet so banner still likely being served.. AndyRussG please can you comment out that this.log line and add a return in its place? If it's disabled campaign that will do more good than harm. While that banner is loaded with errors it breaks all mobile features including editing.
[18:38:47] <AndyRussG>	 jdlrobson: I promise it'll stop going out.
[18:39:31] <jdlrobson>	 ok thanks. I'll go take my day off now then :) thanks for the help here.
[18:39:52] <AndyRussG>	 jdlrobson: have fun!
[18:40:06] <AndyRussG>	 jdlrobson: mw.centralNotice.choiceData shows it's not going out anymore, at least from here
[18:41:24] <AndyRussG>	 (in that array, you can find the "Steward elections 2019" campaign, and see that it only has one banner, which is the one that displays only on desktop)
[18:55:37] <Hauskatze>	 Seddon: https://meta.wikimedia.org/wiki/Talk:CentralNotice#stewnoms_mobile_is_throwing_JavaScript_errors_on_mobile
[18:55:52] <Hauskatze>	 jdlrobson points out script errors everywhere
[18:55:59] <Hauskatze>	 (thanks for that)
[18:57:50] <AndyRussG>	 jdlrobson: https://grafana.wikimedia.org/d/000000566/reading-web-dashboard?orgId=1&panelId=15&fullscreen&from=1547994207340&to=1548097054932
[18:58:04] <AndyRussG>	 Hauskatze: I can help in about 20 minutes
[18:58:10] <Hauskatze>	 I am JS-zero so if. ..
[18:58:16] <Hauskatze>	 thanks AndyRussG
[18:58:34] <AndyRussG>	 Hauskatze: I disabled the mobile banner, please let's not re-enable it until it's fixed?
[18:58:38] <AndyRussG>	 Seddon: ^
[18:58:43] <Hauskatze>	 AndyRussG: fine by me
[18:58:51] <AndyRussG>	 Hauskatze: thx!
[18:59:09] <Hauskatze>	 we mostly get <s>crap</s> invalid nominations from mobile anyway
[19:09:56] <wikibugs>	 (PS3) Umherirrender: Adjust param doc for CentralNotice::getCNSessionVar [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/482038
[19:10:15] <wikibugs>	 (CR) Umherirrender: Adjust param doc for CentralNotice::getCNSessionVar (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/482038 (owner: Umherirrender)
[19:27:02] <AndyRussG>	 Hauskatze: so, the mobile banner was not showing at all, as far as I could tel
[19:27:05] <AndyRussG>	 l
[19:27:15] <Hauskatze>	 :(
[19:33:19] <Seddon>	 Hey all
[20:32:34] <AndyRussG>	 Seddon:
[20:32:35] <AndyRussG>	 hi
[20:32:58] <AndyRussG>	 Seddon: I'm going to edit the mobile steward banner how I think it should go
[20:33:04] <AndyRussG>	 But it's currently not on the campaign
[20:33:32] <AndyRussG>	 Please test carefully on mobile, maybe on aa.wikibooks, before re-enabling, k?
[20:37:00] <AndyRussG>	 Seddon: whatI I'm not sure is what this.log was meant to do
[20:40:49] <wikibugs>	 (CR) Fomafix: [C: +1] Adjust param doc for CentralNotice::getCNSessionVar [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/482038 (owner: Umherirrender)
[20:41:47] <AndyRussG>	 With the change I'm making it'll just log in the browser console
[20:49:35] <wikibugs>	 Fundraising-Backlog: Mobile Steward elections 2019 banner broken - https://phabricator.wikimedia.org/T214330 (AndyRussG)
[21:00:38] <AndyRussG>	 Seddon: or, possibly, it was always showing for everyone
[21:28:24] <wikibugs>	 Fundraising-Backlog: Mobile Steward elections 2019 banner broken - https://phabricator.wikimedia.org/T214330 (AndyRussG) I've updated [[ https://meta.wikimedia.org/wiki/Special:CentralNoticeBanners/edit/stewnoms_mobile | the mobile banner ]]. I don't think it will cause errors now. I also added an `alterImpr...
[21:31:42] <wikibugs>	 Fundraising-Backlog: Mobile Steward elections 2019 banner broken - https://phabricator.wikimedia.org/T214330 (AndyRussG)
[21:36:05] <AndyRussG>	 Seddon: jdlrobson: ^