[01:16:19] Fundraising-Backlog: Mobile Steward elections 2019 banner broken - https://phabricator.wikimedia.org/T214330 (Jdlrobson) Open→Resolved a:Jdlrobson I think we can call this closed for this particular banner. Thanks for the swift response here! Looking forward to improvements relating to T214410! [18:02:46] fundraising-tech-ops: test and deploy payments on Debian Stretch/PHP7.0 - https://phabricator.wikimedia.org/T202290 (Ejegg) Looks like the php-memcache upgrades shouldn't matter. Our filters are using memcache via Mediawiki's BagOStuff interface, which has its own PHP class to talk directly to the daemon wit... [18:05:01] (PS1) Ejegg: Delete obsolete settings [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/486338 [18:07:13] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Performance-Team (Radar): Investigate impact and protection from errors in banners JS - https://phabricator.wikimedia.org/T214410 (AndyRussG) I've set up a test banner with a JS error on the beta cluster. Banner content visible in the Beta-Clu... [18:14:25] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint XML ate my homework, Fundraising-Backlog, Fr-Ingenico-integration_2017-18, Patch-For-Review: currency mismatch between Ingenico Connect & Civi - https://phabricator.wikimedia.org/T211024 (Ejegg) Yes @mepps, we did t... [18:20:18] cwd and Jeff_Green I think we're good on the upgrade from a libraries point of view. I'll take another look at those Chrome CSP errors today. [18:20:43] If we can get those resolved, any chance of rolling out PHP7 today? [18:24:58] hmm, i did one page load on a different browser on the same OS as you and got a bunch of errors [18:25:08] it seems likely that other platforms are going to behave differently [18:25:12] macs, phones [18:43:30] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Performance-Team (Radar): Investigate impact and protection from errors in banners JS - https://phabricator.wikimedia.org/T214410 (Jdlrobson) As Timo predicted, I am not seeing any impact on any other JS on mobile or desktop. [18:44:07] (PS1) Awight: [WIP] New Translate hook cleans up our act [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/486345 (https://phabricator.wikimedia.org/T213943) [18:45:24] (CR) jerkins-bot: [V: -1] [WIP] New Translate hook cleans up our act [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/486345 (https://phabricator.wikimedia.org/T213943) (owner: Awight) [18:55:59] ejegg: what i'm afraid of is deploying subtle donor facing breakage that causes DS tickets to roll in over all hands [18:56:06] how about we hack on this at all hands? [18:56:15] there will be a variety of devices around [19:08:47] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint XML ate my homework, Fundraising-Backlog, Fr-Ingenico-integration_2017-18, Patch-For-Review: currency mismatch between Ingenico Connect & Civi - https://phabricator.wikimedia.org/T211024 (MBeat33) Many thanks, @Ejeg... [19:09:41] I'm really enjoying this ^^^ sprint title [19:10:45] cwd the sooner the better I think - we've got till Feb 5th before they want any actual campaigns up [19:11:11] and after this upgrade we need to upgrade mediawiki to 1.31 [19:11:22] maybe the mw-1.31 upgrade would be fun to do at all-hands? [19:11:42] ejegg: I don't think a rollout before all-hands is realistic [19:11:57] crud [19:12:07] we can't roll something like this out on a Friday right before we're all travelling [19:12:12] ok, maybe we can do both upgrades next week? [19:12:22] I'm up for trying [19:12:45] I'm not sure when the next lull in the campaign schedule would be [19:12:51] and 1.27 is really long in the tooth [19:13:16] I was thinking we could look into reimaging the codfw payments servers, which would allow us to test via host file hackery [19:14:03] I'm not sure how well payments will tolerate cross-colo queue activity, maybe it would be fine? [19:14:39] err, that's totally unknown to me [19:15:06] would that be payments2001 talking to frqueue1001? [19:15:07] it should be just a few round trips right? or is it lots? [19:15:10] yes [19:15:21] it's just a few messages for each donation [19:15:28] for mw they'll use their local read-only db instance so that's not an issue [19:15:33] yeah [19:16:10] and there's just the one round trip to the civi db to get a transaction ID right? [19:16:44] Jeff_Green: I'd have to check on that - there might be one each page load [19:17:09] even that wouldn't be too horrible, if it's just one query [19:17:25] yeah, should be max 1 per page load [19:18:22] I bet it's workable for testing [19:18:41] ok, thanks for the possibilities! Gotta do a quick errand, but I'll be back suhortly [19:18:46] ok [19:32:34] (PS2) Awight: [WIP] New Translate hook cleans up our act [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/486345 (https://phabricator.wikimedia.org/T213943) [20:17:00] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Performance-Team (Radar): Investigate impact and protection from errors in banners JS - https://phabricator.wikimedia.org/T214410 (AndyRussG) >>! In T214410#4906690, @Jdlrobson wrote: > As Timo predicted, I am not seeing any impact on any other... [20:28:39] fr-tech hmm, looks like paypal audit download is failing [20:49:20] (PS3) Awight: New Translate hook cleans up our act [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/486345 (https://phabricator.wikimedia.org/T213943) [20:50:01] (CR) Awight: "Note that tests won't pass until If1300f33f1c908be32563b089a5975c9918463d3 is merged" [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/486345 (https://phabricator.wikimedia.org/T213943) (owner: Awight) [20:50:38] (CR) jerkins-bot: [V: -1] New Translate hook cleans up our act [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/486345 (https://phabricator.wikimedia.org/T213943) (owner: Awight) [20:51:57] ^ Happy week and a half before lunar new year! [21:11:49] thanks awight ! [21:25:29] :) Just going around trying to atone for bad things I did in a previous life. [21:37:13] Fundraising-Backlog: Mobile Steward elections 2019 banner broken - https://phabricator.wikimedia.org/T214330 (Ejegg) Did you intend to have a different field than uri_host in the OR clause looking for Special:BannerLoader? Lools like uri_host has to be exactly meta.wikimedia.org. [21:42:28] Fundraising-Backlog, MediaWiki-extensions-Translate, MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Technical-Debt: Support custom permissions for a subset of translatable pages - https://phabricator.wikimedia.org/T213943 (awight) [22:04:12] awight :) [22:04:55] * AndyRussG|ish disbelieves awight has done bad things [22:06:14] It's just a swath of call_user_func_array and temporary tables... [22:55:46] (CR) Awight: "@AndyRussG: ping--this one seems like it will go stale quickly." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/484784 (https://phabricator.wikimedia.org/T161907) (owner: Awight) [22:56:15] AndyRussG|ish: there's another of my survivors ;) ^ [23:30:15] awight: fantastic, great! I'll check it out! Thx :) [23:43:07] fundraising-tech-ops: test and deploy payments on Debian Stretch/PHP7.0 - https://phabricator.wikimedia.org/T202290 (Ejegg) OK, I'm seeing the loading errors in Chrome now. It's more images inlined into CSS by ResourceLoader as data: urls. This time, it's from core MediaWiki. So we can either pile some patc...