[16:48:14] (CR) Awight: "recheck" [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/486345 (https://phabricator.wikimedia.org/T213943) (owner: Awight) [16:49:28] (CR) jerkins-bot: [V: -1] New Translate hook cleans up our act [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/486345 (https://phabricator.wikimedia.org/T213943) (owner: Awight) [16:55:51] (PS4) Awight: New Translate hook cleans up our act [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/486345 (https://phabricator.wikimedia.org/T213943) [17:00:11] (CR) jerkins-bot: [V: -1] New Translate hook cleans up our act [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/486345 (https://phabricator.wikimedia.org/T213943) (owner: Awight) [17:02:55] the heck, you say [17:03:21] ... and here I thought it wasn't going to be easy [17:06:39] (PS5) Awight: New Translate hook cleans up our act [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/486345 (https://phabricator.wikimedia.org/T213943) [17:09:20] Fundraising-Backlog: Mobile Steward elections 2019 banner broken - https://phabricator.wikimedia.org/T214330 (AndyRussG) >>! In T214330#4907303, @Ejegg wrote: > Did you intend to have a different field than uri_host in the OR clause looking for Special:BannerLoader? Lools like uri_host has to be exactly meta... [17:13:52] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Remove hacky EventLogging-duplicating code and use new lightweight EL facilities - https://phabricator.wikimedia.org/T214709 (AndyRussG) [17:14:26] (CR) jerkins-bot: [V: -1] New Translate hook cleans up our act [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/486345 (https://phabricator.wikimedia.org/T213943) (owner: Awight) [17:15:12] (PS6) Awight: New Translate hook cleans up our act [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/486345 (https://phabricator.wikimedia.org/T213943) [17:26:44] * awight puts wooden stake back in bag [17:31:22] Fundraising-Backlog, MediaWiki-extensions-Translate, MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Technical-Debt: Support custom permissions for a subset of translatable pages - https://phabricator.wikimedia.org/T213943 (awight) @Nikerabbit Do you know of any mechanism to enab... [17:32:04] legoktm: ^ Maybe you know? [17:35:44] fr-tech: MBeat: Just want to flag this thread to you all, it seems like a PR powderkeg: > [Wikimedia-l] Security Notification: Malware creating fake Wikipedia donation banner [17:36:02] thanks, awight [17:36:13] /o\ [17:36:36] Fundraising-Backlog, MediaWiki-extensions-Translate, MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Technical-Debt: Support custom permissions for a subset of translatable pages - https://phabricator.wikimedia.org/T213943 (Nikerabbit) I am not familiar with that part of Jenkins/... [17:37:41] awight: yeah...we should probably go about reproducing that and seeing how it works [17:38:00] i guess you have to download an infected movie [17:38:16] maybe we could have a banner about the banner [17:39:46] It's pretty scary, the reputational damage could be huge even if a small number of people are affected. [17:42:01] (PS1) Awight: [WIP] experiment with extension dependency [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/486500 [17:44:20] legoktm: nvm, you already documented it! [17:44:52] Fundraising-Backlog, MediaWiki-extensions-Translate, MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Technical-Debt: Support custom permissions for a subset of translatable pages - https://phabricator.wikimedia.org/T213943 (awight) Just discovered some good documentation about th... [17:50:48] (PS7) Awight: New Translate hook cleans up our act [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/486345 (https://phabricator.wikimedia.org/T213943) [17:51:02] (Abandoned) Awight: [WIP] experiment with extension dependency [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/486500 (owner: Awight) [18:30:03] Fundraising-Backlog, MediaWiki-extensions-Other, Documentation: [FundraisingTranslateWorkflow] Create https://www.mediawiki.org/wiki/Extension:FundraisingTranslateWorkflow - https://phabricator.wikimedia.org/T167996 (Aklapper) [18:32:50] Fundraising-Backlog: Mobile Steward elections 2019 banner broken - https://phabricator.wikimedia.org/T214330 (AndyRussG) I just re-ran the query, and the results are the same, as expected. [20:14:49] (CR) Awight: "recheck" [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/486345 (https://phabricator.wikimedia.org/T213943) (owner: Awight) [20:19:46] Hello, I know this might not be exactly the right channel, but perhaps you can point me to where that is. I am trying to create a Central Notice banner, but I am unable to clone any of the current banners as that button is gray-ed out for me. I have auto-confirmed rights on meta, do you know what other permissions I might need to clone and design a banner? Thanks in advance. [20:20:17] @notconfusing hey! [20:20:57] @notconfusing You need to have specific rights to create a banner but you can request one here: https://meta.wikimedia.org/wiki/CentralNotice/Request [20:23:06] notconfusing: You should request one even if you build it yourself [20:24:22] Thanks Seddon, I have opened up a request. So does the request need to be approved before even I can start editing and designing javascript? [20:25:03] This is my open request: https://meta.wikimedia.org/wiki/CentralNotice/Request/CivilServant_Experiment [20:25:25] I will pad it out, and then should I ping someone to give me the banner-clone rights? [20:26:10] (PS1) Awight: [WIP] remove guard to test CI dependency [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/486540 [20:26:18] notconfusing: yeah pad it out, because it might require a review from the legal team [20:28:16] notconfusing: in the mean time, if you want to play about with a sandbox this prototype might be of use to you - https://tools-static.wmflabs.org/centralnotice-bannergenerator/livepreview.html [20:31:14] (Abandoned) Awight: [WIP] remove guard to test CI dependency [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/486540 (owner: Awight) [20:32:24] (CR) Awight: "I've confirmed with I36491b89a89c157e229a83bc83f1ee007d0bb4ff that the tests aren't being skipped by CI, and Extension:Translate integrati" [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/486345 (https://phabricator.wikimedia.org/T213943) (owner: Awight) [20:32:44] ^ I'm officially done messing with that one. [20:33:34] notconfusing: Hi! It's not too difficult to install CentralNotice locally as well. [20:36:41] o/ awight, good tip, and Seddon that looks great (but i'm not sure you can use JS) [20:37:02] awight: are you saying that i make a local mwinstallation, and then run central-notice myself? [20:37:43] exactly. I can help, if you run into trouble [20:38:44] awight: is it easy enough to do it within vagrant? [20:38:47] Banners are usually self-contained, so it's easy to copy and paste between servers. (unfortunately--I pushed for heavier use of templating for a while) [20:38:59] Seddon: yeah, good point! There's a role [20:39:23] "vagrant roles enable centralnotice" [20:40:06] Bare metal is also easy, if notconfusing is already set up to do that. [20:55:29] I do not know what "bare metal" is. Are you suggesting firing up a mw-instance though cloud-vps? [20:58:39] notconfusing: "bare metal" is just a way to distinguish between a local VM like mediawiki-vagrant, and a normal MediaWiki install on your development computer. If you aren't already running your own MediaWiki, it's probably best to go with the sandbox Seddon was suggesting... [20:59:44] gotcha [21:49:28] (CR) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/486605 (owner: L10n-bot) [22:28:43] fundraising-tech-ops: test and deploy payments on Debian Stretch/PHP7.0 - https://phabricator.wikimedia.org/T202290 (Jgreen) >>! In T202290#4907730, @Ejegg wrote: > OK, I'm seeing the loading errors in Chrome now. It's more images inlined into CSS by ResourceLoader as data: urls. This time, it's from cor... [22:34:32] oh weird, I'm not seeing ANY CSP headers on wikipedia now [22:34:38] did folks turn it off? [22:56:58] ah, it's only for logged-in users [23:05:23] Fundraising-Backlog, MediaWiki-extensions-Translate, MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Technical-Debt: Support custom permissions for a subset of translatable pages - https://phabricator.wikimedia.org/T213943 (awight) @fr-tech: Okay, just the main patch left and it'...