[00:00:12] So the wierd thing is I have the files locally in buildkit but the version thing ^^ (1.1.5 vs 1.1.6 ) might relate [00:00:43] the drush version is set to https://github.com/drush-ops/drush/commit/d1d13676f5beacaa9f8619088fe3ae45ea28a6cf which is an old commit & perhaps there are drush fixes [00:00:51] hmm, locally I have a directory Console_Table-1.1.6 [00:01:09] oh, we're checking out a specific sha for drush? [00:01:29] we'd want the latest that works with drupal 7, right? [00:03:48] yeah but that’s the sha I have locally & have the right dir locally too [00:04:42] ah, i see, the pear/console_table is a requirement from buildkit's composer.json [00:05:19] just did a composer update and it removed that package [00:05:55] oh really - it removed it? [00:06:25] yep, there's no vendor/pear dir any more [00:06:42] but there's still vendor/drush/drush/lib/Console_Table-1.1.6 [00:08:41] ahh, but if I delete vendor/drush and composer install again, the Console_Table subdir is gone [00:09:10] so I guess it doesn't come with the drush composer package [00:10:33] boo, drush depends hard on pear server working :( [00:11:00] Hmm - so in buildkit I see https://github.com/civicrm/civicrm-buildkit/blob/master/composer.lock#L184 [00:11:05] which is v 1.1.5 [00:16:52] oh, composer.lock is checked in! [00:17:35] yeah - but I can’t see what is triggering requirement for 1.1.6 [00:17:38] 1.1.5 [00:18:26] eileen: the drush code itself checks for that file, and downloads it automatically :( [00:18:48] right cos it didn’t work - but it still doesn’t [00:18:53] i.e. needs to download random code from the internet and run it [00:19:11] but I guess that's what it WAS doing up till they shut down PEAR [00:19:42] so... buildkit could include a copy and copy it in after composer install [00:20:02] from tinkering with composer … it won’t install it anymore due to semver conflict [00:22:16] so yeah copy in somehow [00:24:20] oh jeez, drush dev-master wanted 1.1.5, that's annoying [00:25:33] well, a wholesale composer update still works, though it does get a lot of newer packages [00:25:52] i.e. bumps semver to 1.4.2 [00:28:47] I’m just trying a general ‘update’ - it uninstalls a whole lot [00:29:03] but that seems right to me - ie why have all that stuff in .lock if not in .json [00:30:38] ok that’s gonna work - we;ll have to switch back to our own repo in the script for now [00:31:30] ok, not such a horrible thing [00:31:55] so, we can download it, but it looks like we still need to copy the durn thing to drush's lib directory [00:32:33] ...or do we? [00:33:18] yeah, looks like we do. It's not relying on the class existing, which would be fine with the composer-installed version [00:33:35] instead, it's using get_file_contents on a specific path [00:34:53] right, needs to have either Console/Table.php in the php include path [00:35:19] or the Console_Table-1.1.6/Table.php in the lib dir [00:39:03] yeah [00:39:17] I’m just pushing up a change to my repo now [00:39:37] it’s here but just fixing a merge conflict https://github.com/civicrm/civicrm-buildkit/compare/master...eileenmcnaughton:master [00:41:25] ok, looks like our gerrit repo still exists [00:43:02] so I'll push the current upstream head to gerrit [00:45:38] oh pooh, doesn't want to let me push totten's commits... [00:45:45] :-( [00:45:51] as i have no 'forge committer' permission [00:46:06] my branch is not up to date https://github.com/eileenmcnaughton/civicrm-buildkit - can we change it to point to there for now? [00:46:36] so how did we get the upstream commits in gerrit in the first place? [00:46:52] eileen: ok, sure, let's use yours [00:48:11] ejegg: hmm https://github.com/civicrm/civicrm-buildkit/pull/442 [00:48:36] ejegg: I have merge rights to that PR.... [00:48:51] oh wow, does drush v8 break our old drush commands? [00:49:14] I suppose I could try locally [00:49:16] I don’t think so [00:49:40] there is some discussion [00:50:03] nobody seems too horrified at the prospect [00:50:06] I’m gonna merge it & see if it helps recheck (I can always revert but it’s kinda merge-ready I think) [00:50:52] :) [00:51:00] we might need to clear out the build dir locally [00:51:03] so it gets a fresh copy [00:51:47] yeah, i guess old-drush is dead for everyone now on first install [00:52:39] well I’ll do recheck & see [00:53:22] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/488202 (owner: Eileen) [00:54:04] (CR) jerkins-bot: [V: -1] Drupal core update [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/488202 (owner: Eileen) [00:54:37] (PS1) Eileen: Re-apply WMF patches [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/488209 [00:55:00] (CR) jerkins-bot: [V: -1] Re-apply WMF patches [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/488209 (owner: Eileen) [00:55:48] d'oh! [00:55:54] Source directory /srv/jenkins-workspace/workspace/wikimedia-fundraising-civicrm/src/wikimedia/fundraising/civicrm-buildkit/vendor/drush/drush has uncommitted changes. [00:56:04] yeah - do you know why? [00:56:08] like, somebody copied something into its lib dir :) [00:56:17] I'll clear out the workspace [00:57:06] I was kinda wondering about that .... [01:00:01] (CR) Ejegg: "recheck" [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/488202 (owner: Eileen) [01:00:28] (CR) jerkins-bot: [V: -1] Drupal core update [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/488202 (owner: Eileen) [01:00:50] oops, missed a server [01:01:07] :-) [01:02:06] (CR) Ejegg: "recheck" [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/488202 (owner: Eileen) [01:04:11] (CR) jerkins-bot: [V: -1] Drupal core update [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/488202 (owner: Eileen) [01:04:58] eileen: nice! just needs our namespace patch [01:05:10] ejegg: why do we need that? [01:05:30] drupal doesn't know how to load namespaced classes on its own [01:05:36] well, d7 [01:05:39] (I think I already put up for review but….) [01:05:53] hmm - is there no extension? anyway can ignore for now [01:05:58] (CR) Ejegg: "recheck" [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/488209 (owner: Eileen) [01:07:02] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/488209 (owner: Eileen) [01:07:16] I set recheck on the one with the patch - https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/drupal/+/488209/ [01:07:24] so did you [01:08:02] :) [01:11:07] so far so good [01:11:41] (CR) jerkins-bot: [V: -1] Re-apply WMF patches [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/488209 (owner: Eileen) [01:12:06] ok, weird, just the SmashPig testRecurringChargeJob failed [01:12:07] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/487312 (https://phabricator.wikimedia.org/T199747) (owner: Eileen) [01:12:10] so... close! [01:12:59] ejegg: so last week I got about 1 run through & it failed on that [01:13:11] so I suspect there is a ‘think’ with that test [01:13:30] k, i'll look into that one [01:14:01] still getting that far endorses my abuse of merge rights :-) [01:15:41] ah, february strikes again in my recurring date math [01:16:06] lol [01:16:55] (CR) jerkins-bot: [V: -1] Improve precautionary test cleanup. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/487312 (https://phabricator.wikimedia.org/T199747) (owner: Eileen) [01:17:05] (PS1) Ejegg: Stop SmashPig test breaking in February [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/488210 [01:17:29] eileen that should do it ^ [01:17:44] (CR) Eileen: [C: +2] "Yep - that's what I concluded too 28 days has February but 1+28 = 29" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/488210 (owner: Ejegg) [01:18:14] ejegg: I think we are back! [01:18:52] do you want to +2 this one - https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/487312/ - it’s CI [01:19:08] sure thing! [01:19:24] ejegg: so in terms of the civi upgrade [01:19:38] 1) it’s drop in place - if there was a problem we could revert it [01:19:47] 2) it’s currently on staging [01:20:03] 3) we really should drop it today or tomorrow [01:20:14] since Caitlin said this week [01:20:55] shall we shoot for tomorrow? it's a bit late here already [01:21:01] yeah I was thinking that [01:21:07] & we need tests to run etc [01:21:41] it just means I’m around less after it drops - but OTOH the fact a revert will work means that matters less [01:22:39] (Merged) jenkins-bot: Stop SmashPig test breaking in February [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/488210 (owner: Ejegg) [01:24:05] (PS2) Ejegg: Improve precautionary test cleanup. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/487312 (https://phabricator.wikimedia.org/T199747) (owner: Eileen) [01:24:36] (CR) Ejegg: [C: +2] Improve precautionary test cleanup. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/487312 (https://phabricator.wikimedia.org/T199747) (owner: Eileen) [01:25:08] (CR) Ejegg: [C: +2] Re-apply WMF patches [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/488209 (owner: Eileen) [01:25:29] (CR) Ejegg: [C: +2] Drupal core update [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/488202 (owner: Eileen) [01:32:10] (CR) jerkins-bot: [V: -1] Drupal core update [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/488202 (owner: Eileen) [01:32:12] (CR) jerkins-bot: [V: -1] Re-apply WMF patches [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/488209 (owner: Eileen) [01:33:01] (PS12) Ejegg: Handling for multiple erase databases [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/469155 (https://phabricator.wikimedia.org/T205332) (owner: Eileen) [01:34:31] (CR) Ejegg: [V: +2 C: +2] Drupal core update [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/488202 (owner: Eileen) [01:35:03] (CR) Ejegg: [C: +2] Re-apply WMF patches [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/488209 (owner: Eileen) [01:37:24] (CR) jerkins-bot: [V: -1] Handling for multiple erase databases [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/469155 (https://phabricator.wikimedia.org/T205332) (owner: Eileen) [01:39:50] (Merged) jenkins-bot: Re-apply WMF patches [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/488209 (owner: Eileen) [01:51:04] (PS1) Ejegg: Update drupal submodule [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/488217 [01:51:10] (CR) Ejegg: [C: +2] Update drupal submodule [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/488217 (owner: Ejegg) [01:55:36] (Merged) jenkins-bot: Update drupal submodule [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/488217 (owner: Ejegg) [01:55:59] (PS1) Eileen: Drupal submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/488220 [01:58:17] eileen: just did that one! [01:58:32] ejegg: i was too slow [01:59:13] feel like doing the rest of the deploy? [01:59:44] almost 9 pm here, i oughtta sign off [02:00:10] ejegg: sure I’ll deploy [02:00:25] thanks! [02:00:28] see you tomorrow [02:00:29] (Abandoned) Eileen: Drupal submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/488220 (owner: Eileen) [02:04:51] (PS1) Eileen: Modules update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/488222 [02:06:59] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/469155 (https://phabricator.wikimedia.org/T205332) (owner: Eileen) [02:07:25] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/487988 (owner: Eileen) [02:08:17] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/488223 [02:09:13] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/487989 (https://phabricator.wikimedia.org/T212825) (owner: Eileen) [02:09:34] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/488223 (owner: Eileen) [02:10:05] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/487333 (https://phabricator.wikimedia.org/T199747) (owner: Eileen) [02:10:15] (Merged) jenkins-bot: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/488223 (owner: Eileen) [02:11:21] (CR) jerkins-bot: [V: -1] Handling for multiple erase databases [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/469155 (https://phabricator.wikimedia.org/T205332) (owner: Eileen) [02:12:46] !log civicrm revision changed from 6042acb363 to 613b388916, config revision is 306b4de48f [02:12:47] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [02:15:31] (CR) jerkins-bot: [V: -1] Change Omnimail Forgetme so that it writes Erase requests to the database & processes in a separate job. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/487333 (https://phabricator.wikimedia.org/T199747) (owner: Eileen) [02:33:28] fundraising-tech-ops, Operations, netops: Deploy pfw policy to allow https to frmon.frdev.wikimedia.org - https://phabricator.wikimedia.org/T215364 (ayounsi) a:ayounsi Done. No diff in codfw, 1 new rule in eqiad. [03:10:33] fundraising-tech-ops, Patch-For-Review: Install private Grafana/Promtheus instance in fundraising - https://phabricator.wikimedia.org/T215182 (cwdent) [03:10:36] fundraising-tech-ops, Operations, netops: Deploy pfw policy to allow https to frmon.frdev.wikimedia.org - https://phabricator.wikimedia.org/T215364 (cwdent) Open→Resolved Working, thanks @ayounsi ! [05:35:11] (Abandoned) Eileen: [WIP] Add index hint [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/474809 (owner: Eileen) [07:30:48] Fundraising-Backlog, Wikimedia-CentralNotice-Administration: Banner and JS review request for 'stewvote' banner (desktop & mobile) - https://phabricator.wikimedia.org/T214773 (AndyRussG) I've refactored the javascript and created a test banner with it: https://meta.wikimedia.org/wiki/Special:CentralNoti... [07:40:21] Fundraising-Backlog, Analytics: Clean up old fundraising-related user data on Analytics hosts - https://phabricator.wikimedia.org/T215382 (elukey) p:Triage→Normal [07:43:44] Fundraising-Backlog, Analytics: Clean up old fundraising-related user data on Analytics hosts - https://phabricator.wikimedia.org/T215382 (elukey) * mwalker ` ====== stat1007 ====== total 648 -rwxr-xr-x 1 2454 wikidev 3400 Nov 11 2013 aggByTime.py drwxr-xr-x 2 2454 wikidev 4096 Nov 11 2013 counts... [15:09:19] fr-tech, popping out to get my car windscreen repaired (for the second time!). back a little bit later [15:10:02] * jgleeson|backsoo gives up trying to be descriptive [15:38:37] Fundraising-Backlog, fundraising-tech-ops: switch fundraising cases where we use GeoIP to GeoIP2 - https://phabricator.wikimedia.org/T215425 (Jgreen) [15:49:39] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: Incorrect protection reason for non-source-language version of... - https://phabricator.wikimedia.org/T213565 [15:51:50] fr-tech anything you'd like me to bring up in Scrum of Scrums? [15:52:03] ejegg: thx nothing here :) [15:58:34] (CR) Ejegg: "The new environment indicator looks like it's fighting with the Civi menu. I guess the green color for the whole menu makes it clear where" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/488222 (owner: Eileen) [15:58:43] Fundraising Sprint Casino Royale With Cheese, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, WikimediaMessages, and 4 others: Missing centralnotice admin protection level messages causing broken edit summaries and strings in Special Pages - https://phabricator.wikimedia.org/T210986 (Andy... [16:04:48] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Window dressing is mostly olive oil, Fundraising Sprint XML ate my homework, and 4 others: Make protection reason localiza... - https://phabricator.wikimedia.org/T210102 [18:23:21] (CR) Umherirrender: [C: +2] build: Updating mediawiki/mediawiki-codesniffer to 24.0.0 [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/488327 (owner: Libraryupgrader) [18:34:14] hauskatze: hi! did you see https://phabricator.wikimedia.org/T214773#4930647 ? [18:39:37] AndyRussG: Going through the backlog of unread notifications [18:39:53] ah okok [18:39:57] :) [18:45:42] (CR) jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 24.0.0 [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/488327 (owner: Libraryupgrader) [18:47:01] hauskatze: I have to be away from the keyboard starting around 1 hour 30 minutes (20:15 UTC), then I'll be back about 2 hours late (around 22:00 UTC) [18:47:29] AndyRussG: just arrived to the ticket, and I wanted to thank you [18:47:29] I think ejegg will also take/has also taken a look at the refactored javascript [18:47:43] hehe no worries, thank you for working on all this stuff!!! [18:47:46] I am testing the banner and it looks okay [18:47:50] cool! [18:48:56] I added the test banner to a test campaign on aa.wikibooks, which is where we normally test stuff when we want to run all the code paths that cause a banner to show [18:49:07] However, I couldn't test it there, since I couldn't log into that project [18:49:24] Anyway, the only part that will not be tested when displaying with the preview button [18:49:37] is the alterImpressionData function [18:49:55] which is there so that we can get data back about actual displays vs. js-caused hides [18:50:52] One way to test that part would be to start the campaign off for a few minutes at a very low level (maybe 1%) and then use the randomCampaign URL parameter to force it to display as partat of a campaign directly on a real project [18:51:03] If you like I can help with that when we get there [19:16:40] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Create queue consumer for contribution tracking - https://phabricator.wikimedia.org/T215453 (Ejegg) [19:24:47] Fundraising-Backlog, Wikimedia-CentralNotice-Administration: Banner and JS review request for 'stewvote' banner (desktop & mobile) - https://phabricator.wikimedia.org/T214773 (MarcoAurelio) I have tested it displays correctly to me using https://meta.wikimedia.org/w/index.php?title=Special:Random&banner=... [19:30:03] Fundraising-Backlog, Wikimedia-CentralNotice-Administration: Banner and JS review request for 'stewvote' banner (desktop & mobile) - https://phabricator.wikimedia.org/T214773 (MarcoAurelio) >>! In T214773#4932711, @MarcoAurelio wrote: > > When I went to aa.wikibooks I guess it's not displaying to me bec... [19:48:23] Fundraising-Backlog, Wikimedia-CentralNotice-Administration: Banner and JS review request for 'stewvote' banner (desktop & mobile) - https://phabricator.wikimedia.org/T214773 (AndyRussG) >>! In T214773#4932729, @MarcoAurelio wrote: >>>! In T214773#4932711, @MarcoAurelio wrote: >> >> When I went to aa.wi... [20:29:08] (PS13) Eileen: Handling for multiple erase databases [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/469155 (https://phabricator.wikimedia.org/T205332) [20:34:29] (CR) jerkins-bot: [V: -1] Handling for multiple erase databases [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/469155 (https://phabricator.wikimedia.org/T205332) (owner: Eileen) [20:48:07] (PS3) Ejegg: Sequence generator interface & classes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/485995 (https://phabricator.wikimedia.org/T214436) [20:48:54] (CR) jerkins-bot: [V: -1] Sequence generator interface & classes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/485995 (https://phabricator.wikimedia.org/T214436) (owner: Ejegg) [20:55:06] Fundraising-Backlog, fundraising-tech-ops, FR-Smashpig: Prepare db and queue server for contribution_tracking switchover - https://phabricator.wikimedia.org/T215461 (Ejegg) [20:55:08] (CR) Eileen: "ejegg I'm inclined to figure the new env is the way it's going & bit the bullet & switch & then find a config that's not too annoying" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/488222 (owner: Eileen) [20:56:22] (CR) Eileen: "I take that back - it worked fine :-) I just didn't realise it had - the env indicator isn't visible with it BUT I think if that's gonna b" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/488222 (owner: Eileen) [20:59:14] (PS2) Eileen: Modules update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/488222 [20:59:16] (PS1) Eileen: New CiviCRM menu extension (goes with Civi update) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/488571 [21:08:06] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: DonationInterface should have an option to use new contribution_tracking infrastructure - https://phabricator.wikimedia.org/T215462 (Ejegg) [21:09:39] ejegg: what do you want to do about reviewing the CiviCRM update? [21:10:14] eileen: hi! been going over it locally [21:10:17] so far so good [21:11:21] ejegg: there are security patches kinda ‘hidden’ in there but nothing too major. [21:15:25] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: CRM contribution tracking writing should have a switch to use the new infrastructure - https://phabricator.wikimedia.org/T215463 (Ejegg) [21:23:34] ejegg: by the way I did a performance test on staging for contribution imports with the new code [21:24:01] conclusion = not worse, maybe better [21:24:35] cool [21:24:37] my peak speed was 444 per min I think & I hit it more consistently with the new code but I did hit it once with the old code [21:24:49] so - can’t be sure what to make of that [21:25:34] dang getting local test fails since I made config changes ;-( Having to debug [21:30:34] Fundraising Sprint Casino Royale With Cheese, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Changes to Benevity report - https://phabricator.wikimedia.org/T215196 (DStrine) [21:39:28] ah my triggers were missing [22:06:47] have a good rest of your week fr-tech, see you monday! [22:06:53] see you ! [22:09:12] (PS1) Eileen: Apply drupal formatting to RefundQueueTest class [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/488590 [22:09:32] ^^ should be an easy + 2 [22:11:17] ejegg: try this with the civi update - https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/488571/ - it’s pretty [22:11:39] k [22:12:29] (CR) Ejegg: [C: +2] Apply drupal formatting to RefundQueueTest class [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/488590 (owner: Eileen) [22:18:05] (Merged) jenkins-bot: Apply drupal formatting to RefundQueueTest class [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/488590 (owner: Eileen) [22:26:18] (PS1) Eileen: Apply drupal formatting to RefundQueueConsumer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/488596 [22:27:10] (CR) Ejegg: [C: +2] Apply drupal formatting to RefundQueueConsumer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/488596 (owner: Eileen) [22:33:04] (Merged) jenkins-bot: Apply drupal formatting to RefundQueueConsumer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/488596 (owner: Eileen) [22:33:12] Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Issue with Engage reconciliation report - https://phabricator.wikimedia.org/T213877 (LeanneS) Thanks for clarifying! I'll make a note going fo... [22:51:26] eileen: nice, I like the slimmer menu and the ability to put it below the drupal admin menu. Looks like that way I can still get a visible environment indicator in prod [22:51:37] ejegg: cool [22:51:54] ejegg does RefundQueueTest::testRefund [22:51:55] pass for you locally? [22:53:35] eileen: lemme see [22:54:52] it just did now, when I only ran the 'Refund' group [22:55:20] hmm - I’m getting a php 7.2 count fail [22:55:53] but it seems refund_trxn_id is not being written to gateway_txn_id - but I can’t se what writes it there in our code [22:56:31] I wondered if it was ‘faux-passing’ < php 7.2 [22:57:24] ie what does count(FALSE) calc pre php 7.2 - if ‘1’ then it’s prob a faux-pass [22:58:50] Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Issue with Engage reconciliation report - https://phabricator.wikimedia.org/T213877 (Eileenmcnaughton) Open→Resolved [22:58:57] oh shoot, really? [23:00:05] i've got 7.2 here as well [23:00:13] so I'm not sure that would be it [23:04:06] i have seen it fail locally before, now that I think about it [23:06:28] I just can’t see what makes it pass - is it tech talk now? [23:06:37] eileen: yep, tech talk time! [23:49:03] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Vestigial tails shoot from the hip, and 5 others: Ingenico: 10/15 or 10/18 a... - https://phabricator.wikimedia.org/T208261 [23:58:47] (PS1) Eileen: FIx duff refund test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/488627