[01:17:46] (CR) Jforrester: [C: +2] build: Update eslint and stylelint configs [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/479731 (owner: Esanders) [01:22:18] (Merged) jenkins-bot: build: Update eslint and stylelint configs [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/479731 (owner: Esanders) [01:32:54] (CR) jenkins-bot: build: Update eslint and stylelint configs [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/479731 (owner: Esanders) [14:35:45] (PS4) Ejegg: A small step in the direction of doing better test cleanup [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/488754 (owner: Eileen) [14:35:49] (CR) Ejegg: [C: +2] A small step in the direction of doing better test cleanup [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/488754 (owner: Eileen) [14:40:14] (Merged) jenkins-bot: A small step in the direction of doing better test cleanup [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/488754 (owner: Eileen) [14:49:00] (PS1) Ejegg: Front-end logging for Ingenico url too short [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/489700 (https://phabricator.wikimedia.org/T210893) [15:04:16] Fundraising-Backlog: Civi Upgrade UI issue: Can't select radio buttons in Civi Search - https://phabricator.wikimedia.org/T215802 (CaitVirtue) [15:05:38] (PS3) Ejegg: Further tweak on data cleanup [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/488776 (owner: Eileen) [15:05:44] (CR) Ejegg: [C: +2] Further tweak on data cleanup [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/488776 (owner: Eileen) [15:09:06] (PS3) Ejegg: Do not remove name fields from payment token [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/482356 (owner: Eileen) [15:09:12] (CR) Ejegg: [C: +2] Do not remove name fields from payment token [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/482356 (owner: Eileen) [15:10:02] (Merged) jenkins-bot: Further tweak on data cleanup [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/488776 (owner: Eileen) [15:12:36] (PS2) Ejegg: Kill buffies, give vamps a break [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/488830 (owner: Eileen) [15:12:44] (CR) Ejegg: [C: +2] Kill buffies, give vamps a break [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/488830 (owner: Eileen) [15:13:26] (PS2) Ejegg: Turn of backupGlobals in phpunit.xml [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/488852 (owner: Eileen) [15:13:32] (CR) Ejegg: [C: +2] Turn of backupGlobals in phpunit.xml [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/488852 (owner: Eileen) [15:14:13] (Merged) jenkins-bot: Do not remove name fields from payment token [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/482356 (owner: Eileen) [15:18:22] (Merged) jenkins-bot: Kill buffies, give vamps a break [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/488830 (owner: Eileen) [15:18:27] (Merged) jenkins-bot: Turn of backupGlobals in phpunit.xml [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/488852 (owner: Eileen) [15:40:09] morning fr-tech! [15:40:23] forgot to sign on here till just now... [15:47:00] ejegg: morningsies [15:47:12] hi AndyRussG|ish ! [15:47:29] * AndyRussG|ish makes googlie-eyed face to summarize crazy crazy non-work craziness of the weekend [15:47:45] oh boy... [15:47:51] I tell ya [15:47:53] Actually gonna take a short nap, back at the keyboard in 45 min [15:48:02] k, sleep well [15:48:27] :) thx [16:03:19] mepps: just saw your email. let me know when you're available for 1:1 [16:05:12] Seddon: what's the process for dealing with the centralnotice community requests? I see some of those requests have messaages of support and others don't. Is there a threshold to start creating banners? [16:15:05] Wikimedia-Fundraising-Banners, MediaWiki-extensions-CentralNotice: POTY banners are causing client side error during banner display on mobile AND desktop - https://phabricator.wikimedia.org/T215711 (Pcoombe) The issue with RML.js should be fixed, although I don't understand why these banners were includi... [16:28:48] hey ejegg only just got home and got relieved of childcare duty, AndyRussG do you mind if i check in with ejegg for 15, then you? [16:29:29] AndyRussG|ish ^^ [16:29:55] mepps: all good! [16:30:09] cool, ejegg, you there? [16:31:43] mepps: here i am, will be in the mtg in a sec [16:32:05] (using hangout link from our meeting) [16:49:19] AndyRussG i'm available [16:55:03] mepps: ok cool! Sorry I just saw this... I'm in the hangout [17:37:17] Fundraising-Backlog: Civi Upgrade UI issue: Can't select radio buttons in Civi Search - https://phabricator.wikimedia.org/T215802 (CaitVirtue) I've found some additional search problems....{F28193130} When I try to search for myself by last name, i don't get any results. :-( [18:05:36] Fundraising-Backlog: Civi Upgrade UI issue: Can't select radio buttons in Civi Search - https://phabricator.wikimedia.org/T215802 (CaitVirtue) Leanne's got issues too....i think it's safe to say that the Quick Search bar is generally misbehaving... [18:07:27] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi 2/11/2019 result switcher bug? contribs not reaching Civi - https://phabricator.wikimedia.org/T215828 (MBeat33) [18:11:05] Fundraising-Backlog: Civi Upgrade UI issue: Quick Search doesn't work consistently or well - https://phabricator.wikimedia.org/T215802 (CaitVirtue) [18:26:04] Fundraising Sprint Casino Royale With Cheese, Fundraising-Backlog, Unplanned-Sprint-Work: Civi Upgrade UI issue: Quick Search doesn't work consistently or well - https://phabricator.wikimedia.org/T215802 (DStrine) p:Triage→Unbreak! [18:26:23] Fundraising Sprint Casino Royale With Cheese, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi 2/11/2019 result switcher bug? contribs not reaching Civi - https://phabricator.wikimedia.org/T215828 (DStrine) p:Triage→Unbreak! [18:29:14] hmmm [18:41:28] cstone are you around? [18:41:43] Fundraising-Backlog: Check and improve procedures and doc about code review, testing and linting of banner JS - https://phabricator.wikimedia.org/T214412 (AndyRussG) Another issue: {T215711}. [18:41:43] hello! [18:41:47] hi! [18:42:15] want any help working through the payments-wiki setup we were doing friday? [18:42:32] I'm available for a call if you want to debug this stuff live [18:44:43] yeah maybe in a bit, I'm was looking at my debugger setup this morning and found some issues that I think I can fix [18:44:59] ok, cool [18:54:21] Fundraising Sprint Casino Royale With Cheese, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi 2/11/2019 result switcher bug? contribs not reaching Civi - https://phabricator.wikimedia.org/T215828 (Ejegg) Looks like we're actually OK - the vast majority of today's txns at the console are from... [18:56:27] Wikimedia-Fundraising-Banners, MediaWiki-extensions-CentralNotice: POTY banners are causing client side error during banner display on mobile AND desktop - https://phabricator.wikimedia.org/T215711 (Jdlrobson) p:High→Normal Confirming the fix. Leaving open in case you have any follows up to do he... [19:18:09] ejegg ok my debugger is fixed and I see the right credentials going to the Authenticator [19:20:15] cstone: ok, cool. but you're still getting an error back from ingenico? [19:25:50] ejegg yeah still the MISSING_OR_INVALID_AUTHORIZATION [19:26:23] ok, let's debug into the Api call to see why it's not adding that stuff [19:26:38] want to hop on a call? [19:27:02] ok sure just a sec [19:27:10] cool, i'll be in the usual hangout [19:41:58] Fundraising Sprint Casino Royale With Cheese, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi 2/11/2019 result switcher bug? contribs not reaching Civi - https://phabricator.wikimedia.org/T215828 (MBeat33) Ah, thank you @Ejegg that makes sense - sorry for the false alarm! [20:08:20] Fundraising Sprint Casino Royale With Cheese, Fundraising-Backlog, Unplanned-Sprint-Work: Civi Upgrade UI issue: Quick Search doesn't work consistently or well - https://phabricator.wikimedia.org/T215802 (mepps) Both issues appear to be caused by the js in the selector. Unfortunately I'm trying to re... [20:40:30] Fundraising Sprint Casino Royale With Cheese, Fundraising-Backlog, Unplanned-Sprint-Work: Civi Upgrade UI issue: Quick Search doesn't work consistently or well - https://phabricator.wikimedia.org/T215802 (Eileenmcnaughton) I just disabled the extension that makes the menu responsive now & it seems to... [21:05:23] cwd and Jeff_Green: anything to discuss with fr-tech? [21:05:41] we're all done our other chat, so feel free to join in any time [21:06:08] ejegg: nope, I'm mainly still figuring out the geoip2 situation [21:06:31] Fundraising Sprint Casino Royale With Cheese, Fundraising-Backlog, Unplanned-Sprint-Work: Civi Upgrade UI issue: Quick Search doesn't work consistently or well - https://phabricator.wikimedia.org/T215802 (Eileenmcnaughton) I was able to replicate this off our site - I have logged upstream - expect I'... [21:07:34] down in a rabbit hole w/ grafana atm [21:26:57] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Investigate error tracking for in-banner JS - https://phabricator.wikimedia.org/T215842 (AndyRussG) [21:27:17] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Investigate error tracking and alerts for in-banner JS - https://phabricator.wikimedia.org/T215842 (AndyRussG) [21:29:06] Wikimedia-Fundraising-Banners, MediaWiki-extensions-CentralNotice: POTY banners are causing client side error during banner display on mobile AND desktop - https://phabricator.wikimedia.org/T215711 (AndyRussG) >>! In T215711, @Jdlrobson wrote: > consider during the render process of a banner catching any... [21:41:35] Fundraising Sprint Casino Royale With Cheese, Fundraising-Backlog, Unplanned-Sprint-Work: Civi Upgrade UI issue: Quick Search doesn't work consistently or well - https://phabricator.wikimedia.org/T215802 (CaitVirtue) Everything seems to have been fixed, with the exception of the Last Name search. It... [21:56:12] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Investigate error tracking and alerts for in-banner JS - https://phabricator.wikimedia.org/T215842 (Jdlrobson) I wrote a blog post about this here if you are interested: https://medium.com/freely-sharing-the-sum-of-all-knowledge/were-going-on-a-bug... [21:59:22] Fundraising Sprint Casino Royale With Cheese, Fundraising-Backlog, Unplanned-Sprint-Work: Civi Upgrade UI issue: Quick Search doesn't work consistently or well - https://phabricator.wikimedia.org/T215802 (LeanneS) The name search returned results so it appears to be working for me now. [22:02:36] Fundraising Sprint Casino Royale With Cheese, Fundraising-Backlog, Unplanned-Sprint-Work: Civi Upgrade UI issue: Quick Search doesn't work consistently or well - https://phabricator.wikimedia.org/T215802 (Eileenmcnaughton) It turns out the issue was that you needed to click on the word not the circle... [22:03:34] Check the comment here - https://github.com/aydun/uk.squiffle.kam/issues/45#issuecomment-462509552 - someone should use that for a sprint name …. :-) [22:07:03] haha [22:07:07] brilliant [22:19:40] Fundraising Sprint Casino Royale With Cheese, Fundraising-Backlog, Recurring-Donations: research recurring upsell - https://phabricator.wikimedia.org/T215340 (Ejegg) So we'll have to go through this one processor by processor to see which support a one-time payment with the option to set up recurring... [22:22:29] ugh, paypal express checkout is deprecated [22:22:49] there's a new new thing just called paypal checkout [22:23:25] fundraising casino royale lol [22:23:58] :) gotta keep it fun [22:24:45] * hauskatze breaks the bank and routes all WMF donations to this bank account [22:25:50] unfortunately some scammers did that some weeks ago via fake banners iirc? [22:26:20] (PS7) Eileen: Handle multiple erase DBs & Change Omnimail Forgetme so that it writes Erase requests to the database & processes in a separate job [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/487333 (https://phabricator.wikimedia.org/T205332) [22:27:10] see ya, sleep [22:27:32] hauskatze: there was a malware chrome extension that inserted banners with someone else's bitcoin address [22:30:50] (CR) jerkins-bot: [V: -1] Handle multiple erase DBs & Change Omnimail Forgetme so that it writes Erase requests to the database & processes in a separate job [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/487333 (https://phabricator.wikimedia.org/T205332) (owner: Eileen) [22:34:13] Fundraising Sprint Casino Royale With Cheese, Fundraising-Backlog, Recurring-Donations: research recurring upsell - https://phabricator.wikimedia.org/T215340 (Ejegg) For PayPal, it looks like we need to explicitly have the donor agree to recurring payments on PayPal's site. So we would have to bounce... [22:43:18] (PS19) Eileen: Handling for multiple erase databases [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/469155 (https://phabricator.wikimedia.org/T205332) [22:43:20] (PS1) Eileen: Make sure omnirecipient showme always returns something to ensure forgetme is called [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/489908 [22:44:37] (PS20) Eileen: Handling for multiple erase databases [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/469155 (https://phabricator.wikimedia.org/T205332) [22:47:30] (CR) jerkins-bot: [V: -1] Make sure omnirecipient showme always returns something to ensure forgetme is called [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/489908 (owner: Eileen) [22:49:43] (CR) jerkins-bot: [V: -1] Handling for multiple erase databases [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/469155 (https://phabricator.wikimedia.org/T205332) (owner: Eileen) [22:50:28] (PS21) Eileen: Handling for multiple erase databases [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/469155 (https://phabricator.wikimedia.org/T205332) [22:50:30] (PS2) Eileen: Make sure omnirecipient showme always returns something to ensure forgetme is called [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/489908 [22:51:06] (PS16) Eileen: Updated version of extended reports [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/477452 [22:52:36] yowza, icinga addled again? [22:54:38] (CR) jerkins-bot: [V: -1] Make sure omnirecipient showme always returns something to ensure forgetme is called [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/489908 (owner: Eileen) [22:55:19] (CR) jerkins-bot: [V: -1] Handling for multiple erase databases [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/469155 (https://phabricator.wikimedia.org/T205332) (owner: Eileen) [23:33:04] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Wikimedia-production-error, good first bug: Viewing Special:CentralNoticeBanners subpage can throw fatal BannerExistenceException - https://phabricator.wikimedia.org/T149240 (Cstone) a:Cstone [23:39:31] Fundraising Sprint Casino Royale With Cheese, Fundraising-Backlog, Recurring-Donations: research recurring upsell - https://phabricator.wikimedia.org/T215340 (Ejegg) p:Triage→High a:Ejegg [23:40:58] cwd guessing those nagios mails are false alarms? [23:41:25] ejegg: oh you got those? yeah... [23:41:57] any idea what's wrong with icinga? [23:42:19] this is on the main cluster, icinga process stops responding to nsca checks, there is scrollback in -operations [23:42:25] i don't have access to the server to restart it [23:43:05] Fundraising Sprint Casino Royale With Cheese, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Changes to Benevity import - https://phabricator.wikimedia.org/T215196 (Eileenmcnaughton) [23:43:20] Fundraising Sprint Casino Royale With Cheese, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Changes to Benevity import - https://phabricator.wikimedia.org/T215196 (Eileenmcnaughton) a:Eileenmcnaughton [23:46:02] cwd ah, got it. so plenty of other folks are getting bothered by this too, huh? [23:47:00] Fundraising Sprint Casino Royale With Cheese, Fundraising-Backlog, Unplanned-Sprint-Work: Civi Upgrade UI issue: Quick Search doesn't work consistently or well - https://phabricator.wikimedia.org/T215802 (Eileenmcnaughton) a:Eileenmcnaughton [23:47:03] ejegg: actually we are the only ones who use this particular service [23:47:08] nagios_nsca [23:47:17] ohh man, we're special in yet another way :P [23:49:28] yeah... SRE does not seem to have a grudge about it though :) [23:49:38] we phone home to the icinga master with checks, instead of getting polled [23:49:46] so in theory it's less work for the master [23:50:23] but we are hitting some sort of bug [23:50:40] where the nsca listening process goes to space