[00:00:23] (CR) AndyRussG: [C: +2] Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/489309 (owner: AndyRussG) [00:06:04] (Merged) jenkins-bot: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/489309 (owner: AndyRussG) [00:09:43] fr-tech as per suggestions from releng, deploying CN update now rather than on the train [00:13:14] (CR) jenkins-bot: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/489309 (owner: AndyRussG) [00:13:14] Also fr-tech thcipriani (Tyler) created this neat patch that fixes the whole CN deployments mess: https://gerrit.wikimedia.org/r/#/c/mediawiki/tools/release/+/489906/ [00:27:41] Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: Add null banner preview to CentralNotice for performance testing baseline - https://phabricator.wikimedia.org/T215086 (... [00:30:40] (PS1) Eileen: Update composer to omnimail-silverpop supporting multiple databases [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/489920 [00:35:19] (PS22) Eileen: Handling for multiple erase databases [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/469155 (https://phabricator.wikimedia.org/T205332) [00:35:33] (CR) jerkins-bot: [V: -1] Update composer to omnimail-silverpop supporting multiple databases [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/489920 (owner: Eileen) [00:40:13] (CR) jerkins-bot: [V: -1] Handling for multiple erase databases [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/469155 (https://phabricator.wikimedia.org/T205332) (owner: Eileen) [00:40:20] (PS23) Eileen: Handling for multiple erase databases [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/469155 (https://phabricator.wikimedia.org/T205332) [00:40:46] (Abandoned) Eileen: Update composer to omnimail-silverpop supporting multiple databases [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/489920 (owner: Eileen) [00:46:41] (PS1) Eileen: Update KAM menu with qs fix [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/489926 (https://phabricator.wikimedia.org/T215802) [00:49:56] This is the proper fix for that quicksearch bug https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/489926/ if anyone wants to review - I’ve put it on staging & re-enabled the extenson [00:59:03] (PS8) Eileen: Change Omnimail Forgetme so that it writes Erase requests to the database & processes in a separate job [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/487333 (https://phabricator.wikimedia.org/T199747) [01:04:13] (CR) jerkins-bot: [V: -1] Change Omnimail Forgetme so that it writes Erase requests to the database & processes in a separate job [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/487333 (https://phabricator.wikimedia.org/T199747) (owner: Eileen) [01:15:57] (PS9) Eileen: Change Omnimail Forgetme so that it writes Erase requests to the database & processes in a separate job [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/487333 (https://phabricator.wikimedia.org/T199747) [01:21:23] (CR) jerkins-bot: [V: -1] Change Omnimail Forgetme so that it writes Erase requests to the database & processes in a separate job [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/487333 (https://phabricator.wikimedia.org/T199747) (owner: Eileen) [01:49:05] AndyRussG: how did the deploy go? [01:49:22] ejegg: oh we broke al the wikis [01:49:24] jk! [01:51:16] Just putting off closing one until I do an actual edit on a banner to test the tags [01:51:35] One I did close (the null banner one) [01:51:42] And the last one could be fully closed by someone else, maybe [01:51:48] ^ referring to tasks [01:52:13] Ah and the serious answer to your question is, fine. [01:55:33] haha [02:03:20] 'in general, we should avoid special cases' but in special cases we can make an exception :) [02:06:58] (PS10) Eileen: Change Omnimail Forgetme so that it writes Erase requests to the database & processes in a separate job [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/487333 (https://phabricator.wikimedia.org/T199747) [02:08:51] (CR) Eileen: [C: +2] Remove update to field missing on dev instances [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/489009 (owner: Ejegg) [02:14:08] (CR) Ejegg: [C: +2] Update KAM menu with qs fix (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/489926 (https://phabricator.wikimedia.org/T215802) (owner: Eileen) [02:15:22] (CR) jerkins-bot: [V: -1] Change Omnimail Forgetme so that it writes Erase requests to the database & processes in a separate job [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/487333 (https://phabricator.wikimedia.org/T199747) (owner: Eileen) [02:15:24] (PS11) Eileen: Change Omnimail Forgetme so that it writes Erase requests to the database & processes in a separate job [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/487333 (https://phabricator.wikimedia.org/T199747) [02:15:47] (Merged) jenkins-bot: Remove update to field missing on dev instances [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/489009 (owner: Ejegg) [02:16:38] (Abandoned) Eileen: Make sure omnirecipient showme always returns something to ensure forgetme is called [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/489908 (owner: Eileen) [02:20:21] hmm is there a problem with gerrit [02:20:40] ah yes I see the msg now [02:22:51] thanks for getting that fixed so quick! [02:23:24] gonna sign off now. have a good day / night! [02:24:01] (PS2) Ejegg: Update KAM menu with qs fix [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/489926 (https://phabricator.wikimedia.org/T215802) (owner: Eileen) [02:26:01] (CR) Eileen: "I'm OK with updating to the latest but it's probably moved a bit since this...." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/481094 (owner: Ejegg) [02:26:29] (Abandoned) Eileen: DO NOT MERGE: Debug SQL for test errors [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/464166 (owner: Ejegg) [02:27:01] (Abandoned) Ejegg: Update Shoreditch to 0.1-alpha30 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/481094 (owner: Ejegg) [02:28:11] (CR) Eileen: [C: +1] "Just adding +1 to test gerrit weirdness & see if this 'change' makes it go away" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/487333 (https://phabricator.wikimedia.org/T199747) (owner: Eileen) [02:28:28] (CR) Eileen: "it kinda did" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/487333 (https://phabricator.wikimedia.org/T199747) (owner: Eileen) [04:42:56] Fundraising Sprint Casino Royale With Cheese, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Changes to Benevity import - https://phabricator.wikimedia.org/T215196 (Eileenmcnaughton) Just a quick note to say I've grabbed the file & these are the changes 1)** Columns renamed ** Participatin... [04:46:31] (PS1) Eileen: WIP - Adjust Benevity import to reflect changed csv from Benevity [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/489952 (https://phabricator.wikimedia.org/T215196) [04:51:43] (CR) jerkins-bot: [V: -1] WIP - Adjust Benevity import to reflect changed csv from Benevity [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/489952 (https://phabricator.wikimedia.org/T215196) (owner: Eileen) [05:25:27] I’m running some big queries on staging replica (in case of issues) [06:11:26] Fundraising Sprint Owls, Fundraising Sprint Pluto is still a planet, Fundraising Sprint Queue is pronounced GJif, Fundraising Sprint Raw data can give you salmonella, and 3 others: Mailing data double counting in CiviCRM? - https://phabricator.wikimedia.org/T200240 (Eileenmcnaughton) I am just fo... [06:14:53] Fundraising-Backlog: Re-run omnirecipient repair to catch the few missed ones - https://phabricator.wikimedia.org/T215865 (Eileenmcnaughton) p:Triage→Normal [06:16:03] Fundraising-Backlog: Re-run omnirecipient repair to catch the few missed ones - https://phabricator.wikimedia.org/T215865 (Eileenmcnaughton) [06:16:43] Fundraising-Backlog: Re-run omnirecipient repair to catch the few missed ones - https://phabricator.wikimedia.org/T215865 (Eileenmcnaughton) [06:18:20] (PS1) Eileen: Adjust different on omnirecipient repair - then I can kick it off & catch a few more [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/489969 (https://phabricator.wikimedia.org/T215865) [06:23:17] (CR) jerkins-bot: [V: -1] Adjust different on omnirecipient repair - then I can kick it off & catch a few more [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/489969 (https://phabricator.wikimedia.org/T215865) (owner: Eileen) [14:23:44] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/490059 [14:23:49] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/490059 (owner: Ejegg) [14:24:44] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/490059 (owner: Ejegg) [14:31:49] (PS5) Ejegg: Remove unused banner preview support [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/484784 (https://phabricator.wikimedia.org/T161907) (owner: Awight) [14:32:10] (CR) Ejegg: "PS5: manual rebase" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/484784 (https://phabricator.wikimedia.org/T161907) (owner: Awight) [14:36:17] (CR) jerkins-bot: [V: -1] Remove unused banner preview support [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/484784 (https://phabricator.wikimedia.org/T161907) (owner: Awight) [15:03:12] !log updated fundraising CiviCRM from a541a83cb2 to 02ea871b88 [15:03:13] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [15:04:43] (PS6) Ejegg: Remove unused banner preview support [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/484784 (https://phabricator.wikimedia.org/T161907) (owner: Awight) [16:39:58] (CR) Ejegg: [C: -1] "Thanks for this surgery! On my instance, it looks like it removes the (Preview on-wiki) link and stacks the banner list diagonally though." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/484784 (https://phabricator.wikimedia.org/T161907) (owner: Awight) [18:01:13] Fundraising-Backlog: Edits to text on payments page - https://phabricator.wikimedia.org/T215939 (TSkaff) [18:02:23] mepps are you about? [18:18:53] Fundraising-Backlog: Edits to text on payments page - https://phabricator.wikimedia.org/T215939 (DStrine) @Ejegg as fyi The lack of translations is probably a bug. @MBeat33 might have concerns if we remove this. [18:25:29] Fundraising-Backlog: Edits to text on payments page - https://phabricator.wikimedia.org/T215939 (TSkaff) @DStrine Thanks David; and if it's a bug, can anyone tell me into which languages we have it translated? [19:15:08] well shoot, I'm getting a '502 bad gateway' from payments.frdev on the return from Amazon [19:19:13] cwd / Jeff_Green is there some special web server config needed to handle /index.php/Special:AmazonGateway as a URL? [19:19:33] Seems like payments2003 can only handle /index.php?title=Special:AmazonGateway [19:20:05] yes, the nginx proxy does some URL filtering, so we'll need to add it [19:20:33] ah, got it [19:20:42] is that the only new URL? [19:22:39] that filter is currently looking for /index\.php($|/) [19:25:35] I guess we'd want it set up just like it is on payments1001-4 [19:25:45] err, payments1001-3 [19:25:53] it is the same [19:26:08] the issue is "?title=" vs "/" [19:26:36] really? https://payments.wikimedia.org/index.php/Special:AmazonGateway works [19:26:54] while https://payments.frdev.wikimedia.org/index.php/Special:AmazonGateway gives me '502 bad gateway' [19:26:56] orlly [19:27:31] maybe it's something else then, looking [19:28:18] maybe it's mediawiki-side? though the settings are all copied too [19:28:24] could be a 1.27 vs 1.31 thing [19:28:51] I think I see it [19:29:28] I had to do a bunch of puppet templaty fu to percolate payments.frdev.wm.o through all the places where the hostname is used in configs, and I seem to have missed one in the apache vhost file [19:29:33] fixing [19:32:32] thanks! [19:48:51] (PS1) Ejegg: Make email explanation translatable [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/490135 (https://phabricator.wikimedia.org/T215939) [19:49:29] Fundraising-Backlog, Patch-For-Review: Edits to text on payments page - https://phabricator.wikimedia.org/T215939 (Ejegg) It wan't translatable before (just a quick hack to get something for IE and GB) but it will be once we get that patch merged ^^^ [19:49:49] fr-tech ^^^ should be a quick one [19:50:24] no rush to deploy it, but the sooner we get that message into the json file the sooner the translation elves will give us other language versions [19:51:40] man, that one shoemaker story really brought elves down a peg. [19:52:20] basically oompa loompa status [19:52:49] except i guess the elves are volunteers [20:06:29] lol - I took a quick look & it mostly made sense but there are some changes I’d need to spend time learning to +2 that so I’ll leave for a couple of hours & see if someone else jumps in [20:15:10] ejegg, I'm just looking at your patch and was gonna push through an ingenico sandbox transaction but I've getting invalid credentials back from ingencio, did we change them when I was away? [20:15:22] I'm* [20:22:33] PROBLEM - check_payments_wiki on payments2003 is CRITICAL: HTTP CRITICAL: HTTP/1.1 200 OK - string OK not found on https://payments2003.frack.codfw.wmnet:443https://payments.frdev.wikimedia.org/index.php/Special:SystemStatus - 686 bytes in 0.011 second response time [20:23:00] YES. Nope. [20:23:06] :-) [20:23:13] nginx has become my enemy [20:23:47] how so? [20:25:26] jgleeson: ah yah, the old ones expired at the end of january [20:25:36] ah cool [20:25:40] where do we keep them again [20:25:44] I forget [20:25:50] jgleeson: the new ones are in the SmashPig/sandbox-config folder [20:25:55] in the settings repo [20:25:58] thanks! [20:26:07] jgleeson: it seems as if the config syntax has changed slightly [20:26:10] you'll copy them into your local etc/smashpig/ingenico folder [20:27:20] (PS2) Eileen: WIP - Adjust Benevity import to reflect changed csv from Benevity [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/489952 (https://phabricator.wikimedia.org/T215196) [20:27:33] RECOVERY - check_payments_wiki on payments2003 is OK: HTTP OK: HTTP/1.1 200 OK - 678 bytes in 0.011 second response time [20:29:42] ah I see Jeff_Green, I've not done much with nginx but I remember the config looking a lot more familiar in a 'code like' manner than apache and others [20:30:06] yeah that's true [20:37:59] nginx config *looks* like code but behaves in confusing and nondeterministic ways [20:38:11] :) [20:41:04] also the documentation is a bad joke [20:41:19] and it's basically shareware [20:49:59] hmm, that page is an 'OK' now on payments.frdev [20:50:09] yes that's me [20:50:25] there may be two lines of breakage [20:51:05] it seems like it's handling the regular expression differently, but I can't find any documentation that would explain (A) what the syntax should be or (B) whether it should be different in 10.0.x [20:51:47] the second line of breakage is I think around handling of proxy_* settings, that TBD [21:01:25] ejegg: quick question [21:01:33] eileen: what's up? [21:01:35] the new benevity report gives 3 * fees [21:01:51] oh fun [21:01:54] one is the on the matching gift, so set that aside [21:01:55] let me see [21:01:58] & then there were 2 [21:02:14] so one if the processor & one is a Benevity fee I think [21:02:20] shall I just add them together? [21:02:39] (https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/489952/ commit message kinda details ) [21:02:40] yeah, that sounds right [21:03:53] ok cool [21:14:12] INNNNTERESTING [21:14:54] I guess this makes sense, sorta, but nginx ignores GET args when matching a regex for location [21:45:50] (CR) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/490160 (owner: L10n-bot) [21:56:53] (PS3) Eileen: Adjust Benevity import to reflect changed csv from Benevity [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/489952 (https://phabricator.wikimedia.org/T215196) [22:07:46] Fundraising-Backlog, Patch-For-Review: Re-run omnirecipient repair to catch the few missed ones - https://phabricator.wikimedia.org/T215865 (Eileenmcnaughton) [22:08:56] Fundraising-Backlog, Patch-For-Review: Re-run omnirecipient repair to catch the few missed ones - https://phabricator.wikimedia.org/T215865 (Eileenmcnaughton) [22:10:38] cwd Jeff_Green can I force rotation on the stagng slow query log - I want to run an import & analyse just the queries from that import [22:10:55] hmmm [22:13:58] ah I think I know what I’ve done in the past [22:14:10] I can set a tail on it to a new file when I start my job [22:15:00] hmm gonna take a break - some noise probs here due to handy man efforts [22:15:15] means time for whatever meal I’m up to :-) [22:45:41] (CR) Jgleeson: "@ejegg, could you explain how to test this please?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/490135 (https://phabricator.wikimedia.org/T215939) (owner: Ejegg) [23:41:57] (PS2) Ejegg: Make email explanation translatable [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/490135 (https://phabricator.wikimedia.org/T215939) [23:42:31] (CR) Ejegg: "Sorry that wasn't clear - instructions added in the commit message" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/490135 (https://phabricator.wikimedia.org/T215939) (owner: Ejegg) [23:56:06] Fundraising Sprint Casino Royale With Cheese, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Changes to Benevity import - https://phabricator.wikimedia.org/T215196 (Eileenmcnaughton) I tested importing the first 20 rows on staging & it looks good - I think the changes are f... [23:56:54] ok - looks like the benevity import changes are ok from a code POV & reviewable [23:56:59] but renaming = ug