[00:00:00] renaming what? [00:00:19] oh, the columns? [00:00:48] or the donors? [00:06:43] ejegg: the donors :-( [00:06:59] oh jeez [00:07:03] I think the code changes were not too complex really [00:07:12] now benevity uses nicknames! [00:07:15] but I think the donors is a manual task [00:07:37] it used nicknames for a while because MG didn’t want to name them ‘the thing that Benevity calls them' [00:07:59] oh, for real it used the nickname field? [00:07:59] Which might be a good thing now since we just need to tweak the nick_names not the names - which could be more confusing [00:08:07] yeah - like an override [00:08:39] there are only 161 benevity orgs so I think it’sjust a manual task :-( [00:09:13] Diff topic - that failmail that just came in seems wrong [00:09:16] refund out by a lot [00:09:27] no maybe I misread [00:09:44] oh - locally generated! [00:09:46] arg [00:10:43] hmm [00:28:01] hey ejegg, thanks for explaining how to test the patch. I'm not seeing the message after pulling down the patch and adding the variant param to the url [00:28:30] jgleeson: you're up late! [00:28:37] the joys of a newborn [00:28:44] Oh, so it does depend on the 'variant' directory being configured [00:28:51] it's my "shift" :) [00:28:58] ah ok [00:29:06] if you're on the fundraising/REL1_27 branch of mediawiki, it should have a form_variants directory [00:29:16] at the root of the wiki repo [00:29:21] *mediawiki repo [00:29:42] if that's not there, try updating your local [00:29:55] yup it's there [00:30:12] with subfolders for pgp [00:30:13] ah, let's add something to the vagrant config then [00:30:39] $wgDonationInterfaceVariantConfigurationDirectory = '/vagrant/srv/mediawiki-fr/form_variants/' [00:33:01] hmm I added that to the usual place for DI wiki global config and refreshed and still not seeing a message? [00:33:33] hmm hmm, so let's see if other ones work [00:34:09] for the ingenico gateway, there should be a no_state variant that removes the state dropdown for country=US [00:34:13] does that work? [01:12:53] sorry ejegg|afk Matilda woke up. I thought she go down for an hour but proved me wrong. I'll catch yup with you in the morning. Night! [01:50:55] Fundraising Sprint Casino Royale With Cheese, Fundraising-Backlog, Unplanned-Sprint-Work: Civi Upgrade UI issue: Quick Search doesn't work consistently or well - https://phabricator.wikimedia.org/T215802 (Eileenmcnaughton) @LeanneS @CaitVirtue good to close now? [01:58:55] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising-Backlog, and 2 others: Upgrade PaymentsWiki to Mediawiki 1.31 (new LTS) - https://phabricator.wikimedia.org/T184460 (Ejegg)... [13:19:54] Fundraising Sprint Casino Royale With Cheese, Fundraising-Backlog, Unplanned-Sprint-Work: Civi Upgrade UI issue: Quick Search doesn't work consistently or well - https://phabricator.wikimedia.org/T215802 (CaitVirtue) I think so....we should probably send a note to Civi users that the Last Name search... [16:22:18] (CR) Mepps: [C: +1] "The code looks good but I'm not sure how to test this." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/489700 (https://phabricator.wikimedia.org/T210893) (owner: Ejegg) [16:31:13] fr-tech any news for scrum of scrums? [16:31:35] nothing here [16:32:57] ejegg, looks like my variants setup isn't working. I'm getting some jquery include errors on mw which might explain why so I'm tryna find out where variants are called/included to work through it [16:33:22] ok, I'd be happy to help step through stuff after meetings [16:34:40] it might be tricky to have a call as I'm watching Oscar but he's watching tv. i imagine if he hears me talking to someone he'll become interested and the game will be up :) [16:36:35] actually ping me when you're free ejegg and I'll find a quiet space for a quick walk through the issue [16:52:48] jgleeson: ok, scrum of scrums is over. I'm free for a chat whenever [16:55:51] cool, give me 1 minute [16:55:58] just gonna switch to mobile connection [16:58:34] ejegg, wanna jump into the usual hangout now ? [16:58:38] ok, i'm there [17:06:33] fundraising-tech-ops: Update Maxmind IP addresses - https://phabricator.wikimedia.org/T216051 (cwdent) [17:20:48] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising-Backlog, and 2 others: Upgrade PaymentsWiki to Mediawiki 1.31 (new LTS) - https://phabricator.wikimedia.org/T184460 (cwdent... [17:23:29] ok, the vagrant patch is updated: https://gerrit.wikimedia.org/r/490268 [17:23:59] (CR) Jgleeson: [C: +2] "Code looks good. I'm seeing the message as expected when 'variant=emailExplain' query param is passed." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/490135 (https://phabricator.wikimedia.org/T215939) (owner: Ejegg) [17:34:19] (Merged) jenkins-bot: Make email explanation translatable [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/490135 (https://phabricator.wikimedia.org/T215939) (owner: Ejegg) [18:02:36] PROBLEM - check_procs on frdb1001 is CRITICAL: PROCS CRITICAL: 1042 processes [18:03:17] shoot, what's all that failmail [18:03:39] looks like the db is getting whooped [18:06:41] looks like 3 dedupe queries at once [18:07:14] nnichols, are you on here? [18:10:45] Fundraising Sprint Casino Royale With Cheese, Fundraising-Backlog, Unplanned-Sprint-Work: Civi Upgrade UI issue: Quick Search doesn't work consistently or well - https://phabricator.wikimedia.org/T215802 (Eileenmcnaughton) @CaitVirtue is it still not working for you? It works for me... [18:17:37] RECOVERY - check_procs on frdb1001 is OK: PROCS OK: 216 processes [18:37:39] Fundraising-Backlog: Tag removal triggers unrestricted dedupe query - https://phabricator.wikimedia.org/T216057 (mepps) [19:01:56] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising-Backlog, and 2 others: Upgrade PaymentsWiki to Mediawiki 1.31 (new LTS) - https://phabricator.wikimedia.org/T184460 (Jgreen... [19:12:55] (CR) Awight: "> Thanks for this surgery! On my instance, it looks like it removes" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/484784 (https://phabricator.wikimedia.org/T161907) (owner: Awight) [19:17:07] ejegg|food: I wanted to confirm what you were seeing with the ^ preview patch. [19:17:49] "Preview (on-wiki)" is now "Preview", and it seems to appear and work as expected on in my local env. Can you show me which pages were glitchy? [19:31:16] awight shoot, got a meeting right now, but I can show you in half an hour [19:40:07] no rush [19:42:00] Fundraising-Backlog: Tag removal triggers unrestricted dedupe query - https://phabricator.wikimedia.org/T216057 (mepps) I was able to replicate this in the Contact Summary Layout Major Gifts uses. When I tried to add tags, it froze and then locked up the database. [19:42:20] Fundraising Sprint Casino Royale With Cheese, Fundraising-Backlog: Tag removal triggers unrestricted dedupe query - https://phabricator.wikimedia.org/T216057 (mepps) [19:42:32] Fundraising Sprint Casino Royale With Cheese, Fundraising-Backlog: Tag removal triggers unrestricted dedupe query - https://phabricator.wikimedia.org/T216057 (mepps) a:mepps [19:42:34] Fundraising Sprint Casino Royale With Cheese, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi 2/11/2019 result switcher bug? contribs not reaching Civi - https://phabricator.wikimedia.org/T215828 (Ejegg) Open→Resolved a:Ejegg [19:51:06] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Vestigial tails shoot from the hip, and 5 others: Ingenico: 10/15 or 10/18 a... - https://phabricator.wikimedia.org/T208261 [19:51:19] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Vestigial tails shoot from the hip, Fundraising Sprint Window dressing is mostly olive oil, and 4 others: Ingenico: 10/15 ... - https://phabricator.wikimedia.org/T208261 [20:09:16] Ah, I see which link I've removed, the one in the Special:CentralNoticeBanners list. [20:17:26] donno why I thought I would change functionality [20:30:12] Looks like I took a shortcut to simplify the code. We had implemented a custom HTMLFormElement to render the embedded banner preview (live iframe or static from the snapshot server), and as a side-effect it was displaying the preview link, [20:30:16] . [20:30:26] ah, yep, that was it! [20:30:43] sorry, got lost in another bit of code [20:31:00] d'oh, and now there's another meeting [20:31:15] I can try to reimplement in a simpler way, but maybe it's worth asking end users how important that preview link is? [20:31:28] it's certainly useful! [20:31:29] There's still a Special:Random preview link on the banner detail page. [20:36:08] Strange, I can't find where TemplatePager is used. [20:37:20] CNBannerPager is used for the "manage banners" table. [20:39:58] Banner lists on the campaign management page are not coming from a pager?.. [20:41:26] Harr, TemplatePager is inherited by CentralNoticePager, which seems to be used for "available" banners but not "assigned" ones. [20:41:47] so... where did we want these preview links reinstated? In the Special:CentralNoticeBanners tab? [20:44:55] ejegg: ^ [20:45:29] that would be nice! [20:45:53] (if it's not too much work) [20:46:11] I guess people probably use the editor page preview link more than anything [20:46:19] Fundraising-Backlog: Ingenico: 10/15/2018 or 10/18/2018 audit missing refunds? - https://phabricator.wikimedia.org/T216072 (MBeat33) [20:46:40] ok yeah I see that we didn't have any preview links in the campaign editor [20:46:58] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Vestigial tails shoot from the hip, Fundraising Sprint Window dressing is mostly olive oil, and 4 others: Ingenico: 10/15 ... - https://phabricator.wikimedia.org/T208261 [20:47:02] for sure, I can reimplement in the banner tab [20:53:49] "bannerLanguagePreview [20:53:53] *burble [20:54:15] "getCNSessionVar" [20:54:17] blargh [21:03:48] (PS7) Awight: Remove unused banner preview support [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/484784 (https://phabricator.wikimedia.org/T161907) [21:04:24] ejegg: ^ that has the preview links. But I don't understand how the "bannerPreviewLang" session variable ever worked. Are there a ton of bugs about that? [21:05:15] oh? never noticed it [21:06:53] The challenge is that we need to determine which languages a banner supports, and preview in one of those. [21:07:39] I've left that out for now, because the session stuff isn't reusable as-is, on the theory that I should clip as few wires as possible. [21:08:15] lmk if you're still getting indentation problems, and if so which browser you're using. [21:16:47] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice should be able to detect supported languages for a banner - https://phabricator.wikimedia.org/T216077 (awight) [21:31:21] awight: cool, thanks for the explanation! I've been previewing in Firefox. Will check again in PS7 [21:32:21] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising-Backlog, and 2 others: Upgrade PaymentsWiki to Mediawiki 1.31 (new LTS) - https://phabricator.wikimedia.org/T184460 (Ejegg)... [21:34:13] ejegg: I don't have indent issues in FF... lmk which page this is, when you have a moment. [21:34:35] tags seem to be balanced. [21:35:14] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: CentralNotice: Remove unused code for banner preview in banner editor - https://phabricator.wikimedia.org/T161907 (Ejegg) diagonal banner list on Special:CentralNoticeBanners in Firefox: {F28211753} [21:35:22] awight ^^ [21:36:15] Can you inspect the HTML? [21:36:23] looking [21:37:16] Location: Diagon Alley [21:37:44] Jeff_Green: I want to reply to this but I’m not quite sure what you’re asking :-) “What are the chances of a civi feature allowing authenticated users to access files/reports from the server?” [21:38:47] eileen: hi [21:38:54] hey cwd [21:39:03] we were just wondering if we could offer a download button in civi [21:39:17] the files get pulled down to that machine right? [21:39:21] so each line is a pair of divs, first one with class="mw-htmlform-field-HTMLCheckField cn-bannerlist-check-applyto" then one with class "mw-htmlform-field-HTMLInfoField" [21:39:54] the first seems to have display:inline-block and float:left [21:40:17] while the second has no particular rules applied [21:40:22] eileen: right, i was thinking about a civi or drupal module that provides web access to flat files on disk to an authenticated user with appropriate privileges in civi/drupal [21:40:43] Jeff_Green: ok - so this is to our existing civi users? [21:40:50] yes [21:40:54] I think drupal would have something like that [21:41:18] is this like ‘if you have permission x you can see all files' [21:41:26] or more nuanced [21:41:44] ejegg: Hmm, I wish I could reproduce the rendering issue. But that does seem like fishy styling. [21:41:44] more nuanced seems better to me [21:43:02] ejegg: okay I can reproduce by zooming way out [21:43:09] so hopefully I can fix now... [21:43:19] Fundraising Sprint Casino Royale With Cheese, Fundraising-Backlog: Tag removal triggers unrestricted dedupe query - https://phabricator.wikimedia.org/T216057 (mepps) So the query that gets bogged down is in CRM_Dedupe_BAO_RuleGroup.php on line 204. Note that if it goes through a similar but not identical... [21:43:33] hey eileen, i'm looking at ^^ [21:43:46] ejegg: Also confirmed that it doesn't happen on master [21:43:59] Jeff_Green: what sort of nuance would it be? [21:44:35] eileen: for example being able to grant access to all files in a particular directory to a subset of users [21:45:43] I don't know how granular we are now with civi/drupal user priviliges now, I wouldn't want to overload that with a whole bunch of complexity [21:46:01] we are not really granular for view [21:46:05] a bit more so for edit [21:46:18] even having a 1:1 relationship between civi username/UID and directory name would be workable I guess [21:47:38] also for our immediate purposes, just being able to have a script drop files into directories, for read-only access via civi, would be fine [21:48:13] but I could imagine a scenario where civi users being able to upload files for other users would be useful [21:48:38] Fundraising Sprint Casino Royale With Cheese, Fundraising-Backlog: Tag removal triggers unrestricted dedupe query - https://phabricator.wikimedia.org/T216057 (Eileenmcnaughton) @mepps so it probably is kinda going the wrong path :-( The former path should be for when you only have one contact id I guess... [21:48:58] there is stuff like this https://www.drupal.org/project/file_access_permission [21:49:15] just occured to me, since we love google so much maybe there's a way to solve this with google docs/drive [21:49:50] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: CentralNotice: Remove unused code for banner preview in banner editor - https://phabricator.wikimedia.org/T161907 (awight) >>! In T161907#4952554, @Ejegg wrote: > diagonal banner list on Special:CentralNoticeBanners in Firefox... [21:50:06] * awight fails to suppress a snicker [21:50:19] "The URL of the file is completely safe for the external world because the module is not providing permanent URL of the file." <-- ok if you say so :-P [21:50:27] :-) [21:50:35] well we have that firewall thing…. [21:50:58] answer on here is drupal summary of sorts [21:51:00] https://stackoverflow.com/questions/9849928/drupal-7-how-to-restrict-file-access-to-specific-user-roles [21:51:10] yeah I don't mean to say it's insecure, I just thought that was amusingly optimistic [21:53:10] (CR) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/490436 (owner: L10n-bot) [21:55:31] reading about the open security issues [22:03:06] eileen: ok, thanks--I guess let's see if they will grant her SFTP access [22:03:40] Jeff_Green: cool - I guess create a phab for the drupal side when you are ready [22:04:28] I'm left a bit wary of this module from the open security issues [23:17:28] (CR) XenoRyet: "Just one little change, then it seems like it does the trick and logs everything properly." (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/489700 (https://phabricator.wikimedia.org/T210893) (owner: Ejegg) [23:26:55] (CR) XenoRyet: [C: +2] Delete obsolete settings [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/486338 (owner: Ejegg) [23:44:28] (Merged) jenkins-bot: Delete obsolete settings [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/486338 (owner: Ejegg)