[00:05:00] Fundraising-Backlog: Record opt-in on payment attempts - https://phabricator.wikimedia.org/T216293 (Ejegg) Technical notes: this could use the opt-in queue that we established for the re-provisioning emails. That queue's consumer assumes that we're just flipping a bit on an existing donor, so we would want t... [00:08:06] hi eileen ! hope you're having a good saturday afternoon [00:08:15] ejegg: hey [00:08:21] it’s HOT here [00:08:42] heh, same here [00:09:09] well, better at night [00:11:29] :-) [00:12:12] yeah I’m always glad to see summer arrive but I’m kinda glad when it leaves too :-) [00:12:30] ohh totten is here? [00:13:15] well, i opened up IRC to see how much activity was on #drush - trying to figure where to escalate problems with random drush crashes [00:13:20] lol [00:13:45] this is still the typo issue? [00:14:25] right, the typo3 PHAR interceptor. [00:14:40] i think https://test.civicrm.org/job/PharOut/2/ is a fairly convincing visual [00:14:48] (that the problem occurs) [00:15:05] so it’s an erratic fail though? [00:15:16] yes [00:15:44] ~50% of the time [00:16:43] totten: so is there a patch merged - https://www.drupal.org/project/drupal/issues/3026443 - but not yet a drupal release with it? [00:18:21] my impression (from skimming) was that 3026443 dealt with a different issue -- i.e. if you install a library (like geoip) from a .phar file, then the library doesn't work. [00:18:34] but it sounded like a reliably-produced problem [00:18:40] yeah... [00:19:24] (PS1) Ejegg: Reformat phpunit bootstrap [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/490954 [00:23:22] (PS1) Ejegg: Use alternate template compile dir for unit tests [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/490955 [00:40:31] (Abandoned) Ejegg: WIP: Remove vendor dir [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/405818 (https://phabricator.wikimedia.org/T185547) (owner: Ejegg) [00:42:41] (CR) Eileen: [C: +2] Reformat phpunit bootstrap [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/490954 (owner: Ejegg) [00:45:18] oh fun, that new error was caused by the last security patch? [00:47:32] (CR) Eileen: "so mostly people will have this in civicrm_settngs.php" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/490955 (owner: Ejegg) [00:53:04] ejegg: which one? the drush one that Tim has? [00:54:03] (CR) Ejegg: "yep, I had to add the if (!defined... conditional to my local settings." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/490955 (owner: Ejegg) [00:54:31] eileen: oh yeah, just reading up a bit on the phar: situation [00:54:52] eileen: do you run unit tests with buildkit locally? [00:54:58] ejegg: yeah I haven’t gotten my head around it too much - Tim is debugging over on chat still…. [00:55:30] yeah I guess I’m running a buidkit site- but I think it uses the same buildkit build as our vagrant [00:55:32] ? [00:56:02] but do you create a new site for each test run? [00:56:14] no - I rarely create new sites [00:56:30] I semi-regularly do on my site on the civicm master branch [00:56:49] I’m also kinda ok merging your gerrit & revisting it later if it annoys us - it’s really just our local builds so we can kinda experiment fairly loosely [00:57:07] ahh, i may have misunderstood - were you saying the buildkit settings need that conditional added, so they don't get an error for defining the dir twice? [00:58:25] hmm, my vagrant settings seem to have the conditional already [00:58:56] so with the phpunit bootstrap patch, they'll compile templates to a random temp dir for testing and keep using the normal one for the web ui [01:08:04] ejegg: no I mean they have the conditional in buildkit settings.php [01:08:22] but they’ll lose the ability to control where it goes - maybe it doesn’t matter [01:08:47] eileen: well, just for unit tests. the setting from buildkit will keep being used for the web ui [01:08:54] and drush scripts etc [01:09:27] ejegg: ok - let’s not overthink it - I’ll merge & if it ever does annoy us we can revisit :-) [01:09:36] thanks! [01:10:22] (CR) Eileen: [C: +2] "OK - I think I'm going too far down hypothetical problems - we can worry about them if we hit them" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/490955 (owner: Ejegg) [01:15:30] (Merged) jenkins-bot: Use alternate template compile dir for unit tests [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/490955 (owner: Ejegg) [01:16:21] ok, signing off for the evening. have a good weekend! [01:24:04] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising-Backlog, and 2 others: Upgrade PaymentsWiki to Mediawiki 1.31 (new LTS) - https://phabricator.wikimedia.org/T184460 (Ejegg) [01:24:06] Fundraising Sprint Queue is pronounced GJif, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: Use Composer merge plugin for payments-wiki - https://phabricator.wikimedia.org/T185547 (Ejegg)