[00:02:57] (PS1) Eileen: Add helper for deleting payment processor [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/491876 [00:04:33] (PS2) Eileen: Add helper for deleting payment processor [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/491876 [00:08:05] (PS1) Eileen: In theory this would cleanup OK with the new helper [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/491878 [00:12:33] (CR) Ejegg: [C: -1] "This looks promising! The order should be a bit different though - PaymentToken has to come after ContributionRecur" (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/491876 (owner: Eileen) [00:13:07] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Investigate speeding common searches with combined indexes - https://phabricator.wikimedia.org/T216655 (MBeat33) A search we might use to find someone who's gotten fraudulent charges and left incomplete voicemail: Name LIKE - 'surn%me, firstname' ...... [00:13:09] (CR) jerkins-bot: [V: -1] In theory this would cleanup OK with the new helper [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/491878 (owner: Eileen) [00:38:12] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-backlog-cleanup-Q3_2017-18: Help Civi users configure their dashboards - https://phabricator.wikimedia.org/T118345 (CaitVirtue) @LeanneS @NNichols What do you two think? [01:09:10] Fundraising Sprint Da Vinci Coder, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Some users not able to use quick search - https://phabricator.wikimedia.org/T216553 (Eileenmcnaughton) @CaitVirtue I finally figured out how to replicate it reliably - & presumably what you were doing differently f... [01:20:05] Fundraising-Backlog: Re-add fields to Silverpop export - https://phabricator.wikimedia.org/T170972 (CCogdill_WMF) We met today and discussed making the fields numerical rather than Y/N, which is good! We talked about the benefits of including the native amount rather than USD, but after considering that furt... [02:15:10] (PS3) Eileen: Add helper for deleting payment processor [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/491876 [02:15:39] (PS2) Eileen: In theory this would cleanup OK with the new helper [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/491878 [02:15:56] (CR) Eileen: "update pushed" (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/491876 (owner: Eileen) [02:17:09] (PS4) Eileen: Add helper for deleting payment processor [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/491876 [02:19:52] (CR) jerkins-bot: [V: -1] In theory this would cleanup OK with the new helper [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/491878 (owner: Eileen) [02:36:16] Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Changes to Benevity import - https://phabricator.wikimedia.org/T215196 (Eileenmcnaughton) @LeanneS there are 3 fee columns in the spreadsheet... [02:55:05] eileen: could you hop on the civicrm security channel? we've got a decision we'd like to involve you in [02:55:16] (most of the data should be in that chat channel) [03:06:40] (PS2) Eileen: Adjust different on omnirecipient repair - then I can kick it off & catch a few more [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/489969 (https://phabricator.wikimedia.org/T215865) [03:07:43] (PS3) Eileen: In theory this would cleanup OK with the new helper [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/491878 [03:12:05] (CR) jerkins-bot: [V: -1] In theory this would cleanup OK with the new helper [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/491878 (owner: Eileen) [03:34:31] Fundraising Sprint Da Vinci Coder, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic, FR-Email: Reflect all undeliverables via Silverpop in CiviCRM - https://phabricator.wikimedia.org/T161761 (Eileenmcnaughton) I took a look at this and we have a script to 'process unsubscribes' which... [19:26:09] Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Changes to Benevity import - https://phabricator.wikimedia.org/T215196 (LeanneS) Ah yes, that seems right. I just looked at their report gloss... [19:27:09] Fundraising Sprint Da Vinci Coder, Fundraising-Backlog, FR-Astropay: donation form not passing language pref to dLocal - https://phabricator.wikimedia.org/T216552 (Ejegg) a:Ejegg [19:34:44] (CR) Ejegg: [C: +2] Adjust different on omnirecipient repair - then I can kick it off & catch a few more [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/489969 (https://phabricator.wikimedia.org/T215865) (owner: Eileen) [19:39:29] (Merged) jenkins-bot: Adjust different on omnirecipient repair - then I can kick it off & catch a few more [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/489969 (https://phabricator.wikimedia.org/T215865) (owner: Eileen) [20:27:47] (PS1) Umherirrender: build: Add composer.lock to .gitignore [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/492043 [20:29:27] (PS10) Umherirrender: Remove 'UnitTestList' hook [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/428059 (https://phabricator.wikimedia.org/T142120) (owner: Gopavasanth) [20:30:54] (CR) jerkins-bot: [V: -1] Remove 'UnitTestList' hook [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/428059 (https://phabricator.wikimedia.org/T142120) (owner: Gopavasanth) [20:30:57] (Abandoned) Umherirrender: WIP remove vendor submodule [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/405817 (https://phabricator.wikimedia.org/T185547) (owner: Ejegg) [21:01:54] dstrine: Any word on that IP? Just making sure I haven't missed the email. [21:02:52] XenoRyet: nope if I don't hear anything in the next 30 minutes I'll ping Jerry on chat [21:02:58] 10-4 [21:23:04] XenoRyet: see email [21:23:25] https://giphy.com/gifs/ghostbustersmovies-ghostbusters-original-xT8qB3utUzMWqmpH20 [21:23:29] Just saw. That seems to be an IPv6 address. I'm not totally sure what to do with one of those. [21:23:35] ejegg: ^ [21:24:05] can we whitelist IPv6? [21:25:21] at least it looks like chicago ... so that checks out [21:30:00] How soon does the event start? Wondering how long I have to figure this out. [21:32:05] XenoRyet, where are you checking for the IP? Is it within the $_SERVER['REMOTE_ADDR'] var [21:32:48] It's just the one they're reporting at the site. [21:33:05] The filter is looking at the unstaged data [21:33:13] XenoRyet: ooh, hmm [21:33:52] ah ok, I thought you might of been checking the IP of the visitor somewhere to give access [21:38:39] I'm not clear on whether or not the function we're using for expanding IP blocks works on IPv6 [21:39:19] I'm curious now, do you know what files are performing the check or where abouts in the code this kicks in? [21:39:31] (CR) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/492090 (owner: L10n-bot) [21:39:57] jgleeson: extras/custom_filters/ip_velocity [21:40:04] In donation interface [21:40:50] the part for handling block IPs is in gateway_common/DataValidator.php [21:41:30] mediawiki-fr/extensions/DonationInterface/extras/custom_filters/filters/ip_velocity/ip_velocity.body.php:38 [21:41:44] Yea, that's it. [21:44:51] Ok, expandIPBlockToArray definitely won't do IPv6, so I wonder what happens when we get one. [21:45:04] I think it might [21:45:25] it looks like it only goes through the expansion stuff IF it picks up a / in the ip name [21:45:46] so in the case on ipv6 addresses, I think it will just act as a normal IP [21:45:51] @see mediawiki-fr/extensions/DonationInterface/gateway_common/DataValidator.php:582 [21:46:01] Oh, yea. I see what you're getting at. [21:46:10] We do usually whitelist blocks of IPs though. [21:46:22] I guess we could whitelist just the one [21:47:13] yeah worst we could do is try it I guess [21:48:36] ejegg: What do you think? [21:50:53] Still, I'm not seeing anything that looks like an IPv6 in fredge. [21:54:50] it feels like it shouldn't be that easy [21:55:06] No doesn't seem like it should [21:55:28] but if we are just comparing the IP value sent in the PHP $_SERVER superglobal which I think will be a string value, it might just work [21:55:39] I'd feel better if I could find an example of what happens to IPv6 right now. [21:56:12] You are right about that though, just comparing strings should be fine. [21:56:30] dstrine: Do we know how soon they're going to start trying to donate? [21:56:48] they won't start for a few hours [21:56:54] 7pm their time? [21:56:59] Ok, got a little breathing space then. [21:57:37] XenoRyet: can we whitelist a large area around that ip address? [21:57:55] like all of chicago? [21:58:55] I actually don't think so. The IP address is in a different format than the filter is set up for. [21:58:55] we could also as jerry for the ipv4 [21:58:57] http://whatismyip.host/ [21:59:04] this using this site? [21:59:32] Jerry just gchatted me too, apparently that's the IP of her hotspot. They're trying to get on the wifi at the venue, which has an IPv4 [21:59:48] ahhhh [22:00:19] "there's yer problem" lol [22:00:59] Yep [22:01:07] https://66.media.tumblr.com/92e48fc443351a77695b006d255f381a/tumblr_inline_mon7p93Yyq1qz4rgp.gif [22:01:15] I wonder how stable hotspot public IPs are. [22:01:49] they are usually using cell networks so probably not super accurate [22:02:02] Yea, that's the thing. [22:02:26] well, hopefully they can get the wifi working. Apparently it's municiple wifi though. [22:04:54] hmm, also, I think we might force people to go through an ipv4 gateway to get to payments? [22:04:57] lemme see [22:29:33] I guess another option is we could turn the fail score way down for the duration of the event. [22:30:57] XenoRyet: did you get an ipv4 from her? [22:31:02] Not yet [22:31:07] what's happening on gchat [22:31:08] ok [22:31:25] XenoRyet: can you add me to the gchat? [22:32:02] Ok, just did. [22:39:31] XenoRyet: yeah, looks like we're forcing people to use ipv4 [22:40:21] ejegg: XenoRyet I'm trying to get hold of her. I just sent a text. Could we do something more whacky like whitelisting the whole state for the evening? [22:40:33] just trying to figure out options [22:40:35] So what happens if someone comes in on v6? [22:40:37] dstrine: sorry, no, we need ip addresses [22:40:42] kk [22:40:57] XenoRyet: there's no ipv6 dns record for payments.wikimedia.org [22:40:57] dstrine: The only alternative I can think of is to turn the score way down, but that's global. [22:41:06] ah, ok [22:41:18] so networks usually fall back to an ipv6 to ipv4 gateway [22:41:49] XenoRyet: ejegg so if they are trying to get internet and can't and they resort to using their mobile hotspot, what happens then? [22:43:17] I guess there's just no way to convert from ipv6 to ipv4 :( [22:43:23] if they use the mobile hotspot, it SHOULD come through [22:43:50] when it sees no ipv6 address for our site, it should use a proxy-type-thing [22:43:57] like if they look it up with a tool like this it should show right? [22:43:57] http://whatismyip.host/ [22:43:59] and we'll see that proxy's ipv4 address [22:44:32] dstrine: oh hey, that's a nice clean site to use! [22:44:53] She said she didn't get anything for IPv4 from that site. [22:44:58] yeah I have that one bookmarked [22:45:04] ugh [22:45:19] Hrm? [22:45:25] XenoRyet: is she responding to you in another channel? I'm pinging CV right now [22:45:41] Not right now. That info was from earlier. [22:46:00] I've heard nothing for about 40 mins [22:46:15] Can she try a random url on payments.wikimedia.org? like e.g. https://payments.wikimedia.org/whatisherip [22:46:31] then we can see what shows up in our access log [22:52:21] ejegg: so just tell her to hit that url? [22:52:29] sure [22:52:44] and we'll see what proxy address shows up [22:53:04] or maybe we should tell her one that we don't advertise publicly... [22:53:31] dstrine want to come up with something else to put on the end of it, and send it via email? [22:53:55] cwd heads up, we're hoping to get an IP address out of nginx logs on payments soon [22:54:14] ejegg: added you to chat [22:54:30] all the 'whatismyip' sites are only showing an ipv6 one [23:14:34] ejegg: Ok, setting change pushed [23:16:30] XenoRyet: looks good, deploy when ready! [23:16:37] 10-4 [23:23:16] ejegg: i am out sick [23:23:21] but if it's quick i can do it [23:23:42] cwd oh shoot, hope you feel better soon! [23:23:50] We ended up getting it [23:23:54] sorry to bother you [23:24:13] np, i forgot to send an email [23:24:17] and thanks