[01:19:47] (PS17) Eileen: Updated version of extended reports [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/477452 [01:21:51] (PS4) Eileen: Remove join on civicrm_financial_type table when rendering search results. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/491398 [13:47:01] hello fr-tech! [14:19:38] mepps: morning! how's it going? [14:20:00] AndyRussG|ish mostly good but i'm super tired [14:20:10] which is actually the fault of neither jet lag nor the baby [14:31:43] mepps: it builds up, eh! glad to hear that baby sleep patterns are cooperating a bit more, though, I guess? [14:31:47] How was Prague? [14:33:05] hi mepps! [14:33:12] honestly, it's more that i stopped by an oscars party last night [14:33:22] Prague was great!! [14:33:27] hey ejegg|away! [14:36:20] Fundraising Sprint Da Vinci Coder, Fundraising-Backlog, FR-Astropay: donation form not passing language pref to dLocal - https://phabricator.wikimedia.org/T216552 (Ejegg) Still impossible according to our contact at dLocal: >I've checked with Product and unfortunately it's not possible to modify the... [14:38:03] and hi AndyRussG! [14:38:55] jgleeson are we meeting today? it looks like you declined [14:45:24] (CR) Ejegg: [C: +2] Handling for multiple erase databases [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/469155 (https://phabricator.wikimedia.org/T205332) (owner: Eileen) [14:45:37] (PS24) Ejegg: Handling for multiple erase databases [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/469155 (https://phabricator.wikimedia.org/T205332) (owner: Eileen) [15:02:54] Fundraising Sprint Da Vinci Coder, Fundraising-Backlog, MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Patch-For-Review: Edits to text on payments page - https://phabricator.wikimedia.org/T215939 (Pcoombe) @Ejegg That causes the opt-in question to show again though, even if the choice is included in... [15:05:41] ejegg: helloooo [15:22:02] Fundraising Sprint Da Vinci Coder, Fundraising-Backlog, MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Patch-For-Review: Edits to text on payments page - https://phabricator.wikimedia.org/T215939 (Ejegg) Oh weird @Pcoombe, that was totally not intended. The emailExplain variant was supposed to just i... [15:25:19] Fundraising Sprint Da Vinci Coder, Fundraising-Backlog, MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Patch-For-Review: Edits to text on payments page - https://phabricator.wikimedia.org/T215939 (Pcoombe) @Ejegg If we have the `opt_in` parameter in the URL then I think we do want to suppress the que... [15:38:41] Fundraising-Backlog: Record opt-in on payment attempts - https://phabricator.wikimedia.org/T216293 (Ejegg) The percentage that submit a payments that doesn't process should be fairly straightforward, just looking at the payments_initial table for payments_final_status = failed. The number that don't complet... [15:57:28] hey mepps, might be worth setting that meeting invite up again maybe [16:19:12] Fundraising Sprint Da Vinci Coder, Fundraising-Backlog, MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Patch-For-Review: Edits to text on payments page - https://phabricator.wikimedia.org/T215939 (mepps) Let's break this conversation about opt_in into a separate task. [18:34:13] Fundraising-Backlog, FR-Ingenico, Recurring-Donations: Implement Ingenico recurring up sell - https://phabricator.wikimedia.org/T216560 (DStrine) https://docs.google.com/document/d/1ogk5RUogG-B3PDQTNcj9TNwqRJ-XLO_fVi3gdlby40A/edit [21:05:54] ejegg: wanna check my commits on process-control [21:06:06] sure! [21:31:55] mepps: shall I drop off for our 1-1 [21:32:39] yeah eileen i just joined [21:37:49] eileen: those process-control updates look good [21:46:07] (CR) AndyRussG: "recheck" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/492353 (https://phabricator.wikimedia.org/T208511) (owner: AndyRussG) [21:48:31] (CR) jerkins-bot: [V: -1] Add API for active campaigns and banners [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/492353 (https://phabricator.wikimedia.org/T208511) (owner: AndyRussG) [21:51:06] ejegg: ok deploying [21:52:13] ejegg: where was that thing to automatically add the whole team as reviewers to certain types of changes? [21:54:07] cstone eileen I noticed you didn't get added to as reviewers to this CentralNotice patch like others on the team... I shall add you! bwahahahah (pls remove yourselves if you prefer of course) https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CentralNotice/+/492353/ [21:54:43] !log update process-control config revision is d1826e371b [21:54:44] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:55:30] also, something's weird with Jenkins on CN patches of late [21:57:02] ejegg: I think I found it: https://www.mediawiki.org/wiki/Git/Reviewers#mediawiki/extensions/CentralNotice [21:58:04] cstone eileen ^ I guess maybe add yourselves if you wish to be add automatically to future CN stuff? [21:58:12] *added [21:59:51] ok thanks! [22:03:27] cstone: yw! :) [22:05:41] AndyRussG: oops, just seeing this now [22:05:50] look good! [22:06:15] ejegg cool thx [22:11:17] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 3 others: Upgrade PaymentsWiki to Mediawiki 1.31 (new LT... - https://phabricator.wikimedia.org/T184460 [22:15:12] Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Changes to Benevity import - https://phabricator.wikimedia.org/T215196 (Eileenmcnaughton) On digging it seems to be mishandling matching gifts... [22:18:44] (PS18) Eileen: Updated version of extended reports [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/477452 [22:30:41] ejegg: got a sec? [22:30:49] sure eileen [22:31:12] actually, I was about to ask you for some advice testing the extended reports update [22:31:18] so Bug: T115044 was mishandling thousands [22:31:19] T115044: Benevity: Create an import method for matching gifts and payroll deductions - https://phabricator.wikimedia.org/T115044 [22:31:27] arr [22:31:29] (CR) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/492804 (owner: L10n-bot) [22:31:51] has it re-appeared? [22:32:15] yeah - because we hard-handled ‘gross’ but now we are seeing it in other fields (matched_amount) [22:32:29] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MinervaNeue, Accessibility, and 3 others: Banner/CentralNotice should be child of `header` and not above it - https://phabricator.wikimedia.org/T205360 (alexhollender) no action yet, just adding a note from a discussion with Nirzar so I don... [22:32:32] I can just hard-handle there & maybe I should cos it’s kinda urgent [22:32:43] maybe I hard-handle & add a phab to think about it? [22:33:11] sure, let's do that for now [22:34:45] ejegg: so on extended reports - my general feeling is we don’t use that many reports [22:35:07] right [22:35:13] I’ve put the latest code on staging & have something configured for the benevity report - civicrm/report/instance/143?reset=1output=html [22:35:33] there's nothing obviously wrong with the code changes I've seen so far, it's just a lot of changes [22:37:32] ejegg: yeah [22:37:57] I got fed up & re-wrote - I don’t think it makes sense to review fully at a code level [22:38:15] just maybe check no regressions on the reports we actually use [22:38:21] well, I'll put a couple breakpoints at changed spots and step through a few things [22:38:41] so the big logic change is to change how the metadata is handled [22:39:08] I ALSO introduced some new features which we want & the angular patch is a bit funky but I got it to work .... [22:40:22] ejegg: [22:40:23] select distinct report_id , ov.name FROM civicrm_report_instance LEFT JOIN civicrm_option_value ov ON report_id = ov.value [22:40:23] WHERE ov.name LIKE '%exte%'; [22:40:33] cool, thanks! [22:40:53] the address history is the address history tab [22:41:56] so basically we have 2 configured reports [22:41:57] contact/addresshistory | CRM_Extendedreport_Form_Report_Contact_AddressHistory | 101 | [22:41:57] | contribution/detailextended | CRM_Extendedreport_Form_Report_Contribute_DetailExtended | 102 [22:52:33] hmm, address history tab isn't exactly fast [22:59:46] ejegg: probably unchanged - it is slow where a contact is impacted by a bulk update I think [23:00:16] oh, interesting [23:52:29] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Winter Wanderland, Fundraising-Backlog, and 2 others: Changing contact records from individual records to organizatio... - https://phabricator.wikimedia.org/T156193 [23:52:32] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Ensuring converted organization records are consistent - https://phabricator.wikimedia.org/T156194 (Eileenmcnaughton) Open→Resolved a:Eileenmcnaughton Discussed with @LeanneS & @NNichols - this got done [23:55:32] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Fulltext search for name and org name in Civi - https://phabricator.wikimedia.org/T115536 (Eileenmcnaughton) @DStrine we discussed this in Civi-fortnightly - potentially we could have an extension that saves organisation sort_names like 'Sloan Foundatio... [23:55:59] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Activities tab- multi select option for exclude filter - https://phabricator.wikimedia.org/T203057 (Eileenmcnaughton) @DStrine we discussed giving this a priority bump in civi-fortnightly [23:56:24] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Fulltext search for name and org name in Civi - https://phabricator.wikimedia.org/T115536 (Eileenmcnaughton) related issue https://phabricator.wikimedia.org/T122264