[00:00:08] hmm - I don’t suppose this relates https://intellij-support.jetbrains.com/hc/en-us/community/posts/206999165-Debugging-with-Xdebug-hangs- [00:01:25] ejegg: can you paste your command line into that etherpad above? [00:02:03] that's the forgetme test [00:02:40] ok cool - so we have 5 extensions in phpunit.xml - is smashpig the only one that works ? [00:04:11] Ok 2 differences I see [00:04:14] 1) is the port [00:04:26] 2) is the path to the test file - mine has drupal in it [00:04:33] yeah, I had something else running on 9000 earlier [00:05:01] well, I can try changing the path [00:05:15] In php storm I have drupal in the path in my config [00:06:13] ie https://imagebin.ca/v/4YP3xYgjqgFM [00:07:47] aha, that might be it [00:08:02] contacteditor test ran with that anyway [00:09:18] (PS1) Eileen: (cherry-picked from master) Repair omnirecipient with 14 hour gap [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/493134 (https://phabricator.wikimedia.org/T215865) [00:09:20] cool [00:09:20] hmm, nope, even with the custom working dir it seems to hang [00:09:32] also on forgetme? [00:09:34] on the omnirecipient forgetme test [00:09:43] trying with the forgetme extensions [00:09:46] *extension [00:10:27] oh hey, omnimailingGetTest lets me debug it [00:10:45] so what's the big difference between that and the forgetme? [00:10:55] guzzle? [00:11:21] can’t you add verbose flags to the command line - I feel like that can be done [00:11:39] no omnimailingGet uses guzzle - hmm [00:11:52] yeah, the setup functions are identical [00:12:08] so bizarre! [00:12:24] the thing is it won’t even stop in setup will it? [00:12:39] no, it won't [00:13:17] it must be the use [00:13:18] use SilverpopConnector\SilverpopRestConnector; [00:13:32] because it’s not getting to the setup [00:13:41] hmm [00:14:02] ok, trying to debug OmnirecipientGetTest is also hanging [00:15:42] ditto omnirecipientloadtest [00:15:53] trying omnimailingGet again [00:16:18] still working [00:16:40] ugh... until I set a breakpoint [00:17:12] ah heck, my whole crm dir is a symlink [00:17:16] that's probably it? [00:17:42] could be! [00:18:44] reopening pstorm in the target dir [00:19:59] hmm, taking its time indexing! [00:22:31] ok, re-running testOmnimailingGet via the drupal/sites/default/civicrm/extensions path, with a breakpoint, is hanging [00:25:47] seems like a step backwards :-) [00:26:51] well, without a breakpoint, but still in 'debug' that test still passes [00:27:00] let me try a path with no symlinks at all [00:27:14] (the sites dir inside drupal is a symlink) [00:28:48] ok, hanging still [00:29:08] guh [00:32:50] what happens if you run those apis via drush (it doesn’t actually stop for me atm - drush & phpstorm not getting on) [00:33:21] did you try --verbose after phpunit? [00:33:36] lemme try that [00:34:53] with a breakpoint, it's still hanging before getting to anything in the test [00:34:56] hmm [00:36:01] also with 'break on first line' [00:36:12] guh, guh, guh... [00:38:39] 20 simultaneous connections allowed, that should be fine [00:42:30] turning off path mapping [00:42:40] still hangs [00:44:20] tcpdump? [00:45:33] so those google links suggested no allowing simulateous helps [00:50:03] someone suggested restarting apache/mysql - easy if not likely to help [00:51:18] oh, NOT allowing simultaneous? [00:51:28] will try not allowing [00:51:36] tcpdump is not super enlightening [00:52:22] there's a bunch of random punctuation, and some breakpoint_set lines that confirm I'm looking at the right paths [00:52:47] is there an xdebug log file? [00:52:51] can't imagine apache/nginx/fpm is involved in this command line test [00:56:46] hmm, no xdebug log file [00:57:21] the extension ARE installed aren’t they? [00:57:48] yeah [00:58:14] errr, so now I'm trying to debug into non-extension tests in civi and getting the same problem [00:58:21] runs without a breakpoint [00:58:23] ug [00:58:27] hangs with a breakpoint [00:58:41] going to make sure I can actually debug tests in DonationInterface [00:59:10] I’m gonna have to get some food [01:03:47] well heck, those are hanging too [01:04:28] :( [01:04:50] arg [01:09:25] oh heck, I've got a custom-built xdebug extension, maybe that's it [01:10:06] have I updated my php binary since building it? [01:10:15] maybe debian has xdebug for php7.3 now [01:13:37] hmm, no, seems like I'm back to dist standard [01:13:49] ah, it was php7.2 I had the custom one for [01:14:31] so... let's try using that? [01:14:58] hrmph [01:15:00] well that works! [01:15:30] so... phpstorm + php7.3 + xdebug 2.7.0rc1 = hang [01:15:38] blarg [01:15:50] ok, maybe I need to step back from the bleeding edge [01:31:01] hmm [01:31:18] well, i'm finally stepping into the test! [01:32:23] oh, still on previous patch [01:32:33] hmm, and still failing [01:32:35] let's see [01:33:12] undefined offset 1 looking at $requests [01:34:08] ejegg: yeah that one could relate to your civicrm.settings.php not having a db configured or something [01:34:36] oh, does the test not set up a config? [01:34:40] I think I tried to get away from that but in current master I think you do need to have it pick up a db id to send out a request [01:35:00] I tried to sort it out - I thought the patches did address but… [01:35:05] ok, mailerCredentials is empty [01:35:59] how does that work in jenkins? [01:37:27] I think it’s coming from a settings.create call [01:37:58] I know I had my head really in this when I did those patches but now it’s a bit vague [01:38:11] are you on current master or the patched version? [01:38:13] ok, stepping through the new version [01:38:34] it was current master before, when I got the undefined offset [01:39:22] ok, this time I see it calling OmnimailJobProgress.create [01:39:49] yeah I *think* I fixed that [01:40:12] and now it's hitting the omnirecipient_erase via ProcessForgetme [01:40:44] $mailerCredentials['credentials'] is still empty [01:41:18] as is $retrievalPrameters [01:42:11] oops, need to composer install again [01:42:29] & is that crashing it ? For the test those shouldn’t be needed other than database_id [01:44:04] let's see, the $responses end up empty coming back from Omnirecipient.erase [01:44:27] and then we delete the OmnimailJobProgress [01:45:33] ok, right, cause we've processed it [01:46:28] ah, but that's why the callAPISuccessGetSingle crashes [01:46:39] so I need to add a database ID in my settings to run this test? [01:47:27] Sorry, what's the syntax for that again? [01:47:40] ejegg: well we set it somewhere in the tests for jenkins so in theory no but? [01:48:11] I guess we should add that to the vagrant crm setup [01:48:28] for folks using that [01:49:40] So I think you can get away wih [01:49:58] $civicrm_setting['Omnimail Preferences']['omnimail_credentials']['Silverpop'] = [‘database_id' => 50] [01:50:20] aha, cool, I have a key like that, but minus the database_id [01:50:26] that was the problem [01:50:36] if you had no key it would probably have been ok [01:50:51] ok, re-running [01:52:42] oh wait, it's looking for a 'mail_provider' key [01:52:57] oh derp, no [01:53:37] cool, looking better this time [01:56:23] ok, tests passed, but I need to step through a couple more times to understand better [01:58:20] ejegg: well that’s one hurdle down! [01:58:22] eileen: so, the first time it goes through omnirecipient_erase [01:58:41] it fires one job per db [02:01:28] I’m gonna relocate [02:20:36] whew, this is impressive! [02:20:37] so [02:20:54] the first time you call gdpr_erasure, you call it with ALL the database_ids [02:21:29] then for each of those that's not complete, you create another job with a single database_id in the retrieval_parameters [02:21:56] so later you can just make the same API call to silverpop and see if it returns complete [02:23:46] so what's the meaning of this part of the commit message "- at this stage I have still to fix it so re-tries are given job criteria and only try to fetch if a job already exist" [02:23:50] ? [02:23:54] *exists [02:24:40] the re-tries DO seem to have retrieval_parameters [02:25:25] ejegg: probably because I kept updating the same commit [02:25:25] what else would it need for job criteria? [02:25:33] & may not have removed WIP comments [02:25:37] ah, cool [02:26:36] gonna eat some dinner and give the code one last glance, but it's looking good! [02:51:17] (PS2) Ejegg: Composer update for forget me [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/493128 (owner: Eileen) [02:51:23] (CR) Ejegg: [C: +2] Composer update for forget me [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/493128 (owner: Eileen) [02:51:30] (PS14) Ejegg: Change Omnimail Forgetme so that it writes Erase requests to the database & processes in a separate job [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/487333 (https://phabricator.wikimedia.org/T199747) (owner: Eileen) [02:51:38] (CR) Ejegg: [C: +2] Change Omnimail Forgetme so that it writes Erase requests to the database & processes in a separate job [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/487333 (https://phabricator.wikimedia.org/T199747) (owner: Eileen) [02:51:46] ejegg: woot! [02:52:39] I’m gonna put up a patch prob tomorrow to fix the address log - It’s a bigger update to switch to the metadata methods to get it right [02:56:44] (Merged) jenkins-bot: Composer update for forget me [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/493128 (owner: Eileen) [02:59:11] (Merged) jenkins-bot: Change Omnimail Forgetme so that it writes Erase requests to the database & processes in a separate job [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/487333 (https://phabricator.wikimedia.org/T199747) (owner: Eileen) [03:33:58] (PS2) Ejegg: Remove obsolete CentralNoticeXXCountries [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/485877 [03:36:32] (CR) jerkins-bot: [V: -1] Remove obsolete CentralNoticeXXCountries [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/485877 (owner: Ejegg) [03:36:37] (CR) jerkins-bot: [V: -1] Remove obsolete CentralNoticeXXCountries [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/485877 (owner: Ejegg) [03:37:48] (CR) Ejegg: "recheck" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/485877 (owner: Ejegg) [03:37:57] weird [03:39:49] (CR) jerkins-bot: [V: -1] Remove obsolete CentralNoticeXXCountries [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/485877 (owner: Ejegg) [03:40:12] ejegg|away: oh yeah there's a CI issue [03:40:45] It might be a previous non-issue-y issue in some of the config stuff that was just previously undetected [03:40:49] anyway that's my working theory [03:41:00] I guess we need a fabtask [03:47:16] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 3 others: Upgrade PaymentsWiki to Mediawiki 1.31 (new LT... - https://phabricator.wikimedia.org/T184460 [03:50:36] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 3 others: Upgrade PaymentsWiki to Mediawiki 1.31 (new LT... - https://phabricator.wikimedia.org/T184460 [13:54:19] (PS1) Esanders: build: Switch from jshint/jscs to eslint [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/493229 [15:01:51] hi fr-tech! [15:02:09] hi ejegg :) [15:05:25] how cool is this https://videowiki.wmflabs.org/en/ [15:05:56] whoa, who's working on that? [15:08:11] https://en.wikipedia.org/wiki/Wikipedia_talk:WikiProject_Medicine#Video_Wiki [15:08:26] a note went out today on wikimedia-l [15:09:11] ahh, i should check that now and then [15:10:41] if you haven't read: https://news.ycombinator.com/item?id=19258241 [15:10:53] if here was an internal announcement i missed it [15:19:08] cwd feeling better today? [15:23:43] not especially [15:24:02] been pretty consistent for about 4 days [15:26:57] aw bummer [15:30:26] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 3 others: Upgrade PaymentsWiki to Mediawiki 1.31 (new LT... - https://phabricator.wikimedia.org/T184460 [15:38:11] ejegg jgleeson cwd morning! [15:38:20] hi AndyRussG! [15:38:24] :) [15:38:42] howdy [15:38:46] :) [15:39:21] ejegg didja see my message last night ^ Krinkle's theory about the CI thing is that there's something odd somewhere that was just previously undetected by CI [15:39:48] AndyRussG: ok, so worth us looking into? [15:40:06] let me try to at least reproduce it locally [15:40:11] on latest core [15:40:38] ejegg here's a "draft" patch with no significant changes that also manifests it: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CentralNotice/+/492486/ [15:41:01] Though odd thing, the actual CI error started off as something different [15:44:06] ok, seeing that warning as soon as phpunit starts [15:44:21] PHP Notice: Undefined index: dependencies in src/php/core/includes/resourceloader/ResourceLoader.php on line 427 [15:46:52] related to QUnitTestModules [15:47:36] looks like it should be fixed in core, not by adding an empty array to all of those modules [15:49:58] https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/493254 [15:50:05] AndyRussG: that should fix it ^^^ [16:01:02] Fundraising Sprint Da Vinci Coder, Fundraising-Backlog, MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Patch-For-Review: Edits to text on payments page - https://phabricator.wikimedia.org/T215939 (Ejegg) Aha, I figured it out. The 'variant' parameter lets you override everything in the gateway's conf... [16:01:27] fr-tech: any updates for scrum of scrums? [16:01:42] ejegg: thx nothing here [16:03:14] ejegg: oohh nice! [16:03:19] wrt the fix :) [16:03:25] heh, pretty trivial [16:03:28] but thanks! [16:09:47] oh wow, this'll go stale fast if we don't review it: https://gerrit.wikimedia.org/r/492339 [16:10:15] seems worthy, since any php versions that don't support short arrays are long out of warrantee [16:11:01] fr-tech will approving this badly disrupt any DonationInterface patches you have in progress? ^^ [16:11:26] not for me [16:27:13] Fundraising Sprint Da Vinci Coder, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Hide opt_in radio buttons when the choice has been provided on the query string - https://phabricator.wikimedia.org/T217254 (Ejegg) [16:33:42] that was a lengthy review ejegg! [16:34:37] jgleeson: which one, the short array syntax? [16:34:48] yup [16:34:57] I figure for that one I'll just try running the tool independently [16:35:00] and do a diff [16:35:12] (CR) Jgleeson: [C: +1] "Changes look good to me!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/492339 (owner: Umherirrender) [16:35:31] ah yeah that sounds like a smarter way than reading through each file [16:35:41] heh, lazier anyway! [16:35:53] wouldn't catch any clever naughty stuff the tool did [16:36:16] I was on the look out for the unlikely instances of strings containing "array" [16:36:19] or something like that [16:36:32] although I know the IDE tools to reformat are smart enough to catch them [16:36:49] but the submitter didn't explain how the reformat was performed [16:36:59] (even though it's safe to assume it was an IDE tool) [16:37:57] didn't it say it was composer fix? [16:38:10] think that would be phpcbf [16:38:24] oh crap, you're right [16:38:36] * jgleeson facepalm [16:39:05] for someone reason I didn't interpret that [16:50:55] AndyRussG: do you use dbstore1002 for anything? It's apparently going away very soon [16:51:04] thanks jgleeson I got mysql workbench working! [16:52:48] ejegg on the analytics cluster? [16:53:01] AndyRussG: yeah [16:53:33] ejegg: yeah there was a ticket for that that flew by no? I don't think I have anything there, but I'll take a peek [16:54:00] right, there was some stuff that Jeff_Green archived a copy of [16:56:00] ejegg actually I can't even log in there. Maybe it's gone already? I'm pretty sure I didn't keep anything there... Thanks for the heads-up btw! [16:57:57] good to hear cstone ! [17:00:58] so.... how to track WHERE donation data comes from? [17:01:07] i.e. GET / PUT / SESSION [17:01:19] err, GET / POST / SESSION [17:02:34] ejegg: damn that's an actual error there that CI was catching... Did you happen to notice which version of core the change went in? (If not I can find it.) We might have to rush something out [17:02:51] It would be nice to keep the request access contained in the page classes [17:03:28] AndyRussG: oh shoot, is 'dependencies' a required key for QUnit modules now? [17:04:20] https://gerrit.wikimedia.org/r/491741 [17:12:39] AndyRussG: looks like Thiemo just +2ed the core fix [17:15:50] hmm hmm, if we merge that short array fix, we won't be able to easily cherry-pick changes around it to deploy :( [17:16:11] and I /think/ we need to cherry pick till we're on mw 1.31 [17:23:24] (CR) Ejegg: "recheck" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/492353 (https://phabricator.wikimedia.org/T208511) (owner: AndyRussG) [17:23:41] (CR) Ejegg: "recheck" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/485877 (owner: Ejegg) [17:24:53] (CR) Ejegg: "recheck" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/492513 (owner: Umherirrender) [17:25:20] (CR) jerkins-bot: [V: -1] Add API for active campaigns and banners [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/492353 (https://phabricator.wikimedia.org/T208511) (owner: AndyRussG) [17:26:20] Oh hey, that's actually a phpcs check failing, not the other warning ^^^ [17:28:01] ejegg: thanks! Now I think I must be losing it. Besides the core change didn't you also send up a CN patch changing something there too? I'm like sure I saw that this morning, but I can't find it... Maybe I'm feverish [17:28:27] AndyRussG: i just rebased my cleanup of the XXCountries [17:28:28] like checking is_set for dependencies before checking is_string [17:28:37] AndyRussG: that was the core patch [17:28:40] in some part of the choice data mechanism [17:28:54] nope, didn't touch anything in CN! [17:29:24] but Umherrireinder's patch is passing now, so I think that was all we needed [17:29:41] *Umherirrender [17:30:08] ejegg: ah okok [17:30:11] rrrrgh [17:42:35] Fundraising-Backlog: Re-add fields to Silverpop export - https://phabricator.wikimedia.org/T170972 (CCogdill_WMF) I've noticed the number of rows imported to IBM nightly has decreased over the last two days. It's only about 5k rows smaller each day, but that's an odd phenomenon. Is it because someone is work... [17:50:19] Fundraising-Backlog: Re-add fields to Silverpop export - https://phabricator.wikimedia.org/T170972 (Ejegg) Guessing it's because of the job @Eileenmcnaughton just re-enabled to bring undeliverable data back from Silverpop into Civi. If that job marks an address as on_hold, it won't be exported. [18:06:01] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MinervaNeue, Accessibility, and 3 others: Banner/CentralNotice should be child of `header` and not above it - https://phabricator.wikimedia.org/T205360 (alexhollender) [18:07:23] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MinervaNeue, Accessibility, and 3 others: Banner/CentralNotice should be child of `header` and not above it - https://phabricator.wikimedia.org/T205360 (alexhollender) p:Lowest→Low [18:08:15] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MinervaNeue, Accessibility, and 3 others: Banner/CentralNotice should be child of `header` and not above it - https://phabricator.wikimedia.org/T205360 (alexhollender) p:Low→Normal [18:09:30] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 3 others: Upgrade PaymentsWiki to Mediawiki 1.31 (new LT... - https://phabricator.wikimedia.org/T184460 [18:13:24] Seddon: dstrine: just to note here, looks like there's some movement on https://phabricator.wikimedia.org/T205360 [18:24:05] It looks like Seddon wanted to test this but not sure if that happened. [18:46:07] ejegg yeah I tried setting $wgEnableJavaScriptTest to false, and the messages in the error log went away, so I think we're all good [19:44:00] Fundraising Sprint Da Vinci Coder, Fundraising-Backlog: fill out PCIU forms for this yearr - https://phabricator.wikimedia.org/T217184 (XenoRyet) a:Ejegg→XenoRyet [19:44:23] Fundraising Sprint Da Vinci Coder, Fundraising-Backlog: fill out PCI forms for this yearr - https://phabricator.wikimedia.org/T217184 (DStrine) [20:15:45] (PS1) Eileen: CiviCRM submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/493310 [20:16:58] (CR) Eileen: [C: +2] CiviCRM submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/493310 (owner: Eileen) [20:18:59] Fundraising Sprint Da Vinci Coder, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Some users not able to use quick search - https://phabricator.wikimedia.org/T216553 (Eileenmcnaughton) @CaitVirtue shall we close this now? [20:24:28] (Merged) jenkins-bot: CiviCRM submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/493310 (owner: Eileen) [20:30:07] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/493316 [20:30:40] (CR) jerkins-bot: [V: -1] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/493316 (owner: Eileen) [20:36:04] (PS1) Eileen: Composer updates [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/493318 [20:37:26] (CR) Eileen: [C: +2] Composer updates [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/493318 (owner: Eileen) [20:46:01] (Merged) jenkins-bot: Composer updates [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/493318 (owner: Eileen) [20:46:20] (PS2) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/493316 [20:46:37] (Abandoned) Eileen: (cherry-picked from master) Repair omnirecipient with 14 hour gap [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/493134 (https://phabricator.wikimedia.org/T215865) (owner: Eileen) [20:48:21] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/493316 (owner: Eileen) [20:48:56] (Merged) jenkins-bot: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/493316 (owner: Eileen) [20:50:02] !log civicrm revision changed from 224bf15206 to c81fe7a4fd, config revision is d1826e371b [20:50:04] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:50:27] Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Changes to Benevity import - https://phabricator.wikimedia.org/T215196 (Eileenmcnaughton) @leannes how is the import going? [20:54:07] Fundraising-Backlog: Re-add fields to Silverpop export - https://phabricator.wikimedia.org/T170972 (CCogdill_WMF) Okay that makes sense. Should we be seeing the unsubscribes file grow proportionately? Is there any amount of variance we should flag? [20:58:03] cwd / Jeff_Green the new darkmode private grafana looks great! [20:58:34] ejegg: cool. lemme try sending you an editor invite... [20:58:40] pretty spiffy eh? nice job cwd! [20:58:48] So to publish some stats to that and not to the public grafana, do we just add an extra dir to be scraped? [21:00:24] ah good question [21:00:32] (the email thing does not work...i'll check on it) [21:00:35] Fundraising-Backlog: Re-add fields to Silverpop export - https://phabricator.wikimedia.org/T170972 (Eileenmcnaughton) I think my checks when I turned it on were that there were about 400k to process - if it's only doing 5000 per day we should probably speed it up [21:00:38] probably missing an mta [21:01:07] ejegg: how about we duplicate what we need from prod and disconnect it? [21:01:45] the boards can be imported/exported in the UI [21:02:11] 'the email thing' = the mail queue graph? That one's looking kinda high [21:02:57] heh sorry no the email account invite [21:03:09] and yeah actually we have been getting icinga warnings about that [21:03:13] cwd ah, I guess we could stop publishing to public grafana, would be a bit of a bummer [21:03:43] not making the stats public? [21:04:57] eh, guess very few people will miss [21:04:59] em [21:06:04] Fundraising-Backlog: Re-add fields to Silverpop export - https://phabricator.wikimedia.org/T170972 (Eileenmcnaughton) Here is the query of how many are still to process ` select count(*) FROM civicrm_mailing_provider_data WHERE event_type IN ('Opt Out', 'Reply Abuse', 'Suppressed') AND is_civicrm_updated =... [21:08:47] Fundraising Sprint Da Vinci Coder, Fundraising Sprint They Live, Fundraising Sprint USB stands for underhanded socket bureaucracy, Fundraising Sprint Vestigial tails shoot from the hip, and 3 others: Extend deletion to multiple silverpop databases - https://phabricator.wikimedia.org/T205332 (Eilee... [21:09:45] Fundraising Sprint Da Vinci Coder, Fundraising Sprint They Live, Fundraising Sprint USB stands for underhanded socket bureaucracy, Fundraising Sprint Vestigial tails shoot from the hip, and 3 others: Extend deletion to multiple silverpop databases - https://phabricator.wikimedia.org/T205332 (Eilee... [21:22:29] ejegg: I just updated civicrm.settings in git for multiple dbs - wanna check & I can deploy? [21:23:10] sure thing [21:27:30] (PS1) Eileen: Add helper for deleting payment processor [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/493324 [21:35:28] (Restored) Eileen: In theory this would cleanup OK with the new helper [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/491878 (owner: Eileen) [21:36:04] (PS4) Eileen: In theory this would cleanup OK with the new helper [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/491878 [21:41:13] (CR) jerkins-bot: [V: -1] In theory this would cleanup OK with the new helper [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/491878 (owner: Eileen) [21:44:56] !log civicrm revision is c81fe7a4fd, config revision is 050abdf9e8 [21:44:57] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:17:53] Fundraising-Backlog: Re-add fields to Silverpop export - https://phabricator.wikimedia.org/T170972 (CCogdill_WMF) 5000 per day lines up with what we're seeing. Thanks, that makes sense! [22:19:42] Fundraising-Backlog: Re-add fields to Silverpop export - https://phabricator.wikimedia.org/T170972 (Eileenmcnaughton) @CCogdill_WMF we just added a 0 to the number to be processed per run - so it should speed up a bit now [22:41:32] Fundraising-Backlog: Re-add fields to Silverpop export - https://phabricator.wikimedia.org/T170972 (CCogdill_WMF) Sounds good! [23:01:02] (PS1) Ejegg: WIP hide opt_in buttons when given on querystring [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/493334 (https://phabricator.wikimedia.org/T217254) [23:01:14] fr-tech want to let me know what you think of that ^^^ ? [23:01:58] gonna relocate, getting chilly in this outdoor cafe [23:48:59] Fundraising Sprint Da Vinci Coder, Fundraising-Backlog: fill out PCI forms for this yearr - https://phabricator.wikimedia.org/T217184 (DStrine) test [23:49:24] Fundraising Sprint Da Vinci Coder, Fundraising-Backlog: fill out PCI forms for this year - https://phabricator.wikimedia.org/T217184 (DStrine) [23:51:42] Fundraising-Backlog: Re-add fields to Silverpop export - https://phabricator.wikimedia.org/T170972 (DStrine) test [23:52:08] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 5 others: slow loading of contribution tab when many con... - https://phabricator.wikimedia.org/T209415 [23:52:12] what are you testing dstrine? [23:59:53] ejegg: sorry I got a bug report that emailing back on a phabricator email added extra people as subscribers. I can't reproduce it but I saw it happen with cogdil