[00:03:29] Fundraising Sprint Da Vinci Coder, Fundraising-Backlog: fill out PCI forms for this year - https://phabricator.wikimedia.org/T217184 (XenoRyet) New forms are filled out, and sent to @Ppena and Fr-tech for review. [00:26:34] (PS2) Ejegg: Hide opt_in buttons when given on querystring [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/493334 (https://phabricator.wikimedia.org/T217254) [03:02:46] (PS1) Aaron Schulz: Convert extractMessageFields() caching to the WAN cache [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/493354 [15:13:56] (PS1) Ejegg: Process unsubscribes: omit blank contact_id [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/493423 (https://phabricator.wikimedia.org/T161761) [15:14:18] fr-tech: ^^^ should fix the problem with the job that was sending us failmail all night [16:17:42] (CR) AndyRussG: [C: -2] "> Suggests there is a genuine bug, that was somehow not previously detected." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/492486 (owner: AndyRussG) [16:22:08] AndyRussG: I'm about to rebase and +2 this patch removing the obsolete banner screenshot support in CN: https://gerrit.wikimedia.org/r/484784 [16:22:14] unless you have any objections [16:24:02] ejegg: cool, thanks, and thanks for asking! I haven't even peeked at it yet, but pls go ahead. Beta cluster is always nice. I'll give it and other accumulated stuff one more once-over before deploy, as usual. [16:24:17] (PS8) Ejegg: Remove unused banner preview support [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/484784 (https://phabricator.wikimedia.org/T161907) (owner: Awight) [16:24:22] The new deploy thing is working good now btw, we should close all those old tickets [16:24:34] (CR) Ejegg: [C: +2] "Thanks again awight!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/484784 (https://phabricator.wikimedia.org/T161907) (owner: Awight) [16:25:10] awight also did this to remove all the custom caching for banner message fields: https://gerrit.wikimedia.org/r/484809 [16:25:12] ejegg: my only thought is that we should let Ike know, since he and his shadows will probably also want to rebase [16:25:24] ah, yah [16:25:39] Did he/they ever make it to IRC btw? [16:25:54] so there's a competing patch about the banner message field caching: https://gerrit.wikimedia.org/r/493354 [16:26:01] from Aaron Schulz [16:26:17] hmmmm [16:26:29] Fundraising-Backlog, fundraising-tech-ops: tmp on civi1001 is large - https://phabricator.wikimedia.org/T217341 (cwdent) [16:26:30] That's a good question - we haven't gotten any obvious pings or emails with irc nicks [16:30:29] thx for following those patches... I can check them out btw [16:32:23] fr-tech also btw apologies if I suddenly disappear or even miss standup... The library internet here does sometimes flake out, and I just realized I forgot to load up the data on my pay-as-you-go phone [16:33:12] I think I may have a few _bits_ of phone data left tho, we'll see [16:35:15] (Merged) jenkins-bot: Remove unused banner preview support [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/484784 (https://phabricator.wikimedia.org/T161907) (owner: Awight) [16:43:15] (CR) jenkins-bot: Remove unused banner preview support [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/484784 (https://phabricator.wikimedia.org/T161907) (owner: Awight) [16:48:34] Fundraising-Backlog, fundraising-tech-ops: Deploy inconsistency between civi1001 and mintaka - https://phabricator.wikimedia.org/T217342 (cwdent) [17:26:02] (PS1) AndyRussG: Rename and improve method for processes after campaign change [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/493457 (https://phabricator.wikimedia.org/T208511) [17:30:05] (PS1) AndyRussG: Create CampaignChange hook [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/493459 (https://phabricator.wikimedia.org/T208511) [17:31:56] (CR) jerkins-bot: [V: -1] Create CampaignChange hook [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/493459 (https://phabricator.wikimedia.org/T208511) (owner: AndyRussG) [17:33:41] (CR) jerkins-bot: [V: -1] Create CampaignChange hook [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/493459 (https://phabricator.wikimedia.org/T208511) (owner: AndyRussG) [17:35:32] fundraising-tech-ops: Backup strategy for Grafana - https://phabricator.wikimedia.org/T217353 (cwdent) [17:40:26] fundraising-tech-ops: Revoke production prometheus fundraising access - https://phabricator.wikimedia.org/T217355 (cwdent) [17:43:15] Fundraising-Backlog, Analytics, Analytics-Kanban: CentralNoticeImpression refined impressionEventSampleRate is int instead of double - https://phabricator.wikimedia.org/T217109 (Milimetric) p:Triage→Normal [17:43:20] Fundraising-Backlog, Analytics: CentralNoticeImpression refined impressionEventSampleRate is int instead of double - https://phabricator.wikimedia.org/T217109 (Milimetric) [17:51:19] Hmmm this is an interesting test failure: https://integration.wikimedia.org/ci/job/mwext-phpunit-coverage-patch-docker/9347/console [17:51:40] Just renamed a method, I wonder if that was the problem [17:52:33] Anyway we can just force CI's hand when we +2 that one [17:53:02] I wonder how it keeps track of that ~5% test coverage [18:11:01] (PS2) AndyRussG: Create CampaignChange hook [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/493459 (https://phabricator.wikimedia.org/T208511) [19:05:33] (PS3) AndyRussG: Create CampaignChange hook [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/493459 (https://phabricator.wikimedia.org/T208511) [20:27:48] (CR) Eileen: [C: +2] Process unsubscribes: omit blank contact_id [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/493423 (https://phabricator.wikimedia.org/T161761) (owner: Ejegg) [20:31:11] cccccchrbkbkkgbtgkkidvvkerktfjtijkuhjkkehukr [20:31:17] whooooops [20:33:10] (Merged) jenkins-bot: Process unsubscribes: omit blank contact_id [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/493423 (https://phabricator.wikimedia.org/T161761) (owner: Ejegg) [20:36:33] Fundraising-Analysis, Code-Stewardship-Reviews, MediaWiki-extensions-CentralNotice, QuickSurveys, and 4 others: Consolidate QuickSurveys into CentralNotice - https://phabricator.wikimedia.org/T217374 (Niedzielski) [20:37:26] Fundraising-Backlog, Code-Stewardship-Reviews, MediaWiki-extensions-CentralNotice, QuickSurveys, and 4 others: Consolidate QuickSurveys into CentralNotice - https://phabricator.wikimedia.org/T217374 (AndyRussG) [20:42:31] Fundraising Sprint Da Vinci Coder, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Some users not able to use quick search - https://phabricator.wikimedia.org/T216553 (CaitVirtue) Yes, I think we're good for now. Thank you! [21:44:28] (CR) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/493542 (owner: L10n-bot) [21:47:40] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Paypal: Finish fixing bad contribution_recur data from PayPal October 2018 cancel-storm - https://phabricator.wikimedia.org/T217379 (Ejegg) [22:21:41] (PS3) Ejegg: Hide opt_in buttons when given on querystring [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/493334 (https://phabricator.wikimedia.org/T217254) [22:23:03] (CR) jerkins-bot: [V: -1] Hide opt_in buttons when given on querystring [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/493334 (https://phabricator.wikimedia.org/T217254) (owner: Ejegg) [22:24:58] (PS4) Ejegg: Hide opt_in buttons when given on querystring [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/493334 (https://phabricator.wikimedia.org/T217254) [22:30:38] (PS1) Ejegg: Only show emailExplain when opted out [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/493618 (https://phabricator.wikimedia.org/T215939) [22:31:11] Fundraising Sprint Da Vinci Coder, Fundraising-Backlog, MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Patch-For-Review: Edits to text on payments page - https://phabricator.wikimedia.org/T215939 (Ejegg) p:Triage→Normal a:Ejegg [22:31:24] Fundraising Sprint Da Vinci Coder, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: Hide opt_in radio buttons when the choice has been provided on the query string - https://phabricator.wikimedia.org/T217254 (Ejegg) p:Triage→Normal a:Ejegg [22:33:57] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/493620 [22:35:43] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/493620 (owner: Ejegg) [22:36:22] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/493620 (owner: Ejegg) [22:39:36] !log updated fundraising CiviCRM from c81fe7a4fd to 616c58cebe [22:39:37] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:45:34] Fundraising-Backlog, Code-Stewardship-Reviews, MediaWiki-extensions-CentralNotice, QuickSurveys, and 5 others: Consolidate QuickSurveys into CentralNotice - https://phabricator.wikimedia.org/T217374 (Jdlrobson) Is this a more detailed version of T125125 ? Should we consolidate the two? [23:30:35] (PS2) AndyRussG: Rename and improve method for processes after campaign change [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/493457 (https://phabricator.wikimedia.org/T208511) [23:32:53] (PS3) AndyRussG: Rename and improve method for processes after campaign change [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/493457 (https://phabricator.wikimedia.org/T208511) [23:36:42] (PS4) AndyRussG: Create CampaignChange hook [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/493459 (https://phabricator.wikimedia.org/T208511) [23:55:34] Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Changes to Benevity import - https://phabricator.wikimedia.org/T215196 (LeanneS) It went well! Thanks so much, @Eileenmcnaughton! The one thi...