[00:00:15] hmm that should have worked I would have thought - not sure the error [00:03:19] huh [00:03:22] checking [00:03:49] CiviCRM_API3_Exception: invalid criteria for BETWEEN [00:07:02] lemme see how many say 'prospect' [00:07:41] ejegg: there is an api bug - change 0 to 1 [00:07:44] & it will work [00:07:56] aha, I just saw that too [00:08:09] want to submit the upstream patch or should i? [00:08:33] I can do it - it’ll need a test [00:08:39] thanks! [00:08:45] for now I'll change that to 1 [00:08:59] were you thinking something more clever than [00:09:31] (PS2) Ejegg: Better way to skip non-numeric contact_id [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/494378 [00:09:47] if ((empty($criteria[0]) && $criteria[0] !== 0) || (empty($criteria[1]) && $criteria[1] !== 0))) [00:10:22] eileen: sure, those work! That's the only 'empty' value that would make sense as a criteria [00:10:28] I assume BETWEEN works for strings so is_numeric doesn’t work [00:10:49] right, strings are totally kosher [00:11:03] but false and the empty array are bogus [00:15:15] (CR) Eileen: [C: +2] Better way to skip non-numeric contact_id [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/494378 (owner: Ejegg) [00:16:09] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic, FR-Email: EPIC: Add key silverpop data into Civi - https://phabricator.wikimedia.org/T161757 (Eileenmcnaughton) [00:16:12] Fundraising Sprint Da Vinci Coder, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic, and 2 others: Reflect all undeliverables via Silverpop in CiviCRM - https://phabricator.wikimedia.org/T161761 (Eileenmcnaughton) Open→Resolved Just also merged a fix by @ejegg for the Non-numeric... [00:23:14] ejegg: https://github.com/civicrm/civicrm-core/pull/13766 [00:23:38] dang but you work fast! [00:23:51] Fundraising Sprint Da Vinci Coder, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic, and 2 others: Reflect all undeliverables via Silverpop in CiviCRM - https://phabricator.wikimedia.org/T161761 (Eileenmcnaughton) Upstream fix for bug Elliott hit (& worked around ) https://github.com/civi... [00:23:54] that one I was pretty well set up for [00:24:06] oh nice, good catch on the string zero too [00:24:23] well - my test failed without that! [00:24:57] ohhh, it's cast to a string in the API call! [00:25:02] weird [00:25:25] does it end up sent to SQL quoted, then? [00:26:42] sorry to interrupt :| Eileen, I've given up trying to optimise this bunch of left joins. Can you send me a link to the CASE statement you mentioned in the call last week as the alternative for the fredge report query please? [00:27:15] jgleeson aww, they're still slow? [00:27:17] jgleeson: I’ll look after I’ve grabbed some food - do you want to push up what you have somewhere anyway? [00:27:48] I’m gonna open up that address history fix then too so will be reports for the rest of the day for me [00:28:15] yep still slow. Ok eileen I'll push up the WIP [00:28:35] feels weird referring to someone by their real first name on irc [00:28:41] lol [00:29:03] my privacy alarm goes off as soon as I hit enter [00:29:06] :) [00:30:09] (PS1) Ejegg: Hide opt_in buttons when given on querystring [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/494382 (https://phabricator.wikimedia.org/T217254) [00:31:34] hmm, I thought I had cherry-picked a lot more than just that! [00:37:16] ok, gonna send a flood of cherry-picks up [00:37:16] flood warning! [00:37:16] (foiled by git-review) [00:37:16] ! [remote rejected] HEAD -> refs/for/deployment (the number of pushed changes in a batch exceeds the max limit 10) [00:37:17] (PS1) Ejegg: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/494385 [00:37:19] (PS1) Ejegg: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/494386 [00:37:21] (PS1) Ejegg: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/494387 [00:37:23] (PS1) Ejegg: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/494388 [00:37:25] (PS1) Ejegg: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/494389 [00:37:27] (PS1) Ejegg: Make email explanation translatable [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/494390 (https://phabricator.wikimedia.org/T215939) [00:37:29] (PS1) Ejegg: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/494391 [00:37:31] (PS1) Ejegg: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/494392 [00:37:33] (PS1) Ejegg: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/494393 [00:37:35] (PS2) Ejegg: Hide opt_in buttons when given on querystring [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/494382 (https://phabricator.wikimedia.org/T217254) [00:37:37] (PS1) Ejegg: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/494394 [00:37:39] (PS1) Ejegg: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/494395 [00:37:41] (PS1) Ejegg: Only show emailExplain when opted out [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/494396 (https://phabricator.wikimedia.org/T215939) [00:37:52] (CR) Ejegg: [C: +2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/494385 (owner: Ejegg) [00:38:06] (CR) Ejegg: [C: +2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/494386 (owner: Ejegg) [00:38:09] (CR) Ejegg: [C: +2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/494387 (owner: Ejegg) [00:38:23] (CR) Ejegg: [C: +2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/494388 (owner: Ejegg) [00:38:29] (CR) Ejegg: [C: +2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/494389 (owner: Ejegg) [00:38:39] (CR) Ejegg: [C: +2] Make email explanation translatable [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/494390 (https://phabricator.wikimedia.org/T215939) (owner: Ejegg) [00:39:00] (CR) Ejegg: [C: +2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/494391 (owner: Ejegg) [00:39:05] (CR) Ejegg: [C: +2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/494392 (owner: Ejegg) [00:39:10] (CR) Ejegg: [C: +2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/494393 (owner: Ejegg) [00:39:17] (CR) Ejegg: [C: +2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/494394 (owner: Ejegg) [00:39:22] (CR) Ejegg: [C: +2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/494395 (owner: Ejegg) [00:39:28] (CR) Ejegg: [C: +2] Hide opt_in buttons when given on querystring [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/494382 (https://phabricator.wikimedia.org/T217254) (owner: Ejegg) [00:39:34] (CR) Ejegg: [C: +2] Only show emailExplain when opted out [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/494396 (https://phabricator.wikimedia.org/T215939) (owner: Ejegg) [00:40:06] (PS1) Ejegg: Front-end logging for Ingenico url too short [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/494397 (https://phabricator.wikimedia.org/T210893) [00:40:14] (CR) Ejegg: [C: +2] Front-end logging for Ingenico url too short [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/494397 (https://phabricator.wikimedia.org/T210893) (owner: Ejegg) [00:40:55] (Merged) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/494385 (owner: Ejegg) [00:40:58] (Merged) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/494386 (owner: Ejegg) [00:41:07] (Merged) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/494387 (owner: Ejegg) [00:41:10] (Merged) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/494388 (owner: Ejegg) [00:41:12] (Merged) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/494389 (owner: Ejegg) [00:41:14] (Merged) jenkins-bot: Make email explanation translatable [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/494390 (https://phabricator.wikimedia.org/T215939) (owner: Ejegg) [00:41:16] (Merged) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/494391 (owner: Ejegg) [00:41:18] (Merged) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/494392 (owner: Ejegg) [00:41:20] (Merged) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/494393 (owner: Ejegg) [00:41:22] (Merged) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/494394 (owner: Ejegg) [00:41:28] (Merged) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/494395 (owner: Ejegg) [00:41:30] (Merged) jenkins-bot: Hide opt_in buttons when given on querystring [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/494382 (https://phabricator.wikimedia.org/T217254) (owner: Ejegg) [00:41:50] (Merged) jenkins-bot: Only show emailExplain when opted out [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/494396 (https://phabricator.wikimedia.org/T215939) (owner: Ejegg) [00:41:53] (Merged) jenkins-bot: Front-end logging for Ingenico url too short [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/494397 (https://phabricator.wikimedia.org/T210893) (owner: Ejegg) [01:02:23] Fundraising Sprint Da Vinci Coder, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic, and 2 others: Reflect all undeliverables via Silverpop in CiviCRM - https://phabricator.wikimedia.org/T161761 (CCogdill_WMF) @Eileenmcnaughton, does this mean there are 4.2 million records with one of the... [02:31:13] (PS8) Jgleeson: WIP: civi wmffraud fredge report [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/482672 (https://phabricator.wikimedia.org/T199268) [02:32:23] (CR) jerkins-bot: [V: -1] WIP: civi wmffraud fredge report [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/482672 (https://phabricator.wikimedia.org/T199268) (owner: Jgleeson) [02:43:30] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/494403 [02:43:43] (CR) Ejegg: [C: +2] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/494403 (owner: Ejegg) [02:46:44] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/494403 (owner: Ejegg) [02:59:59] !log updated payments-wiki from ca7c280f3e to 4f2935ad17 [03:00:00] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [03:29:28] (PS1) Ejegg: Allow multiple classes on a tag in a banner message [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/494404 (https://phabricator.wikimedia.org/T216150) [03:30:39] Fundraising Sprint Da Vinci Coder, Fundraising-Backlog, Fr-CentralNotice-Translation-Bugs, MediaWiki-extensions-CentralNotice, Patch-For-Review: New message inclusion syntax strips with more than one class - https://phabricator.wikimedia.org/T216150 (Ejegg) a:Ejegg [03:38:19] (PS3) Ejegg: Add helper for deleting payment processor [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/493324 (owner: Eileen) [03:38:28] (CR) Ejegg: [C: +2] Add helper for deleting payment processor [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/493324 (owner: Eileen) [03:38:42] ejegg: I got there [03:43:34] (Merged) jenkins-bot: Add helper for deleting payment processor [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/493324 (owner: Eileen) [03:47:39] :) [03:51:02] (CR) Ejegg: "Looks good so far! I want to test locally a little more tomorrow with contributions from different sources." (3 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/490666 (https://phabricator.wikimedia.org/T213209) (owner: Cstone) [05:12:58] (PS5) Eileen: In theory this would cleanup OK with the new helper [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/491878 [05:18:04] (CR) jerkins-bot: [V: -1] In theory this would cleanup OK with the new helper [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/491878 (owner: Eileen) [06:52:22] PROBLEM - check_puppetrun on frdb2001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 5 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-client] [06:57:22] PROBLEM - check_puppetrun on frdb2001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 10 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-client] [07:02:22] RECOVERY - check_puppetrun on frdb2001 is OK: OK: Puppet is currently enabled, last run 1 minute ago with 0 failures [14:13:33] fundraising-tech-ops: Backup strategy for Grafana - https://phabricator.wikimedia.org/T217353 (CDanis) It's almost certainly unnecessary with as little write traffic as our grafanas get, but what I've been doing for my own pre-version-upgrade backups is the following: `sqlite3 /var/lib/grafana/grafana.db ".... [16:35:30] Fundraising Sprint Da Vinci Coder, Fundraising-Backlog, MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Patch-For-Review: Edits to text on payments page - https://phabricator.wikimedia.org/T215939 (Ejegg) This is deployed - the emailExplain variant now only shows the text when the donor has opted OUT,... [16:39:52] Fundraising Sprint Da Vinci Coder, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: Hide opt_in radio buttons when the choice has been provided on the query string - https://phabricator.wikimedia.org/T217254 (Ejegg) This is deployed - the radio buttons for the opt_in... [16:43:46] Fundraising Sprint Da Vinci Coder, Fundraising-Backlog, MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Patch-For-Review: Edits to text on payments page - https://phabricator.wikimedia.org/T215939 (Ejegg) @tskaff, @spatton, et al: Do you want to keep this as a 'variant' that needs to be triggered by t... [16:52:03] off to pick up Oscar from nursery, back soon! [16:52:20] AndyRussG: oh man, that not_ prefix on the CN table fields is a bit unfortunate :P [16:52:34] not_enabled = 1 means it IS enabled [16:52:44] hahahah [16:52:45] indeed [16:52:53] and not = notice = campaign [16:53:02] heh, also befuddling [16:53:24] probably not TOO huge a table to rename if we wanted to [16:54:23] Hmph, what kind of IDE spellchecker doesn't recognize 'Automagically' ? [16:54:28] ejegg: sure, but I think just a big old major refactor of all that stuff would be higher priority [16:54:30] heheh [16:54:36] added to dictionary! [16:55:12] Fundraising Sprint Da Vinci Coder, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: Hide opt_in radio buttons when the choice has been provided on the query string - https://phabricator.wikimedia.org/T217254 (CCogdill_WMF) Yeah, good thinking! We should add all EU /... [17:02:27] (PS5) Cstone: Add in check to set no_thank_you field for recurring payments after the first recurring payment. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/490666 (https://phabricator.wikimedia.org/T213209) [17:02:50] Fundraising Sprint Da Vinci Coder, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: Hide opt_in radio buttons when the choice has been provided on the query string - https://phabricator.wikimedia.org/T217254 (Ejegg) Besides GB & IE for English, it looks like we can a... [17:05:35] AndyRussG: so there's no value in returning the database IDs for notices and templates? [17:05:50] I guess names are more portable, and have a unique constraint [17:06:20] ejegg: yeah I think that's right [17:06:53] cool, cool [17:08:48] bwahahahah you know the failing tests on the hook patch? [17:08:57] it's not that there was something wrong with the tests [17:09:12] rather, they're detecting an error heh [17:09:24] (albeit in a convoluted way) [17:11:18] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 4 others: Reduce recurring TY emails - https://phabricator.wikimedia.org/T213209 (Ejegg) @jrobel... [17:11:58] AndyRussG: oho? [17:12:18] (PS10) AndyRussG: Create CampaignChange hook [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/493459 (https://phabricator.wikimedia.org/T217565) [17:12:28] cstone: so... I'm holding off merging that code, just till we get an answer to the question just posted on the ticket [17:12:53] feel free to work on other stuff while we wait for that text! [17:13:53] ok! [17:15:07] gonna relocate, back soon [17:20:35] ejegg|brb: ^ tests passing now on the hook patch. I think it's reviewable in principle, but maybe let's hold off on the +2 until the EventBus handler side is also done? [17:21:21] (CR) AndyRussG: [C: -1] "Let's not merge until handler is working as expected. Thanks!!!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/493459 (https://phabricator.wikimedia.org/T217565) (owner: AndyRussG) [17:21:38] Really silly that you can still +2 stuff even though it's marked as WIP [17:39:36] (Abandoned) AndyRussG: [Test] CI test [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/492486 (owner: AndyRussG) [17:59:26] fr-tech, COO Office hour or tech-talk? [17:59:58] jgleeson i'm doing coo office hour [18:00:23] I just saw your message in fredge as I typed in here :) [18:00:26] cool thanks [18:04:43] MBeat dstrine Hi hi, we're putting up Italy mobile today ... all good? [18:04:55] totally! [18:08:31] tskaff: should be fine [18:08:41] Thanks! [18:12:27] Fundraising Sprint Da Vinci Coder, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), Patch-For-Review: Hide opt_in radio buttons when the choice has been provided on the query string - https://phabricator.wikimedia.org/T217254 (CCogdill_WMF... [18:45:11] Fundraising Sprint Owls, Fundraising Sprint Pluto is still a planet, Fundraising Sprint Queue is pronounced GJif, Fundraising Sprint Raw data can give you salmonella, and 3 others: Mailing data double counting in CiviCRM? - https://phabricator.wikimedia.org/T200240 (CCogdill_WMF) Thanks for conti... [19:13:15] fr-tech, I just rebuilt a vagrant vm using the latest changes on mediawiki-vagrant with the fundraising role and redis IS installed as expected, so no changes needed. I did get an error during the provisioning step enabling of our drupal modules but running `vagrant provision` right after the first `vagrant up` completed, rectified that. These days I build in an expectation of some vagrant weirdness now being part of the overall [19:13:15] successful use of the tool. [19:40:53] jgleeson: ok, glad to know redis is there as expected [19:41:14] did you happen to catch the exact error in the module enablement? [19:42:29] (PS6) Ejegg: Add API for active campaigns and banners [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/492353 (https://phabricator.wikimedia.org/T217524) (owner: AndyRussG) [19:42:38] (CR) Ejegg: [C: +2] "Looking good!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/492353 (https://phabricator.wikimedia.org/T217524) (owner: AndyRussG) [19:42:47] ejegg, it was: Exception: API error: DB Error: constraint violation in CRM_Core_ManagedEntities->onApiError() (line 457 of /vagrant/srv/org.wikimedia.civicrm/civicrm/CRM/Core/ManagedEntities.php) [19:42:59] ejegg: thanks much! [19:43:50] ==> default: Notice: /Stage[main]/Crm::Drupal/Exec[enable_drupal_modules]/returns: Exception: API error: DB Error: constraint violation in CRM_Core_ManagedEntities->onApiError() (line 457 of /vagrant/srv/org.wikimedia.civicrm/civicrm/CRM/Core/ManagedEntities.php). [19:44:17] although I haven't ruled out it being caused by the fact that I'm building from a previously running codebase? [19:44:23] jgleeson: huh, that ManagedEntities sounds like it's one of the things that we manage in the mgd files [19:44:43] interesting [19:45:13] Would there have been a pre-existing database? I'm not sure how much checking for existing data happens in that ManagedEntities code [19:45:26] me neither [19:45:40] my understanding is that the civicrm db gets wiped and rebuilt [19:45:50] Fundraising Sprint Da Vinci Coder, Fundraising-Backlog: Ingenico: 10/15/2018 or 10/18/2018 audit missing refunds? - https://phabricator.wikimedia.org/T216072 (Ejegg) From previous ticket: > Not sure if this is related, but it looks like some Ingenico refunds from 1/30 and 2/1 are not yet in Civi. Sample... [19:46:15] ejegg, it might be due to a bug in the code I've added locally for the fredge reports that I'm not aware of yet [19:46:30] although it fixed itself without me looking there, second time around [19:47:20] ok, I hope all the entities got created [19:57:52] (Merged) jenkins-bot: Add API for active campaigns and banners [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/492353 (https://phabricator.wikimedia.org/T217524) (owner: AndyRussG) [20:09:18] (CR) jenkins-bot: Add API for active campaigns and banners [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/492353 (https://phabricator.wikimedia.org/T217524) (owner: AndyRussG) [20:21:12] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 3 others: Upgrade PaymentsWiki to Mediawiki 1.31 (new LT... - https://phabricator.wikimedia.org/T184460 [20:22:59] AndyRussG & ejegg: hello, you there? [20:23:16] Hi MarcoAurelio, how's it going? [20:23:36] ejegg I'm fine, thanks. Could you please take a look at https://phabricator.wikimedia.org/T217649 ? [20:23:46] it's a restricted task but I added you [20:24:31] Ooh, interesting. We've got our sprint planning meeting in 5 minutes, and I'll definitely bring up that ticket [20:24:34] Thanks! [20:24:45] Thank you :) [20:24:55] I got to go now. I'll check for updates later. [21:12:41] Fundraising Sprint Da Vinci Coder, Fundraising-Backlog, FR-Astropay: donation form not passing language pref to dLocal - https://phabricator.wikimedia.org/T216552 (Ejegg) Open→Resolved p:Triage→Normal [21:15:08] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 6 others: Ingenico Connect hosted checkouts - using brok... - https://phabricator.wikimedia.org/T210893 [21:16:33] Fundraising-Backlog, Fr-Ingenico-integration_2017-18: Ingenico: audit lagging on manual settled transactions? - https://phabricator.wikimedia.org/T217582 (DStrine) [21:16:36] Fundraising Sprint Da Vinci Coder, Fundraising-Backlog: Ingenico: 10/15/2018 or 10/18/2018 audit missing refunds? - https://phabricator.wikimedia.org/T216072 (DStrine) [21:16:45] Fundraising Sprint Da Vinci Coder, Fundraising-Backlog, Fr-Ingenico-integration_2017-18: Ingenico: audit lagging on manual settled transactions? - https://phabricator.wikimedia.org/T217582 (DStrine) [21:21:00] Fundraising-Backlog: Send message to opt-in queue on failed payments attempts with opt_in=1 - https://phabricator.wikimedia.org/T216293 (Ejegg) [21:21:16] Fundraising-Backlog: Send message to opt-in queue on failed payments attempts with opt_in=1 - https://phabricator.wikimedia.org/T216293 (DStrine) We are going to focus on the failed transactions first. We'll need to talk about the difficulty and priority of those who don't complete the form. [21:21:54] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Update opt-in queue consumer to be able to create new donor records - https://phabricator.wikimedia.org/T217710 (Ejegg) [21:22:05] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 3 others: Upgrade PaymentsWiki to Mediawiki 1.31 (new LT... - https://phabricator.wikimedia.org/T184460 [21:23:03] Fundraising-Backlog, FR-Email: Update Silverpop export to include opted in records with no donations - https://phabricator.wikimedia.org/T217712 (Ejegg) [21:28:08] Fundraising-Backlog: Thank You email: revise how we specify local currency - https://phabricator.wikimedia.org/T207674 (DStrine) Definition of Done: please spent 2-3 hours on this max and report back on the difficulty to implement. [21:30:01] Fundraising-Backlog: Documentation: Move checklist to mediawiki - https://phabricator.wikimedia.org/T217149 (mepps) a:mepps [21:32:42] Fundraising Sprint Da Vinci Coder, Fundraising-Backlog, fundraising Sprint E 2019: fill out PCI forms for this year - https://phabricator.wikimedia.org/T217184 (DStrine) [21:32:47] Fundraising-Backlog, fundraising Sprint E 2019: Thank You email: revise how we specify local currency - https://phabricator.wikimedia.org/T207674 (DStrine) [21:32:51] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 5 others: Reduce recurring TY emails - https://phabricator.wikimedia.org/T213209 (DStrine) [21:32:53] Fundraising Sprint Da Vinci Coder, Fundraising-Backlog, fundraising Sprint E 2019, MediaWiki-extensions-DonationInterface: DonationInterface should have an option to use new contribution_tracking infrastructure - https://phabricator.wikimedia.org/T215462 (DStrine) [21:32:55] Fundraising-Backlog, fundraising Sprint E 2019, fundraising-tech-ops: Update fundriaising tech training matrix - https://phabricator.wikimedia.org/T217176 (DStrine) [21:32:57] Fundraising-Backlog, fundraising Sprint E 2019: Documentation: Move checklist to mediawiki - https://phabricator.wikimedia.org/T217149 (DStrine) [21:32:59] Fundraising-Backlog, fundraising Sprint E 2019, FR-Email: Update Silverpop export to include opted in records with no donations - https://phabricator.wikimedia.org/T217712 (DStrine) [21:33:01] Fundraising Sprint Da Vinci Coder, Fundraising-Backlog, fundraising Sprint E 2019, Fr-Ingenico-integration_2017-18: Ingenico: audit lagging on manual settled transactions? - https://phabricator.wikimedia.org/T217582 (DStrine) [21:33:03] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising Sprint E 2019, FR-Email: Update opt-in queue consumer to be able to create new donor records - https://phabricator.wikimedia.org/T217710 (DStrine) [21:33:07] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising Sprint E 2019: New Citibank import - https://phabricator.wikimedia.org/T217390 (DStrine) [21:33:12] Fundraising Sprint Da Vinci Coder, Fundraising-Backlog, fundraising Sprint E 2019, Fr-CentralNotice-Translation-Bugs, and 2 others: New message inclusion syntax strips with more than one class - https://phabricator.wikimedia.org/T216150 (DStrine) [21:33:15] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 6 others: Create sequence generation in SmashPig - https://phabricator.wikimedia.org/T214436 (DSt... [21:33:18] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 6 others: find another way to compile the donor list for... - https://phabricator.wikimedia.org/T118822 [21:33:20] Fundraising Sprint Da Vinci Coder, Fundraising-Backlog, fundraising Sprint E 2019, Patch-For-Review: Re-run omnirecipient repair to catch the few missed ones - https://phabricator.wikimedia.org/T215865 (DStrine) [21:33:22] Fundraising Sprint Da Vinci Coder, Fundraising-Backlog, fundraising Sprint E 2019, MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), Patch-For-Review: Edits to text on payments page - https://phabricator.wikimedia.org/T215939 (DStrine) [21:33:24] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 4 others: Upgrade PaymentsWiki to Mediawiki 1.31 (new LT... - https://phabricator.wikimedia.org/T184460 [21:33:27] Fundraising Sprint Da Vinci Coder, Fundraising-Backlog, fundraising Sprint E 2019, MediaWiki-extensions-DonationInterface, and 2 others: Hide opt_in radio buttons when the choice has been provided on the query string - https://phabricator.wikimedia.org/T217254 (DStrine) [21:54:39] (CR) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/494568 (owner: L10n-bot) [23:04:50] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 4 others: Upgrade PaymentsWiki to Mediawiki 1.31 (new LT... - https://phabricator.wikimedia.org/T184460 [23:12:31] phooey, more ingenico failmail [23:12:50] lemme see if I can update SmashPig without messing with payments too much [23:13:00] would be nice to get jgleeson's new logging up [23:13:17] ah I was just messaging you [23:13:26] heh, just saw it [23:13:33] ahhh it's not up? oh my bad I thought you were referring to that on retro [23:13:50] I can deploy now if that's ok? we're cherry picking right [23:14:07] For deploy, I cherry-picked around the commit that deletes vendor and composer.lock [23:14:31] so... I guess the way to update the lib now is just to do it in the vendor submodule on the deployment branch [23:14:47] not ideal, but it'll get the new code up [23:15:22] I don't follow [23:15:41] so we can't deploy the updates directly to the smashpig project? [23:16:36] jgleeson: so, DonationInterface loads the SmashPig library from its vendor directory, not from the standalone dir that's used as out IPN listener endpoint [23:16:51] the smashpig project just deploys that standalone listener endpoint [23:16:55] ah I see [23:17:16] In order to deploy the version used by DonationInterface, we have to update its vendor submodule [23:17:53] Under mediawiki 1.31, we're doing away with the individual vendor submodules in each extension [23:18:14] and using the composer-merge-plugin to get a single vendor module at the mediawiki root dir [23:18:44] so since i thought we were all set to upgrade, I merged a few things to DonationInterface, like getting rid of its own composer.lock and vendor dir [23:19:07] I see now [23:19:27] still just to the master and the (temporary) deploy-1.31 branches [23:19:44] the 'deployment' branch is still set up for mediawiki 1.27 [23:20:05] so on the deployment branch, you can just composer update wikimedia/smash-pig [23:20:18] and in the vendor submodule, add what's changed [23:20:40] then back in the deployment branch of DonationInterface, bump the vendor submodule [23:20:52] ...or I can take care of that. It's crazy late where you are! [23:21:02] ok I think I follow now. I will have to deploy in the morning now as Roxy is reminding me it's my turn to look after Matilda so I'll save this chat and pick up first thing [23:21:42] Don't worry about it - I'll take care of it so we get the logging if we make more bad calls overnight [23:23:00] ok. I do think I'm a little rusty on releases in general having not done many since before christmas so I'll look for excuses over this sprint to make some releases [23:23:43] I think I wrote down our release plan (inc the differences between projects) so I'll dig that out [23:24:12] I'm gonna jump off, catch you all tomorrow fr-tech o/ [23:24:20] jgleeson: cya! [23:28:22] (PS1) Ejegg: Update SmashPig library [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/494622 [23:29:11] (CR) Ejegg: [V: +2 C: +2] Update SmashPig library [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/494622 (owner: Ejegg) [23:35:06] (PS1) Ejegg: Update SmashPig library [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/494625 [23:35:11] (CR) Ejegg: [C: +2] Update SmashPig library [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/494625 (owner: Ejegg) [23:36:03] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/494627 [23:36:07] (CR) Ejegg: [C: +2] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/494627 (owner: Ejegg) [23:39:02] (Merged) jenkins-bot: Update SmashPig library [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/494625 (owner: Ejegg) [23:39:04] (CR) jerkins-bot: [V: -1] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/494627 (owner: Ejegg) [23:39:28] (CR) Ejegg: [C: +2] "recheck" [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/494627 (owner: Ejegg) [23:39:40] (CR) jerkins-bot: [V: -1] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/494627 (owner: Ejegg) [23:41:38] (CR) Ejegg: [C: +2] "recheck" [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/494627 (owner: Ejegg) [23:42:55] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/494627 (owner: Ejegg) [23:48:02] Fundraising Sprint Da Vinci Coder, Fundraising Sprint Ewoks Take Manhattan, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 2 others: Hide opt_in radio buttons when the choice has been provided on the query string - https://phabricator.wikimedia.org/T217254 (Ejegg) Ah, cool, we c... [23:51:50] !log updated payments-wiki from 4f2935ad17 to f1a89d7045 [23:51:52] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log