[00:19:21] (CR) Eileen: "I take it back - the changes are fine - the issue was what I was checking" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/494640 (https://phabricator.wikimedia.org/T118822) (owner: Eileen) [00:20:27] fr-tech, so I fixed my xdebug issues... I had to install the latest version of PHPStorm [00:20:37] ooooh [00:20:57] yup [00:21:10] it's pretty nice too, they've tweaked the UI a little [00:24:45] Fundraising Sprint Da Vinci Coder, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic, and 2 others: Reflect all undeliverables via Silverpop in CiviCRM - https://phabricator.wikimedia.org/T161761 (Eileenmcnaughton) @CCogdill_WMF I refined the query - it's still high but perhaps not inaccur... [00:29:59] Fundraising Sprint Da Vinci Coder, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic, and 2 others: Reflect all undeliverables via Silverpop in CiviCRM - https://phabricator.wikimedia.org/T161761 (Eileenmcnaughton) @CCogdill_WMF Hmmm.... select count(DISTINCT contact_id), event_type FROM... [00:35:18] (PS9) Jgleeson: WIP: civi wmffraud fredge report [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/482672 (https://phabricator.wikimedia.org/T199268) [00:37:09] Fundraising Sprint Da Vinci Coder, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic, and 2 others: Reflect all undeliverables via Silverpop in CiviCRM - https://phabricator.wikimedia.org/T161761 (Eileenmcnaughton) This shows it better - ie all the 'Opt Out' contacts are already Suppressed... [00:39:27] Fundraising Sprint Ewoks Take Manhattan, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: New Citibank import - https://phabricator.wikimedia.org/T217390 (LeanneS) @Eileenmcnaughton thanks, these look great. Some comments to your questions are below! Amounts are in original... [00:39:36] ooh, speaking of upgrades, LineageOS 16 is out for my phone... maybe this weekend [00:40:36] can't wait to rock android pie on my 2014 phone [00:41:10] Fundraising Sprint Da Vinci Coder, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic, and 2 others: Reflect all undeliverables via Silverpop in CiviCRM - https://phabricator.wikimedia.org/T161761 (CCogdill_WMF) That 737k number makes sense to me. The distinct seems important. Le mer. 6 ma... [00:53:55] Fundraising Sprint Owls, Fundraising Sprint Pluto is still a planet, Fundraising Sprint Queue is pronounced GJif, Fundraising Sprint Raw data can give you salmonella, and 3 others: Mailing data double counting in CiviCRM? - https://phabricator.wikimedia.org/T200240 (Eileenmcnaughton) @CCogdill_WM... [00:55:36] Fundraising Sprint Owls, Fundraising Sprint Pluto is still a planet, Fundraising Sprint Queue is pronounced GJif, Fundraising Sprint Raw data can give you salmonella, and 3 others: Mailing data double counting in CiviCRM? - https://phabricator.wikimedia.org/T200240 (Eileenmcnaughton) This is a pr... [00:57:32] Fundraising Sprint Owls, Fundraising Sprint Pluto is still a planet, Fundraising Sprint Queue is pronounced GJif, Fundraising Sprint Raw data can give you salmonella, and 3 others: Mailing data double counting in CiviCRM? - https://phabricator.wikimedia.org/T200240 (Eileenmcnaughton) Note the abo... [01:08:33] (PS3) Eileen: Add Citibank import for individuals [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/494851 (https://phabricator.wikimedia.org/T217390) [01:13:00] (CR) jerkins-bot: [V: -1] Add Citibank import for individuals [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/494851 (https://phabricator.wikimedia.org/T217390) (owner: Eileen) [01:24:50] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 5 others: Reduce recurring TY emails - https://phabricator.wikimedia.org/T213209 (Ejegg) Sure, w... [01:32:35] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 4 others: Upgrade PaymentsWiki to Mediawiki 1.31 (new LT... - https://phabricator.wikimedia.org/T184460 [01:34:02] (PS4) Eileen: Add Citibank import for individuals [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/494851 (https://phabricator.wikimedia.org/T217390) [01:34:59] Fundraising Sprint Ewoks Take Manhattan, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: New Citibank import - https://phabricator.wikimedia.org/T217390 (Eileenmcnaughton) a:Eileenmcnaughton [01:37:44] Fundraising Sprint Owls, Fundraising Sprint Pluto is still a planet, Fundraising Sprint Queue is pronounced GJif, Fundraising Sprint Raw data can give you salmonella, and 3 others: Mailing data double counting in CiviCRM? - https://phabricator.wikimedia.org/T200240 (CCogdill_WMF) Ah okay, thanks... [01:39:10] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 5 others: Reduce recurring TY emails - https://phabricator.wikimedia.org/T213209 (CCogdill_WMF)... [01:41:03] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 4 others: Upgrade PaymentsWiki to Mediawiki 1.31 (new LT... - https://phabricator.wikimedia.org/T184460 [01:45:31] Fundraising-Backlog, FR-Paypal, Recurring-Donations: design Paypal recurring up sell - https://phabricator.wikimedia.org/T216558 (Ejegg) Thanks @spatton. You're right, I think this screen can be identical for PayPal and CC donors, it's just that for PayPal donors the 'Yes' click will bring them back... [01:47:20] (PS5) Eileen: Add Citibank import for individuals [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/494851 (https://phabricator.wikimedia.org/T217390) [01:49:07] Fundraising-Backlog, Epic: EPIC: Recurring upsell for donors - https://phabricator.wikimedia.org/T143429 (Ejegg) OK, great to have those amounts, and these mockups look do-able. Will Trilogy be supplying HTML / CSS / JS, or is that all up to fr-tech? And how do those amounts translate to other currencies... [01:51:42] (CR) jerkins-bot: [V: -1] Add Citibank import for individuals [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/494851 (https://phabricator.wikimedia.org/T217390) (owner: Eileen) [01:53:00] Fundraising Sprint Owls, Fundraising Sprint Pluto is still a planet, Fundraising Sprint Queue is pronounced GJif, Fundraising Sprint Raw data can give you salmonella, and 3 others: Mailing data double counting in CiviCRM? - https://phabricator.wikimedia.org/T200240 (Eileenmcnaughton) @CCogdill_WM... [01:56:22] Fundraising Sprint Owls, Fundraising Sprint Pluto is still a planet, Fundraising Sprint Queue is pronounced GJif, Fundraising Sprint Raw data can give you salmonella, and 3 others: Mailing data double counting in CiviCRM? - https://phabricator.wikimedia.org/T200240 (CCogdill_WMF) Ah great, thanks... [01:59:27] (PS6) Eileen: Add Citibank import for individuals [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/494851 (https://phabricator.wikimedia.org/T217390) [02:07:58] Fundraising Sprint Ewoks Take Manhattan, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: New Citibank import - https://phabricator.wikimedia.org/T217390 (Eileenmcnaughton) I just put this on staging - seems to be working OK [02:23:47] Fundraising Sprint Owls, Fundraising Sprint Pluto is still a planet, Fundraising Sprint Queue is pronounced GJif, Fundraising Sprint Raw data can give you salmonella, and 3 others: Mailing data double counting in CiviCRM? - https://phabricator.wikimedia.org/T200240 (Eileenmcnaughton) @CCogdill_WM... [02:47:39] (CR) Eileen: "So the answer to the alias issue is this" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/482672 (https://phabricator.wikimedia.org/T199268) (owner: Jgleeson) [04:45:04] Fundraising Sprint Owls, Fundraising Sprint Pluto is still a planet, Fundraising Sprint Queue is pronounced GJif, Fundraising Sprint Raw data can give you salmonella, and 3 others: Mailing data double counting in CiviCRM? - https://phabricator.wikimedia.org/T200240 (CCogdill_WMF) Fair point, I'll... [05:17:56] (PS2) Eileen: Update extended reports, fix address history, pivots [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/494640 (https://phabricator.wikimedia.org/T118822) [05:18:04] (Abandoned) Eileen: In theory this would cleanup OK with the new helper [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/491878 (owner: Eileen) [07:22:33] PROBLEM - check_gcsip on payments2002 is CRITICAL: CRITICAL - Socket timeout after 121 seconds [07:22:35] PROBLEM - check_gcsip on payments2001 is CRITICAL: CRITICAL - Socket timeout after 121 seconds [07:25:31] RECOVERY - check_gcsip on payments2002 is OK: HTTP OK: HTTP/1.1 200 OK - 343 bytes in 0.313 second response time [07:25:35] RECOVERY - check_gcsip on payments2001 is OK: HTTP OK: HTTP/1.1 200 OK - 343 bytes in 0.351 second response time [12:29:53] (Abandoned) Ejegg: Custom IPVelocity settings per netblock [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/289893 (owner: Ejegg) [12:30:26] (PS9) Ejegg: WIP fraud points for email address at nonexistant tld [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290615 [12:31:57] (PS10) Ejegg: Maintenance script to create all db tables [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/312577 [12:31:59] (CR) jerkins-bot: [V: -1] WIP fraud points for email address at nonexistant tld [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290615 (owner: Ejegg) [12:33:35] (Abandoned) Ejegg: Fix transaction isolation level [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/336739 (https://phabricator.wikimedia.org/T157600) (owner: Ejegg) [12:33:58] (PS2) Ejegg: WIP Move a couple easy staging helpers into SmashPig [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/350355 (https://phabricator.wikimedia.org/T163867) [12:35:34] (PS3) Ejegg: Use a new field to track retry count instead of age [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/428032 (https://phabricator.wikimedia.org/T192692) [13:54:39] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 4 others: Upgrade PaymentsWiki to Mediawiki 1.31 (new LT... - https://phabricator.wikimedia.org/T184460 [15:58:48] Fundraising-Backlog, Epic: EPIC: Recurring upsell for donors - https://phabricator.wikimedia.org/T143429 (spatton) Hey @Ejegg, @CCogdill_WMF and I spoke to Eric @ Trilogy yesterday and he confirmed that they've already started working on the HTML, CSS & JS - should be complete soon and we'll pass it alon... [17:05:35] Hey fr-tech. Looks like I forgot to adjust the calendar so that standup doesn't conflict with staff community time today. Sorry about that. [17:05:43] Everyone cool to just do standup after community time? [17:06:20] XenoRyet: fine for me, mepps also mentioned this elsewhere [17:06:27] Cool [17:15:42] (PS11) AndyRussG: Create CampaignChange hook [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/493459 (https://phabricator.wikimedia.org/T208511) [17:16:24] (CR) jerkins-bot: [V: -1] Create CampaignChange hook [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/493459 (https://phabricator.wikimedia.org/T208511) (owner: AndyRussG) [17:16:27] (CR) jerkins-bot: [V: -1] Create CampaignChange hook [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/493459 (https://phabricator.wikimedia.org/T208511) (owner: AndyRussG) [17:18:48] (PS12) AndyRussG: Create CampaignChange hook [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/493459 (https://phabricator.wikimedia.org/T208511) [17:19:35] fr-tech can we move standup? this other meeting is sounding kinda interesting [17:19:57] Yea, I think we have a loose consensus to have standup after. [17:20:03] oh lol I just saw the other conversation [17:20:19] (CR) jerkins-bot: [V: -1] Create CampaignChange hook [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/493459 (https://phabricator.wikimedia.org/T208511) (owner: AndyRussG) [17:22:19] cstone ejegg ^ also ok about moving standup? I think jgleeson and eileen wouldn't be around in any case [17:22:21] (CR) jerkins-bot: [V: -1] Create CampaignChange hook [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/493459 (https://phabricator.wikimedia.org/T208511) (owner: AndyRussG) [17:22:28] yep that works for me! [17:22:41] sure [17:22:44] :) [17:23:09] XenoRyet dstrine ^ [17:32:20] (PS13) AndyRussG: Create CampaignChange hook [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/493459 (https://phabricator.wikimedia.org/T217565) [17:58:31] Wikimedia-Fundraising-Banners: Can't use comma as decimal separator for Other amount in some banners - https://phabricator.wikimedia.org/T217854 (Pcoombe) [17:58:50] Wikimedia-Fundraising-Banners: Can't use comma as decimal separator for Other amount in some banners - https://phabricator.wikimedia.org/T217854 (Pcoombe) a:Pcoombe [18:05:01] Wikimedia-Fundraising-Banners: Can't use comma as decimal separator for Other amount in some banners - https://phabricator.wikimedia.org/T217854 (spatton) CC'ing @CCogdill_WMF for FYI and I can also reproduce this on donate wiki (where it's also input type = number), FWIW. [18:20:00] Wikimedia-Fundraising-Banners, donate.wikimedia.org: Can't use comma as decimal separator for Other amount in some banners - https://phabricator.wikimedia.org/T217854 (Pcoombe) Thanks @spatton. That's annoying, but also helpful as it rules out it being related to the inline validation we added to banners. [18:24:20] Fundraising Sprint Da Vinci Coder, Fundraising Sprint Ewoks Take Manhattan, Fundraising-Backlog, Fr-Ingenico-integration_2017-18: Ingenico: audit lagging on manual settled transactions? - https://phabricator.wikimedia.org/T217582 (Ejegg) p:Triage→Normal a:Ejegg [18:26:41] cstone so there are three opt-in tickets in the backlog [18:27:00] this one is probably the best to start with: https://phabricator.wikimedia.org/T217710 [18:28:14] the existing queue consumer code is in the sites/all/modules/queue2civicrm module [18:28:34] hmm, it's in a subfolder currently named 'unsubscribe' [18:29:15] but that's increasingly misnamed! [18:29:28] that folder has two queue consumers [18:29:31] haha ok [18:29:34] UnsibscribeQueueConsumer [18:29:39] (the original) [18:29:46] and OptInQueueConsumer [18:29:56] (the new one, which we're going to augment) [18:31:01] So what we're going to do (later) in DonationInterface is send messages to this queue when a person has opted-in to emails on a banner or donatewiki [18:31:16] but who then doesn't get all the way through a donation attempt [18:32:09] I figure those messages will have all of the contact data that lands in the civicrm_contact, civicrm_email, and civicrm_address tables [18:33:07] So in the OptInQueueConsumer, we first check to see if the email is in our DB, and mark all associated contacts as 'opt-in' [18:34:08] line 42 is where we drop the message when no contact is found, so that's where we'd be changing the behavior for this ticket [18:34:32] ok and then if they are being opted in its going into the $optUsIn array? [18:35:39] cstone: if we're creating a new contact, we'd set opt-in during that same process [18:36:08] so we wouldn't have to separately call the optInContacts function on the newly-created ones [18:36:31] let's see if we'd want to re-use the same contact insert function from wmf_civicrm [18:36:55] wmf_civicrm_message_create_contact [18:37:26] ok, we can set contact_source to opt_in [18:37:56] ah, and we'd want to send language along from donationinterface, too [18:39:06] ok, looks like OptInQueueConsumer can mostly just pass through the message from DonationInterface to wmf_civicrm_message_create_contact! [18:39:28] just maybe setting contact_source=opt_in and opt_in=1 [18:41:22] ok cool thanks for the starting point [18:42:57] sure thing! [18:43:25] after you look over the code, want to let me know what you think of that approach? [18:43:33] and of course if you have any questions [18:44:26] sure sounds goood [18:58:02] gonna go deliver some stuff to a neighborhood composting project, back in a bit [19:04:11] ls [19:22:08] (CR) Umherirrender: "Please give me a ping, if this is okay and should be merged." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/492339 (owner: Umherirrender) [19:23:43] (CR) Umherirrender: Use ::class for class name resolution (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/493965 (owner: Umherirrender) [19:25:56] (CR) D3r1ck01: [C: +1] Use ::class for class name resolution (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/493965 (owner: Umherirrender) [20:43:05] ejegg: you around? I'm starting to test the mediawiki upgrade. I turned on developer tools in the menu as directed on your link but I don't see the expected sidebar or some other space in the UI in safari. I don't do this much in safari. I'm used to a sidebar opening in chrome. I looked through the view menu and didn't seen any other options to enable developer tools [20:43:42] nm [20:43:44] found it [20:44:04] hi dstrine [20:44:31] ah cool, i wasn't sure what i could do to help! [20:45:19] * dstrine curses "Tim Apple" under his breath [20:45:21] :P [20:48:08] ejegg: I got through adyen ok with the warnings you already noted on the etherpad but the thank you page loaded and I got this: [Warning] This page is using the deprecated ResourceLoader module "jquery.throttle-debounce". (load.php, line 247) [20:48:08] Please use OO.ui.throttle/debounce instead. See https://phabricator.wikimedia.org/T213426 [20:58:52] Fundraising Sprint Ewoks Take Manhattan, Fundraising-Backlog, fundraising-tech-ops: Update fundriaising tech training matrix - https://phabricator.wikimedia.org/T217176 (XenoRyet) Updated my column. [21:04:25] dstrine: ah cool, good to note, but also not a blocker [21:04:28] thanks so much! [21:12:04] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 4 others: Upgrade PaymentsWiki to Mediawiki 1.31 (new LT... - https://phabricator.wikimedia.org/T184460 [21:15:52] OMG, as if one fr-sprint tag was not long enough ;) [21:17:22] heh, doesn't leave much room for the actual ticket name [21:17:54] they're funny though [21:24:28] Fundraising Sprint Ewoks Take Manhattan, Fundraising-Backlog: Documentation: Move onboarding checklist to mediawiki - https://phabricator.wikimedia.org/T217149 (mepps) [21:42:27] (CR) jerkins-bot: [V: -1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/495092 (owner: L10n-bot) [21:47:48] (CR) Raimond Spekking: [C: +2] "false positive" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/495092 (owner: L10n-bot) [21:51:43] (CR) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/495082 (owner: L10n-bot) [22:33:24] Fundraising Sprint Ewoks Take Manhattan, Fundraising-Backlog: Send message to opt-in queue on failed payments attempts with opt_in=1 - https://phabricator.wikimedia.org/T216293 (Ejegg) a:Ejegg [23:11:09] Fundraising Sprint Ewoks Take Manhattan, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: New Citibank import - https://phabricator.wikimedia.org/T217390 (LeanneS) Thanks! I just tested and overall is working well. I imported the September tab and 1 of them was rejected as a... [23:30:36] Fundraising Sprint Da Vinci Coder, Fundraising Sprint Ewoks Take Manhattan, Fundraising-Backlog, Fr-Ingenico-integration_2017-18: Ingenico: audit lagging on manual settled transactions? - https://phabricator.wikimedia.org/T217582 (Ejegg) Looks like 66010478.1 came in on the audit file that was de...