[01:51:37] (PS1) Ejegg: Stop mangling donor data on truncation [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/495821 (https://phabricator.wikimedia.org/T202417) [02:14:22] (CR) Ejegg: [C: +2] Stop mangling donor data on truncation [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/495821 (https://phabricator.wikimedia.org/T202417) (owner: Ejegg) [02:17:20] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/495822 [02:17:28] (CR) Ejegg: [C: +2] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/495822 (owner: Ejegg) [02:22:01] (CR) jerkins-bot: [V: -1] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/495822 (owner: Ejegg) [02:26:31] (Merged) jenkins-bot: Stop mangling donor data on truncation [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/495821 (https://phabricator.wikimedia.org/T202417) (owner: Ejegg) [02:26:33] (CR) jerkins-bot: [V: -1] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/495822 (owner: Ejegg) [02:30:08] (CR) Ejegg: [C: +2] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/495822 (owner: Ejegg) [02:32:49] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/495822 (owner: Ejegg) [02:40:07] !log updated payments-wiki from f1a89d7045 to 7a312e371a [02:40:08] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [08:03:21] (CR) D3r1ck01: Improve param docs (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/495513 (owner: Umherirrender) [08:12:10] (CR) D3r1ck01: [C: +2] Improve param docs [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/495513 (owner: Umherirrender) [08:13:07] (Merged) jenkins-bot: Improve param docs [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/495513 (owner: Umherirrender) [17:43:14] Fundraising Sprint Ewoks Take Manhattan, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: New Citibank import - https://phabricator.wikimedia.org/T217390 (LeanneS) @Eileenmcnaughton I attempted the same files on Live but it's giving me an error message: "This page isn’t worki... [18:20:43] (PS11) Gopavasanth: Remove 'UnitTestList' hook [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/428059 (https://phabricator.wikimedia.org/T142120) [18:23:14] (CR) jerkins-bot: [V: -1] Remove 'UnitTestList' hook [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/428059 (https://phabricator.wikimedia.org/T142120) (owner: Gopavasanth) [18:39:26] Fundraising Sprint Ewoks Take Manhattan, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: New Citibank import - https://phabricator.wikimedia.org/T217390 (Ejegg) Might have been the install script not run yet - I just ran it and it created a new contact. [18:45:33] (PS3) Ejegg: WIP use GeoIP2 for local geoip lookup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/469058 (https://phabricator.wikimedia.org/T215425) [18:45:52] (PS3) Ejegg: Center-align card radio buttons on mobile [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/453316 [18:46:54] (PS1) Ejegg: WIP Amazon: close order when showing fail page [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/495963 [18:47:03] (CR) jerkins-bot: [V: -1] WIP use GeoIP2 for local geoip lookup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/469058 (https://phabricator.wikimedia.org/T215425) (owner: Ejegg) [18:47:49] (PS2) Ejegg: Add settings and logos for two UY-specific cards [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/472503 (https://phabricator.wikimedia.org/T208963) [18:53:02] (PS5) Ejegg: WIP: getAllValidForms uses isValidForm [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/338458 (https://phabricator.wikimedia.org/T136254) [18:54:24] (PS1) Umherirrender: Adjust param comment style [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/495968 [18:55:40] (CR) jerkins-bot: [V: -1] WIP: getAllValidForms uses isValidForm [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/338458 (https://phabricator.wikimedia.org/T136254) (owner: Ejegg) [18:57:30] (PS2) Ejegg: WIP: bad code retry tests for Ingenico Connect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/423830 (https://phabricator.wikimedia.org/T176502) [18:58:58] (CR) jerkins-bot: [V: -1] WIP: bad code retry tests for Ingenico Connect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/423830 (https://phabricator.wikimedia.org/T176502) (owner: Ejegg) [19:05:34] (PS1) Ejegg: WIP log transactions rejected for fraud [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/495973 [19:05:47] (PS3) Ejegg: Support lots of country tlds for yahoo, hotmail, and outlook [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449900 [19:07:20] (PS3) Ejegg: Guard against duplicate WmfFramework alias [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/484757 [19:10:15] (Abandoned) Ejegg: WIP test processor error in SET_PAYMENT [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/378047 (owner: Ejegg) [19:10:40] (PS1) Umherirrender: Simplify ternary operator by using ?: [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/495979 [19:14:18] Fundraising-Backlog, Fr-CiviCRM-dedupe-FY2017/18: Civi dedupe: merge screen upgrades - https://phabricator.wikimedia.org/T217903 (NNichols) Additional notes: 1. Middle initial is becoming **really important** during the prospecting process 2. I am looking at 2 things in particular when it comes to the... [19:18:13] (PS3) Ejegg: Update extended reports, fix address history, pivots [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/494640 (https://phabricator.wikimedia.org/T118822) (owner: Eileen) [19:18:59] (CR) Ejegg: [C: +2] "Changes look good, fixes address history for me locally!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/494640 (https://phabricator.wikimedia.org/T118822) (owner: Eileen) [19:19:28] ejegg: thanks! [19:19:39] thank you! [19:19:58] can you also +2 the omnirecipient tweak one? [19:20:00] I wish git had a log switch that would ignore array() -> [] changes :) [19:20:11] ah, lemme take a look [19:20:13] https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/495755/ [19:20:30] yeah I’ve been changing the array format quite a lot now [19:23:28] (Merged) jenkins-bot: Update extended reports, fix address history, pivots [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/494640 (https://phabricator.wikimedia.org/T118822) (owner: Eileen) [19:24:05] (PS4) Ejegg: Reset omnirecipient clean to original 420 sec (7 hours) but without event_type=Sent [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/495755 (owner: Eileen) [19:24:52] (CR) Ejegg: [C: +2] Reset omnirecipient clean to original 420 sec (7 hours) but without event_type=Sent [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/495755 (owner: Eileen) [19:25:51] (Abandoned) Ejegg: WIP only cry DUPLICATE if there's no change [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/340810 (https://phabricator.wikimedia.org/T159455) (owner: Ejegg) [19:26:15] (Abandoned) Ejegg: WIP shared context is its own thing [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/372432 (owner: Ejegg) [19:29:14] (Merged) jenkins-bot: Reset omnirecipient clean to original 420 sec (7 hours) but without event_type=Sent [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/495755 (owner: Eileen) [19:30:41] (PS3) Ejegg: Delay TY letters for imported contributions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/423799 (https://phabricator.wikimedia.org/T191338) [19:38:48] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/495981 [19:40:11] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/495981 (owner: Eileen) [19:41:01] (Merged) jenkins-bot: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/495981 (owner: Eileen) [19:48:24] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Wikimedia-production-error, good first bug: Viewing Special:CentralNoticeBanners subpage can throw fatal BannerExistenceException - https://phabricator.wikimedia.org/T149240 (DStrine) a:Cstone→None [19:48:35] !log civicrm revision changed from 977b9bfcf1 to 5c45e4c24d, config revision is f930677e97 [19:48:36] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:55:13] (PS2) Umherirrender: Simplify ternary operator by using ?: [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/495979 [19:55:23] Fundraising Sprint Ewoks Take Manhattan, Fundraising-Backlog: Contacts with contributions being deleted - https://phabricator.wikimedia.org/T218061 (DStrine) [19:56:57] Fundraising Sprint Ewoks Take Manhattan, Fundraising-Backlog, fundraising-tech-ops: New Custom Field: "Endowment Stage" on the prospect tab - https://phabricator.wikimedia.org/T218002 (DStrine) [20:19:21] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 7 others: find another way to compile the donor list for... - https://phabricator.wikimedia.org/T118822 [20:55:46] Fundraising Sprint Ewoks Take Manhattan, Fundraising-Backlog, fundraising-tech-ops: New Custom Field: "Endowment Stage" on the prospect tab - https://phabricator.wikimedia.org/T218002 (Eileenmcnaughton) @cwdent @Jgreen we need to reload triggers for this table - are you OK if I generate the sql to lo... [21:06:30] Fundraising Sprint Ewoks Take Manhattan, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: New Citibank import - https://phabricator.wikimedia.org/T217390 (LeanneS) @Ejegg That worked! One thing I noticed is that the contacts all show under the contact "Citibank" rather than "... [21:08:01] Fundraising Sprint Ewoks Take Manhattan, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: New Citibank import - https://phabricator.wikimedia.org/T217390 (Eileenmcnaughton) @LeanneS I think I proposed Citibank import & then changed the name during coding? It's not a problem f... [21:15:35] (PS1) Eileen: Reformat array style in update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/496019 [21:15:51] ^^ formatting only patch [21:16:32] (CR) Ejegg: [C: +2] Reformat array style in update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/496019 (owner: Eileen) [21:18:32] Fundraising Sprint Ewoks Take Manhattan, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: New Citibank import - https://phabricator.wikimedia.org/T217390 (LeanneS) Okay great! Then I think we're all set. :) Thanks @Eileenmcnaughton. [21:19:33] Fundraising Sprint Ewoks Take Manhattan, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: New Citibank import - https://phabricator.wikimedia.org/T217390 (Eileenmcnaughton) @LeanneS shall we close it? [21:22:02] (Merged) jenkins-bot: Reformat array style in update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/496019 (owner: Eileen) [21:22:11] Fundraising Sprint Ewoks Take Manhattan, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: New Citibank import - https://phabricator.wikimedia.org/T217390 (LeanneS) Close away! [21:24:22] (PS2) Ejegg: Send opt-in message on donation failure [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/495154 (https://phabricator.wikimedia.org/T216293) [21:25:39] (CR) jerkins-bot: [V: -1] Send opt-in message on donation failure [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/495154 (https://phabricator.wikimedia.org/T216293) (owner: Ejegg) [21:30:41] Fundraising Sprint Ewoks Take Manhattan, Fundraising-Backlog, fundraising-tech-ops: Update fundraising tech training matrix - https://phabricator.wikimedia.org/T217176 (Ejegg) Updated my column, added a row for Process-Control, deleted a couple obsolete rows [21:31:35] (PS3) Ejegg: Send opt-in message on donation failure [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/495154 (https://phabricator.wikimedia.org/T216293) [21:32:06] cstone: ^^^ might be useful to you [21:32:17] It should generate some contact-data-only messages on the opt-in queue [21:32:38] when the donor has opted in to emails, and the payment fails [21:33:10] (CR) jerkins-bot: [V: -1] Send opt-in message on donation failure [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/495154 (https://phabricator.wikimedia.org/T216293) (owner: Ejegg) [21:35:21] oh hmm [21:37:19] oh hey, we're enforcing more phpdoc stuffs in tests now [21:37:20] nice! [21:37:38] (PS1) Eileen: Add endowment stage to prospect fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/496057 (https://phabricator.wikimedia.org/T218002) [21:38:29] (PS4) Ejegg: Send opt-in message on donation failure [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/495154 (https://phabricator.wikimedia.org/T216293) [21:41:17] Fundraising Sprint Ewoks Take Manhattan, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: New Citibank import - https://phabricator.wikimedia.org/T217390 (Eileenmcnaughton) Open→Resolved [21:41:18] (CR) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/496025 (owner: L10n-bot) [21:46:13] (PS6) Ejegg: WIP: getAllValidForms uses isValidForm [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/338458 (https://phabricator.wikimedia.org/T136254) [21:47:02] Fundraising Sprint Ewoks Take Manhattan, Fundraising-Backlog, fundraising-tech-ops, Patch-For-Review: New Custom Field: "Endowment Stage" on the prospect tab - https://phabricator.wikimedia.org/T218002 (Jgreen) >>! In T218002#5019172, @Eileenmcnaughton wrote: > @cwdent @Jgreen we need to reload t... [21:48:21] (PS3) Ejegg: WIP: bad code retry tests for Ingenico Connect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/423830 (https://phabricator.wikimedia.org/T176502) [21:52:31] (PS4) Ejegg: WIP use GeoIP2 for local geoip lookup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/469058 (https://phabricator.wikimedia.org/T215425) [21:54:52] Fundraising Sprint Ewoks Take Manhattan, Fundraising-Backlog, fundraising-tech-ops, Patch-For-Review: New Custom Field: "Endowment Stage" on the prospect tab - https://phabricator.wikimedia.org/T218002 (Eileenmcnaughton) @Jgreen OK - this isn't highly urgent - are there any other outage-worthy th... [21:57:08] fr-tech any requests for tech-talk? [21:57:49] I'd like to do the Amazon Pay one when we have all the payments-wiki hackers around [21:57:57] Only that I don't have to do the talking. My face is still all numb from the dentist. [21:58:04] heh [21:58:26] hmmm something technical [22:05:32] Fundraising Sprint Ewoks Take Manhattan, Fundraising-Backlog, fundraising-tech-ops, Patch-For-Review: New Custom Field: "Endowment Stage" on the prospect tab - https://phabricator.wikimedia.org/T218002 (Jgreen) >>! In T218002#5019418, @Eileenmcnaughton wrote: > @Jgreen OK - this isn't highly urge... [22:15:47] ejegg: helloooo? [22:49:55] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-Email: Burn down FundraisingEmailUnsubscribe extension, rewrite special pages in DonationInterface - https://phabricator.wikimedia.org/T218171 (Ejegg) [23:00:40] (PS1) Eileen: Update triggers.mysql [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/496069 (https://phabricator.wikimedia.org/T218002) [23:02:06] Fundraising Sprint Ewoks Take Manhattan, Fundraising-Backlog, fundraising-tech-ops, Patch-For-Review: New Custom Field: "Endowment Stage" on the prospect tab - https://phabricator.wikimedia.org/T218002 (Eileenmcnaughton) OK I have our new triggers sql update https://gerrit.wikimedia.org/r/#/c/wik...