[00:17:39] (CR) Eileen: "Jgleeson I took a look & this seems pretty good to me - it's very readable :-)" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/482672 (https://phabricator.wikimedia.org/T199268) (owner: Jgleeson) [00:31:40] (PS8) Eileen: Redo merges on contacts who clashed during merge with inappropriate data outcomes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/496095 (https://phabricator.wikimedia.org/T218061) [01:06:19] (PS1) Ejegg: Update SmashPig for audit fix [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/496358 [01:06:36] (CR) Ejegg: [C: +2] Update SmashPig for audit fix [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/496358 (owner: Ejegg) [01:11:05] (Merged) jenkins-bot: Update SmashPig for audit fix [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/496358 (owner: Ejegg) [01:12:10] (PS2) Ejegg: Add endowment stage to prospect fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/496057 (https://phabricator.wikimedia.org/T218002) (owner: Eileen) [01:12:17] (CR) Ejegg: [C: +2] Add endowment stage to prospect fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/496057 (https://phabricator.wikimedia.org/T218002) (owner: Eileen) [01:13:18] (PS2) Ejegg: Update triggers.mysql [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/496069 (https://phabricator.wikimedia.org/T218002) (owner: Eileen) [01:13:24] (CR) Ejegg: [C: +2] Update triggers.mysql [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/496069 (https://phabricator.wikimedia.org/T218002) (owner: Eileen) [01:14:32] eileen: I'mma do a CRM deploy shortly, then I'll take another look at the merge fix [01:14:55] I just wanted to get the SmashPig lib update out to re-parse the ingenico audits [01:15:03] and get some refunds we've been missing [01:16:41] (Merged) jenkins-bot: Add endowment stage to prospect fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/496057 (https://phabricator.wikimedia.org/T218002) (owner: Eileen) [01:18:28] (Merged) jenkins-bot: Update triggers.mysql [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/496069 (https://phabricator.wikimedia.org/T218002) (owner: Eileen) [01:23:06] (PS1) Ejegg: Update SmashPig library [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/496359 [01:23:18] (CR) Ejegg: [C: +2] Update SmashPig library [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/496359 (owner: Ejegg) [01:28:49] ejegg: sorry back now [01:29:09] I think the 3 I have in review are all gtg [01:31:25] (Merged) jenkins-bot: Update SmashPig library [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/496359 (owner: Ejegg) [01:34:08] cool, I'm deploying 2 of them just now, might have to review the 3rd tomorrow [01:34:32] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/496360 [01:34:38] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/496360 (owner: Ejegg) [01:35:22] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/496360 (owner: Ejegg) [01:39:31] !log updated fundraising CiviCRM from 5c45e4c24d to b4e3cf16cc [01:39:33] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:44:47] hmm hitting [01:44:48] import logging.config [01:44:49] ImportError: No module named config [01:49:24] pip install logging.config [01:49:24] works but no change [01:52:36] trying a python upgrade [02:07:38] oh dear this is going badly [02:18:50] (CR) Ejegg: "Unit test would be great! Might need to make a preliminary patch in SmashPig defining the new queue though (and maybe a cleaner method to " (3 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/496351 (https://phabricator.wikimedia.org/T215462) (owner: XenoRyet) [02:26:46] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-WMF-Audit: Audit parsers should output stats to grafana - https://phabricator.wikimedia.org/T218276 (Ejegg) [03:02:21] Fundraising Sprint Ewoks Take Manhattan, Fundraising-Backlog, FR-Email: Update Silverpop export to include opted in records with no donations - https://phabricator.wikimedia.org/T217712 (Eileenmcnaughton) So I've been struggling all afternoon to get the script tests/test_update.py to run & still thin... [13:31:27] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Main View of CiviCRM contact record doesn't show much useful info - https://phabricator.wikimedia.org/T117265 (CaitVirtue) Oh wow -- I remember those days! :-) [14:09:33] (CR) Mepps: [C: +1] "I had a thought based on my local testing. I'm going to update my credentials and test it again as written. I can see how my suggestion co" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/495154 (https://phabricator.wikimedia.org/T216293) (owner: Ejegg) [16:13:41] (PS1) Ejegg: Add another payment product mapping for Ingenico [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/496479 (https://phabricator.wikimedia.org/T217582) [16:14:05] fr-tech another trivial thing for review ^^^ [17:09:22] (CR) Thiemo Kreuz (WMDE): [C: +2] "Uh, I'm sorry. I was again leaving some comments addressed to the owners of this codebase. Not meant as edit requests." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/495968 (owner: Umherirrender) [17:14:48] (CR) XenoRyet: [C: +2] Add another payment product mapping for Ingenico [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/496479 (https://phabricator.wikimedia.org/T217582) (owner: Ejegg) [17:15:44] (Merged) jenkins-bot: Add another payment product mapping for Ingenico [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/496479 (https://phabricator.wikimedia.org/T217582) (owner: Ejegg) [17:16:14] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 4 others: Upgrade PaymentsWiki to Mediawiki 1.31 (new LT... - https://phabricator.wikimedia.org/T184460 [17:23:07] (PS1) Ejegg: Update SmashPig for audit fix [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/496492 [17:23:10] (CR) Ejegg: [C: +2] Update SmashPig for audit fix [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/496492 (owner: Ejegg) [17:24:08] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/496493 [17:25:29] (PS1) Ejegg: Update SmashPig [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/496494 [17:25:37] (CR) Ejegg: [C: +2] Update SmashPig [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/496494 (owner: Ejegg) [17:26:14] (CR) jerkins-bot: [V: -1] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/496493 (owner: Ejegg) [17:27:44] (Merged) jenkins-bot: Update SmashPig for audit fix [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/496492 (owner: Ejegg) [17:31:17] (Merged) jenkins-bot: Update SmashPig [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/496494 (owner: Ejegg) [17:34:54] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 4 others: Upgrade PaymentsWiki to Mediawiki 1.31 (new LT... - https://phabricator.wikimedia.org/T184460 [17:35:24] (PS2) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/496493 [17:35:36] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/496493 (owner: Ejegg) [17:36:17] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/496493 (owner: Ejegg) [17:40:41] (Merged) jenkins-bot: Adjust param comment style [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/495968 (owner: Umherirrender) [17:58:24] (PS2) Umherirrender: Use short array syntax [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/492339 [17:58:44] (CR) Umherirrender: "Redone" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/492339 (owner: Umherirrender) [18:23:01] (CR) Thiemo Kreuz (WMDE): [C: +2] Use short array syntax [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/492339 (owner: Umherirrender) [18:42:23] (Merged) jenkins-bot: Use short array syntax [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/492339 (owner: Umherirrender) [19:07:19] (PS1) Umherirrender: Fix whitespace issues [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/496532 [19:07:41] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 4 others: Upgrade PaymentsWiki to Mediawiki 1.31 (new LT... - https://phabricator.wikimedia.org/T184460 [19:24:29] (CR) Mepps: [C: +2] "Finally got to see that this works." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/495154 (https://phabricator.wikimedia.org/T216293) (owner: Ejegg) [19:38:13] (CR) jerkins-bot: [V: -1] Send opt-in message on donation failure [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/495154 (https://phabricator.wikimedia.org/T216293) (owner: Ejegg) [19:38:37] thanks! [19:38:52] let's see what that V-1 is about [19:39:26] oh hey, that short array syntax patch merged [19:39:43] heh, that'll be fun to rebase around [19:46:41] (PS5) Mepps: Send opt-in message on donation failure [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/495154 (https://phabricator.wikimedia.org/T216293) (owner: Ejegg) [19:47:07] (CR) Mepps: [C: +2] "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/495154 (https://phabricator.wikimedia.org/T216293) (owner: Ejegg) [19:47:43] it seemed to be a pretty rebase locally--i just never hit the button before [19:48:04] (CR) jerkins-bot: [V: -1] Send opt-in message on donation failure [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/495154 (https://phabricator.wikimedia.org/T216293) (owner: Ejegg) [19:48:19] (CR) jerkins-bot: [V: -1] Send opt-in message on donation failure [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/495154 (https://phabricator.wikimedia.org/T216293) (owner: Ejegg) [19:48:26] erg nevermind [19:51:05] mind if i push that change to the array syntax ejegg? [19:51:14] mepps: ah, I was just about to do it [19:51:26] okay that works [19:51:26] but if you've already done it, that's awesome! [19:52:44] (PS6) Mepps: Send opt-in message on donation failure [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/495154 (https://phabricator.wikimedia.org/T216293) (owner: Ejegg) [19:53:42] (PS5) Ejegg: WIP use GeoIP2 for local geoip lookup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/469058 (https://phabricator.wikimedia.org/T215425) [19:53:59] (PS4) Ejegg: Center-align card radio buttons on mobile [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/453316 [19:54:33] (PS2) Ejegg: WIP Amazon: close order when showing fail page [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/495963 [19:55:43] (PS3) Ejegg: Add settings and logos for two UY-specific cards [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/472503 (https://phabricator.wikimedia.org/T208963) [19:56:07] (PS10) Ejegg: WIP fraud points for email address at nonexistant tld [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290615 [19:56:18] (PS1) Ejegg: WIP replace MWExceptions with standard types [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/496569 [19:57:12] (CR) jerkins-bot: [V: -1] WIP Amazon: close order when showing fail page [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/495963 (owner: Ejegg) [19:58:53] (CR) Mepps: [C: +2] Send opt-in message on donation failure [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/495154 (https://phabricator.wikimedia.org/T216293) (owner: Ejegg) [19:59:16] (CR) jerkins-bot: [V: -1] WIP fraud points for email address at nonexistant tld [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290615 (owner: Ejegg) [19:59:21] ejegg i have an hour left in my day, anything that's high priority for review? [19:59:50] (Merged) jenkins-bot: Send opt-in message on donation failure [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/495154 (https://phabricator.wikimedia.org/T216293) (owner: Ejegg) [20:00:17] mepps that was the big one, thanks! [20:00:26] There's an eileen patch in review too [20:00:47] Looks like it would be nice to get deployed [20:00:59] since it'll fix some bad data on prod [20:01:45] (PS7) Ejegg: WIP: getAllValidForms uses isValidForm [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/338458 (https://phabricator.wikimedia.org/T136254) [20:03:36] (CR) jerkins-bot: [V: -1] WIP: getAllValidForms uses isValidForm [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/338458 (https://phabricator.wikimedia.org/T136254) (owner: Ejegg) [20:05:38] cool, i'm taking a look [20:16:22] erm did gerrit just go down? [20:16:37] fr-tech anyone else getting an error? [20:17:09] seems to be working for me [20:17:25] okay it's back for me, weird [20:17:53] !log updated CiviCRM from b4e3cf16cc to 41efa14fb0 [20:17:54] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:18:19] oh hey, do we need to run updb on mintaka? [20:18:50] (CR) Mepps: [C: +1] "This looks good to me, but I didn't test locally. My only question is whether the php.xml and bootstrap.php should be in this commit. It's" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/496095 (https://phabricator.wikimedia.org/T218061) (owner: Eileen) [20:19:41] (PS14) AndyRussG: Create CampaignChange hook [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/493459 (https://phabricator.wikimedia.org/T208511) [20:21:19] (CR) jerkins-bot: [V: -1] Create CampaignChange hook [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/493459 (https://phabricator.wikimedia.org/T208511) (owner: AndyRussG) [20:21:31] (CR) Mepps: [C: +1] "A few more thoughts." (3 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/496095 (https://phabricator.wikimedia.org/T218061) (owner: Eileen) [20:21:37] (CR) Eileen: "@mepps I think it's correct to add them as they are files generated when I used civix to add the test. The top level phpunit.xml adds it t" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/496095 (https://phabricator.wikimedia.org/T218061) (owner: Eileen) [20:24:49] sigh gerrit just went out for me again [20:27:31] (CR) Mepps: [C: +2] "I'll stop nitpicking :), but I am curious why there was scathing output and skipped contacts. For now, the code looks good and we need thi" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/496095 (https://phabricator.wikimedia.org/T218061) (owner: Eileen) [20:27:33] (CR) Eileen: Redo merges on contacts who clashed during merge with inappropriate data outcomes (3 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/496095 (https://phabricator.wikimedia.org/T218061) (owner: Eileen) [20:29:53] (CR) Eileen: "mepps - so I checked a small handful of the skipped contacts in the scathing output. Only 4 were in the last 2 years & at least some of th" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/496095 (https://phabricator.wikimedia.org/T218061) (owner: Eileen) [20:31:28] (CR) Mepps: [C: +2] "Hmm, Eileen, so do you think some of the older ones just didn't fit the pattern/had some other barrier to merging?" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/496095 (https://phabricator.wikimedia.org/T218061) (owner: Eileen) [20:32:01] (Merged) jenkins-bot: Redo merges on contacts who clashed during merge with inappropriate data outcomes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/496095 (https://phabricator.wikimedia.org/T218061) (owner: Eileen) [20:32:08] ejegg, did you work that out--i would think it's not a bad idea to run updb [20:32:39] mepps: hmm, maybe we shouldn't actually? [20:32:53] since it's not running its own db, but a replica of the main one [20:33:03] yeah, we shouldn't [20:33:31] (CR) Eileen: "Right I spot checked them & the couple I looked at were not deleted as a result of a merge." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/496095 (https://phabricator.wikimedia.org/T218061) (owner: Eileen) [20:35:51] ah got it ejegg [20:36:21] (CR) Mepps: [C: +2] "Got it, eileen!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/496095 (https://phabricator.wikimedia.org/T218061) (owner: Eileen) [20:39:05] (PS8) Ejegg: WIP: getAllValidForms uses isValidForm [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/338458 (https://phabricator.wikimedia.org/T136254) [20:39:55] (PS9) Ejegg: WIP: getAllValidForms uses isValidForm [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/338458 (https://phabricator.wikimedia.org/T136254) [20:50:38] (PS11) Ejegg: WIP fraud points for email address at nonexistant tld [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290615 [21:02:03] (PS3) Ejegg: WIP Amazon: close order when showing fail page [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/495963 [21:02:38] I just jumped on that zoom & I’m alone? [21:03:04] oh next week :-) [21:03:08] I looked at time only [21:14:05] fundraising-tech-ops: rsyslog will not unattended-upgrade - https://phabricator.wikimedia.org/T218269 (cwdent) $ apt-cache policy rsyslog rsyslog: Installed: 8.24.0-1 Candidate: 8.1901.0-1~bpo9+1 Version table: 8.1901.0-1~bpo9+1 1001 -10 http://ftp.debian.org/de... [21:25:28] oh darn, lots of "WD ingenico_audit: DATA_INCONSISTENT Inconsistent data. Skipping the following:" [21:25:32] in the audit parsing output [21:25:44] so what's still off? [21:29:47] ah, currency code missing too in some records? [21:39:09] fundraising-tech-ops: rsyslog will not unattended-upgrade - https://phabricator.wikimedia.org/T218269 (cwdent) Open→Resolved a:cwdent I looked back and rsyslog was set to install from backports like 6 months ago. What I don't understand is why it is not installed from backports right now. I upd... [22:05:10] oooh, crap, I wasn't even parsing those as refunds [22:06:18] (PS1) Ejegg: Fix audit parsing for XCR records [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/496678 (https://phabricator.wikimedia.org/T217582) [22:06:35] fr-tech ^^^ would be really nice to have [22:06:48] else I need to revert the last 'fix' to the ingenico audits [22:06:59] sorry! [22:07:09] This time I put a unit test in [22:08:02] (CR) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/496633 (owner: L10n-bot) [22:08:08] now to see if I've created any bogus donations, or if they all errored out [22:11:58] argh [22:12:02] mbeat, heads up [22:12:32] I've just created another headache for you :( [22:12:40] ty for heads-up ejegg [22:12:58] I think the latest attempt at including more refund records in audit parsing [22:13:07] actually parsed them as *new donations* [22:13:20] and sent out a bunch of ty letters for refunds :( :( :( [22:13:48] double-checking now [22:13:53] ha ha, that’s actually funny. we’ll see if donors inquire [22:14:08] oh man, I'm glad you see it that way :) [22:14:37] usually the “brief technical error, sorry, it’s fixed now” line works well, may even humanize us a bit [22:15:08] probably most the emails went to fraudsters ;) [22:15:10] ok, at worst it would be 30-ish records. [22:15:31] no biggie [22:15:35] just based on the total # of records added via audit files today [22:15:51] now spot-checking to see how many of those really should have been refunds [22:16:10] maybe, just maybe, the refund records that went down the wrong pipe were all missing an essential field [22:16:14] and there are actually zero [22:16:33] cool (and in fact, sending ty’s for refunds to fraudsters might be a fun feature request) [22:16:38] haha [22:37:41] fr-tech anyone around able to review? [22:37:48] cstone ? [22:40:53] https://gerrit.wikimedia.org/r/496678 [22:41:11] ejegg: sorry if I've missed some backscroll but I just saw a ton of nagios emails [22:41:21] oh hmm, looking [22:41:58] well, whatever it was, the WARNING ones seem to have been followed by a crop of OK ones [22:42:29] looks like a false alarm? [22:42:57] XenoRyet|afk: if you get back online today, mind taking a look at https://gerrit.wikimedia.org/r/496678 ? [22:43:13] Hoping to get it out before the next scheduled audit parsing! [22:43:31] hmm, guess I should turn that off in the meantime [22:50:50] MBeat: whew, ok, looks like none of the refunds actually made it into the donations table. False alarm! [22:51:06] thanks for confirming, ejegg [22:54:24] !log temporarily disabled Ingenico WX audit parsing [22:54:26] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:59:32] hey sorry was coming back from cafe I had reloated to ejegg [22:59:43] ah, no worries [22:59:56] want to take a look at that patch? https://gerrit.wikimedia.org/r/496678 [23:00:03] It's got a unit test this time... [23:04:18] cstone let me know if you need any more context to review that [23:04:36] hah yeah probably I just got it checked out correctly, i think [23:06:58] how would I run that unit test? [23:09:39] cstone: just vendor/bin/phpunit in the base smashpig dir [23:09:54] if you want to narrow it down you can add --group=Ingenico [23:10:40] or I guess you'd want php7.0 vendor/bin/phpunit [23:10:53] so it runs in the right version [23:11:56] haha ok now that I actually ran them when in vagrant, that worked and they all passed [23:12:55] is there anything else I should check ejegg? I have not done much with SmashPig [23:15:18] cstone: just that the code makes sense to you [23:15:45] so, you can compare the new refund record with one of the existing ones [23:16:10] the anonymized refund records are in the Ingenico/tests/Data folder [23:16:31] zipped up, like the actual audit files Ingenico gives us [23:16:39] the new one is refund_uncollected.xml.gz [23:16:57] and the old ones are refund.xml.gz and refund_ingenico_connect.xml.gz [23:17:33] what does $record['gross'] do? [23:20:10] 'gross' is the total donation amount [23:20:20] sometimes we have 'fee' and 'net_amount' too [23:20:32] to take the processing fees into account [23:22:35] so the refund is expecting the gross to be positive but the XCR ones come in negative? [23:22:49] yep, exactly [23:23:16] if you look at the -CR refund, you'll see it has multiple fields for the amount [23:24:05] like paymentamount, deductedamount? [23:24:36] hey ejegg I saw your comment in T218120 - will it impede anything if I push this donation through? [23:25:04] mbeat no, it shouldn't be a problem [23:25:10] ty, will do [23:25:18] hmm, actually, we might need to mark it in civi [23:25:21] manually? [23:25:34] MBeat: sorry, can you hold off on pushing it through for one more day? [23:25:45] oof, I just settled it - sorry! [23:25:49] ah, no worries [23:26:26] cstone: now I've got to head back from the cafe I'm at... [23:26:34] but I'll be back online in 25 min or so [23:58:52] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/496691 [23:59:08] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/496691 (owner: Eileen)