[00:02:37] (PS17) AndyRussG: Create CampaignChange hook [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/493459 (https://phabricator.wikimedia.org/T217565) [04:00:03] (PS1) AndyRussG: Consolidate code used to construct a campaign URL [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/497223 (https://phabricator.wikimedia.org/T217565) [04:01:52] (CR) jerkins-bot: [V: -1] Consolidate code used to construct a campaign URL [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/497223 (https://phabricator.wikimedia.org/T217565) (owner: AndyRussG) [04:02:57] (CR) jerkins-bot: [V: -1] Consolidate code used to construct a campaign URL [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/497223 (https://phabricator.wikimedia.org/T217565) (owner: AndyRussG) [04:11:28] (PS2) AndyRussG: Consolidate code used to construct a campaign URL [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/497223 (https://phabricator.wikimedia.org/T217565) [04:18:39] (PS3) AndyRussG: Consolidate construction of campaign URLs [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/497223 (https://phabricator.wikimedia.org/T217565) [09:51:54] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 5 others: Reduce recurring TY emails - https://phabricator.wikimedia.org/T213209 (jrobell) Thank... [13:59:33] mepps, I'm gonna be 5 minutes late to our 1:1 [14:02:19] k jgleeson, just let me know when you're around [14:02:57] back mepps :) [14:43:28] hi fr-tech! [14:43:38] howdy ejegg :) [14:49:21] ejegg: hi! [15:19:08] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Smashpig, FR-Fraud: Record MaxMind fraud alerts in Civi - https://phabricator.wikimedia.org/T218585 (Ejegg) [15:21:02] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-Fraud: Consider using MaxMind fraud breakdown in future pre-emptive fraud filters - https://phabricator.wikimedia.org/T218586 (Ejegg) [19:18:42] fr-tech, we might struggle to do backlog refinement with phabricator currently down for maintenance [19:19:09] ahh good point jgleeson|back [19:33:30] oh hey, I was wrong about which function we used for localizing currencies in the TY letter [19:33:52] it's not the php i18n library at all there - we made a function outselves [19:34:02] and it just has a currency symbol table [20:10:55] google just loggged me out so I could do 2fa [20:11:01] off to find my phone [20:15:29] cwd thoughts on Sam q? [20:50:30] cstone and other lego fans: https://www.mediawiki.org/wiki/Brickimedia [20:51:13] apparently is important enough to have special consideration in granting gerrit privs! [20:58:08] oh hey fr-tech, phab is back up [20:58:23] looks like gerrit too [20:58:48] ejegg: I checked on unsubscribes & they are ticking so I pushed out 2 more weeks [20:59:04] eileen: oh great, thank you! [20:59:21] re Samuel’s emial about whether we need them to turn off campaigns? [20:59:29] hmm, wikibugs is not on? [20:59:38] huh? [21:00:00] the announcement bot didn't say anything when I put a patch up just now [21:00:04] oh ok’ [21:00:32] oh, turning off campaigns for the Civi trigger update? [21:00:37] I wouldn't think so [21:00:46] yeah - he said in email there are 26 on [21:00:55] but we can just make a list I think [21:01:19] sorry, a list of what? [21:01:29] the 26 campaigns [21:01:39] cwd thought we should take down campaigns I think [21:02:08] oh, sorry [21:02:14] well, OK then [21:02:37] sure, it's just a big list of checkboxes [21:02:41] yeah [21:02:57] And there's a log entry to help remember which ones to re-enable [21:03:18] ah cool [21:03:40] ok eff meet [21:04:01] ejegg: are you joining that [21:04:36] yep yep [21:34:02] (CR) Eileen: Disambiguate $-sign-using currencies (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/497349 (https://phabricator.wikimedia.org/T207674) (owner: Ejegg) [21:41:49] (PS2) Ejegg: Disambiguate $-sign-using currencies [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/497349 (https://phabricator.wikimedia.org/T207674) [21:42:33] eileen: ^^^ updated to $NZD [21:42:40] ejegg: dstrine I think those recent performance improvements Mark was talking about came from us [21:42:48] ejegg: ok - I’ll look again [21:43:04] eileen: hehe, yeah, it sounded like some of the stuff you were working on a couple months back! [21:44:40] eileen: hey sorry, just got to the DMV [21:45:18] It would be super if someone from banner team could help with the check boxes [21:45:42] I have already forgot them before and caused headaches [21:45:53] And the list is much bigger now [21:46:13] ejegg: yep - getting those joins out [21:46:27] cwd hmm - [21:46:47] I don’t see spatton on here atm [21:47:34] ok - emailed to see [21:47:49] thanks! [21:49:30] ejegg: I’ll take another look at those currencies. I don’t have much left in the sprint so are there any you think I can help with other than that? [21:50:19] eileen: hmm, nothing obvious. Maybe ask cstone if she wants to pair on the opt-in queue update? [21:50:33] ok cstone ^^ [21:50:55] I’m also gonna check on the repair job & check if that needs a re-tweak yet [21:52:45] oh sure eileen if you want to [21:53:02] which one is that? [21:54:43] eileen: https://phabricator.wikimedia.org/T217710 [21:55:27] ejegg: looks like you already run the deleted merge contact fixes? [21:55:54] cstone: lol - not much in there is there :-) [21:56:05] yeah I realize that now [21:56:08] have you already started digging into it? [21:56:19] I have [21:56:39] cool - do you want to open a hang out? [21:56:45] sure [21:58:10] eileen: oops, yeah, I should have noted that on the ticket [21:58:27] gonna head out for a bit. back on later this evening! [21:59:05] cool [22:27:26] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 5 others: Reduce recurring TY emails - https://phabricator.wikimedia.org/T213209 (mepps) Oops, t... [22:29:24] Fundraising-Backlog, Fr-CiviCRM-dedupe-FY2017/18: Civi dedupe: merge screen upgrades - https://phabricator.wikimedia.org/T217903 (LeanneS) @MBeat33 I think these requests would be useful! I also usually use the oldest record to merge any pertinent new data into when merging two records. Re: 2a., would th... [22:31:46] Fundraising Sprint Da Vinci Coder, Fundraising Sprint Ewoks Take Manhattan, Fundraising-Backlog, Patch-For-Review: Re-run omnirecipient repair to catch the few missed ones - https://phabricator.wikimedia.org/T215865 (Eileenmcnaughton) Just checked status on the 420 run - it's up to civicrm_repai... [22:33:10] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi recurring donation cancel metric request - https://phabricator.wikimedia.org/T218616 (MBeat33) [22:43:22] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi recurring donation cancel metric request - https://phabricator.wikimedia.org/T218616 (MBeat33) [22:50:35] Fundraising Sprint Ewoks Take Manhattan, Fundraising-Backlog, Patch-For-Review: Contacts with contributions being deleted - https://phabricator.wikimedia.org/T218061 (Eileenmcnaughton) @LeanneS @NNichols We've done this restore - a search for deleted with contributions still unearths a few - maybe we... [22:51:37] AndyRussG: are you still there? [22:51:54] eileen: yes [22:52:11] ejegg|afk: has done this patch tweaking how currencies display https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/497349/2/sites/all/modules/wmf_communication/twigext_l10n/TwigLocalization.php [22:52:38] but the NZD one was ‘wrong’ as in ‘not what a person here would expect’ - ditto the AUD one now I look - I’m wondering about the Mexico line [22:53:16] (Mex$ is the new one - not MXD or MXN ) [22:54:44] eileen: that looks ok. Here they're called pesos but we use the same $ sign [22:54:53] MXN I think would be more normal [22:55:14] Yeah - I think the list ejegg|afk worked off might not be better than what we had [22:55:25] ie. it’s changing from MXN to mex [22:55:50] hmmm [22:55:56] was there a problem with MXN? [22:55:58] the NZ one was the wrong change & I suspect if I ask I’ll be told AUD & CAD are better than the replacement ones [22:56:18] so ejegg|afk said “Looked up the Wikipedia article on each one and noted what was written [22:56:19] there about alternative ways to write them” [22:56:50] I haven’t found the article yet [22:59:52] eileen: yeah I was looking about for good examples just now [23:00:07] I think $MXN is typical [23:03:15] AndyRussG: what about Canada? [23:07:03] eileen: the C$ looks OK. I think I saw that one recently [23:07:16] $CAD would also be understandable [23:25:21] eileen: https://etherpad.wikimedia.org/p/2019-03-18_trigger-refresh [23:25:30] pretty basic but... let me know if anything is missing [23:25:47] heading home now, talk to you in a bit...