[00:05:33] (CR) Eileen: [C: +1] "I'm a little mixed on this - Andy said MXN would be more normal for Mexico but either for Canada. But then it feels like it's not a tech " [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/497349 (https://phabricator.wikimedia.org/T207674) (owner: Ejegg) [00:08:17] (CR) Eileen: [C: +2] "Seems safe & sensible to me" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/496902 (https://phabricator.wikimedia.org/T218120) (owner: Ejegg) [00:13:31] (Merged) jenkins-bot: Error codes are ints [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/496902 (https://phabricator.wikimedia.org/T218120) (owner: Ejegg) [00:26:33] (PS12) Jgleeson: WIP: civi wmffraud fredge report [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/482672 (https://phabricator.wikimedia.org/T199268) [00:48:50] cwd eileen Banner campaigns are down--you can do your thing :) [00:49:21] thanks tskaff ! [00:50:28] tskaff: thank you so much! [00:50:33] taking the site down... [00:51:19] ccccccgdlcjgjjeuhenhjtulrleuffuigdkbrbrkinur [00:52:13] i hear that [00:54:34] so we are still turning off q consumers through a commit to process-control? [00:54:51] or just via run-job [00:56:13] eileen: we have a setting in puppet that should work [00:56:17] making sure of that... [00:59:44] eileen: looks good to me, i'm ready to run triggers.mysql, anything i'm forgetting? [00:59:54] I don’t think so [01:00:01] I added the location in the file [01:00:07] & also what to check afterwards [01:00:15] ok here goes [01:03:28] eileen: ok i see what's listed in the etherpad (show trigger syntax is weird) [01:03:45] ok let’s turn it all on again then [01:03:53] kk here goes [01:06:44] eileen: ok we are back [01:07:19] PROBLEM - check_mysql on frdb2001 is CRITICAL: Slave IO: No Slave SQL: No Seconds Behind Master: (null) [01:07:25] “An authorized SSL client certificate is required to access this server." [01:09:26] eileen: hmmm, is that new? that's what you should see if you don't have the browser cert [01:09:50] yeah I haven’t logged on today but it wasn’t present last time I did - which would be last week [01:09:54] ACKNOWLEDGEMENT - check_mysql on frdb2001 is CRITICAL: Slave IO: No Slave SQL: No Seconds Behind Master: (null) Casey Dentinger maintenance mode [01:10:15] oh staging is down too [01:10:21] but my cert worked there [01:10:34] well prob may be local [01:10:50] hmmm, my cert is working [01:11:15] staging is ok for me too [01:11:31] but frdb2001 is still down in case i broke something... [01:11:35] staging is down for mtce [01:12:00] but yeah - not sure why prod doesn’t ask for a cert - will close browser & re-open - [01:12:37] ok that’s better [01:12:48] yep - am in [01:13:38] hrmph...damn browser certs [01:13:46] yep triggers working [01:13:53] \o/ [01:13:55] all good to fire up again [01:14:00] i don'tknow why that browser cert is flaky [01:15:38] ok errything is back [01:17:06] Does that mean I'm good to put campaigns back up? [01:17:19] RECOVERY - check_mysql on frdb2001 is OK: Uptime: 900908 Threads: 1 Questions: 78488710 Slow queries: 455508 Opens: 1865 Flush tables: 1 Open tables: 659 Queries per second avg: 87.121 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 [01:17:47] tskaff: barring any concerns from eileen i think we are good [01:17:52] thanks again! [01:17:53] aok from me [01:18:05] much appreciate the responsiveness on short notice [01:18:08] Awesome! [01:18:20] No prob at all. Thanks both! [01:18:48] :) [01:20:06] Confirming they're all back up (i'll reply to the thread unless you want to) [01:20:27] all you. thanks! [01:20:28] Y'all are so punctual :) [01:20:33] Cool [01:22:50] great thanks [01:23:14] & we got the phab done in the sprint so it can be closed & not sprawl over :-) [01:23:21] tskaff: having someone familiar with the campaign schedule to dis|enable is a huge improvement on our process :) [01:23:56] Good to know! [01:25:06] and in WMF tradition now that you have done it once you'll be on the hook to do it forever [01:25:49] jkjk...sorta :) [01:26:44] Heh heh hence the lag to reply? Srsly happy to help anytime. Now I'm gonna go eat some turkey burgers! Mmm [01:27:46] enjoy [01:33:14] Fundraising Sprint Ewoks Take Manhattan, Fundraising-Backlog, fundraising-tech-ops, Patch-For-Review: New Custom Field: "Endowment Stage" on the prospect tab - https://phabricator.wikimedia.org/T218002 (Eileenmcnaughton) Open→Resolved [01:35:19] Fundraising Sprint Ewoks Take Manhattan, Fundraising-Backlog: Documentation: Move onboarding checklist to mediawiki - https://phabricator.wikimedia.org/T217149 (Eileenmcnaughton) looks good to me [01:38:40] thanks cwd [01:39:00] np! [05:26:59] (PS3) Mill: ebaaaaaaaaaaaa [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/497349 (owner: Ejegg) [05:27:01] (PS13) Mill: abaaaaaaaaaaaa [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/482672 (owner: Jgleeson) [05:31:48] (PS4) Mill: zeaaaaaaaaaaaa [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/497223 (owner: AndyRussG) [05:31:50] (PS18) Mill: 5eaaaaaaaaaaaa [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/493459 (owner: AndyRussG) [05:35:59] (PS2) Mill: jhaaaaaaaaaaaa [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/497026 (owner: Umherirrender) [05:42:38] (PS2) Mill: $oaaaaaaaaaaaa [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/495973 (owner: Ejegg) [05:42:50] (PS4) Mill: %5eoaaaaaaaaaaaa [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449900 (owner: Ejegg) [05:42:52] (PS4) Mill: #oaaaaaaaaaaaa [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/484757 (owner: Ejegg) [05:43:01] (PS12) Mill: poaaaaaaaaaaaa [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/428059 (owner: Gopavasanth) [12:25:21] Seddon: The EU banner you're creating, for which wikis will it be? [13:13:49] looks like gerrit is down again following vandalism this morning [13:14:00] ouch [13:14:00] oh actually it's just come back [13:20:54] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 3 others: Adjust codfw payments servers to log to frlog1... - https://phabricator.wikimedia.org/T218661 [13:43:16] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 3 others: upgrade payments2001 & 2002 to stretch - https://phabricator.wikimedia.org/T218667 (Jgr... [13:43:30] Jeff_Green: jgleeson: yeah the vandalous patch sets also seem to be gone, thankfully [13:44:18] woot [13:44:55] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 3 others: Reconfigure mariadb for codfw payments cluster - https://phabricator.wikimedia.org/T218669... [13:45:14] AndyRussG|ish: You about? [13:45:38] Seddon: ish [13:45:56] Just got up and I have to kinda rush, but I'll have my phone with IRC when I'm out [13:46:07] whassup? [13:47:22] AndyRussG|ish: With the cn-translate integration, are allowing ? [13:47:41] was that the only one we decided to allow? [13:47:54] Seddon: correct, though only with the class attribute [13:48:14] currently also they only can have one CSS class, but there is a patch waiting to be deployed to fix that to allow more [13:48:53] AndyRussG: Does it allow inline "onclick"? [13:49:02] https://phabricator.wikimedia.org/T216150 [13:49:06] Seddon: absolutely not [13:53:21] Seddon: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/CentralNotice/+/master/includes/BannerMessage.php#99 [14:03:24] AndyRussG: Understood! Will handle it all with js and classes [14:03:45] Yeah, that's what we're doing for links in the fundraising banners [14:04:57] cool! feel free to oing anytime if there are issues, if I can't answer right away, I'll at least see it eventually [16:12:08] AndyRussG|ish: to distinguish between pesos and dollars, we should use e.g. "$MXN 1.50" ? [16:12:43] or "MXN$ 1.50" [16:12:45] ? [16:14:02] or even "MX$ 1.50" ? [16:15:56] ejegg the first one feels right [16:16:08] ok, thanks [16:16:25] I was looking for good examples yesterday [16:16:37] didn't find any quickly [16:21:09] (PS4) Ejegg: Disambiguate $-sign-using currencies [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/497349 (https://phabricator.wikimedia.org/T207674) [16:21:10] ejegg actually looking again, the second one might be better [16:21:17] sorry [16:21:21] ok, no worries [16:21:37] (PS5) Ejegg: Disambiguate $-sign-using currencies [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/497349 (https://phabricator.wikimedia.org/T207674) [16:21:43] just a few keystrokes [16:21:58] Hehe in fact I think it varies [16:22:38] But how many pesos did each of those keystrokes cost us??!? [16:38:19] hehe, well, it'll maybe save Donor Services some time [16:39:01] fr-tech anyone want to take another look at that and see if we can et it over the line this sprint? [16:39:34] I should be able to take a look soon ejegg [16:40:38] actually it's a small one [16:42:13] ejegg, is it ok that BBD and BSd have the same symbol? [16:43:18] jgleeson: I think so [16:44:09] ok great. only other question is whether columbia needs a unique prefix/suffix? [16:44:24] COP [16:46:18] ejegg, ^ [16:46:32] oops, looking [16:46:46] COL$ looks like the recommended choice [16:46:55] ... with COL$ also being used to distinguish it from other peso-denominated currencies. [16:46:55] hehe, can't believe I missed Colombia! [16:46:58] ha! [16:48:22] and how do we feel about case consistency, I see a mix of of upper and capitalised [16:48:26] (although with ~3,000 COP to the dollar, the amount will usually make it clear which currency it was) [16:48:33] lol [16:48:38] - 1x of [16:51:26] hmm, I don't think I've seen a lot of "COL$" signs around, but it seems to be more common than "COP$" or "$COP" on the web [16:51:30] so I'll go with that [16:52:03] (PS6) Ejegg: Disambiguate $-sign-using currencies [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/497349 (https://phabricator.wikimedia.org/T207674) [16:52:06] ok jgleeson, ready for another round [16:52:43] ejegg, it looks like the case usage is deliberate [16:52:58] I can see some are actually just capitalised and others are all uppercase [16:53:06] (when checking online) [16:53:12] ah yeah [16:55:45] (CR) Jgleeson: [C: +2] "Looks good to me!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/497349 (https://phabricator.wikimedia.org/T207674) (owner: Ejegg) [16:57:09] ejegg, it looks like we might also need to do a '£' disambiguation job at some point down the line [16:58:24] jgleeson: maybe, yeah [16:58:40] guessing that's an order of magnitude smaller [16:58:45] thanks for the CR! [16:58:47] yup [16:58:49] np! [16:59:49] hey fr-tech I've somehow broken my civi unit tests and none of them will run and its giving me this error in cv() (line 42 of /vagrant/srv/org.wikimedia.civicrm/sites/default/civicrm/extensions/org.wikimedia.omnimail/tests/phpunit/bootstrap.php). [17:00:18] is there more to that error message cstone? [17:00:22] what's the error :Z [17:00:27] no thats it [17:00:35] ah, is cv in your path? [17:00:40] `cv` [17:01:04] i dont think so? [17:01:26] (Merged) jenkins-bot: Disambiguate $-sign-using currencies [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/497349 (https://phabricator.wikimedia.org/T207674) (owner: Ejegg) [17:02:25] cstone, I think you can just checkout the civi-buildkit project by doing `git clone https://github.com/civicrm/civicrm-buildkit` somewhere on your machine and then add vagrant/your-path/civicrm-buildkit/bin to your path [17:03:30] actually before doing that, you might wanna `echo $PATH` [17:03:42] just to see if it's there but not pointing to the /bin dir [17:04:31] i see /vagrant/srv/civicrm-buildkit/bin in the path [17:04:57] ah, and typing `cv` gives you nothing useful? [17:06:13] ahh okay it does give me the help on it so it is here [17:06:15] there* [17:08:38] ah yeah looks like we added that checkout and setup as part of the puppet setup [17:09:05] I feel like I've had that error before cstone [17:13:48] they were last week but I don't know 100% what I did in between [17:14:36] I think the quick and dirty way would be to comment out the offending lines in that file [17:15:26] can you run this `./vendor/bin/phpunit --group e2e --testdox` [17:15:33] from the civicrm project root [17:16:09] cstone so that bootstrap is pretty weird [17:16:21] it runs a commandline util that spits out some php code [17:16:46] then evaluatest that php code [17:17:02] *evaluates [17:17:52] jgleeson: that gives me the same error [17:18:27] so if you try just running the util from the command line, it generates some include lines [17:18:48] > cv php:boot --level=classloader [17:18:56] /*BEGINPHP*/ [17:18:56] require_once '/home/elliott/src/php/fundraising/crm/drupal/sites/all/modules/civicrm' . "/CRM/Core/ClassLoader.php";\CRM_Core_ClassLoader::singleton()->register(); [17:18:59] /*ENDPHP*/ [17:19:45] so... If you want, you can replace the eval(cv(...)) line with the equivalent require_once and singleton()->register() line [17:19:56] I've had to do that locally a couple times [17:20:03] but probably not the best solution [17:20:14] ejegg, I also ran into this and fixed it somehow but can't remember :Z [17:23:00] gonna make some lunch, back in a bit! [17:24:43] ahh I think I might know what it was cstone [17:26:08] if you navigate to civi-root/drupal and type `cv php:boot --level=classloader` as ejegg|food mentioned before [17:26:50] do you get something resembling what ejegg|food posted? [17:29:18] yeah I get [17:29:18] /*BEGINPHP*/ [17:29:18] require_once '/vagrant/srv/org.wikimedia.civicrm/civicrm' . "/CRM/Core/ClassLoader.php";\CRM_Core_ClassLoader::singleton()->register(); [17:29:19] /*ENDPHP*/ [17:39:22] cool, so if you comment out line 8 of sites/default/civicrm/extensions/org.wikimedia.omnimail/tests/phpunit/bootstrap.php and then below paste in that block [17:42:15] woo yay! tests running! [17:42:24] thanks :) [17:44:43] ejegg|food gets the credit for that one :) although there was definitely another way to fix it that didn't involved touching the file but I can't remember how : [17:44:45] :S [17:46:21] cstone, the civi cv tool is pretty cool. It lets you access lots of stuff including useful config values if you ever need to know them. `cv vars:show` has helped me out a few times [17:50:16] oh cool [18:42:39] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/497585 [18:53:26] (PS14) Jgleeson: Wmffraud fredge report [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/482672 (https://phabricator.wikimedia.org/T199268) [19:03:41] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/497585 (owner: Ejegg) [19:04:40] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/497585 (owner: Ejegg) [19:09:43] !log updated CiviCRM from a2316be94f to 3bfc7a762e [19:09:43] ejegg: Failed to log message to wiki. Somebody should check the error logs. [19:11:24] Fundraising-Backlog: Adding notes to an email activity in civi - https://phabricator.wikimedia.org/T218725 (NNichols) [19:35:38] Fundraising Sprint Ewoks Take Manhattan, Fundraising-Backlog, Patch-For-Review: Thank You email: revise how we specify local currency - https://phabricator.wikimedia.org/T207674 (Ejegg) OK @MBeat33 , this is deployed. This part turned out to be using a different internationalization library than we t... [19:36:07] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 2 others: Reconfigure mariadb for codfw payments cluster - https://phabricator.wikimedia.org/T218669... [19:36:28] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 2 others: upgrade payments2001 & 2002 to stretch - https://phabricator.wikimedia.org/T218667 (Eje... [19:36:38] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 2 others: Adjust codfw payments servers to log to frlog1... - https://phabricator.wikimedia.org/T218661 [19:40:43] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Window dressing is mostly olive oil, Fundraising Sprint XML ate my homework, Fundraising-Backlog: Contribution Trackin... - https://phabricator.wikimedia.org/T211057 [19:40:47] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 6 others: Create sequence generation in SmashPig - https://phabricator.wikimedia.org/T214436 (Eje... [19:42:37] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Make 'emailExplain' variant default behavior - https://phabricator.wikimedia.org/T218730 (Ejegg) [19:42:49] Fundraising Sprint Da Vinci Coder, Fundraising Sprint Ewoks Take Manhattan, Fundraising-Backlog, MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), Patch-For-Review: Edits to text on payments page - https://phabricator.wikimedia.org/T215939 (Ejegg) Open→Resolved [19:43:16] Fundraising Sprint Da Vinci Coder, Fundraising Sprint Ewoks Take Manhattan, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 2 others: Hide opt_in radio buttons when the choice has been provided on the query string - https://phabricator.wikimedia.org/T217254 (Ejegg) Open→Re... [19:43:19] Fundraising Sprint Da Vinci Coder, Fundraising Sprint Ewoks Take Manhattan, Fundraising-Backlog, MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), Patch-For-Review: Edits to text on payments page - https://phabricator.wikimedia.org/T215939 (Ejegg) [19:43:26] Fundraising Sprint Ewoks Take Manhattan, Fundraising-Backlog, FR-Smashpig, Fr-Ingenico-integration_2017-18, and 2 others: Error: POSTing empty data to hostedcheckouts endpoint - https://phabricator.wikimedia.org/T202417 (Ejegg) Open→Resolved [19:43:48] Fundraising Sprint Ewoks Take Manhattan, Fundraising-Backlog, Patch-For-Review: Thank You email: revise how we specify local currency - https://phabricator.wikimedia.org/T207674 (Ejegg) Open→Resolved p:Triage→Normal a:Ejegg [19:50:42] Fundraising-Backlog, fundraising-tech-ops, Epic: epic: frtech onwiki documentation overhaul - https://phabricator.wikimedia.org/T209872 (Ejegg) [19:50:44] Fundraising Sprint Ewoks Take Manhattan, Fundraising-Backlog, fundraising-tech-ops: Update fundraising tech training matrix - https://phabricator.wikimedia.org/T217176 (Ejegg) Open→Resolved p:Triage→Normal [19:53:45] Fundraising Sprint Da Vinci Coder, Fundraising Sprint Ewoks Take Manhattan, Fundraising-Backlog: fill out PCI forms for this year - https://phabricator.wikimedia.org/T217184 (XenoRyet) Open→Resolved [20:03:24] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review, Spike: Investigate country code = XX making it to Ingenico - https://phabricator.wikimedia.org/T151411 (Ejegg) Open→Resolved a:Ejegg I think this was fixed with https://gerrit.wikimedia.org/r/478364 [20:06:09] Fundraising Sprint F 2019, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Fulltext search for name and org name in Civi - https://phabricator.wikimedia.org/T115536 (XenoRyet) [20:06:13] Fundraising Sprint F 2019, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Activities tab- multi select option for exclude filter - https://phabricator.wikimedia.org/T203057 (XenoRyet) [20:06:15] Fundraising Sprint F 2019, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: CRM contribution tracking writing should have a switch to use the new infrastructure - https://phabricator.wikimedia.org/T215463 (XenoRyet) [20:06:18] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 6 others: Reduce recurring TY emails - https://phabricator.wikimedia.org/T213209 (XenoRyet) [20:06:20] Fundraising Sprint F 2019, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Create queue consumer for contribution tracking - https://phabricator.wikimedia.org/T215453 (XenoRyet) [20:06:22] Fundraising Sprint Da Vinci Coder, Fundraising Sprint Ewoks Take Manhattan, Fundraising Sprint F 2019, Fundraising-Backlog, and 2 others: DonationInterface should have an option to use new contribution_tracking infrastructure - https://phabricator.wikimedia.org/T215462 (XenoRyet) [20:06:25] Fundraising Sprint F 2019, Fundraising-Backlog: Documentation: Simplify homepage - https://phabricator.wikimedia.org/T217178 (XenoRyet) [20:06:29] Fundraising Sprint Ewoks Take Manhattan, Fundraising Sprint F 2019, Fundraising-Backlog: Documentation: Move onboarding checklist to mediawiki - https://phabricator.wikimedia.org/T217149 (XenoRyet) [20:06:31] Fundraising Sprint F 2019, Fundraising-Backlog: Create variants for fancy new opt in pages on payments wiki - https://phabricator.wikimedia.org/T218240 (XenoRyet) [20:06:35] Fundraising Sprint F 2019, Fundraising-Backlog, fundraising-tech-ops, Patch-For-Review: switch fundraising cases where we use GeoIP to GeoIP2 - https://phabricator.wikimedia.org/T215425 (XenoRyet) [20:06:37] Fundraising Sprint Ewoks Take Manhattan, Fundraising Sprint F 2019, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Update opt-in queue consumer to be able to create new donor records - https://phabricator.wikimedia.org/T217710 (XenoRyet) [20:06:41] Fundraising Sprint F 2019, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Create job to set the field civicrm_email.on_hold to 1 for hard bounce & reply mail block - https://phabricator.wikimedia.org/T217603 (XenoRyet) [20:06:43] Fundraising Sprint Ewoks Take Manhattan, Fundraising Sprint F 2019, Fundraising-Backlog, Patch-For-Review: Contacts with contributions being deleted - https://phabricator.wikimedia.org/T218061 (XenoRyet) [20:06:45] Fundraising Sprint Da Vinci Coder, Fundraising Sprint Ewoks Take Manhattan, Fundraising Sprint F 2019, Fundraising-Backlog, and 3 others: New message inclusion syntax strips with more than one class - https://phabricator.wikimedia.org/T216150 (XenoRyet) [20:06:50] Fundraising Sprint Da Vinci Coder, Fundraising Sprint Ewoks Take Manhattan, Fundraising Sprint F 2019, Fundraising-Backlog, Patch-For-Review: Re-run omnirecipient repair to catch the few missed ones - https://phabricator.wikimedia.org/T215865 (XenoRyet) [20:06:52] Fundraising Sprint Ewoks Take Manhattan, Fundraising Sprint F 2019, Fundraising-Backlog, MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review: Send message to opt-in queue on failed payments attempts with opt_in=1 - https://phabricator.wikimedia.org/T216293 (XenoRyet) [20:06:54] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 5 others: Upgrade PaymentsWiki to Mediawiki 1.31 (new LT... - https://phabricator.wikimedia.org/T184460 [20:06:56] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 8 others: find another way to compile the donor list for... - https://phabricator.wikimedia.org/T118822 [20:07:13] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Do some data integrity digging - https://phabricator.wikimedia.org/T212271 (Eileenmcnaughton) [20:07:15] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: Metaissue for data integrity in Civi - https://phabricator.wikimedia.org/T218251 (Eileenmcnaughton) [20:08:02] Fundraising Sprint F 2019, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Fix data where contacts have multiple emails or addresses of the same location type (or have no location type) - https://phabricator.wikimedia.org/T152474 (Eileenmcnaughton) [20:30:48] fr-tech, do we have a tech-talk today? I don't see it on my cal [20:31:00] It's later than you'll probably want to be on. [20:31:17] In about an hour and a half [20:31:19] ah cool [20:31:24] good point [20:31:37] The one tomorrow will be more in your time zone. [20:31:51] yup I've accepted that one [20:32:58] eileen, could I grab you for 5 minutes at some point to chat through my thoughts around testing the civi report? [20:33:13] jgleeson: sure unit testing ? [20:33:35] possibly or if they're are more front-endy ways of testing in civi [20:33:46] -are [20:34:03] s/they're/there are/ [20:34:22] I was looking at the extendingreports tests [20:34:24] I’m gonna be away for the keyboard for 20 mins but generally I just use the getrows api call [20:34:35] extended reports* [20:34:38] yeah [20:35:04] ok I'll type my thoughts in the chat and then just take a look when you're back if that's ok [20:35:08] cool [20:35:13] brb [20:56:32] (PS1) Vedmaka Wakalaka: Banner live preview on edit screen [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/497611 (https://phabricator.wikimedia.org/T208125) [20:58:27] fr-tech ooooh ^ incoming live CN preview [20:59:31] (CR) jerkins-bot: [V: -1] Banner live preview on edit screen [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/497611 (https://phabricator.wikimedia.org/T208125) (owner: Vedmaka Wakalaka) [21:01:25] (CR) jerkins-bot: [V: -1] Banner live preview on edit screen [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/497611 (https://phabricator.wikimedia.org/T208125) (owner: Vedmaka Wakalaka) [21:08:02] fr-tech, I just remembered Conair was another good Nicholas Cage movie. [21:08:11] that is a classic [21:08:39] indeed [21:09:11] oh man, i've somehow come this far in life without seeing it. On the list it goes! [21:09:19] whaaaaa [21:09:30] jgleeson: OK here now [21:09:58] I kinda feel like Steve Buscemi played the role he was always meant to play in con air [21:10:09] great eileen ! [21:10:36] so my thoughts on this are [21:10:54] yeah SB was good [21:12:14] When I came across the e2e testing I was kinda expecting to be digging into something like selenium but I think I got that wrong. I looked at the extended reports test and it looks like we're checking the output of API calls and I had previously imagined that we'd be checking the actual DOM output [21:12:35] (PS2) Vedmaka Wakalaka: Banner live preview on edit screen [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/497611 (https://phabricator.wikimedia.org/T208125) [21:13:08] jgleeson: yeah Civi used to do webtests [21:13:16] it was really hard to maintain... [21:14:09] so we focus on unit tests now [21:14:13] got it. ok so the API method ReportInstance, is that what I need to mimic a report? [21:14:27] I think it’s reportTemplate.getrows? [21:15:38] (CR) jerkins-bot: [V: -1] Banner live preview on edit screen [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/497611 (https://phabricator.wikimedia.org/T208125) (owner: Vedmaka Wakalaka) [21:19:24] ah ok now I see what it does [21:20:48] (PS3) Vedmaka Wakalaka: Banner live preview on edit screen [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/497611 (https://phabricator.wikimedia.org/T208125) [21:21:02] https://github.com/wikimedia/wikimedia-fundraising-crm-civicrm/blob/master/api/v3/ReportTemplate.php [21:30:21] (PS1) Krinkle: ext.centralNotice.geoIP: Remove redundant variable, and use then() [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/497644 [21:47:55] So I’m interested on people’s thoughts on this https://phabricator.wikimedia.org/T115536 - I had the idea in fortnightly that a simple pre-save hook to make sort_name equal to ‘Justice Foundation, The’ would be all that’s needed - any thoughts? [22:03:29] tech talk... [22:33:20] PROBLEM - check_mysql on payments1004 is CRITICAL: Cant connect to local MySQL server through socket /var/run/mysqld/mysqld.sock (2 No such file or directory) [22:33:22] PROBLEM - check_payments_wiki on payments1004 is CRITICAL: HTTP CRITICAL: HTTP/1.1 500 Internal Server Error - string OK not found on https://payments1004.frack.eqiad.wmnet:443https://payments.wikimedia.org/index.php/Special:SystemStatus - 1245 bytes in 0.033 second response time [22:33:22] PROBLEM - check_mysql on payments2003 is CRITICAL: Slave IO: Connecting Slave SQL: Yes Seconds Behind Master: (null) [22:38:00] uhm [22:38:18] RECOVERY - check_mysql on payments2003 is OK: Uptime: 1924151 Threads: 1 Questions: 2357559 Slow queries: 0 Opens: 242 Flush tables: 1 Open tables: 95 Queries per second avg: 1.225 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 [22:38:20] RECOVERY - check_mysql on payments1004 is OK: Uptime: 261 Threads: 2 Questions: 323 Slow queries: 0 Opens: 18 Flush tables: 1 Open tables: 12 Queries per second avg: 1.237 [22:38:22] RECOVERY - check_payments_wiki on payments1004 is OK: HTTP OK: HTTP/1.1 200 OK - 736 bytes in 0.030 second response time [23:29:14] wierd, db lag on the payments cluster? [23:32:32] (CR) XenoRyet: [C: +2] Move sequence generators under their own top level key [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/496819 (owner: Ejegg) [23:32:35] (CR) XenoRyet: [C: +2] Add factory method for sequence generators [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/496820 (https://phabricator.wikimedia.org/T215462) (owner: Ejegg) [23:32:38] (CR) XenoRyet: [C: +2] Add settings for contribution-tracking queue [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/496821 (https://phabricator.wikimedia.org/T215462) (owner: Ejegg) [23:33:08] (Merged) jenkins-bot: Move sequence generators under their own top level key [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/496819 (owner: Ejegg) [23:33:10] (Merged) jenkins-bot: Add factory method for sequence generators [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/496820 (https://phabricator.wikimedia.org/T215462) (owner: Ejegg) [23:33:12] (Merged) jenkins-bot: Add settings for contribution-tracking queue [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/496821 (https://phabricator.wikimedia.org/T215462) (owner: Ejegg) [23:41:23] (PS2) XenoRyet: WIP: c_t ids from the sequence generator [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/496351 (https://phabricator.wikimedia.org/T215462) [23:44:03] (CR) jerkins-bot: [V: -1] WIP: c_t ids from the sequence generator [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/496351 (https://phabricator.wikimedia.org/T215462) (owner: XenoRyet)