[00:09:13] (CR) Ejegg: [C: +2] lWIP: c_t ids from the sequence generator (4 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/496351 (https://phabricator.wikimedia.org/T215462) (owner: XenoRyet) [00:09:33] (CR) Ejegg: [C: -1] "Oops, hit the wrong button!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/496351 (https://phabricator.wikimedia.org/T215462) (owner: XenoRyet) [00:27:37] (CR) Ejegg: [C: -1] "When the switch is turned on, we need to completely decouple from the database. So the db connection logic needs to be conditional, and th" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/496351 (https://phabricator.wikimedia.org/T215462) (owner: XenoRyet) [00:44:51] Fundraising Sprint Fistful of $variables, Fundraising-Backlog: Create variants for fancy new opt in pages on payments wiki - https://phabricator.wikimedia.org/T218240 (Ejegg) p:Triage→High a:Ejegg [02:28:48] Fundraising Sprint Ewoks Take Manhattan, Fundraising-Backlog, fundraising-tech-ops: Update fundraising tech training matrix - https://phabricator.wikimedia.org/T217176 (AndyRussG) Columned my update. [05:50:12] (PS1) Eileen: Update Datacheck extension to fix duplicate location types. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/498001 (https://phabricator.wikimedia.org/T152474) [05:58:17] (PS2) Eileen: Update Datacheck extension to fix duplicate location types. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/498001 (https://phabricator.wikimedia.org/T152474) [05:58:49] (PS3) Eileen: Update Datacheck extension to fix duplicate location types. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/498001 (https://phabricator.wikimedia.org/T152474) [07:56:58] fundraising-tech-ops: Fundraising event page redirect for Austin event/10276 - https://phabricator.wikimedia.org/T218823 (Aklapper) [08:45:07] (CR) D3r1ck01: [C: +1] "This looks really nice, but I'll prefer someone else to land this! I can work on back-porting this change @Krinkle when the time comes." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/485877 (owner: Ejegg) [10:02:38] Fundraising-Analysis, Beta-Cluster-Infrastructure, MediaWiki-extensions-Translate: ExtensionDependencyError FundraisingTranslateWorkflow requires Translate to be installed. - https://phabricator.wikimedia.org/T218860 (hashar) [10:04:24] Fundraising-Analysis, Beta-Cluster-Infrastructure, MediaWiki-extensions-Translate: ExtensionDependencyError FundraisingTranslateWorkflow requires Translate to be installed. - https://phabricator.wikimedia.org/T218860 (hashar) Might be related to https://gerrit.wikimedia.org/r/#/c/operations/mediawi... [10:05:21] Fundraising-Backlog, fundraising-tech-ops, Privacy: RFC: Establish a privacy-forward backup strategy in fundraising - https://phabricator.wikimedia.org/T218810 (Peachey88) [10:07:11] Fundraising-Analysis, Beta-Cluster-Infrastructure, MediaWiki-extensions-Translate: ExtensionDependencyError FundraisingTranslateWorkflow requires Translate to be installed. - https://phabricator.wikimedia.org/T218860 (hashar) The first broken build was on March 20th 2019 at 20:59:13 which is before... [10:11:58] Fundraising-Analysis, Beta-Cluster-Infrastructure, MediaWiki-extensions-Translate: ExtensionDependencyError FundraisingTranslateWorkflow requires Translate to be installed. - https://phabricator.wikimedia.org/T218860 (hashar) So it is broken and I have no idea what is going on sorry :( [10:26:12] Fundraising-Analysis, Beta-Cluster-Infrastructure, MediaWiki-extensions-Translate: ExtensionDependencyError FundraisingTranslateWorkflow requires Translate to be installed. - https://phabricator.wikimedia.org/T218860 (hashar) Wondering if that would cause the train to break when we next regenerate... [10:29:11] Fundraising-Analysis, Beta-Cluster-Infrastructure, MediaWiki-extensions-Translate: ExtensionDependencyError FundraisingTranslateWorkflow requires Translate to be installed. - https://phabricator.wikimedia.org/T218860 (hashar) [10:31:43] (CR) Hashar: "I have filled T218860" [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/486345 (https://phabricator.wikimedia.org/T213943) (owner: Awight) [10:32:31] Fundraising-Analysis, Beta-Cluster-Infrastructure, MediaWiki-extensions-Translate: ExtensionDependencyError FundraisingTranslateWorkflow requires Translate to be installed. - https://phabricator.wikimedia.org/T218860 (hashar) That also points to https://gerrit.wikimedia.org/r/#/c/mediawiki/extensio... [10:50:28] Fundraising-Analysis, Beta-Cluster-Infrastructure, MediaWiki-extensions-Translate: ExtensionDependencyError FundraisingTranslateWorkflow requires Translate to be installed. - https://phabricator.wikimedia.org/T218860 (hashar) $wmgFundraisingTranslateWorkflow is only enabled on meta. What I guess i... [10:56:18] Fundraising-Analysis, Beta-Cluster-Infrastructure, MediaWiki-extensions-Translate: ExtensionDependencyError FundraisingTranslateWorkflow requires Translate to be installed. - https://phabricator.wikimedia.org/T218860 (hashar) A very basic attempt at reproducing the issue on my local setup: ` $ php... [12:53:51] (PS11) Vedmaka Wakalaka: Banner live preview [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/497611 (https://phabricator.wikimedia.org/T208125) [13:27:42] good time of day fr-tech! [13:46:27] Fundraising Sprint Fistful of $variables, Fundraising-Backlog: Documentation: Simplify homepage - https://phabricator.wikimedia.org/T217178 (mepps) a:mepps [14:00:21] Fundraising Sprint Fistful of $variables, Fundraising-Backlog: Documentation: Simplify homepage - https://phabricator.wikimedia.org/T217178 (mepps) I've started on this. Currently trying to decide which headings belong on the main page versus sub pages. I want to break up the big block called "Documents"... [14:48:59] mepps hi! shouldn't that be "good time of day or evening", eh? [14:49:02] jk [14:50:28] I'm in the waiting room of the pediatric hospital here with Ceci. It's probably nothing serious, just her eyelid started swelling really suddenly, since yesterday morning. Just thought we should check it out in case it's celulitis [14:51:28] Likely they'll just give her some medicine, then it'll be off to school, so I expect to be around for meetings and all [14:53:21] hope it's not a long visit AndyRussG! [14:53:32] jgleeson_: thanks! [14:54:31] at least I can take out the 'puter and get tethered internet, while Ceci is busy reading a book on the cell phone... [14:56:25] how about "good timezone appropriate greeting" AndyRussG? [14:56:46] :) [14:56:52] that's tooo long mepps :) [14:57:04] gtagzzz! [14:57:11] that's what i'm going with jgleeson_ [14:57:37] what's it for mepps? sorry I came into the discussion late [14:58:17] you didn't really jgleeson, i was just trying to find a timezone inclusive greeting to say hi [14:58:32] ahh [14:58:38] gtagzzz to you too :) [14:59:52] what are you working on today jgleeson? [15:00:39] i'm working on our documentation homepage [15:01:12] currently trying to wrap up a test for the civi report we deployed yesterday on the DS call and then I was gonna look at the sprint backlog. Looks like ejegg|away already wrapped up the geoIp2 task so I might do some review also [15:01:54] good luck with the docs! [15:02:10] I find structuring documentation difficult [15:04:42] mepps, it is possible to change the time of our 1:1 next Monday? We've been given an xray appointment for Matilda and it's 30m after our usual 1:1 time [15:04:50] of course jgleeson [15:09:18] awesome [15:23:52] fr-tech you might enjoy this video: https://www.youtube.com/watch?v=JWjMiwAbGgA [15:24:00] (not work related) [15:25:50] (PS2) Cstone: Add create new contact on opt-in [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/497950 [15:26:26] (CR) Cstone: "> This looks like it works, but couldn't we create the contacts with" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/497950 (owner: Cstone) [15:26:29] woah [15:26:38] Fundraising-Backlog, fundraising-tech-ops, Privacy: RFC: Establish a privacy-forward backup strategy in fundraising - https://phabricator.wikimedia.org/T218810 (Bawolff) > For instance, based on my experience working here, needing a specific web request after 2 years seems very unlikely, but indefini... [15:26:56] mepps, I was like "run London run, New York is coming!!" but then it finished nowhere at the end ! [15:28:05] huh, gotta be metro areas [15:28:06] New York mostly disappeared too! [15:28:16] nyc proper has only 8M-ish [15:28:18] I'm curious how they defined cities on that cause Tokyo is huge [15:29:53] I think NYC is more people dense [16:10:12] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 8 others: find another way to compile the donor list for... - https://phabricator.wikimedia.org/T118822 [16:18:52] Fundraising-Backlog, Analytics, Product-Analytics: Fix EventLogging schemas that use array for items type - https://phabricator.wikimedia.org/T218617 (AndyRussG) [16:19:20] Fundraising-Backlog, Analytics, Product-Analytics: Fix EventLogging schemas that use array for items type - https://phabricator.wikimedia.org/T218617 (AndyRussG) >>! In T218617#5044948, @Nuria wrote: > FYI that this blocks some changes to improve refinement of data, cause until these schemas are chan... [16:26:25] the data on Mexico City is definitely metropolitan region [16:27:13] the city proper is like 8 or 9m [16:34:58] (PS12) Vedmaka Wakalaka: Banner live preview [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/497611 (https://phabricator.wikimedia.org/T208125) [16:35:20] Fundraising-Analysis, Beta-Cluster-Infrastructure, MediaWiki-extensions-Translate: ExtensionDependencyError FundraisingTranslateWorkflow requires Translate to be installed. - https://phabricator.wikimedia.org/T218860 (Jdforrester-WMF) Oh, yeah, you can't use proper dependencies for extensions that... [16:42:24] (PS1) Jforrester: Replace static extension registration dependency with callback hack [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/498149 (https://phabricator.wikimedia.org/T218860) [16:44:40] (CR) jerkins-bot: [V: -1] Replace static extension registration dependency with callback hack [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/498149 (https://phabricator.wikimedia.org/T218860) (owner: Jforrester) [16:45:02] (CR) Vedmaka Wakalaka: "This change is ready for review." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/497611 (https://phabricator.wikimedia.org/T208125) (owner: Vedmaka Wakalaka) [16:54:31] (PS2) Jforrester: Replace static extension registration dependency with callback hack [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/498149 (https://phabricator.wikimedia.org/T218860) [17:47:22] jgleeson: so, any preference on one of those CRM-side contribution tracking tickets? [17:47:32] might be fun to make a new queue consumer! [17:48:04] hey ejegg, I'm easy! [17:48:24] just looking at them now [17:49:58] ejegg, the queue consumer one looks the most straight forward based on the descriptioins [17:50:13] is it worth chatting a little about the overall big picture? [17:51:07] sure - let's see if the old hangout still works [17:51:29] cool, give me a few minutes and I'll hop in [18:06:37] (CR) Esanders: [C: +2] "Oh good, my horrible hack is in two extensions now..." [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/498149 (https://phabricator.wikimedia.org/T218860) (owner: Jforrester) [18:09:12] Fundraising Sprint Fistful of $variables, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Create queue consumer for contribution tracking - https://phabricator.wikimedia.org/T215453 (jgleeson) a:jgleeson [18:19:44] (Merged) jenkins-bot: Replace static extension registration dependency with callback hack [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/498149 (https://phabricator.wikimedia.org/T218860) (owner: Jforrester) [18:19:58] Fundraising-Backlog, Epic: EPIC: Recurring upsell for donors - https://phabricator.wikimedia.org/T143429 (spatton) @Ejegg, here's a coded version from Eric and Randy @ Trilogy, along with their notes on functionality: https://design.bytrilogy.com/wikipedia-recurring-upsell General Notes - Fine to use... [18:41:23] (PS1) Jforrester: Revert "Replace static extension registration dependency with callback hack" [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/498200 [18:42:01] (CR) jerkins-bot: [V: -1] Revert "Replace static extension registration dependency with callback hack" [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/498200 (owner: Jforrester) [18:42:27] Fundraising-Analysis, Beta-Cluster-Infrastructure, MediaWiki-extensions-Translate, Patch-For-Review: ExtensionDependencyError FundraisingTranslateWorkflow requires Translate to be installed. - https://phabricator.wikimedia.org/T218860 (Jdforrester-WMF) Open→Resolved a:Jdforrester-WMF... [18:50:19] Fundraising-Backlog, Analytics, Product-Analytics: Fix EventLogging schemas that use array for items type - https://phabricator.wikimedia.org/T218617 (chelsyx) Hi @Ottomata , IIUC this only requires changes on the schema on meta wiki ([MobileWikiAppiOSUserHistory](https://meta.wikimedia.org/wiki/Sche... [19:20:29] (CR) Ejegg: [C: +1] "This is great! Could totally merge as is, but here are a couple of suggestions for tweaks." (3 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/497950 (owner: Cstone) [20:01:11] Fundraising Sprint Fistful of $variables, Fundraising-Backlog: Create variants for fancy new opt in pages on payments wiki - https://phabricator.wikimedia.org/T218240 (Ejegg) These look great! Do all the captions need to be localized? [20:18:36] Fundraising-Backlog, Analytics, Product-Analytics: Fix EventLogging schemas that use array for items type - https://phabricator.wikimedia.org/T218617 (Ottomata) > IIUC this only requires changes on the schema on meta wiki I believe so yes! Unless yall have reasons for specifying the items type as a... [20:26:30] have a great rest of yours fr-tech, bye for now o/ [20:27:12] jgleeson bye--ah he took of already... [20:27:17] *off [21:13:21] Fundraising Sprint Fistful of $variables, Fundraising-Backlog: Create variants for fancy new opt in pages on payments wiki - https://phabricator.wikimedia.org/T218240 (spatton) Thanks @Ejegg, I'll pass that positive feedback along to Eric and Randy :) Got a couple new versions that have gotten valuable... [21:19:53] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Epic: Document essential CentralNotice debugging - https://phabricator.wikimedia.org/T218953 (AndyRussG) [21:21:10] Fundraising Sprint Fistful of $variables, Fundraising-Backlog: Create variants for fancy new opt in pages on payments wiki - https://phabricator.wikimedia.org/T218240 (Ejegg) @Spatton - the lightbox plugin should be fine. With all those captions, are you planning to pay to have them translated, or wait... [21:26:00] Fundraising-Backlog, Analytics, Product-Analytics: Fix EventLogging schemas that use array for items type - https://phabricator.wikimedia.org/T218617 (chelsyx) @Ottomata I was trying to change the schema on meta wiki, but got this error message: > Error: Invalid node: expecting "array", got "object".... [21:27:45] Fundraising Sprint Fistful of $variables, Fundraising-Backlog: Create variants for fancy new opt in pages on payments wiki - https://phabricator.wikimedia.org/T218240 (CCogdill_WMF) Re translations, yes, we will be getting them, starting with Italian but moving on to Swedish and likely Dutch in April and... [21:28:09] Fundraising-Backlog, Analytics, Product-Analytics: Fix EventLogging schemas that use array for items type - https://phabricator.wikimedia.org/T218617 (Ottomata) HUH! I wonder if this is why the items are arrays......is EventLogging extension enforcing this with its weirdo JSONSchema? Will check... [21:30:24] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Document essential CentralNotice debugging - https://phabricator.wikimedia.org/T218953 (AndyRussG) [21:42:54] Fundraising-Backlog: E-mail unsubscribe: alerts for full pipeline - https://phabricator.wikimedia.org/T218957 (AndyRussG) [21:45:07] Fundraising-Backlog: E-mail unsubscribe: integration testing - https://phabricator.wikimedia.org/T218958 (AndyRussG) [21:54:38] Fundraising Sprint Fistful of $variables, Fundraising-Backlog: Create variants for fancy new opt in pages on payments wiki - https://phabricator.wikimedia.org/T218240 (Ejegg) Ooh, there are translated captions and descriptions under a bunch of the pictures on commons - looks like some of the payoff from... [22:19:27] hey ejegg I'm trying to break up the messages like you suggested but it is not liking it. Any idea why it's not liking two arrays combining to make the message? [22:20:07] cstone: want to paste what you've got someplace? [22:20:27] I was thinking they wouldn't even be combined [22:20:45] since the version with all the contact info wouldn't have the 'process' key [22:22:45] so instead of having the original and then [22:22:45] protected function getContactMessage() { [22:22:45] return [ [22:22:45] 'first_name' => 'Christine', [22:22:45] 'last_name' => 'Test', [22:22:45] 'display_name' => 'Christine', [22:22:45] 'street_address' => '1 Test Street', [22:22:46] 'city'=> 'Testland', [22:22:46] 'postal_code' => '13126', [22:22:47] 'country' => 'US', [22:22:47] ]; [22:22:48] } [22:25:51] yeah, just add the email key to that one and use it directly in the test of the full message [22:42:04] okay I think I see whats happening now, so when I remove the additional content from getMessage my unit test fails on creating the new contact, even though I am not passing it getMessage and am passing it getContactMessage. Any ideas there ejegg? [22:43:18] cstone: you added the email to the getContactMessage array? [22:43:28] wrong postal code maybe? [22:44:00] :P [22:44:19] hah yeah I did [22:45:20] its giving me Original error: Mandatory key(s) missing from params array: one of (first_name, last_name, email, display_name) Details: Array but they are all there [22:50:05] can you put up another patch set? [22:50:18] sure [22:52:45] (PS3) Cstone: Add create new contact on opt-in [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/497950 [22:54:04] (CR) Cstone: Add create new contact on opt-in (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/497950 (owner: Cstone) [22:55:00] thanks! pulling it down to test locally [22:56:52] oh wait, display_name shouldn't be necessary in the message from donatewiki [22:58:47] (CR) jerkins-bot: [V: -1] Add create new contact on opt-in [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/497950 (owner: Cstone) [23:03:32] cstone: ohh, so the issue is with the testNonPrimaryEmail test [23:03:47] OK, so maybe we need to add another check [23:05:02] does the getMessage have something else that makes it work opposed to the new one? [23:06:01] So, maybe we need to check that we have at least a name before creating the new contact [23:06:19] That last test is sort of equivalent to the nonExistantEmail test [23:06:26] because in the OptInQueueConsumer [23:06:46] the getContactsFromEmail function limits to only contacts with that email address as is_primary [23:07:09] so we end up going down the count($contacts) === 0 path [23:07:15] where you're creating a new contact [23:08:02] so maybe we do need an additional check inside there [23:08:29] so we only create the contact when we've got a name [23:08:58] was the test just failing gracefully then when I thought it was working before? [23:11:58] the test was passing because you changed the base message to always include all the contact fields [23:12:32] base messages are the best whatever you are talking about [23:13:00] but that would be inaccurate test data, since the standalone opt-in form only asks for the email address [23:13:22] ahhh okay [23:14:33] (CR) Ejegg: Add create new contact on opt-in (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/497950 (owner: Cstone)