[00:34:31] (PS5) Jgleeson: WIP: Create queue consumer for contribution tracking [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/498413 [00:39:30] (CR) Jgleeson: WIP: Create queue consumer for contribution tracking (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/498413 (owner: Jgleeson) [00:45:50] (PS6) Jgleeson: WIP: Create queue consumer for contribution tracking [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/498413 [01:40:48] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Can't save dedupe rule due to mystery - https://phabricator.wikimedia.org/T117179 (Eileenmcnaughton) Open→Resolved a:Eileenmcnaughton Let's kill this - the symptom went away > 3 years ago & doesn't seem to have come back [01:42:22] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Dedupe rules cannot be saved because they have duplicate names - https://phabricator.wikimedia.org/T117177 (Eileenmcnaughton) Open→Resolved a:Eileenmcnaughton Another one logged by Adam years ago that hasn't re-surfaced - killing [01:43:30] Fundraising Sprint Uptight Piano, Fundraising Sprint Vaporwerewolf, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, Patch-For-Review: Still an issue in merge screen display -not showing all ... - https://phabricator.wikimedia.org/T177873 [01:45:24] (PS1) Eileen: Restore colour coding on dedupe screen [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/499369 (https://phabricator.wikimedia.org/T217903) [01:45:57] Fundraising-Backlog, Fr-CiviCRM-dedupe-FY2017/18, Patch-For-Review: Civi dedupe: merge screen upgrades - https://phabricator.wikimedia.org/T217903 (Eileenmcnaughton) [01:45:59] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18, Patch-For-Review: Civi: middle name field questions for dedupe - https://phabricator.wikimedia.org/T188141 (Eileenmcnaughton) [01:46:56] Fundraising-Backlog, Fr-CiviCRM-dedupe-FY2017/18, Patch-For-Review: Civi dedupe: merge screen upgrades - https://phabricator.wikimedia.org/T217903 (Eileenmcnaughton) I've linked in https://phabricator.wikimedia.org/T188141 which relates to the middle name - I'm wondering if the issue with middle name... [02:16:04] Fundraising-Backlog, Fr-CiviCRM-dedupe-FY2017/18, Patch-For-Review: Civi dedupe: merge screen upgrades - https://phabricator.wikimedia.org/T217903 (Eileenmcnaughton) @MBeat33 in the vein of things that are not technical but might help - do you ever use the button 'show/hide rows with the same details... [02:17:35] Fundraising-Backlog, Fr-CiviCRM-dedupe-FY2017/18, Patch-For-Review: Civi dedupe: merge screen upgrades - https://phabricator.wikimedia.org/T217903 (Eileenmcnaughton) On the middle name - I found an example - but it's showing the middle name ... civicrm/contact/merge?reset=1&cid=26469608&oid=30188795 - [02:30:48] Fundraising-Backlog, Fr-CiviCRM-dedupe-FY2017/18, Patch-For-Review: Civi dedupe: merge screen upgrades - https://phabricator.wikimedia.org/T217903 (Eileenmcnaughton) OK another thought - I can see from your request to have the most recent on the right that you are keeping the most recent contact (not... [04:12:16] (CR) AndyRussG: "Hi!!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/497611 (https://phabricator.wikimedia.org/T208125) (owner: Vedmaka Wakalaka) [04:14:55] Fundraising Sprint Fistful of $variables, Fundraising-Backlog: Review live banner preview - https://phabricator.wikimedia.org/T219214 (AndyRussG) Copying here the initial comments posted on the Gerrit change: > Hi!! > > Thank you so much for this work. In general the code looks very clean and well thou... [14:49:26] Fundraising Sprint Ewoks Take Manhattan, Fundraising Sprint Fistful of $variables, Fundraising-Backlog, MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review: Send message to opt-in queue on failed payments attempts with opt_in=1 - https://phabricator.wikimedia.org/T216293 (CCogdill_WMF... [15:02:08] Fundraising-Backlog: Opt-in numbers in IBM not as expected - https://phabricator.wikimedia.org/T219401 (CCogdill_WMF) p:Triage→High [15:15:04] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi recurring donation cancel metric request - https://phabricator.wikimedia.org/T218616 (Ejegg) I think the October 2018 numbers are more related to those bogus cancellations that PayPal was sending us in audit files [15:24:12] fr-tech any news for scrum of scrums? [15:24:30] nothing from me ejegg [16:06:00] (PS4) Ejegg: Update Datacheck extension to fix duplicate location types. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/498001 (https://phabricator.wikimedia.org/T152474) (owner: Eileen) [16:06:41] (CR) Ejegg: [C: +2] "Looks good! Those are some super-descriptive function names you've got there." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/498001 (https://phabricator.wikimedia.org/T152474) (owner: Eileen) [16:12:20] (Merged) jenkins-bot: Update Datacheck extension to fix duplicate location types. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/498001 (https://phabricator.wikimedia.org/T152474) (owner: Eileen) [16:13:33] Fundraising Sprint Ewoks Take Manhattan, Fundraising Sprint Fistful of $variables, Fundraising-Backlog: Documentation: Move onboarding checklist to mediawiki - https://phabricator.wikimedia.org/T217149 (mepps) @Ejegg I don't see any edits from you in the page history. Where did you put them? [16:21:55] (PS2) Ejegg: Add job to process on_holds [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/499033 (https://phabricator.wikimedia.org/T217603) (owner: Eileen) [16:22:07] (CR) Ejegg: [C: +2] "Looks good!" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/499033 (https://phabricator.wikimedia.org/T217603) (owner: Eileen) [16:24:56] Fundraising Sprint Ewoks Take Manhattan, Fundraising Sprint Fistful of $variables, Fundraising-Backlog: Documentation: Move onboarding checklist to mediawiki - https://phabricator.wikimedia.org/T217149 (Ejegg) @mepps The last two on this page - https://collab.wikimedia.org/w/index.php?title=Fundraisi... [16:29:32] (Merged) jenkins-bot: Add job to process on_holds [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/499033 (https://phabricator.wikimedia.org/T217603) (owner: Eileen) [16:33:43] (PS7) Jgleeson: WIP: Create queue consumer for contribution tracking [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/498413 [16:35:47] (CR) jerkins-bot: [V: -1] WIP: Create queue consumer for contribution tracking [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/498413 (owner: Jgleeson) [16:36:23] (PS8) Jgleeson: WIP: Create queue consumer for contribution tracking [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/498413 [16:38:23] (CR) jerkins-bot: [V: -1] WIP: Create queue consumer for contribution tracking [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/498413 (owner: Jgleeson) [16:54:55] (PS9) Jgleeson: WIP: Create queue consumer for contribution tracking [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/498413 [16:57:00] (CR) jerkins-bot: [V: -1] WIP: Create queue consumer for contribution tracking [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/498413 (owner: Jgleeson) [16:59:52] (PS10) Jgleeson: WIP: Create queue consumer for contribution tracking [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/498413 [17:02:45] fr-tech I'm gonna go pickup Oscar and there's a chance I might get stuck in rush hour traffic and be a little late to tech-talk. Back soon [17:06:21] (CR) jerkins-bot: [V: -1] WIP: Create queue consumer for contribution tracking [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/498413 (owner: Jgleeson) [18:11:36] (PS1) Ejegg: Only send opt-in messages when we have email [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/499557 [18:30:09] cstone: ^^^ should filter out bogus opt-in messages like that one [19:08:43] fr-tech I'm finishing for today but I'll be back a little later to hopefully catch up with XenoRyet for a quick chat on the frontend fields on the CT queue consumer stuff [19:08:58] bye for now! [19:09:02] jgleeson|away: Yea, anytime you like, just give me a ping [19:09:09] great will do [19:09:27] jgleeson|away: cya! [19:09:30] (CR) Cstone: [C: +2] Only send opt-in messages when we have email [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/499557 (owner: Ejegg) [19:11:04] jgleeson|away: ejegg: XenoRyet: cstone: thanks again for listening to the live banner preview stuff and for ur comments :) [19:11:22] Thank you for showing us around [19:11:34] :) [19:13:25] I've noted down the stuff we talked about... for now I'm gonna plunge into some viscous paperwork tar sands, but will post the additional comments to the task later... Pls lmk if u see anything I forgot, or if u think of more to add... thx again! [19:22:16] (Merged) jenkins-bot: Only send opt-in messages when we have email [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/499557 (owner: Ejegg) [20:12:40] Fundraising-Backlog, FR-Ingenico: rate of GC50 errors from 3DS in Sweden - https://phabricator.wikimedia.org/T219445 (MBeat33) [20:18:37] Do we need to re-act in any way when a country changes it’s name ? https://lab.civicrm.org/dev/core/issues/829 [20:23:04] Fundraising Sprint Fistful of $variables, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi recurring donation cancel metric request - https://phabricator.wikimedia.org/T218616 (Eileenmcnaughton) [20:24:26] ejegg: what do you think next steps are on https://phabricator.wikimedia.org/T218616 - ie. should I be creating a report to display this? [20:24:41] dsrine ^ [20:25:13] we COULD store the data to a custom field as well - but I’m not sure that’s a good thing [20:27:00] also - I’m just gonna deploy a cupla things - would be nice to include this https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/499369/ [20:32:39] eileen I'll take a loom shortly! [20:33:02] also I was thinking maybe we should change the recurring charge code [20:33:09] and the audit process code [20:33:23] so we only set and end date, not a cancel date [20:33:37] when it's a passive cancel [20:34:05] ejegg: so they are cancelled by virtue of payments no longer working [20:34:07] ? [20:34:14] we might even get some distinguishing info about end reasons in paypal ipns and audit files [20:34:15] e.g cancelled card [20:34:20] yep, exactly [20:34:45] I suspect that in stock civi they would remain ‘In progress’ if not actually cancelled [20:35:03] (& in fact many organisations then contact those people for a new card to continue it) [20:37:00] so what would ‘end_date’ mean - at this point we gave up on it? [20:37:12] We do something weird in general [20:37:19] ie. stock civi [20:37:43] created = Pending, some payments received = In Progress, all payments received = Completed [20:37:56] whereas we go straight to completed [20:46:47] (PS2) Eileen: Restore colour coding on dedupe screen [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/499369 (https://phabricator.wikimedia.org/T217903) [20:46:49] (PS1) Eileen: Opps missed the tests out of the commit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/499591 [20:50:40] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/499593 [20:51:00] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/499593 (owner: Eileen) [20:52:47] (Merged) jenkins-bot: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/499593 (owner: Eileen) [20:55:13] eileen: ooh, shoot [20:55:48] it's always nice to move towards how core acts [20:56:22] Fundraising-Backlog, FR-Ingenico: rate of GC50 errors from 3DS in Sweden - https://phabricator.wikimedia.org/T219445 (MBeat33) #571071 got the same error as above. They write: //After I enter my VISA information, I get stuck on the screen shown in the attachment. I've left it for over 10 minutes and not... [20:58:22] (CR) Ejegg: [C: +2] "This does the trick! Just needed a 'ctrl-f5' reload for the new styles to show." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/499369 (https://phabricator.wikimedia.org/T217903) (owner: Eileen) [20:59:29] ejegg: I missed the tests on the datacheck one - https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/499591/ [20:59:40] eileen: just pulled 'em down, reviewing [20:59:53] yeah that was a bit dumb of me [20:59:59] anyway, yeah, end_date would mean the date we gave up trying to charge a card [21:00:05] (is what I was thinking) [21:00:29] either that, or we add a field to record why something was canceled [21:00:35] actually, that might be clearer [21:00:38] and you would still change the status to cancelled? [21:00:50] yeah [21:01:39] I think if we are going to track this with more data than I could retrieve with the query I’d probably add a cancel-reason custom field [21:02:18] the end_date vs cancel_date doesn’t feel like we’ll remember which is which in 6 months if we haven’t thought about it in between [21:02:44] hmm, getting failures in the tests: Failure in api call for Data fix: Undefined index: phone_type_id [21:02:52] is my civi missing a field? [21:03:39] dang - [21:03:49] (Merged) jenkins-bot: Restore colour coding on dedupe screen [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/499369 (https://phabricator.wikimedia.org/T217903) (owner: Eileen) [21:04:10] no, phone_type_id is a column on civicrm_phone [21:04:58] I’ll retry locally [21:05:01] seems to be in filterOutPhonesWhereTypeIsDifferentButLocationISame [21:05:23] oh hey, that could use one more letter - missing s in I*s*Same [21:05:48] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/499601 [21:06:10] I think I hit a function length character limit :-) [21:07:31] hmm yeah, no phone_type_id in the entitiesArray passed in from fix [21:07:47] hmm I just tested & locally it worked [21:07:58] is it due to phones in your table already [21:08:05] without phone_type_id [21:08:10] ah, maybe [21:08:19] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/499601 (owner: Eileen) [21:09:17] (Merged) jenkins-bot: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/499601 (owner: Eileen) [21:09:29] ejegg: OK so on recurring cancel reason I feel like we should either say [21:09:47] 1) actually we can figure out how they were cancelled with a clever query OR [21:09:53] yeah, I think that was it [21:10:04] 2) really we want more visibiility on that - let’s add a custom field [21:10:38] (we could put our clever query into a report if we wanted) [21:10:40] any chance cancel_reason would make sense to add to core? [21:11:41] so the fact that there is an equivalent for contribution means there is a case to be made [21:12:09] I can test the waters on that - would add some delay but that’s probably not too much [21:12:27] cool! [21:14:01] ok - I’ll log something & see what response I get [21:15:02] (CR) Ejegg: [C: +2] Opps missed the tests out of the commit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/499591 (owner: Eileen) [21:20:32] (Merged) jenkins-bot: Opps missed the tests out of the commit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/499591 (owner: Eileen) [21:21:23] ejegg: I’ve just pushed a process control commit to add the new job - if you check I’ll deploy [21:21:35] k, looking [21:22:44] AndyRussG|ish: hi - what's the status of T217649 ? Was the code already merged? If so we should probably make a patch at gerrit and merge it there as well [21:22:58] hauskatze: the code is in gerrit [21:23:13] eileen: the new job looks right to me [21:23:14] and merged? [21:23:19] thanks [21:24:15] ! process-control config revision is e1bc772c89 [21:24:16] hauskatze: I think so, checking [21:24:18] !log process-control config revision is e1bc772c89 [21:24:19] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:25:02] !log civicrm revision changed from 67b8405b60 to 7560af93df, config revision is 5a0cbb3c7d (was actually before the process control one) [21:25:04] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:25:11] hauskatze: yep, here it is: https://gerrit.wikimedia.org/r/#/q/I9a7edf6fc7d0bb0f4129fe13323964e9fae791f3 [21:26:10] ejegg: awesome - are we using wmf_deploy still? I see nothing in that branch [21:26:29] hauskatze: it was in core, not in the centralnotice extension [21:26:41] oh, so true [21:26:57] well I guess I can close the task then? [21:27:03] yeah, I think so! [21:28:59] ejegg: I’m a little perturbed that I can see there are fixes to be done on primarylocation too when I run ‘check’ with data checks. I guess since we added that fix in the past I should run it? Ideally we’d dig into why / do more complete stuff to monitor but I think that’s not in scope for the sprint but perhaps just running the fix on them will at least do some good [21:29:15] Done! [21:29:22] thanks hauskatze [21:29:37] While I can make the task public, I'll let others decide. [21:29:59] eileen: oh, so it seems like there's some process still corrupting the primary location? [21:30:07] ejegg: I guess so [21:30:09] hauskatze: oh, we're all OK with it being public now [21:30:23] or at least - since we last looked [21:30:55] I created a meta issue here https://phabricator.wikimedia.org/T218251 [21:42:58] Fundraising-Backlog, FR-Ingenico: rate of GC50 errors from 3DS in Sweden - https://phabricator.wikimedia.org/T219445 (Ppena) Im checking with Ingenico right now, but thanks fr-tech for checking if its something internal. Also, can we change the iframe message, as we have previously done? [21:43:02] /nick XenoRyet [21:46:58] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Recurring-Donations: "Uncommitted DB writes" errors are getting creepy - https://phabricator.wikimedia.org/T100585 (aaron) Does this still occur? [22:09:45] (PS5) XenoRyet: WIP: c_t ids from the sequence generator [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/496351 (https://phabricator.wikimedia.org/T215462) [22:10:02] (CR) jerkins-bot: [V: -1] WIP: c_t ids from the sequence generator [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/496351 (https://phabricator.wikimedia.org/T215462) (owner: XenoRyet) [22:15:39] Fundraising-Backlog, FR-Ingenico: rate of GC50 errors from 3DS in Sweden - https://phabricator.wikimedia.org/T219445 (Ejegg) OK, FR-tech is pretty sure this is caused by the new access-control header that we added with the payments-wiki upgrade. That header tells the browser to only load frames, images,... [22:16:28] Fundraising-Backlog, FR-Ingenico: rate of GC50 errors from 3DS in Sweden - https://phabricator.wikimedia.org/T219445 (Ejegg) @MBeat33 yep, that donor had it right on the money! Man, do we have some smart ppl giving us money :) [22:17:46] Fundraising-Backlog, FR-Ingenico: rate of GC50 errors from 3DS in Sweden - https://phabricator.wikimedia.org/T219445 (MBeat33) srsly @Ejegg we might have to give them some Wikistore credit for swag as a thank-you [22:19:23] pcoombe, Seddon: you're the only banner folks I see on right now, but I know it's pretty late for you [22:19:51] Can someone from the banner team add a URL param to card donations from NO, SE, and PL? [22:36:59] on it [22:37:40] thanks pcoombe ! [22:44:59] ejegg: ah we never fully fixed primaries in the past it seems - code comment “This will actually only update contacts with only 1 location (e.g [22:45:00] * 1 email etc) rather than those where it is not clear which should be selected." [22:45:47] Okay ejegg done for banners. But wow that redirected page looks sparse [22:47:23] ug finding benevity-created contacts with no location on their emails [22:47:31] recent ones [22:51:24] (PS6) XenoRyet: WIP: c_t ids from the sequence generator [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/496351 (https://phabricator.wikimedia.org/T215462) [22:53:23] (CR) jerkins-bot: [V: -1] WIP: c_t ids from the sequence generator [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/496351 (https://phabricator.wikimedia.org/T215462) (owner: XenoRyet) [22:58:51] done for donatewiki as well [23:04:55] replied on the email thread [23:13:39] (PS7) XenoRyet: WIP: c_t ids from the sequence generator [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/496351 (https://phabricator.wikimedia.org/T215462) [23:17:05] pcoombe: yeah... we need to make a second version of the hosted checkout at the ingenico side! [23:48:28] (CR) Ejegg: [C: +1] "This is looking good! The first time I ran it, I got a null in the $beginSettings value inside the hook (for a modification), but I can't " (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/493459 (https://phabricator.wikimedia.org/T217565) (owner: AndyRussG)