[00:09:52] Fundraising Sprint Fistful of $variables, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Fix data where contacts have multiple emails or addresses of the same location type (or have no location type) - https://phabricator.wikimedia.org/T152474 (Eileenmcnaughton) before `... [00:23:59] (PS1) Eileen: Extra s for Elliott [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/499683 [00:24:43] (PS1) Eileen: Additional test check [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/499684 [01:28:41] (PS1) Eileen: Update primary location fix to also fix when more than one option [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/499687 (https://phabricator.wikimedia.org/T218616) [01:36:29] (PS1) Eileen: Update query to not treat blank location types as duplicate [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/499688 (https://phabricator.wikimedia.org/T218616) [02:32:01] (PS1) Eileen: Add a check to fix blank location types [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/499689 (https://phabricator.wikimedia.org/T218616) [03:32:55] Fundraising Sprint Fistful of $variables, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Fix data where contacts have multiple emails or addresses of the same location type (or have no location type) - https://phabricator.wikimedia.org/T152474 (Eileenmcnaughton) OK - I adde... [03:37:02] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Write a script to generate fail mail when integrity checks fail - https://phabricator.wikimedia.org/T150388 (Eileenmcnaughton) [03:37:47] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: blank location type entries being created - https://phabricator.wikimedia.org/T219478 (Eileenmcnaughton) [03:38:47] Fundraising Sprint Fistful of $variables, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Fix data where contacts have multiple emails or addresses of the same location type (or have no location type) - https://phabricator.wikimedia.org/T152474 (Eileenmcnaughton) Looks like... [04:32:10] Fundraising Sprint Da Vinci Coder, Fundraising Sprint Ewoks Take Manhattan, Fundraising Sprint Fistful of $variables, Fundraising-Backlog, Patch-For-Review: Re-run omnirecipient repair to catch the few missed ones - https://phabricator.wikimedia.org/T215865 (Eileenmcnaughton) Looks like it's... [05:04:21] (CR) AndyRussG: "Hi again! More comments here:" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/497611 (https://phabricator.wikimedia.org/T208125) (owner: Vedmaka Wakalaka) [07:42:54] (CR) Vedmaka Wakalaka: "> Patch Set 12:" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/497611 (https://phabricator.wikimedia.org/T208125) (owner: Vedmaka Wakalaka) [07:55:08] (CR) Vedmaka Wakalaka: "> Patch Set 12:" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/497611 (https://phabricator.wikimedia.org/T208125) (owner: Vedmaka Wakalaka) [12:52:14] Fundraising-Backlog, fundraising-tech-ops, Epic: epic: frtech onwiki documentation overhaul - https://phabricator.wikimedia.org/T209872 (mepps) [12:52:17] Fundraising Sprint Ewoks Take Manhattan, Fundraising Sprint Fistful of $variables, Fundraising-Backlog: Documentation: Move onboarding checklist to mediawiki - https://phabricator.wikimedia.org/T217149 (mepps) Open→Resolved @Ejegg Thanks! It looks good. I'm closing this. [13:08:14] (PS11) Jgleeson: WIP: Create queue consumer for contribution tracking [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/498413 [13:10:28] (CR) jerkins-bot: [V: -1] WIP: Create queue consumer for contribution tracking [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/498413 (owner: Jgleeson) [13:40:30] fr-tech, I'm currently baffled by what's causing PHP 5 not to see the class declared using the namespace included on this build failure https://integration.wikimedia.org/ci/job/wikimedia-fundraising-civicrm/8204/console. The offending line is here https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/498413/10/sites/all/modules/queue2civicrm/tests/phpunit/ContributionTrackingQueueTest.php@17 although this works locally [13:40:30] without issue :| [14:08:54] Fundraising Sprint Fistful of $variables, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: CRM contribution tracking writing should have a switch to use the new infrastructure - https://phabricator.wikimedia.org/T215463 (mepps) @Ejegg would we both write to the db and use a queue? [14:53:20] jgleeson: sounds frustrating! [14:53:37] so some autoloader isn't loading, probably? [14:54:11] lemme pull that patch down and take a look [14:54:36] thanks ejegg [14:59:42] jgleeson: I don't see a change to sites/default/enabled_modules in that patch [14:59:52] try just adding wmf_ct_qc to that file [14:59:56] ahhh [15:00:31] my focus was way to narrow on that one [15:00:34] too* [15:00:41] thanks ejegg I'll add the file and repush [15:00:47] update to file* [15:01:02] cool :) [15:02:10] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/499789 [15:02:19] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/499789 (owner: Ejegg) [15:03:38] (PS12) Jgleeson: WIP: Create queue consumer for contribution tracking [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/498413 [15:04:23] Fundraising Sprint Fistful of $variables, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: CRM contribution tracking writing should have a switch to use the new infrastructure - https://phabricator.wikimedia.org/T215463 (Ejegg) @mepps We would do either one or the other. I'm leaning towards doing... [15:07:28] fr-tech sounds like there might still be problems with the redirect and 3DS [15:07:46] anyone want to brainstorm on a non-variant way to do the redirection [15:07:52] sure [15:08:08] I saw michaels email but wasn't confident on a better approach [15:08:09] so we have this script to override the isIframe function [15:08:29] https://phabricator.wikimedia.org/diffusion/EDOI/browse/master/modules/js/ext.donationInterface.alwaysRedirect.js [15:08:47] let's see, where would make sense to pull that in [15:08:49] ? [15:09:29] there's a $stagedData variable called 'use_authentication' [15:09:58] which we would consult to decide whether to use that override [15:10:23] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/499789 (owner: Ejegg) [15:10:26] I guess in the Mustache form class? [15:11:32] I'm looking at the staging function now [15:11:56] yeah my knowledge is sparse around our use of the front-end forms [15:12:32] hmm so do we think the redirect is working and it's just not being triggered? [15:12:35] hmm, actually, I'm not sure if we have that particular variable staged up when we initially render the form [15:13:05] jgleeson: like maybe the banners aren't actually passing the variant=redirect parameter? [15:13:35] hmm I'd guess that would be working as it's a hard one to get wrong [15:13:46] or is that query param conditional? [15:13:49] heh, banners have some complex code! [15:14:08] yeah, it should only be sent for country = NO, PL, and SE [15:14:18] oh huh, and we shouldn't be fundraising in NO anyway [15:15:02] hmm, so the other option would be to change the ajax response coming back from the donation API [15:15:18] so are we adding that param cleverly at somewhere like gateformchooser or is that a static URL people are landing at [15:15:23] so it reflects the need to redirect [15:15:36] jgleeson: it's being added in the banners and on donatewiki [15:15:43] (which is kinda fragile) [15:15:52] (and just a stopgap/workaround) [15:15:53] ah so explicit? [15:15:57] yeah [15:16:06] ok so that makes me think that's not the issue [15:16:25] where's the gerrit patch for the redirect behaviour? [15:17:14] Banner and donatewiki code is just edited on wiki [15:17:26] I think pcoombe sent around a link to the diffs yesterday [15:17:41] https://meta.wikimedia.org/w/index.php?title=MediaWiki:FundraisingBanners/CoreJS-2018.js&diff=prev&oldid=18971898 [15:17:48] and https://donate.wikimedia.org/w/index.php?title=Template%3A2012FR%2FForm-section%2FProcessing%2FDefault&type=revision&diff=33900&oldid=33896 [15:17:53] yeah I can see he adds it [15:18:12] but I'm imaging we then process that param somewhere [15:18:14] the variant=redirect code was added in I think december [15:18:18] ah ok [15:18:42] https://phabricator.wikimedia.org/rEDOI64a210aae7c76d9e6638828d84fd141ee5581125 [15:18:59] imagining* [15:19:33] oh cool, so it's that simple [15:20:36] I will extrapolate beyond that that the subsequent code finds a url and does a hard redirect, with the user coming back to us on completion at the gayeway? [15:20:49] gateway* [15:21:22] fundraising-tech-ops: upgrade fundraising puppetmasters to Debian Buster - https://phabricator.wikimedia.org/T219315 (Jgreen) [15:21:36] fundraising-tech-ops: EPIC: migrate fundraising hosts to Debian Stretch - https://phabricator.wikimedia.org/T185013 (Jgreen) [15:21:49] jgleeson: yep, the donor enters their card number and then gets redirected to visa or mastercard for authentication [15:22:06] here's the mediawiki-repo patch to add the variant config https://phabricator.wikimedia.org/rMWdb26d7380a527248336a49e048b12f346e30d041 [15:22:16] so the redirect error MBeat mentions interests me [15:22:26] would be good to see/know more on that [15:22:35] maybe the URL is wrong? [15:22:49] jgleeson: I think that happens when the form is still using an iframe [15:23:12] and the iframe tries to redirect to a URL that our access-control header doesn't allow [15:23:24] thanks, all Order ID : 4001267964 is one from today [15:23:34] (you can see a donor reporting exactly that in one of the first comments on that ticket) [15:23:37] ahhhhhh so we're blocking the redirect in the first place due to the AC headers [15:23:49] if any more detail would help, lemme know and I’ll add to Phab [15:24:14] jgleeson: so if our access control headers are still in effect, that means we haven't done the full redirect to the hosted checkout page [15:24:32] MBeat, I think I'm covering ground already discovered but thank you [15:25:03] np [15:25:29] jgleeson, ejegg from my reading of the emails isn't there also an issue with styling? like when it was working the donor was going to page that looked kind of sketchy? it sounds like there's a few things going on with 3DS [15:26:06] mepps right, we don't have a separate hosted checkout page configured for the full redirect with Ingenico [15:26:28] so they see a full page with just the elements that appear in the iframe [15:26:30] cool ejegg, thanks--and these are two separate issues? [15:26:36] mepps right [15:26:45] okay, got it [15:26:53] do we have phab tasks created for these? [15:27:04] if they're getting to the full sparse page, they shouldn't see the redirect error [15:27:26] the redirect error should only be happening when we load things in the iframe [15:27:30] okay so some folks aren't even getting redirected, and those that are seeing a sketchy page with no styling [15:27:40] ah interesting [15:27:57] there are two 'redirects' at issue here [15:28:06] ahhhh [15:28:19] 1) from payments-wiki to the processor. [15:28:24] that was me understanding, not me yelling btw :) [15:29:03] with the variant=redirect parameter, we should do a full redirect from payments-wiki to the hosted checkout page, rather than loading the hosted checkout page in an iframe [15:29:21] 2) from the processor to the card issuer, to do the 3DS authentication [15:29:36] this should work fine if we have done a full redirect in step 1) [15:29:54] okay this makes sense, and is variant=redirect where we're getting the redirect error? [15:30:02] if we have instead loaded the processor form in an iframe, our access-control headers block the redirect in step 2) [15:30:09] this makes snese [15:30:28] mepps I'm not sure if the donors with errors today have variant=redirect [15:30:54] oh okay [15:30:57] we can look at that, or we can try to make a change in DonationInterface to make the variant=redirect parameter unnecessary [15:31:16] We should make that DonationInterface change at some point [15:31:29] since it's just the correct behavior [15:31:57] so would that mean it would always redirect? sorry i ready your chats with jgleeson but i wasn't clear [15:31:58] and relying on every point of entry to add the correct variant for the correct countries is fragile as heck [15:32:08] or always redirect for 3ds? [15:32:11] yeah definitely [15:32:13] mepps, I'm still a little lost [15:32:15] mepps yeah, for 3ds [15:32:39] I read from michaels email that we are still getting issues, post the redirect fix [15:33:08] okay so to summarize, the idea is to add logic that says "whenever a donor is using 3ds, do a full redirect" rather than requiring banners or donatewiki to know to add that [15:33:15] which I guess would be explain by countries using 3d secure not arriving with the variant param? [15:33:32] but that seems unlikely [15:34:15] hmm I'm gonna do some log diving on 4001267964 [15:34:21] to see if I can find out what URL they came in at [15:35:18] good idea jgleeson! [15:35:51] ejegg it sounds like another thing to tackle is the styling for ingenico--can we do separately styled forms with them? [15:36:12] mepps I think we can [15:36:19] PROBLEM - check_puppetrun on payments2002 is CRITICAL: CRITICAL: Puppet has 7 failures. Last run 5 minutes ago with 7 failures. Failed resources (up to 3 shown) [15:37:13] PROBLEM - check_puppetrun on frdb2001 is CRITICAL: CRITICAL: Puppet has 29 failures. Last run 6 minutes ago with 29 failures. Failed resources (up to 3 shown) [15:38:19] PROBLEM - check_puppetrun on alnilam is CRITICAL: CRITICAL: Puppet has 8 failures. Last run 7 minutes ago with 8 failures. Failed resources (up to 3 shown): File[/usr/lib/nagios/plugins/check_frtech_mail],File[/usr/lib/nagios/plugins/check_fundraising_jobs],File[/usr/lib/nagios/plugins/check_impression_logs],File[/usr/lib/nagios/plugins/check_puppetrun] [15:38:23] PROBLEM - check_puppetrun on payments2003 is CRITICAL: CRITICAL: Puppet has 33 failures. Last run 7 minutes ago with 33 failures. Failed resources (up to 3 shown) [15:38:23] PROBLEM - check_puppetrun on payments2001 is CRITICAL: CRITICAL: Puppet has 7 failures. Last run 7 minutes ago with 7 failures. Failed resources (up to 3 shown) [15:40:13] PROBLEM - check_puppetrun on mintaka is CRITICAL: CRITICAL: Puppet has 3 failures. Last run 9 minutes ago with 3 failures. Failed resources (up to 3 shown) [15:40:13] PROBLEM - check_puppetrun on alnitak is CRITICAL: CRITICAL: Puppet has 30 failures. Last run 9 minutes ago with 30 failures. Failed resources (up to 3 shown) [15:41:13] PROBLEM - check_puppetrun on pay-lvs2002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 9 minutes ago with 1 failures. Failed resources (up to 3 shown): File[/usr/local/bin/aide_new_db] [15:41:19] PROBLEM - check_puppetrun on payments2002 is CRITICAL: CRITICAL: Puppet has 7 failures. Last run 10 minutes ago with 7 failures. Failed resources (up to 3 shown) [15:42:13] PROBLEM - check_puppetrun on frdb2001 is CRITICAL: CRITICAL: Puppet has 29 failures. Last run 11 minutes ago with 29 failures. Failed resources (up to 3 shown) [15:43:19] PROBLEM - check_puppetrun on alnilam is CRITICAL: CRITICAL: Puppet has 8 failures. Last run 12 minutes ago with 8 failures. Failed resources (up to 3 shown): File[/usr/lib/nagios/plugins/check_frtech_mail],File[/usr/lib/nagios/plugins/check_fundraising_jobs],File[/usr/lib/nagios/plugins/check_impression_logs],File[/usr/lib/nagios/plugins/check_puppetrun] [15:43:23] PROBLEM - check_puppetrun on payments2003 is CRITICAL: CRITICAL: Puppet has 33 failures. Last run 12 minutes ago with 33 failures. Failed resources (up to 3 shown) [15:43:23] PROBLEM - check_puppetrun on payments2001 is CRITICAL: CRITICAL: Puppet has 7 failures. Last run 12 minutes ago with 7 failures. Failed resources (up to 3 shown) [15:44:25] yikes cwd, Jeff_Green ^^ are those expected? [15:44:50] jeff is on it [15:45:13] RECOVERY - check_puppetrun on mintaka is OK: OK: Puppet is currently enabled, last run 2 minutes ago with 0 failures [15:45:13] RECOVERY - check_puppetrun on alnitak is OK: OK: Puppet is currently enabled, last run 2 minutes ago with 0 failures [15:45:19] sorry, yeah [15:46:03] I'm prepping to upgrade one of the puppetmasters (heka), so I switched all the puppet traffic to the other one (frpm1001) but the switch didn't happen as quickly as I expected [15:46:13] PROBLEM - check_puppetrun on pay-lvs2002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 14 minutes ago with 1 failures. Failed resources (up to 3 shown): File[/usr/local/bin/aide_new_db] [15:46:19] PROBLEM - check_puppetrun on payments2002 is CRITICAL: CRITICAL: Puppet has 7 failures. Last run 15 minutes ago with 7 failures. Failed resources (up to 3 shown) [15:46:33] it's harmless, just means these hosts didn't fetch any config changes [15:46:48] puppet is like a hysterical car alarm [15:47:13] PROBLEM - check_puppetrun on frdb2001 is CRITICAL: CRITICAL: Puppet has 29 failures. Last run 16 minutes ago with 29 failures. Failed resources (up to 3 shown) [15:47:59] i should change my text message sound to a car alarm, it would make more sense [15:48:19] RECOVERY - check_puppetrun on alnilam is OK: OK: Puppet is currently enabled, last run 1 minute ago with 0 failures [15:48:21] RECOVERY - check_puppetrun on payments2003 is OK: OK: Puppet is currently enabled, last run 43 seconds ago with 0 failures [15:48:21] RECOVERY - check_puppetrun on payments2001 is OK: OK: Puppet is currently enabled, last run 46 seconds ago with 0 failures [15:51:13] RECOVERY - check_puppetrun on pay-lvs2002 is OK: OK: Puppet is currently enabled, last run 3 minutes ago with 0 failures [15:51:19] RECOVERY - check_puppetrun on payments2002 is OK: OK: Puppet is currently enabled, last run 3 minutes ago with 0 failures [15:52:13] RECOVERY - check_puppetrun on frdb2001 is OK: OK: Puppet is currently enabled, last run 4 minutes ago with 0 failures [15:52:41] lol cwd [15:53:04] (PS1) Ejegg: Ingenico connect: Always redirect when using 3DS [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/499800 (https://phabricator.wikimedia.org/T219445) [15:53:07] fr-tech that might work ^^^ [15:53:45] trying it out locally [15:55:21] ejegg, that variant isn't present in the arrival URL of the donor attached to the order ID MBeat's posted earlier [15:55:34] jgleeson: ok, that's what I thought [15:55:56] we should probably go ahead and try to fix the DonationInterface behavior so as not to rely on a variant [15:56:02] want to take a look at that patch? [15:56:06] sure [15:56:25] to test it, you can use INR [15:56:32] which should have 3DS on by default [15:56:52] (CR) Mepps: "One question, and note" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/499800 (https://phabricator.wikimedia.org/T219445) (owner: Ejegg) [15:56:55] and Ingenico Connect [15:58:26] (CR) Ejegg: "thanks mepps" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/499800 (https://phabricator.wikimedia.org/T219445) (owner: Ejegg) [15:59:21] (PS2) Ejegg: Ingenico connect: Always redirect when using 3DS [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/499800 (https://phabricator.wikimedia.org/T219445) [16:00:22] code looks good ejegg, just gonna pull it down and try it [16:00:40] I'm hoping I can use the usual ingenico test card details with that country code [16:01:03] INR would be the currency code [16:01:09] so hmm [16:01:21] Or you can add this to your LocalSettings: [16:01:21] oh [16:01:37] $wgDonationInterface3DSRules = [ 'USD' => [] ] [16:01:48] Which will turn on 3DS for all USD transactions [16:02:01] that sounds easier [16:04:17] hmm, doesn't quite seem to worok [16:04:20] *work [16:06:04] hmm [16:06:13] my payments wiki is just stuck at the loading screen [16:06:26] after I click the payment method [16:06:38] feels like a debugging pause but nothings running... grrr [16:07:04] That's weird [16:08:04] I don't think I've seen that kind of behavior before [16:09:36] oh, that setData call clobbers the original data [16:09:40] that's unhelpful [16:09:49] changing stuff... [16:10:49] ok I got paymentswiki working locally [16:11:41] (PS3) Ejegg: Ingenico connect: Always redirect when using 3DS [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/499800 (https://phabricator.wikimedia.org/T219445) [16:11:41] by running composer install in paymentswiki root, and DI root and getting back "Nothing to install or update" but it fixed something [16:11:52] guessing the autoload files were broken? who knows [16:12:15] woop, that works! [16:12:26] jgleeson: oh, interesting [16:12:35] hmm it's broken again [16:12:42] since checking out that patch ejegg [16:12:44] strange [16:12:58] want to screenshare and debug? [16:13:07] mepps PS3 seems to do the trick for me [16:13:08] sure I'll jump in queen mary [16:13:19] actually I don't think google will let me anymore [16:13:23] I'll join todays standup room [16:13:36] ok, see you there [16:15:05] XenoRyet: want to pull down this patch and see if it makes Ingenico Connect always redirect when using 3DS? https://gerrit.wikimedia.org/r/499800 [16:15:20] Sure, let me give it a try [16:21:40] ejegg i feel like i must be missing something but i'm seeing that $result would be of the class PaymentResult which doesn't seem to have a setData or getData function? what am i missing? [16:22:33] mepps it's a PaymentTransactionResponse object [16:23:09] got it, i was looking at doPayment [16:23:26] yeah, I feel like we SHOULD be using doPayment [16:23:29] but we're not [16:24:13] the api is calling do_transaction directly [16:24:59] ejegg just curious but would it make any sense to change it this way in PaymentTransactionResponse: public function setData( $data, $append = false ) { [16:24:59] if ($append) { [16:24:59] $this->data = $this->data + $data; [16:24:59] return; [16:24:59] } [16:24:59] $this->data = $data; [16:24:59] } [16:25:03] woops [16:25:14] oh it's fine, i thought it sent that as separate messages at first [16:26:06] mepps yeah, that could be good! [16:26:08] Fundraising Sprint Fistful of $variables, Fundraising-Backlog: Review live banner preview - https://phabricator.wikimedia.org/T219214 (AndyRussG) More comments posted in Gerrit: > Patch Set 12: > > Hi again! More comments here: > > - Nice work with the "working" indicator in the live preview area, l... [16:26:11] will put that up as a separate patch [16:26:14] (CR) Jgleeson: [C: +2] "Code looks good and works as expected for me." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/499800 (https://phabricator.wikimedia.org/T219445) (owner: Ejegg) [16:28:33] (PS1) Ejegg: PaymentTransactionResponse::setData allows append [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/499807 [16:30:01] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/499809 [16:30:10] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/499809 (owner: Ejegg) [16:32:33] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/499811 [16:35:59] (CR) jerkins-bot: [V: -1] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/499811 (owner: Ejegg) [16:53:49] (Merged) jenkins-bot: Ingenico connect: Always redirect when using 3DS [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/499800 (https://phabricator.wikimedia.org/T219445) (owner: Ejegg) [16:55:20] (CR) Ejegg: [C: +2] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/499811 (owner: Ejegg) [17:02:53] Jeff_Green: looks like the main cluster is about to move to PHP7.2, using a package built and maintained by wmf service ops [17:07:11] ok [17:07:39] ejegg: do you think there's any reason not to stick with the stock version? [17:10:26] there's a bit of performance to be gained [17:10:41] and the fact that 7.0 is technically already EOL [17:10:57] yeah [17:11:54] I think perhaps the way we should handle this is stick with 7.0 and work toward upgrading payments servers to buster as soon as we can [17:17:11] Fundraising Sprint Ewoks Take Manhattan, Fundraising Sprint Fistful of $variables, Fundraising-Backlog, MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review: Send message to opt-in queue on failed payments attempts with opt_in=1 - https://phabricator.wikimedia.org/T216293 (MBeat33) @Ej... [17:44:55] argh, core patches have an hour backlog [17:45:59] :O [17:46:50] can't they transcribe the punch cards any faster? [17:47:28] http://farm3.static.flickr.com/2587/4176601036_95fb12ac18_o.jpg [17:47:41] inside jenkins [17:50:40] XenoRyet, when's the best time to squeeze in a chat on the CT stuff? I've pulled down your latest patch and gonna look through it now [17:51:08] I've got a meeting with cstone in about 10 minutes, any time after that would be fine with me. [17:51:19] great [17:51:33] I'll try and catch you after that then [17:53:56] Sounds good [17:58:00] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/499811 (owner: Ejegg) [17:59:06] Fundraising Sprint Ewoks Take Manhattan, Fundraising Sprint Fistful of $variables, Fundraising-Backlog, MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review: Send message to opt-in queue on failed payments attempts with opt_in=1 - https://phabricator.wikimedia.org/T216293 (Ejegg) Yep @... [18:01:01] Oh, or I guess monthly activities is going right now too. [18:03:05] !log updated payments-wiki from 6661655e37 to 4b49bb7333 [18:03:07] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [18:19:41] Fundraising Sprint Ewoks Take Manhattan, Fundraising-Backlog, FR-Email: Update Silverpop export to include opted in records with no donations - https://phabricator.wikimedia.org/T217712 (CCogdill_WMF) Ah @Ejegg can we roll this out more slow... [18:19:44] Fundraising Sprint Ewoks Take Manhattan, Fundraising Sprint Fistful of $variables, Fundraising-Backlog, MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review: Send message to opt-in queue on failed payments attempts with opt_in=1 - https://phabricator.wikimedia.org/T216293 (CCogdill_WMF... [18:43:35] fundraising-tech-ops: upgrade fundraising puppetmasters to Debian Buster - https://phabricator.wikimedia.org/T219315 (Jgreen) as of 3/28 heka=stretch, frpm1001=jessie [19:33:33] (PS13) Jgleeson: Create queue consumer for contribution tracking messages [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/498413 [19:38:32] Fundraising Sprint Ewoks Take Manhattan, Fundraising Sprint Fistful of $variables, Fundraising-Backlog, MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review: Send message to opt-in queue on failed payments attempts with opt_in=1 - https://phabricator.wikimedia.org/T216293 (Ejegg) @CCog... [19:43:38] (CR) jerkins-bot: [V: -1] Create queue consumer for contribution tracking messages [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/498413 (owner: Jgleeson) [20:13:00] (Abandoned) Mepps: Insert a job into the queue because in this case it is not fast enough to wait for run Would love testing on this patch [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/459843 (owner: Mepps) [20:18:58] (PS8) XenoRyet: WIP: c_t ids from the sequence generator [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/496351 (https://phabricator.wikimedia.org/T215462) [20:25:45] Wikimedia-Fundraising-Banners, donate.wikimedia.org: Try adding inline errors instead of alerts for missing amount/opt-in - https://phabricator.wikimedia.org/T205701 (Pcoombe) Open→Resolved a:Pcoombe This is done on donate.wikimedia.org now as well. See the `donationForm.validate` method in h... [20:43:03] Fundraising-Backlog: Payments wiki form variant with employer field - https://phabricator.wikimedia.org/T219558 (spatton) [20:48:22] Fundraising-Backlog: Payments wiki form variant with employer field - https://phabricator.wikimedia.org/T219558 (DStrine) We can try to look into this soon. However we're pretty wary of putting fields right into the banner for security reasons. Adding an extra field to the form isn't usually that difficult. [20:49:14] Fundraising-Backlog: Payments wiki form variant with employer field - https://phabricator.wikimedia.org/T219558 (spatton) [20:50:38] Fundraising-Backlog: Payments wiki form variant with employer field - https://phabricator.wikimedia.org/T219558 (spatton) For sure @DStrine ! I think I used confusing language in my initial task; we won't be putting any new forms **in** the banner, just running a test w/ one banner pointing to the standard p... [20:51:06] Fundraising-Backlog: Payments wiki form variant with employer field - https://phabricator.wikimedia.org/T219558 (CaitVirtue) Nora's traveling, so I'm jumping in. 1. The field should not be required. 2. Yes, we can include explainer text. "See if your employer will match your donation!" or somesuch.... [21:06:15] fundraising-tech-ops: upgrade fundraising puppetmasters to Debian Buster - https://phabricator.wikimedia.org/T219315 (Jgreen) >>! In T219315#5067074, @Jgreen wrote: > as of 3/28 heka=stretch, frpm1001=jessie Now heka=buster! [21:09:20] fundraising-tech-ops: upgrade fundraising puppetmasters to Debian Buster - https://phabricator.wikimedia.org/T219315 (Jgreen) a:Jgreen [21:37:01] Fundraising Sprint Ewoks Take Manhattan, Fundraising Sprint Fistful of $variables, Fundraising-Backlog, MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review: Send message to opt-in queue on failed payments attempts with opt_in=1 - https://phabricator.wikimedia.org/T216293 (CCogdill_WMF... [22:02:50] (PS9) XenoRyet: c_t ids from the sequence generator [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/496351 (https://phabricator.wikimedia.org/T215462) [22:03:46] (CR) Ejegg: "Couple of possibilities to look into for the external preview, without saving anything to the database:" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/497611 (https://phabricator.wikimedia.org/T208125) (owner: Vedmaka Wakalaka) [22:35:01] (CR) Ejegg: [C: +2] "Thankss!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/499683 (owner: Eileen) [22:36:21] ejegg: lols [22:37:08] :) [22:39:12] (CR) Vedmaka Wakalaka: "> Patch Set 12:" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/497611 (https://phabricator.wikimedia.org/T208125) (owner: Vedmaka Wakalaka) [22:40:41] (Merged) jenkins-bot: Extra s for Elliott [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/499683 (owner: Eileen) [22:54:46] (CR) Ejegg: [C: +2] Additional test check [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/499684 (owner: Eileen) [22:58:21] Fundraising-Backlog: Create separate export file for non-donor opt-in contacts - https://phabricator.wikimedia.org/T219574 (CCogdill_WMF) [22:58:37] Fundraising-Backlog: Create separate export file for non-donor opt-in contacts - https://phabricator.wikimedia.org/T219574 (CCogdill_WMF) p:Triage→Normal [23:00:44] (Merged) jenkins-bot: Additional test check [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/499684 (owner: Eileen) [23:07:14] Fundraising Sprint Ewoks Take Manhattan, Fundraising Sprint Fistful of $variables, Fundraising-Backlog, MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review: Send message to opt-in queue on failed payments attempts with opt_in=1 - https://phabricator.wikimedia.org/T216293 (CCogdill_WMF... [23:08:20] (PS1) Ejegg: Use special form variant for redirect to hosted Connect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/499942