[01:04:48] <wikibugs>	 (PS3) Ejegg: WIP: fancy variant for opt-in page [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/498287 (https://phabricator.wikimedia.org/T218240)
[01:09:54] <wikibugs>	 Fundraising Sprint Fistful of $variables, Fundraising-Backlog, FR-Ingenico, MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review: rate of GC50 errors from 3DS in Sweden - https://phabricator.wikimedia.org/T219445 (Ejegg) p:Triage→High
[05:14:18] <wikibugs>	 (CR) AndyRussG: "Hi! Just a few more thoughts:" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/497611 (https://phabricator.wikimedia.org/T208125) (owner: Vedmaka Wakalaka)
[12:55:17] <wikibugs>	 (PS14) Jgleeson: Create queue consumer for contribution tracking messages [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/498413
[14:00:38] <wikibugs>	 Fundraising-Backlog: Successful Ingenico donors not transitioning to TY page 3/29 - https://phabricator.wikimedia.org/T219636 (MBeat33)
[14:28:52] <wikibugs>	 (CR) Reedy: "Any reason we can't move forward with this? ;)" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/493978 (https://phabricator.wikimedia.org/T217498) (owner: Reedy)
[14:38:49] <wikibugs>	 (PS15) Jgleeson: Create queue consumer for contribution tracking messages and add drush command to call it. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/498413
[14:46:10] <wikibugs>	 (PS16) Jgleeson: Create queue consumer for contribution tracking messages and add drush command to call it. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/498413
[14:48:21] <wikibugs>	 (PS17) Jgleeson: Create queue consumer for contribution tracking messages and add drush command to call it. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/498413
[14:50:29] <wikibugs>	 (PS18) Jgleeson: Create queue consumer for contribution tracking messages and add drush command to call it. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/498413
[15:05:48] <wikibugs>	 (PS19) Jgleeson: Create queue consumer for contribution tracking messages and add drush command to call it. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/498413
[15:34:00] <jgleeson>	 hey ejegg
[15:34:21] <ejegg>	 hi jgleeson
[15:34:48] <jgleeson>	 when reviewing 	AndyRussG's EventBus patches, did you need to install EventGate for mediawiki to try it out?
[15:34:58] <jgleeson>	 I'm reading up on it now
[15:35:19] <jgleeson>	 I noticed there is a vagrant role we can use to play with it
[15:35:24] <ejegg>	 jgleeson: I still haven't reviewed those, just the vanilla CentralNotice one that creates the hook
[15:35:31] <jgleeson>	 ah ok
[15:35:37] <AndyRussG|ish>	 ejegg: jgleeson I installed just the eventbus vagrant role for that, it brought everything automagically
[15:35:50] <AndyRussG|ish>	 just had to tweak one little file to make it work
[15:35:59] <AndyRussG|ish>	 yeah Analytics reviewed those for us
[15:36:10] <jgleeson>	 AndyRussG|ish, I'm in two minds as to continue the review without chatting with you
[15:36:18] <jgleeson>	 as I mind end up down a rabbit hole
[15:36:29] <jgleeson>	 Might be best to catch up with you next week?
[15:36:36] <jgleeson>	 prior to jumping in
[15:36:52] <jgleeson>	 I might*
[15:37:09] <jgleeson>	 whatcha think?
[15:37:19] <AndyRussG|ish>	 jgleeson: yeah I think it makes more sense for me to give an overview of how it all fits together first?
[15:37:37] <AndyRussG|ish>	 maybe u can get a head start by installing a vagrant with only that role tho!
[15:37:52] <AndyRussG|ish>	 and then manually installing CentralNotice extension in the mw in that Vagrant?
[15:37:53] <jgleeson>	 sounds good, I'll do that
[15:37:59] <AndyRussG|ish>	 thanks so much BTW!!!!
[15:38:18] <jgleeson>	 thank you for giving us such cool stuff to review!
[15:39:29] <AndyRussG|ish>	 jgleeson hehe maybe it's just cool 'cause I took so long with it so it's like it's been sitting in the freezer forever? 8p
[15:39:40] <jgleeson>	 :)
[17:02:34] <wikibugs>	 Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 4 others: Iterate on DS fredge query - https://phabricator.wikimedia.org/T219646 (DStrine)
[17:04:37] <wikibugs>	 Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 4 others: Iterate on DS fredge query - https://phabricator.wikimedia.org/T219646 (DStrine)
[17:16:35] <wikibugs>	 Fundraising Sprint Fistful of $variables, Fundraising-Backlog: Successful Ingenico donors not transitioning to TY page 3/29 - https://phabricator.wikimedia.org/T219636 (DStrine)
[17:35:00] <wikibugs>	 (PS1) Ejegg: For full redirect, process immediately on return [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/500084 (https://phabricator.wikimedia.org/T219636)
[17:37:15] <jgleeson_>	 ejegg, just bring up vagrant to test that
[17:37:20] <jgleeson_>	 bringing*
[17:38:49] <wikibugs>	 (PS2) Krinkle: ext.centralNotice.geoIP: Remove redundant variable, and use then() [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/497644
[17:39:24] <wikibugs>	 (PS1) Ejegg: Fix Ingenico UI modules loaded for emailExplain variant [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/500085
[17:39:57] <ejegg>	 fr-tech ^^^ will fix the emailExplain variant
[17:40:09] <jgleeson_>	 that over the previous?
[17:40:21] <ejegg>	 that fixes one thing
[17:40:28] <ejegg>	 and the previous fixes another
[17:40:39] <jgleeson_>	 cool
[17:40:40] <ejegg>	 the variant fix is way simpler though
[17:42:31] <ejegg>	 cstone: that variant fix explains why prod was loading the wrong javascript for ingenico
[17:43:12] <ejegg>	 basically, the 'variant' mechanism completely replaces files in config.yaml
[17:43:17] <ejegg>	 rather than adding to them
[17:43:25] <ejegg>	 so we have to copy the contents and modify
[17:43:35] <ejegg>	 maybe not the best
[17:44:37] <jgleeson_>	 hmm if I add emailExplain variant to url without the newpatch
[17:44:46] <jgleeson_>	 I still see in the module loader
[17:44:48] <jgleeson_>	 mw.loader.implement("ext.donationInterface.ingenico-hosted", ["/w/extensions/DonationInterface/ingenico_gateway/forms/js/ingenico.js?9b264"], {
[17:44:48] <jgleeson_>	     "url": {
[17:44:48] <jgleeson_>	         "all": ["/w/extensions/DonationInterface/ingenico_gateway/forms/css/ingenico.css?443b4"]
[17:44:48] <jgleeson_>	     }
[17:44:49] <jgleeson_>	 });
[17:44:54] <wikibugs>	 (CR) Ejegg: "Hmm, we could also add &liberated=1 to the return URL" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/500084 (https://phabricator.wikimedia.org/T219636) (owner: Ejegg)
[17:46:00] <ejegg>	 jgleeson_: are you on fundraising/REL1_31 ?
[17:46:06] <jgleeson_>	 ah no
[17:46:12] <jgleeson_>	 still 1_27
[17:46:17] <jgleeson_>	 I think
[17:46:19] <ejegg>	 ok, try it on 1_31
[17:46:21] <jgleeson_>	 let me check
[17:47:44] <ejegg>	 hmm, no, 1.27 had the same error
[17:48:22] <ejegg>	 and prod is definitely loading the scripts from globalcollect_gateway with variant=emailExplain
[17:51:41] <jgleeson_>	 ah it's not straightforward for me to pull down 1_31
[17:51:51] <jgleeson_>	 the vagrant mw clone is some type of branch only thing
[17:51:56] <jgleeson_>	 which I have to undo to pull other branches
[17:51:59] <jgleeson_>	 from the remote
[17:51:59] <ejegg>	 oh weird
[17:52:05] <jgleeson_>	 I've run into this before
[17:52:17] <jgleeson_>	 it'll take a few mins to remember
[17:53:15] <ejegg>	 ohhhh, one other thing - I'm not sure if the variants directory is actually configured in vagrant!
[17:53:31] <ejegg>	 lemme add a patch for that
[17:53:48] <jgleeson_>	 erm I think I have them
[17:53:53] <jgleeson_>	 mediawiki-fr/form_variants/emailExplain/ingenico/ui_modules.yaml
[17:54:49] <ejegg>	 and LocalSettings had wgDonationInterfaceVariantConfigurationDirectory set to /vagrant/mediawiki-fr/form_variants ?
[17:55:10] <ejegg>	 ah, that setting is indeed in donation_interface.pp
[17:55:33] <ejegg>	 well, does the emailExplain variant add the emailExplain javascript?
[17:58:17] <ejegg>	 jgleeson_: ^^ ?
[17:58:49] <jgleeson_>	 it doesn't look like it is
[17:58:53] <jgleeson_>	 was just trying to work out why
[17:58:55] <jgleeson_>	 as it used to work
[18:00:21] <ejegg>	 fr-tech are the variants working for anyone else ?
[18:00:50] <ejegg>	 also: https://gerrit.wikimedia.org/r/483914 (vagrant patch to use REL1_31 for payments)
[18:01:23] <jgleeson_>	 ah man this git branch lock thing is annoying
[18:01:37] <jgleeson_>	 it's like a lightweight checkout which breaks the link to the remote
[18:01:57] <jgleeson_>	 I'll dig it out in puppet
[18:03:42] <ejegg>	 cstone: can you test this variant fix? https://gerrit.wikimedia.org/r/500085
[18:08:05] <jgleeson_>	 ok in my .git/config I had to replace:
[18:08:29] <jgleeson_>	 fetch = +refs/heads/fundraising/REL1_27:refs/remotes/origin/fundraising/REL1_27
[18:08:30] <jgleeson_>	 with
[18:08:36] <ejegg>	 oh, interesting!
[18:08:38] <jgleeson_>	 fetch = +refs/heads/*:refs/remotes/origin/*
[18:08:44] <jgleeson_>	 to get all branches
[18:08:49] <ejegg>	 didn't know you could do that in gitconfig
[18:08:50] <jgleeson_>	 that REALLY should be easier
[18:09:01] <ejegg>	 I guess it makes sense to save disk space
[18:09:04] <cstone>	 ejegg testing it now
[18:09:06] <ejegg>	 since that's a HUGE repo
[18:09:51] <jgleeson_>	 yeah
[18:10:48] <jgleeson_>	 composer installin
[18:11:05] <jgleeson_>	 so this form variant config
[18:11:12] <cstone>	 hmm would I need to do the same thing jgleeson_  is doing somehow I've broken everything now
[18:11:23] <jgleeson_>	 :(
[18:11:45] <jgleeson_>	 cstone, are you already on mw 1_31?
[18:11:52] <jgleeson_>	 if so, no, you're ok
[18:11:59] <cstone>	 i am not
[18:12:19] <ejegg>	 https://gerrit.wikimedia.org/r/483914
[18:12:43] <jgleeson_>	 ejegg, I think that only helps newly build vagrant boxes
[18:12:57] <ejegg>	 ah, it doesn't switch existing repos?
[18:13:04] <jgleeson_>	 reprovisioning won't run the clone again I don't think
[18:13:34] <jgleeson_>	 I will try to confirm once I've test the patch
[18:14:44] <jgleeson_>	 also I think whatever $wg vars we need for variants can be added here https://github.com/wikimedia/mediawiki-vagrant/blob/master/puppet/modules/payments/manifests/donation_interface.pp
[18:15:38] <ejegg>	 jgleeson_: yeah, the wgDonationInterfaceVariantConfigurationDirectory is already in there
[18:15:58] <jgleeson_>	 ah ok then
[18:16:10] <jgleeson_>	 that's interesting
[18:16:19] <jgleeson_>	 because I don't see it in the usual file
[18:16:21] <ejegg>	 Ah, I just added that mid-february
[18:16:28] <jgleeson_>	 ah ok
[18:16:34] <ejegg>	 so if you haven't rebuilt lately that might be the issue
[18:16:42] <jgleeson_>	 yeah that'll be it I'm guessin
[18:18:00] <jgleeson_>	 ok ejegg  I see the failure
[18:18:02] <jgleeson_>	 in 1_31
[18:18:07] <jgleeson_>	 now pulling down your patch
[18:18:07] <ejegg>	 ok, cool
[18:18:16] <jgleeson_>	 s/failure/globalcollect script/
[18:18:28] <ejegg>	 heh, that's a failure
[18:20:37] <ejegg>	 ok, gonna make some lunch. back in a bit!
[18:20:38] <jgleeson_>	 ok now I see the expected include
[18:21:54] <jgleeson_>	 umm
[18:22:12] <jgleeson_>	 I was expecting to get kicked out to a 3ds secure page ejegg|food after adding:
[18:22:17] <jgleeson_>	 $wgDonationInterface3DSRules = [ 'USD' => [] ];
[18:22:22] <jgleeson_>	 to my localsettings
[18:22:31] <jgleeson_>	 but it just processed the donation as usual
[18:24:07] <wikibugs>	 (CR) Jgleeson: [C: +2] "includes the correct scripts for me." [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/500085 (owner: Ejegg)
[18:24:32] <jgleeson_>	 I've +2'd it anyway as the patch works, maybe just not my follow on config to trigger the 3ds pages
[18:24:57] <jgleeson_>	 now I need to finish creating a mothers day card off the kids for roxy before the cut off!
[18:27:11] <wikibugs>	 (Merged) jenkins-bot: Fix Ingenico UI modules loaded for emailExplain variant [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/500085 (owner: Ejegg)
[18:39:08] <ejegg|food>	 jgleeson|away: oh shoot, right, Ingenico's sandbox only has 3DS enabled for Maestro
[18:39:13] <ejegg|food>	 and we don't offer that anywhere
[18:39:21] <ejegg|food>	 so that's annoying
[18:41:15] <ejegg>	 !log updated payments-wiki from 4b49bb7333 to 793bce1a5f
[18:41:18] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log
[20:38:12] <wikibugs>	 (CR) AndyRussG: "Ah also btw regarding the banner display bug for CN admins: while I didn't track it down 100%, it looked like it was coming from Special:B" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/497611 (https://phabricator.wikimedia.org/T208125) (owner: Vedmaka Wakalaka)
[21:14:57] <wikibugs>	 Fundraising-Backlog, Analytics, Analytics-EventLogging, Analytics-Kanban, and 2 others: Fix EventLogging schemas that use array for items type - https://phabricator.wikimedia.org/T218617 (Nuria) So, from :  https://tools.ietf.org/html/draft-zyp-json-schema-03#section-5.5  "When this attribute val...
[21:58:56] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Importing Activity Updates - https://phabricator.wikimedia.org/T219191 (Eileenmcnaughton) This extension looks like it might be worth considering https://lab.civicrm.org/extensions/batchupdateactivitystatus - it gets past the 100 limit  No unit test but...
[22:14:40] <ejegg>	 fr-tech any feedback on this? https://gerrit.wikimedia.org/r/500084 I think that issue is pretty urgent
[23:09:36] <wikibugs>	 (PS4) Ejegg: WIP: fancy variant for opt-in page [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/498287 (https://phabricator.wikimedia.org/T218240)
[23:14:07] <wikibugs>	 (CR) jerkins-bot: [V: -1] WIP: fancy variant for opt-in page [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/498287 (https://phabricator.wikimedia.org/T218240) (owner: Ejegg)