[00:04:13] (PS9) Ejegg: WIP: fancy variant for opt-in page [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/498287 (https://phabricator.wikimedia.org/T218240) [02:33:45] (PS10) Ejegg: Fancy variant for opt-in page [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/498287 (https://phabricator.wikimedia.org/T218240) [02:36:29] (CR) jerkins-bot: [V: -1] Fancy variant for opt-in page [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/498287 (https://phabricator.wikimedia.org/T218240) (owner: Ejegg) [03:04:39] (PS11) Ejegg: Fancy variant for opt-in page [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/498287 (https://phabricator.wikimedia.org/T218240) [05:51:24] (PS1) Eileen: Stock civicrm 5.13 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/500646 [05:51:26] (PS1) Eileen: WMF civicrm updates re-applied to 5.13 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/500647 [05:56:05] (CR) jerkins-bot: [V: -1] WMF civicrm updates re-applied to 5.13 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/500647 (owner: Eileen) [05:56:58] (CR) jerkins-bot: [V: -1] Stock civicrm 5.13 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/500646 (owner: Eileen) [06:04:16] (PS1) Eileen: Extensions update for 5.13 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/500649 [06:05:35] (CR) jerkins-bot: [V: -1] Extensions update for 5.13 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/500649 (owner: Eileen) [06:11:57] (PS2) Eileen: Extensions update for 5.13 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/500649 [06:31:34] (PS3) Eileen: Extensions update for 5.13 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/500649 [07:09:17] (PS4) Eileen: Extensions update for 5.13 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/500649 [07:31:16] (PS1) Eileen: Hack to show links on completed [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/500659 [07:36:50] (CR) jerkins-bot: [V: -1] Hack to show links on completed [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/500659 (owner: Eileen) [07:41:04] (PS2) Eileen: Update primary location fix to also fix when more than one option [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/499687 (https://phabricator.wikimedia.org/T218616) [07:41:06] (PS2) Eileen: Update query to not treat blank location types as duplicate [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/499688 (https://phabricator.wikimedia.org/T218616) [07:41:08] (PS2) Eileen: Add a check to fix blank location types [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/499689 (https://phabricator.wikimedia.org/T218616) [07:41:10] (PS5) Eileen: Extensions update for 5.13 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/500649 [07:41:12] (PS1) Eileen: Fix group name in test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/500663 [12:50:56] (PS20) Jgleeson: Create queue consumer for contribution tracking messages and add drush command to call it. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/498413 [13:42:50] (CR) Jgleeson: "I just realised I think we're missing the wgEnableContributionTrackingQueue flag in the extension.json file. I'm guessing we want this?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/496351 (https://phabricator.wikimedia.org/T215462) (owner: XenoRyet) [13:45:06] (CR) Jgleeson: "sorry that was meant to be wgDonationInterfaceEnableSequenceGenerator, is missing from the extensins.json file." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/496351 (https://phabricator.wikimedia.org/T215462) (owner: XenoRyet) [14:03:36] ejegg|away: fr-tech would you say this one is "done", at least in the sense of, can be moved to the "done" column? https://phabricator.wikimedia.org/T219214 [14:06:07] AndyRussG, looks reviewed to me :) [14:06:13] I'd say it can go [14:06:18] jgleeson: k thx! [14:08:08] K done the doning [14:09:14] :> [14:14:30] (CR) Jgleeson: "actually, it looks like we are going to use 'wgEnableContributionTrackingQueue' but the commit message is just out of date." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/496351 (https://phabricator.wikimedia.org/T215462) (owner: XenoRyet) [14:19:53] (CR) Jgleeson: "ok... now I'm thinking it might need to be a concatenation of the two, so '$wgDonationInterfaceEnableContributionTrackingQueue'" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/496351 (https://phabricator.wikimedia.org/T215462) (owner: XenoRyet) [14:57:08] (CR) Ejegg: "Yep jgleeson, it's that concatenated thing that we need in extension.json and README" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/496351 (https://phabricator.wikimedia.org/T215462) (owner: XenoRyet) [15:12:54] Fundraising Sprint Fistful of $variables, Fundraising-Backlog: Rollback upgrade and create plan for shorter tests - https://phabricator.wikimedia.org/T219798 (Jgreen) >>! In T219798#5075745, @mepps wrote: > Our next step is to update the CSP settings, and test both ourselves, and see if we can get any in... [15:15:45] (CR) Ejegg: [C: -1] "Mostly looking good, just need to distinguish between the contribution_id and contribution_tracking_id. We may also need to include a data" (9 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/498413 (owner: Jgleeson) [15:16:48] (PS21) Jgleeson: Create queue consumer for contribution tracking messages and add drush command to call it. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/498413 [15:18:39] thanks for the review ejegg! I'll take a look now. That last update I've just pushed is to clean up some naming confusing around the contribution tracking id being named both 'id' and 'contribution_id' during the life of the command [15:20:16] also ejegg, in my drupal.contribution_tracking table I only seen contribution_id [15:21:41] see* [15:22:17] sure thing! [15:22:33] jgleeson so, contribution_id is actually a foreign key [15:22:40] to the civicrm_contribution table [15:22:59] what we call contribution_tracking_id should be the 'id' column from drupal.contribution_tracking [15:23:48] hmmm [15:24:36] when chatting it through with XenoRyet, he was under the impression we were using contribution_id as the new field and leaving id alone but from what you're saying it sounds like we're removing the AI from id? [15:24:40] and using that [15:25:07] jgleeson we don't have a contribution_id until the donation queue consumer inserts into civicrm_contribution [15:25:18] and there are a lot of donation attempts that never get that far [15:25:37] ah ok, probably just a mix up [15:25:46] so we need the contribution_tracking_id to e.g. correlate fredge rows with the contribution_tracking data [15:25:55] so I need to drop the AI PK and insert the ct_id to the id field on the ct db tbl? [15:26:11] yep yep! [15:26:18] cool, will update [15:26:22] it can still be a PK, just not autoincrement [15:26:32] got it [15:26:57] how do we manage schema revisions in DI? [15:27:18] ignore that [15:28:04] ejegg, I'm guessing I need to add a schema update in the drupal module install also [15:28:17] yeah! Let's see if there's a good example to follow [15:29:08] OK, so let's add a new .install file [15:29:17] and not put it in the wmf_civicrm one [15:29:32] that way it'll be easy to put this code up there and not apply the update till we're ready [15:30:33] hmmm [15:31:16] so we don't want it in queue2civicrm/contribution_tracking ? [15:31:54] I could create separate patches for that change [15:34:23] jgleeson yeah, I think we do want it there [15:37:10] cool. just gonna go pick Oscar up from nursery and then I'll add that in when I get back [15:44:24] (CR) Ejegg: [C: -2] "relies on now-reverted patch, revisit later" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/500084 (https://phabricator.wikimedia.org/T219636) (owner: Ejegg) [15:44:35] (CR) Ejegg: [C: -2] "relies on now-reverted patch, revisit later" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/499807 (owner: Ejegg) [15:45:06] (CR) Ejegg: [C: -2] "relies on now-reverted patch, revisit later" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/499942 (owner: Ejegg) [15:46:11] (CR) Ejegg: [C: +2] Revert "Ingenico connect: Always redirect when using 3DS" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/500555 (owner: Ejegg) [15:48:52] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/500770 [15:54:05] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/500770 (owner: Ejegg) [16:10:25] Fundraising-Backlog, Analytics: CentralNoticeImpression refined impressionEventSampleRate is int instead of double - https://phabricator.wikimedia.org/T217109 (Milimetric) @DStrine can you let us know what you'd like to do here? It's not technically complicated, but it's a little time sensitive in case... [16:13:53] Fundraising Sprint Fistful of $variables, Fundraising-Backlog: Rollback upgrade and create plan for shorter tests - https://phabricator.wikimedia.org/T219798 (Ejegg) payments.frdev tested in Firefox and Chrome on Linux, working well. We can use the links from https://etherpad.wikimedia.org/p/PaymentsPhp... [16:14:45] (PS1) Ejegg: Switch for sending opt-in on payment failure [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/500776 (https://phabricator.wikimedia.org/T216293) [16:20:06] (PS2) Ejegg: Switch for sending opt-in on payment failure [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/500776 (https://phabricator.wikimedia.org/T216293) [16:20:14] jeez, zuul is slooooowwwwww again today [16:20:33] fr-tech I think PS2 ^^^ would be good to have [16:20:44] ccogdill asked for that switch [16:20:52] pretty simple patch to review [16:21:02] I'll take a look [16:25:51] (Merged) jenkins-bot: Revert "Ingenico connect: Always redirect when using 3DS" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/500555 (owner: Ejegg) [16:26:49] (CR) Ejegg: "Oops, I just looked at XenoRyet's patch again, and it looks like the incoming ct_id is in the messages just as 'id'." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/498413 (owner: Jgleeson) [16:26:53] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/500770 (owner: Ejegg) [16:27:28] (CR) XenoRyet: [C: +2] "Simple and effective" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/500776 (https://phabricator.wikimedia.org/T216293) (owner: Ejegg) [16:32:56] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/500781 [16:33:00] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/500781 (owner: Ejegg) [16:43:09] (CR) XenoRyet: "Right, forgot to do that bit." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/496351 (https://phabricator.wikimedia.org/T215462) (owner: XenoRyet) [16:46:50] (PS10) XenoRyet: c_t ids from the sequence generator [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/496351 (https://phabricator.wikimedia.org/T215462) [16:54:58] (Merged) jenkins-bot: Switch for sending opt-in on payment failure [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/500776 (https://phabricator.wikimedia.org/T216293) (owner: Ejegg) [16:55:02] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/500781 (owner: Ejegg) [17:15:19] (PS1) Ejegg: Update DonationInterface [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/500791 [17:16:17] (CR) Ejegg: [C: +2] Update DonationInterface [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/500791 (owner: Ejegg) [17:32:07] Fundraising-Backlog, FR-Amazon, MediaWiki-extensions-DonationInterface: Amazon Pay form missing donate button on iPhone - https://phabricator.wikimedia.org/T219905 (Ejegg) [17:35:24] (Merged) jenkins-bot: Update DonationInterface [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/500791 (owner: Ejegg) [17:37:37] !log updated payments-wiki-staging from 793bce1a5f to 15bcb3d1a6 [17:37:39] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [17:39:28] (CR) jenkins-bot: Update DonationInterface [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/500791 (owner: Ejegg) [18:47:09] Fundraising Sprint Fistful of $variables, Fundraising-Backlog: Rollback upgrade and create plan for shorter tests - https://phabricator.wikimedia.org/T219798 (Ejegg) Tested on Win10 (IE11 & Edge) and iPhone / safari. No problems, except one with Amazon on iPhone that seems to be present on both versions... [18:51:45] (CR) Ejegg: "Maybe the one with the highest ID would actually be better, as the most recently entered one?" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/499687 (https://phabricator.wikimedia.org/T218616) (owner: Eileen) [19:25:24] can I get a +2 on this super easy one https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/500663/ so I can retry some tests [19:26:05] (CR) Ejegg: [C: +2] Fix group name in test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/500663 (owner: Eileen) [19:29:27] fr-tech can someone with vagrant +2 give a vote on this? https://gerrit.wikimedia.org/r/483914 [19:29:56] jgleeson: do you have +2 in the vagrant repo? [19:30:09] This is still waiting for review: https://gerrit.wikimedia.org/r/483914 [19:30:22] looks like I do [19:30:27] nice nice! [19:30:34] (Merged) jenkins-bot: Fix group name in test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/500663 (owner: Eileen) [19:30:41] yeah I wanted to run it from a state of having 1_27 on [19:30:51] to see if puppet picks up the change and pulls the latest [19:30:55] I have a feel it won't [19:31:00] although I've not confirmed it [19:31:02] jgleeson: I think you just need to destroy and delete the dir [19:31:33] yeah I guess if it just works on the initial build that's good enough [19:32:01] and if we don't have a precedent of expecting things to update already build checkouts, seems unfair to expect that of your patch :P [19:32:10] built* [19:33:13] oh man, ejegg the idea of destroying my payments wiki dir gives me shudders [19:33:21] I'll rename it for now [19:33:25] oops we have a call! [19:33:29] coming fr-tech [19:37:38] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/500646 (owner: Eileen) [19:37:53] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/500647 (owner: Eileen) [19:42:02] (CR) jerkins-bot: [V: -1] Stock civicrm 5.13 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/500646 (owner: Eileen) [19:42:18] (CR) jerkins-bot: [V: -1] WMF civicrm updates re-applied to 5.13 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/500647 (owner: Eileen) [19:44:44] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/500647 (owner: Eileen) [19:47:14] Fundraising Sprint Da Vinci Coder, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic, and 2 others: Reflect all undeliverables via Silverpop in CiviCRM - https://phabricator.wikimedia.org/T161761 (Eileenmcnaughton) [19:47:17] Fundraising Sprint Fistful of $variables, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email, Patch-For-Review: Create job to set the field civicrm_email.on_hold to 1 for hard bounce & reply mail block - https://phabricator.wikimedia.org/T217603 (Eileenmcnaughton) Open→Resolv... [19:49:00] (CR) jerkins-bot: [V: -1] WMF civicrm updates re-applied to 5.13 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/500647 (owner: Eileen) [20:09:15] fundraising-tech-ops: upgrade fundraising puppetmasters to Debian Buster - https://phabricator.wikimedia.org/T219315 (Jgreen) [20:12:47] Fundraising Sprint Fistful of $variables, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Civi recurring donation cancel metric request - https://phabricator.wikimedia.org/T218616 (Eileenmcnaughton) a:Eileenmcnaughton I got the cancel_reason field we discussed added upst... [20:13:29] Fundraising Sprint Fistful of $variables, Fundraising-Backlog, FR-Ingenico, MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review: rate of GC50 errors from 3DS in Sweden - https://phabricator.wikimedia.org/T219445 (Ejegg) Open→Resolved [20:13:38] Fundraising Sprint Fistful of $variables, Fundraising-Backlog, Patch-For-Review: Successful Ingenico donors not transitioning to TY page 3/29 - https://phabricator.wikimedia.org/T219636 (Ejegg) Open→Resolved [20:13:47] Fundraising Sprint Fistful of $variables, Fundraising-Backlog: Rollback upgrade and create plan for shorter tests - https://phabricator.wikimedia.org/T219798 (DStrine) [20:14:07] Fundraising Sprint Fistful of $variables, Fundraising-Backlog, FR-Ingenico: Ingenico: iframe / dropoff errors 3/30/19 - https://phabricator.wikimedia.org/T219783 (DStrine) [20:15:58] Fundraising-Backlog, FR-Amazon, MediaWiki-extensions-DonationInterface: Amazon Pay form missing donate button on iPhone - https://phabricator.wikimedia.org/T219905 (DStrine) [20:20:33] Fundraising Sprint G 2019, Fundraising-Backlog, FR-Amazon, MediaWiki-extensions-DonationInterface: Amazon Pay form missing donate button on iPhone - https://phabricator.wikimedia.org/T219905 (DStrine) [20:20:36] Fundraising Sprint Fistful of $variables, Fundraising Sprint G 2019, Fundraising-Backlog: Rollback upgrade and create plan for shorter tests - https://phabricator.wikimedia.org/T219798 (DStrine) [20:20:38] Fundraising Sprint G 2019, Fundraising-Backlog: Payments wiki form variant with employer field - https://phabricator.wikimedia.org/T219558 (DStrine) [20:20:41] Fundraising Sprint Fistful of $variables, Fundraising Sprint G 2019, Fundraising-Backlog: Review live banner preview - https://phabricator.wikimedia.org/T219214 (DStrine) [20:20:43] Fundraising Sprint G 2019, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Regular CiviCRM upgrade - https://phabricator.wikimedia.org/T218754 (DStrine) [20:20:46] Fundraising Sprint Fistful of $variables, Fundraising Sprint G 2019, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Civi recurring donation cancel metric request - https://phabricator.wikimedia.org/T218616 (DStrine) [20:20:48] Fundraising Sprint Ewoks Take Manhattan, Fundraising Sprint Fistful of $variables, Fundraising Sprint G 2019, Fundraising-Backlog, and 2 others: Update opt-in queue consumer to be able to create new donor records - https://phabricator.wikimedia.org/T217710 (DStrine) [20:20:50] Fundraising Sprint Ewoks Take Manhattan, Fundraising Sprint Fistful of $variables, Fundraising Sprint G 2019, Fundraising-Backlog, Patch-For-Review: Contacts with contributions being deleted - https://phabricator.wikimedia.org/T218061 (DStrine) [20:21:01] Fundraising Sprint Fistful of $variables, Fundraising Sprint G 2019, Fundraising-Backlog: Documentation: Simplify homepage - https://phabricator.wikimedia.org/T217178 (DStrine) [20:21:03] Fundraising Sprint Fistful of $variables, Fundraising Sprint G 2019, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: CRM contribution tracking writing should have a switch to use the new infrastructure - https://phabricator.wikimedia.org/T215463 (DStrine) [20:21:05] Fundraising Sprint Da Vinci Coder, Fundraising Sprint Ewoks Take Manhattan, Fundraising Sprint Fistful of $variables, Fundraising Sprint G 2019, and 3 others: DonationInterface should have an option to use new contribution_tracking infrastructure - https://phabricator.wikimedia.org/T215462 (DStrin... [20:21:07] Fundraising Sprint Fistful of $variables, Fundraising Sprint G 2019, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Create queue consumer for contribution tracking - https://phabricator.wikimedia.org/T215453 (DStrine) [20:21:10] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 7 others: Reduce recurring TY emails - https://phabricator.wikimedia.org/T213209 (DStrine) [20:21:12] Fundraising Sprint Da Vinci Coder, Fundraising Sprint Ewoks Take Manhattan, Fundraising Sprint Fistful of $variables, Fundraising Sprint G 2019, and 4 others: New message inclusion syntax strips with more than one class - https://phabricator.wikimedia.org/T216150 (DStrine) [20:21:15] Fundraising Sprint Fistful of $variables, Fundraising Sprint G 2019, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Activities tab- multi select option for exclude filter - https://phabricator.wikimedia.org/T203057 (DStrine) [20:21:16] Fundraising Sprint Fistful of $variables, Fundraising Sprint G 2019, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Search for name and org name in a 'the-agnositc way' in Civi - https://phabricator.wikimedia.org/T115536 (DStrine) [20:21:18] Fundraising Sprint Fistful of $variables, Fundraising Sprint G 2019, Fundraising-Backlog, Patch-For-Review: Create variants for fancy new opt in pages on payments wiki - https://phabricator.wikimedia.org/T218240 (DStrine) [20:21:22] Fundraising Sprint Da Vinci Coder, Fundraising Sprint Ewoks Take Manhattan, Fundraising Sprint Fistful of $variables, Fundraising Sprint G 2019, and 2 others: Re-run omnirecipient repair to catch the few missed ones - https://phabricator.wikimedia.org/T215865 (DStrine) [20:21:24] Fundraising Sprint Ewoks Take Manhattan, Fundraising Sprint Fistful of $variables, Fundraising Sprint G 2019, Fundraising-Backlog, and 2 others: Send message to opt-in queue on failed payments attempts with opt_in=1 - https://phabricator.wikimedia.org/T216293 (DStrine) [20:21:26] Fundraising Sprint Fistful of $variables, Fundraising Sprint G 2019, Fundraising-Backlog, fundraising-tech-ops, and 2 others: switch fundraising cases where we use GeoIP to GeoIP2 - https://phabricator.wikimedia.org/T215425 (DStrine) [20:21:29] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 6 others: Upgrade PaymentsWiki to Mediawiki 1.31 (new LT... - https://phabricator.wikimedia.org/T184460 [20:21:30] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 9 others: find another way to compile the donor list for... - https://phabricator.wikimedia.org/T118822 [21:03:34] cstone: https://payments.wiki.local.wmftest.net:4430/wiki/Special:FundraiserSubscribe?p=optin&e=a%40b.com&v=wle_001 [21:03:57] that link works for me, but due to a bug in the multiwiki setup the images are missing :( [21:05:11] you can see them if you check out the same revision in /vagrant/mediawiki/extensions/FundraisingEmailUnsubscribe [21:05:51] it might end up easier to set up mediawiki outside of vagrant... [21:06:01] certainly gets you better battery lige [21:06:03] *life [21:10:33] cstone does that work for you? [21:12:27] sorry was having internet connection issues but its back now! [21:13:53] the bug description https://phabricator.wikimedia.org/T218240 has a link to Trilogy's original design [21:14:15] ejegg, that works for me [21:14:25] although I don't have ssl role enabled so I had to browse via http [21:14:48] (after pulling down your patch) [21:14:56] great! [21:15:30] cstone, if you don't have ssl vagrant role enabled, you can use http://payments.wiki.local.wmftest.net:8080/wiki/Special:FundraiserSubscribe?p=optin&e=a%40b.com&v=wle_001 [21:15:56] It should add the variant to the opt-in queue message too, but so far we don't do anything with it on the consumer side [21:16:24] ah ok, so I can just submit the form and should expect to see a new redis list? [21:16:36] yep! [21:16:48] Opt in [21:16:48] An error occurred while attempting to process your request. Please contact donate@wikimedia.org. [21:16:58] Oh? Can you tell what the issue is? [21:16:58] I'll check syslog [21:17:31] ah thanks I'm somewhat seeing the page there but there's lots of PHP warnings investigating that now [21:17:46] cstone there are definitely two deprecation warnings [21:18:11] Apr 2 18:11:14 mwdebian9 FundraisingEmailUnsubscribe: (3641127839293) : Could not process '' or execute pre-existing session. [21:18:14] but here's how I want to solve those: https://phabricator.wikimedia.org/T218171 [21:18:30] jgleeson: oh weird, taking a look [21:18:43] I'm not sure if I actually sent anything after the last revision [21:19:09] ejegg, this might be because I've broken something with my crude approach at pulling down 1_31 [21:20:00] oh hey, I got an error too [21:20:41] ah, I need to fix my queue connection info [21:20:57] might need to add that to vagrant settings too? [21:21:42] yeah [21:21:57] dang thing is duplicating the queue info [21:22:05] again, see https://phabricator.wikimedia.org/T218171 [21:22:20] gotta jump off for a bit ejegg but I'll be back online later on to send my eod so I'll try it out then [21:22:51] oops, I need to do a quick errand. Back in 10 min ish [21:50:23] ejegg I was able to get the form loaded and am getting the same error jack saw [21:56:23] ok, can you tell where that's thrown? [21:58:13] (PS1) Eileen: Add extension to cleanup sort name for orgs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/500851 (https://phabricator.wikimedia.org/T115536) [22:02:47] (CR) jerkins-bot: [V: -1] Add extension to cleanup sort name for orgs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/500851 (https://phabricator.wikimedia.org/T115536) (owner: Eileen) [22:26:32] hey ejegg did you work out the issue with the opt in patch? [22:27:02] no, I'll take another look later [23:00:46] mepps: dstrine did either you have thoughts on that email draft before I send [23:49:45] (PS22) Jgleeson: WIP: Create queue consumer for contribution tracking messages and add drush command to call it. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/498413