[00:15:52] hmm stil trying to replicate gerrit test fail locally - have found another small local tweak which I will put up - sigh [00:17:18] (PS1) Eileen: Extra call to parent::tearDown [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/502364 [00:22:24] (PS1) Eileen: Add handling for relationship type already existing [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/502368 [00:22:41] (CR) jerkins-bot: [V: -1] Extra call to parent::tearDown [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/502364 (owner: Eileen) [00:24:48] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/502364 (owner: Eileen) [00:26:06] (PS2) Eileen: Update existing recurring records to hold payment processor ids [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/501132 (https://phabricator.wikimedia.org/T218616) [00:26:39] (PS2) Eileen: Add cancel_reason to cancel [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/501133 (https://phabricator.wikimedia.org/T218616) [00:26:49] (CR) jerkins-bot: [V: -1] Add handling for relationship type already existing [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/502368 (owner: Eileen) [00:30:00] (CR) jerkins-bot: [V: -1] Extra call to parent::tearDown [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/502364 (owner: Eileen) [00:31:27] ejegg: there is a weird new fail [00:31:48] oh fun, what's happening now? [00:32:37] BitpayFileTest::testImport [00:32:38] 12:29:58 Failed asserting that 'You have requested a non-existent service "prevnext.driver.". Did you mean one of these: "prevnext.driver.redis", "prevnext.driver.sql"?Array [00:32:59] err, this is with upgraded core? [00:33:09] we need new settings in test? [00:33:25] (PS2) Eileen: Extra call to parent::tearDown [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/502364 [00:33:26] no! [00:33:31] it’s on the old core [00:33:45] I’m just trying with the change being a no-change [00:34:02] see https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/502364/ [00:34:21] I wonder if the ci has a thing going on [00:40:32] ok - let’s just conclude it’s tricky [00:40:38] something about order of things [00:40:58] weird, I was just able to merge jgleeson's change: https://gerrit.wikimedia.org/r/498413 [00:41:42] yeah for some reason the tear down can’t load the cache - not clear why but I’ll ditch that change [00:42:11] Shall we do a co-ordinated add pay api to civi & remove from smashpig & deploy to get that out of the way? [00:42:44] sure, sounds like a good idea! [00:43:30] (PS1) Eileen: Add Pay api from 5.13 so we can remove it from smashpig [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/502374 [00:43:35] just pushed up the civi one ^^ [00:47:12] eileen: oh shoot, looks like the one in SmashPig has some extra handling [00:47:18] to pass through error codes [00:47:31] so we don't have to do horrible text parsing to get them out on the other side [00:47:46] we do kinda depend on that in SmashPig recurring [00:48:00] so we can have specific handling for different error cases [00:48:06] (CR) jerkins-bot: [V: -1] Add Pay api from 5.13 so we can remove it from smashpig [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/502374 (owner: Eileen) [00:48:09] i.e. retry or not [00:48:44] or increment the invoice ID [00:54:51] https://github.com/civicrm/civicrm-core/pull/14006 [00:54:59] I’ll try to get that merged [00:57:13] (PS2) Eileen: Add Pay api from 5.13 so we can remove it from smashpig [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/502374 [00:57:30] (PS1) Eileen: Remove smashpig version of pay api [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/502376 [00:57:45] ejegg: how can we get those past jenkins given the circularity? [00:58:54] eileen: we'd have to force one or the other [00:59:03] ejegg: yeah :-( [00:59:06] guess so [00:59:20] force the civi one I guess [00:59:28] then the other can incorporte the civi update [01:00:04] thanks for that pull request! [01:00:34] yeah I should be able to convince someone to merge it.... [01:00:40] I have a good bank of favours [01:01:06] (CR) jerkins-bot: [V: -1] Add Pay api from 5.13 so we can remove it from smashpig [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/502374 (owner: Eileen) [01:01:25] (CR) Ejegg: [V: +2 C: +2] "Forcing this so we can merge a dependent parent-repo patch" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/502374 (owner: Eileen) [01:02:56] (CR) jerkins-bot: [V: -1] Remove smashpig version of pay api [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/502376 (owner: Eileen) [01:03:08] (PS4) Eileen: Update to civicrm 5.13 stock [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/500646 (https://phabricator.wikimedia.org/T218754) [01:04:25] (PS2) Eileen: Remove smashpig version of pay api [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/502376 [01:04:44] ok hopefully that will pass! [01:07:00] (CR) jerkins-bot: [V: -1] Update to civicrm 5.13 stock [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/500646 (https://phabricator.wikimedia.org/T218754) (owner: Eileen) [01:07:56] (PS2) Eileen: Add handling for relationship type already existing [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/502368 [01:08:09] (Abandoned) Eileen: Extra call to parent::tearDown [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/502364 (owner: Eileen) [01:10:50] ejegg: it passed https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/502376/ [01:11:46] (CR) jerkins-bot: [V: -1] Add handling for relationship type already existing [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/502368 (owner: Eileen) [01:13:07] (CR) Ejegg: [C: +2] Remove smashpig version of pay api [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/502376 (owner: Eileen) [01:18:27] (Merged) jenkins-bot: Remove smashpig version of pay api [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/502376 (owner: Eileen) [01:19:34] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/500646 (https://phabricator.wikimedia.org/T218754) (owner: Eileen) [01:22:51] (PS1) Eileen: Remove smashpig version of pay api [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/502381 [01:23:12] ejegg: just deploying those changes - ct change broke my tests so a bit wary of it [01:23:25] (CR) Eileen: [C: +2] Remove smashpig version of pay api [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/502381 (owner: Eileen) [01:24:01] (Merged) jenkins-bot: Remove smashpig version of pay api [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/502381 (owner: Eileen) [01:24:17] (PS3) Ejegg: Add handling for relationship type already existing [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/502368 (owner: Eileen) [01:24:38] just checking if rebasing around that bit might help [01:24:56] (CR) jerkins-bot: [V: -1] Update to civicrm 5.13 stock [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/500646 (https://phabricator.wikimedia.org/T218754) (owner: Eileen) [01:27:24] ejegg: I’m pushing out the api change now [01:27:49] cool cool. We should watch the next run of the recurring charge job [01:27:57] !log civicrm revision changed from dfe89516b3 to d0e44a9e51, config revision is 2bcbf44521 [01:27:59] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:28:13] ejegg: do you watch from prod or log1001 [01:28:24] from prod [01:28:45] I think maybe the process-control logs don't go live to log1001 [01:29:01] for those it's more like a daily sync [01:30:52] it looks like it only runs every hour [01:33:45] ejegg: I can just do an extra run though? [01:34:39] eileen: hmm, and it may have already charged everything due today [01:34:48] ejegg: yeah.... [01:34:55] or... no, we're just past midnight UTC, so it should have some more to do [01:35:13] hmm, well, two runs in [01:35:18] you can try another run! [01:35:31] just do it under 'screen' [01:35:35] in case of disconnect [01:36:13] let's see, we didn't give that one a slow-start variant, did we? [01:36:32] we did! [01:36:38] so you can do [01:36:50] run-job recurring_smashpig_charge --slow-start [01:36:59] and it'll just try to charge one donation [01:37:49] Error code 300620: MERCHANTREFERENCE 60507345.6 ALREADY EXISTS [01:38:20] eileen: shoot [01:38:23] that seems kinda stuck [01:38:45] when we get that, we should increment the invoice ID and try again [01:38:53] but I think that might already have had problems [01:38:55] :( [01:39:09] I think if I don’t do slow start it will try more [01:39:14] https://phabricator.wikimedia.org/T218120 [01:39:21] but I guess maybe we’ve proven the pay worked? [01:39:43] it's certainly finding the method! [01:40:24] :-) [01:40:38] it looks like my local probs with contribution tracking one were lack of vendor update [01:41:19] aha! [01:41:37] hmm still failing [01:41:43] but something like that I guess [01:46:49] I got the go ahead to merge the pay tweak [01:46:53] (PS5) Eileen: Update to civicrm 5.13 stock [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/500646 (https://phabricator.wikimedia.org/T218754) [01:53:42] nice! [02:17:34] (PS2) Eileen: WMF civicrm updates re-applied to 5.13 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/500647 [02:20:47] (CR) jerkins-bot: [V: -1] WMF civicrm updates re-applied to 5.13 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/500647 (owner: Eileen) [02:21:24] (CR) Krinkle: Banner: Fix regex in non-unicode mode and class reference (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/501902 (owner: D3r1ck01) [02:25:28] (CR) Krinkle: [C: -1] Banner: Fix regex in non-unicode mode and class reference (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/501902 (owner: D3r1ck01) [02:44:05] (PS1) Ejegg: Update FundraisingEmailUnsubscribe extension [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/502383 [02:44:11] (CR) Ejegg: [C: +2] Update FundraisingEmailUnsubscribe extension [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/502383 (owner: Ejegg) [02:56:41] (PS1) Eileen: Add fix & test for handling of disabled languages [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/502384 [03:04:14] (PS2) Eileen: Hack to show links on completed [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/500659 [03:07:22] (CR) jerkins-bot: [V: -1] Hack to show links on completed [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/500659 (owner: Eileen) [03:10:35] (PS3) Eileen: Hack to show links on completed [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/500659 [03:10:52] (Merged) jenkins-bot: Update FundraisingEmailUnsubscribe extension [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/502383 (owner: Ejegg) [03:13:46] (CR) jerkins-bot: [V: -1] Hack to show links on completed [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/500659 (owner: Eileen) [03:15:40] (CR) jenkins-bot: Update FundraisingEmailUnsubscribe extension [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/502383 (owner: Ejegg) [06:27:15] PROBLEM - check_puppetrun on bismuth is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 9 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[initramfs-tools] [06:32:15] RECOVERY - check_puppetrun on bismuth is OK: OK: Puppet is currently enabled, last run 1 minute ago with 0 failures [07:15:21] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/500659 (owner: Eileen) [10:17:42] Fundraising-Backlog: Inaccurate placement for the currency symbol (SEK) in Sweden Thank you letter - https://phabricator.wikimedia.org/T220192 (jrobell) Thank you for the additional info here. I agree with @CCogdill_WMF here that we should just go ahead and remove the amount all together. Can that be done ea... [11:14:33] (PS1) Jgleeson: (DO NOT MERGE YET) Drop auto-increment behaviour from `id` field on contribution_tracking table as we're now generating them within DonationInterface to decouple the frontend from the backend db. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/502467 [11:16:38] (PS1) Jgleeson: Minor comments update to ContributionTrackingQueueTest [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/502468 [11:17:19] (CR) jerkins-bot: [V: -1] (DO NOT MERGE YET) Drop auto-increment behaviour from `id` field on contribution_tracking table as we're now generating them within DonationInterface to decouple the frontend from the backend db. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/502467 (owner: Jgleeson) [12:35:13] fundraising-tech-ops: EPIC: migrate fundraising off of Debian Jessie - https://phabricator.wikimedia.org/T185013 (Jgreen) [12:35:15] fundraising-tech-ops: build & deploy latest pybal for frack - https://phabricator.wikimedia.org/T176260 (Jgreen) [12:35:17] fundraising-tech-ops: migrate pay-lvs servers to Debian Stretch - https://phabricator.wikimedia.org/T185014 (Jgreen) Open→Resolved pay-lvs1001 and 1002 are done [13:54:34] (PS9) Mepps: Use banner instance variable sooner and check for errors in SpecialCentralNoticeBanners [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/501049 (https://phabricator.wikimedia.org/T149240) [14:11:19] Fundraising Sprint Greps of Wrath, Fundraising-Backlog: Payments wiki form variant with employer field - https://phabricator.wikimedia.org/T219558 (mepps) @CaitVirtue will we be checking if their employer matches the gift? If I saw that text on a donation form, I'd expect an automatic lookup. [14:12:17] Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising-Backlog: Documentation: Simplify homepage - https://phabricator.wikimedia.org/T217178 (mepps) I'm moving this to done, but more feedback is still welcome. [14:30:13] Fundraising Sprint Greps of Wrath, Fundraising-Backlog: Payments wiki form variant with employer field - https://phabricator.wikimedia.org/T219558 (NNichols) @mepps It's a great question and I just mentioned this to Caitlin V yesterday. The company we are thinking about working with after testing would... [14:31:49] Fundraising-Backlog, FR-Ingenico: 3DS iFrame errors after 4/8/19 upgrade - https://phabricator.wikimedia.org/T220512 (MBeat33) [14:32:34] Fundraising-Backlog, FR-Ingenico: 3DS iFrame errors after 4/8/19 upgrade - https://phabricator.wikimedia.org/T220512 (MBeat33) p:Triage→High I'm going to call this High priority as Sweden email3 is due to be sent this week. [14:36:15] (CR) D3r1ck01: Banner: Fix regex in non-unicode mode and class reference (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/501902 (owner: D3r1ck01) [14:39:01] fr-tech I'mma put out that fancy opt-in page now [14:39:16] cool ejegg! [14:40:23] \o/ [14:41:13] (PS4) D3r1ck01: Banner: Use self to reference class name in PHP and PHPDoc [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/501902 [14:42:07] ooh, my 3char confirmation codes were the same 3 letters, just with two transposed between them [14:42:26] !log updated payments-wiki from 15bcb3d1a6 to aa8dad50e7 [14:42:28] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [14:45:00] hmm, images not loading [14:45:21] ah, need to update the allow list? [14:47:17] hmm, that seems to be just wiki page titles [14:47:56] Jeff_Green: do you know what might be restricting access to images with paths like https://payments.wikimedia.org/extensions/FundraisingEmailUnsubscribe/templates/wle_001_files/640px-Satchari_National_Park_Habiganj_Sylhet.jpg ? [14:48:21] That's giving me a redirect to donatewiki [14:56:23] fundraising-tech-ops: migrate pay-lvs servers to Debian Stretch - https://phabricator.wikimedia.org/T185014 (Jgreen) [14:56:25] fundraising-tech-ops: upgrade pay-lvs servers to stretch - https://phabricator.wikimedia.org/T220100 (Jgreen) [14:57:08] fundraising-tech-ops: upgrade civi1001 and mintaka to Stretch, possibly Buster - https://phabricator.wikimedia.org/T220453 (Jgreen) [14:58:28] ejegg not offhand, I'll take a look [14:59:25] ejegg: out of curiosity, is that image something that's actually expected to be on the server? [15:01:46] Fundraising Sprint Greps of Wrath, Fundraising-Backlog: Payments wiki form variant with employer field - https://phabricator.wikimedia.org/T219558 (CaitVirtue) I also want to make sure we're testing this in a way that gives Online good data about the impact of adding this field. @jrobell Can you chime i... [15:04:05] nm. i see it [15:07:12] fundraising-tech-ops: whitelist extensions/FundraisingEmailUnsubscribe at payments reverse proxy - https://phabricator.wikimedia.org/T220516 (Jgreen) [15:10:01] Jeff_Green: yeah, it's part of a fancy new opt-in page [15:10:21] cool. I think I see the problem: https://phabricator.wikimedia.org/T220516 [15:11:05] ah, got it. Guess DonationInterface already has that treatment, which is why we can show the card icons [15:11:11] right [15:14:01] ejegg: should be fixed, give it a try [15:16:11] (PS1) Ejegg: Remove amount from English TY subject [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/502517 (https://phabricator.wikimedia.org/T220192) [15:16:21] Jeff_Green: great, looks like it works! [15:16:28] great [15:16:39] fundraising-tech-ops: whitelist extensions/FundraisingEmailUnsubscribe at payments reverse proxy - https://phabricator.wikimedia.org/T220516 (Jgreen) Open→Resolved Fixed. [15:16:52] Fundraising-Backlog, Patch-For-Review: Inaccurate placement for the currency symbol (SEK) in Sweden Thank you letter - https://phabricator.wikimedia.org/T220192 (Ejegg) OK, ^^^ that patch takes it out. [15:44:50] fr-tech: dead simple review right there [15:46:33] Fundraising Sprint Greps of Wrath, Fundraising-Backlog, Patch-For-Review: Inaccurate placement for the currency symbol (SEK) in Sweden Thank you letter - https://phabricator.wikimedia.org/T220192 (Ejegg) p:Triage→Normal a:Ejegg [15:48:56] Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising-Backlog, Patch-For-Review: Create variants for fancy new opt in pages on payments wiki - https://phabricator.wikimedia.org/T218240 (Ejegg) OK, this is deployed. An example of the new form: https://payments.w... [15:53:26] Fundraising-Backlog, FR-Ingenico: 3DS iFrame errors after 4/8/19 upgrade - https://phabricator.wikimedia.org/T220512 (Ejegg) We should redirect all 3DS donations... [15:55:23] (PS1) Ejegg: Ingenico connect: Always redirect when using 3DS [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/502525 (https://phabricator.wikimedia.org/T220512) [15:55:26] cwd ^^^ [15:56:58] (PS2) Ejegg: PaymentTransactionResponse::setData allows append [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/499807 [15:58:00] (PS2) Ejegg: Use special form variant for redirect to hosted Connect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/499942 [16:02:16] (PS2) Ejegg: For full redirect, process immediately on return [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/500084 (https://phabricator.wikimedia.org/T219636) [16:04:55] (CR) jerkins-bot: [V: -1] For full redirect, process immediately on return [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/500084 (https://phabricator.wikimedia.org/T219636) (owner: Ejegg) [16:07:32] Fundraising Sprint Greps of Wrath, Fundraising-Backlog: Payments wiki form variant with employer field - https://phabricator.wikimedia.org/T219558 (DStrine) This is getting a lot larger and more complicated than just a test of adding a field to the form >>! In T219558#5097482, @NNichols wrote: > @mepps... [16:09:50] Fundraising Sprint Greps of Wrath, Fundraising-Backlog: Payments wiki form variant with employer field - https://phabricator.wikimedia.org/T219558 (CaitVirtue) Yes, please let's start with a simple test. I believe that's what @jrobell recommended [16:12:35] (PS1) Ejegg: Merchant-side dynamic 3D-secure [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/502528 [16:18:06] fr-tech ^^^ might buy us some time on the redirect patches [16:18:18] but... we'd be annoying our most generous donors [16:21:43] (PS3) Ejegg: For full redirect, process immediately on return [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/500084 (https://phabricator.wikimedia.org/T219636) [16:27:58] fr-tech any thoughts on those patches? ^^^ [16:28:21] are they qualitative or quantitative? [16:28:30] AndyRussG|ish: both! [16:28:50] aaargh! ok I agree [16:28:55] Hehe [16:29:06] Well, this one is strictly quantitative: https://gerrit.wikimedia.org/r/502528 [16:29:11] sorry to be so -|ish today [16:29:25] heh, no worries, get that paper! [16:30:38] Wikimedia-Fundraising-Banners, MediaWiki-extensions-CentralNotice: POTY banners are causing client side error during banner display on mobile AND desktop - https://phabricator.wikimedia.org/T215711 (Pcoombe) Open→Resolved a:Pcoombe [16:32:25] ejegg: :) thx! [16:36:07] Wikimedia-Fundraising-Banners: Use semantic elements (,