[07:39:55] (CR) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/502711 (owner: L10n-bot) [07:58:35] (CR) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/502691 (owner: L10n-bot) [12:55:41] (CR) Krinkle: [C: -1] CentralNoticeHooks: Bundle configuration vars into JS that needs it (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/502772 (https://phabricator.wikimedia.org/T219342) (owner: D3r1ck01) [14:55:16] PROBLEM - check_puppetrun on mintaka is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 2 minutes ago with 1 failures. Failed resources (up to 3 shown): Service[opendkim] [15:19:19] fr-tech: what news for scrum-o-scrums? [15:19:37] nothing from me ejegg [15:57:39] back soon just swapping location [16:12:02] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 4 others: Iterate on DS fredge query - https://phabricator.wikimedia.org/T219646 (MBeat33) If th... [16:28:39] fr-tech, I'm considering tackling 'Payments wiki form variant with employer field' if it's not already been started? [16:29:29] jgleeson, i think XenoRyet picked it up and put it down, but would you and cstone wnat to pair on it? there'd been some discussion of doing that with that one [16:31:11] yeah that works for me unless XenoRyet fancies continuing with it? [16:31:12] Fundraising-Backlog: Opt-in numbers in IBM not as expected - https://phabricator.wikimedia.org/T219401 (CCogdill_WMF) Bumping this ticket as I think this might be an important bug! I mentioned comparing the data in IBM to "email performance data". I'm basing that on the statler query we run to collect A/B t... [16:31:23] Which one are we talking about here? [16:31:28] Just signed on [16:31:33] https://phabricator.wikimedia.org/T219558 [16:32:06] is this the one I nominated myself to work on dstrine ? [16:32:07] Yea, what with the CT_ID patch still going through revisions, I hadn't actually touched that yet [16:32:17] You can have it if you want. [16:32:45] (not explicity self-nominated :) [16:33:03] XenoRyet, if you wanna keep it I can look at the iphone form bug? [16:33:14] Either way if fine with me [16:33:52] ok cool I'll pick up the employer field one then as I don't have an iphone so testing might be tricky [16:33:54] jgleeson meeting? [16:33:59] oops! [16:34:00] coming [17:00:15] PROBLEM - check_puppetrun on mintaka is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 1 minute ago with 1 failures. Failed resources (up to 3 shown): Service[opendkim] [17:05:01] mepps, sorry!!!! I got my vm's mixed up. I've booted up the other (where the code I was looking at lives) and I no longer see an error :) [17:08:56] cstone, do you have some time after tech-talk to chat about https://phabricator.wikimedia.org/T219558 with me and XenoRyet [17:08:57] ? [17:10:07] fr-tech I'm heading home to take tech-talk from there as the cafe I'm working out of closes shortly. i might be a few mins late but hopefully not too long [17:10:15] RECOVERY - check_puppetrun on mintaka is OK: OK: Puppet is currently enabled, last run 27 seconds ago with 0 failures [17:20:52] fundraising-tech-ops: upgrade civi1001 and mintaka to Stretch, possibly Buster - https://phabricator.wikimedia.org/T220453 (Jgreen) mintaka is upgraded to stretch [17:27:36] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: harmonize currency & amount in TY emails - https://phabricator.wikimedia.org/T220636 (MBeat33) [18:01:59] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: harmonize currency & amount in TY emails - https://phabricator.wikimedia.org/T220636 (CCogdill_WMF) Looks great, Michael! To confirm, this would be the ideal situation for the donor Michael referenced in his example: **Subject line**: Re: Your gi... [18:04:14] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: harmonize currency & amount in TY emails - https://phabricator.wikimedia.org/T220636 (MBeat33) Yes, I think that would be perfect! First sentence specifying monthly is a total keeper :) [18:27:40] oh, that paypal meeting just disappeared? [18:27:53] guess I should read my email [18:28:14] ah, now it's may 1 [18:32:10] (CR) Ejegg: [C: +2] "Nice catch!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/502384 (owner: Eileen) [18:33:58] Fundraising-Backlog, fundraising-tech-ops, Mail, Operations, Patch-For-Review: Identify appropriate SPF record for domain wikimediafoundation.org - https://phabricator.wikimedia.org/T220412 (Jgreen) >>! In T220412#5098902, @herron wrote: > > I noticed there is a DKIM record in the wikimediaf... [18:36:39] (Merged) jenkins-bot: Add fix & test for handling of disabled languages [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/502384 (owner: Eileen) [18:54:21] (PS1) Ejegg: Update SmashPig [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/502853 [18:54:28] jgleeson sorry if i mssed this on the call but are you looking into the oanda email further? [18:54:30] (CR) Ejegg: [C: +2] Update SmashPig [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/502853 (owner: Ejegg) [18:54:55] I don't think I have access to the Oanda console. ejegg do you? [18:55:54] I was looking at this, http://developer.oanda.com/exchange-rates-api/v1/remaining-quotes/ [18:56:07] looks like we can get the remaining quotes via an api call [18:56:16] but not really the best way to do it [18:56:46] I'll see if I can hit that API method locally [18:56:56] ..from my local* [18:56:57] Fundraising Sprint Greps of Wrath, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Weird language code crashes dq consumer - https://phabricator.wikimedia.org/T190467 (Ejegg) [18:57:22] Fundraising Sprint Greps of Wrath, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Weird language code crashes dq consumer - https://phabricator.wikimedia.org/T190467 (Ejegg) Patch is https://gerrit.wikimedia.org/r/502384 [18:59:40] (Merged) jenkins-bot: Update SmashPig [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/502853 (owner: Ejegg) [19:11:19] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/502861 [19:11:38] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/502861 (owner: Ejegg) [19:12:21] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/502861 (owner: Ejegg) [19:14:32] !log updated fundraising CiviCRM from d0e44a9e51 to 24b968b1f9 [19:14:34] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:19:07] Fundraising-Backlog: Where and how to record opt-ins on payment attempts - https://phabricator.wikimedia.org/T220645 (CCogdill_WMF) [19:20:33] have a good one fr-tech, catch you all tomorrow o/ [19:28:41] Fundraising-Backlog, fundraising-tech-ops: ccogdill has new yubikey, need to update frdev server access - https://phabricator.wikimedia.org/T220647 (CCogdill_WMF) p:Triage→High [20:21:05] (PS1) Ejegg: PaymentResult: redirect methods support data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/502879 [20:37:12] (PS1) Ejegg: WIP doPayment for Ingenico [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/502889 [20:57:16] (PS1) Ejegg: WIP Flesh out Adyen doPayment with data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/502892 [20:58:06] fr-tech there are some first steps toward the donation.api refactor if you want to give early feedback ^^^ [20:59:40] Trying to split out each adapter's doPayment into a separate patch, then do a bigger patch to fix donation.api and all the JS that uses it [21:00:00] hmm, always a challenge to deploy linked server & js changes, due to caching [21:06:38] (CR) Ejegg: [C: -2] "Going to do this differently" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/502525 (https://phabricator.wikimedia.org/T220512) (owner: Ejegg) [21:06:56] (PS3) Ejegg: Use special form variant for redirect to hosted Connect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/499942 [21:08:39] (CR) Ejegg: [C: -1] "This should be only deployed after one of the options to make us redirect when use_authentication is true" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/499942 (owner: Ejegg) [21:09:13] (Abandoned) Ejegg: For full redirect, process immediately on return [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/500084 (https://phabricator.wikimedia.org/T219636) (owner: Ejegg) [22:35:44] Fundraising-Backlog, FR-Ingenico, Patch-For-Review: 3DS iFrame errors after 4/8/19 upgrade - https://phabricator.wikimedia.org/T220512 (MBeat33) @Ejegg will you let me know when 3DS is off for NOK? I want to invite the donor to retry - thanks [22:59:54] Fundraising-Backlog, FR-Ingenico, Patch-For-Review: 3DS iFrame errors after 4/8/19 upgrade - https://phabricator.wikimedia.org/T220512 (Ejegg) @MBeat33 It's turned off now. You can go ahead whenever you want. [23:03:07] Fundraising-Backlog, FR-Ingenico, Patch-For-Review: 3DS iFrame errors after 4/8/19 upgrade - https://phabricator.wikimedia.org/T220512 (MBeat33) Thank you! [23:19:16] (PS2) Ejegg: WIP Flesh out Adyen doPayment with data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/502892 [23:19:18] (PS1) Ejegg: Forward-compatible js for Ingenico Connect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/502915