[00:03:23] (PS2) Ejegg: Forward-compatible js for Ingenico Connect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/502915 [00:03:25] (PS3) Ejegg: WIP Flesh out Adyen doPayment with data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/502892 [00:03:27] (PS1) Ejegg: WIP Donation API uses doPayment for all gateways [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/502923 (https://phabricator.wikimedia.org/T220512) [00:34:59] (PS2) Ejegg: PaymentResult: redirect methods support data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/502879 (https://phabricator.wikimedia.org/T220512) [00:35:01] (PS2) Ejegg: WIP doPayment for Ingenico [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/502889 (https://phabricator.wikimedia.org/T220512) [00:35:03] (PS3) Ejegg: Forward-compatible js for legacy GlobalCollect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/502915 (https://phabricator.wikimedia.org/T220512) [00:35:05] (PS4) Ejegg: WIP Flesh out Adyen doPayment with data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/502892 (https://phabricator.wikimedia.org/T220512) [00:35:07] (PS2) Ejegg: WIP Donation API uses doPayment for all gateways [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/502923 (https://phabricator.wikimedia.org/T220512) [00:35:09] (PS1) Ejegg: Paypal forward-compatible JS, comments [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/502927 (https://phabricator.wikimedia.org/T220512) [00:36:18] Fundraising Sprint Greps of Wrath, Fundraising-Backlog, FR-Ingenico, Patch-For-Review: 3DS iFrame errors after 4/8/19 upgrade - https://phabricator.wikimedia.org/T220512 (Ejegg) a:Ejegg [00:52:57] (PS3) Ejegg: WIP Donation API uses doPayment for all gateways [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/502923 (https://phabricator.wikimedia.org/T220512) [00:52:59] (PS1) Ejegg: Forward-compatible JS for Ingenico Connect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/502930 (https://phabricator.wikimedia.org/T220512) [00:56:06] (PS4) Ejegg: Remove obsolete CentralNoticeXXCountries [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/485877 [06:16:05] (CR) XenoRyet: [C: +2] Remove obsolete CentralNoticeXXCountries [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/485877 (owner: Ejegg) [06:20:09] (CR) XenoRyet: [C: +2] Remove amount from English TY subject [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/502517 (https://phabricator.wikimedia.org/T220192) (owner: Ejegg) [06:21:13] (CR) jerkins-bot: [V: -1] Remove obsolete CentralNoticeXXCountries [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/485877 (owner: Ejegg) [06:25:23] (Merged) jenkins-bot: Remove amount from English TY subject [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/502517 (https://phabricator.wikimedia.org/T220192) (owner: Ejegg) [12:12:07] good day fr-tech ;) [13:31:32] hi jgleeson ! [13:31:42] and hello to the rest of fr-tech [13:32:57] (CR) Ejegg: "recheck" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/485877 (owner: Ejegg) [13:33:55] :> [13:34:39] Looks like our retro sits right on top of advancement coffee today [13:37:14] jgleeson: seems like somebody moved it [13:38:21] yup I'm guessing dstrine due to his conference and maybe with eileen's travel? [13:47:46] (CR) jenkins-bot: Remove obsolete CentralNoticeXXCountries [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/485877 (owner: Ejegg) [13:56:15] hey ejegg, I've been playing around with our payments forms as part of the ticket I'm looking at, and I'm currently looking at our usage of Mustache via the lightncandy package. I was impressed by the stated performance improvements of that package over the source packages it includes, do you have any idea how the improvements are achieaved? https://github.com/zordius/lightncandy [13:58:51] jgleeson: no, I haven't looked into the implementation! [13:59:04] achieved*** [13:59:16] I just blindly use the templates and they seem to work :) [13:59:20] :) [13:59:49] so, we've got an easy mechanism to add a new required field to a variant [14:00:05] hmm, at least per-country [14:00:17] but it will need some adaptation to add an optional field [14:00:41] I'm currently using your optin patch as a guide for focus areas [14:00:48] https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/DonationInterface/+/445327/ [14:01:01] I vaguely remember reviewing it [14:01:21] ok, cool [14:01:52] I vaguely remember writing it [14:02:01] :) [14:05:19] sometimes I go through my own merged patches in gerrit and surprise myself by having zero memory of most of the things I've added [14:05:39] it must be like walking around a blackhole for someone as prolific as you ejegg :) [14:19:04] (PS2) Ejegg: Minor comments update to ContributionTrackingQueueTest [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/502468 (owner: Jgleeson) [14:19:10] (CR) Ejegg: [C: +2] Minor comments update to ContributionTrackingQueueTest [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/502468 (owner: Jgleeson) [14:22:19] thanks ejegg ! [14:22:41] :) thanks for the correctitude [14:23:41] (Merged) jenkins-bot: Minor comments update to ContributionTrackingQueueTest [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/502468 (owner: Jgleeson) [14:25:14] ejegg: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/DonationInterface/+/493978/ Any chance we can merge this? Or any reason we can't? (I'm guessing you're not going back to MW 1.27) [14:26:01] Reedy: oh hey, yeah, we just need the zuul config patch merged to get the tests up to date [14:26:09] ohhh [14:26:11] is that still not done? [14:26:13] https://gerrit.wikimedia.org/r/499334 [14:26:22] Heh, and it's a bear to rebase each time [14:26:58] I can just deploy it if you're happy (and it gets V+2'd) [14:27:03] thanks! [14:27:35] I /think/ that patch is OK, but there are a whole bunch of changes to CI since I last had to mess with it much [14:29:28] jerkins V+2'd it [14:31:57] thanks Reedy ! [14:32:34] (Abandoned) Reedy: Use composer-merge-plugin 1.4.1 to prepend VCS repos [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/459762 (https://phabricator.wikimedia.org/T203084) (owner: Hashar) [14:37:08] Or not [14:37:10] Apparently [14:37:15] (CR) Mepps: [C: +1] "This looks good but I had one clarifiying question. Also, it looks like there are no tests for this class?" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/502879 (https://phabricator.wikimedia.org/T220512) (owner: Ejegg) [14:39:27] ejegg you got going on those refactor patches quickly! [14:43:05] mepps heh, turns out the changes are not that huge [14:45:14] Fundraising Sprint Greps of Wrath, Fundraising-Backlog: Payments wiki form variant with employer field - https://phabricator.wikimedia.org/T219558 (jgleeson) Hello all I've started work on the front-end side of this ticket. I wanted to confirm the location of the new form element with you all, does the... [14:47:25] (CR) Ejegg: "Thanks! Yeah, I guess tests covering the fromResults class would be appropriate. If I change that to handle iframe / redirect hints, I'll " (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/502879 (https://phabricator.wikimedia.org/T220512) (owner: Ejegg) [14:47:45] (CR) Ejegg: "err, fromResults *method*, that is" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/502879 (https://phabricator.wikimedia.org/T220512) (owner: Ejegg) [14:55:23] another good comment here: [14:55:25] @TODO also: Think about putting log alarms on the [14:55:25] * keys we want to see disappear forever, complete with [14:55:25] * ffname and referrer for easy total destruction. [14:55:39] :> [14:57:44] fr-tech, I'm taking a break now and will be back for retro [14:57:50] enjoy! [15:34:12] Fundraising-Backlog, fundraising-tech-ops, Mail, Operations, Patch-For-Review: Identify appropriate SPF record for domain wikimediafoundation.org - https://phabricator.wikimedia.org/T220412 (herron) Open→Resolved a:herron The below SPF record is now active ` wikimediafoundation.o... [15:36:07] hi fr-tech! wondering what retro jgleeson meant? ^ or is that the same as advancement coffee today? [15:47:56] AndyRussG: I think just the coffee, yeah [15:48:50] ejegg: ah okok... I saw on the coffee invite it sez something about the mid-term plan, so I guess it's a pretty important coffee today, maybe? [15:53:16] aha, today or tomorrow [16:42:14] Fundraising Sprint Greps of Wrath, Fundraising-Backlog: Payments wiki form variant with employer field - https://phabricator.wikimedia.org/T219558 (NNichols) @jgleeson Moving it there sounds right. I think the field should read "Employer Name (Optional)". [18:18:18] ejegg|food: Deployed [18:57:47] (PS3) Umherirrender: Declare visibility on private static class properties [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/497026 [18:58:46] (CR) jerkins-bot: [V: -1] Declare visibility on private static class properties [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/497026 (owner: Umherirrender) [19:07:29] (Abandoned) Hashar: Test merge plugin prepend-repositories [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/459765 (https://phabricator.wikimedia.org/T203084) (owner: Hashar) [19:07:41] (PS2) Umherirrender: Use php null coalesce operator ?? [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/496237 [19:07:54] (CR) Umherirrender: "Rebased" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/496237 (owner: Umherirrender) [19:08:35] (CR) jerkins-bot: [V: -1] Use php null coalesce operator ?? [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/496237 (owner: Umherirrender) [19:09:18] (CR) D3r1ck01: [C: +1] "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/497026 (owner: Umherirrender) [19:10:21] (CR) jerkins-bot: [V: -1] Declare visibility on private static class properties [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/497026 (owner: Umherirrender) [19:31:49] (PS1) Ejegg: Make monolog requirement match mediawiki [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/503091 [19:33:00] (CR) jerkins-bot: [V: -1] Make monolog requirement match mediawiki [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/503091 (owner: Ejegg) [19:35:23] (CR) Krinkle: [C: -1] "Let's convert this module to packageFiles in its own commit. separate from changing the configuration variable. Let me know if you'd like " [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/502772 (https://phabricator.wikimedia.org/T219342) (owner: D3r1ck01) [19:49:14] (CR) D3r1ck01: "> I'll move on with a few other perf issues first, and give you some time for this one." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/502772 (https://phabricator.wikimedia.org/T219342) (owner: D3r1ck01) [21:01:03] (CR) Krinkle: [C: -1] "Yes, that is correct :)" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/502772 (https://phabricator.wikimedia.org/T219342) (owner: D3r1ck01) [22:32:17] (CR) Reedy: "We probably should look at bumping it in core ;)" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/503091 (owner: Ejegg) [22:39:27] (CR) Reedy: "if ( $wgContributionTrackingDBserver === null &&" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/503091 (owner: Ejegg) [22:41:23] (PS1) Reedy: Use DB_MASTER if $wgContributionTrackingDBuser === null [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/503137 [22:41:37] ejegg: ^ I think that might be enough to fix it for CI [22:42:05] I can understand not needing a password, but a user seems useful for connecting to a db ;P [22:43:48] https://github.com/wikimedia/mediawiki/blame/master/includes/libs/rdbms/database/Database.php#L353-L373 [22:44:21] Code changed in REL1_31 [22:50:27] (PS1) Reedy: DB settings default to null [extensions/ContributionTracking] (REL1_31) - https://gerrit.wikimedia.org/r/503138 (https://phabricator.wikimedia.org/T195814) [22:50:29] (PS1) Reedy: Use DB_MASTER if $wgContributionTrackingDBuser === null [extensions/ContributionTracking] (REL1_31) - https://gerrit.wikimedia.org/r/503139 [22:51:06] ejegg: Oh [22:51:23] I bet just that first patch being backported (it was a couple of months after 1.31 was branched) is enough to help [22:51:47] (CR) Reedy: [C: +2] DB settings default to null [extensions/ContributionTracking] (REL1_31) - https://gerrit.wikimedia.org/r/503138 (https://phabricator.wikimedia.org/T195814) (owner: Reedy) [22:51:49] Reedy: oho, thanks! [22:52:00] Let's just merge that one and see if it helps [22:52:22] I was thinking that extension would be on master [22:54:06] but of course it's REL1_31 [22:54:17] heh [22:57:17] (PS1) Ejegg: Update platform to PHP 7.0 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/503141 [22:58:48] (CR) jerkins-bot: [V: -1] Update platform to PHP 7.0 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/503141 (owner: Ejegg) [22:59:41] patch is nearly merged [23:01:35] (Merged) jenkins-bot: DB settings default to null [extensions/ContributionTracking] (REL1_31) - https://gerrit.wikimedia.org/r/503138 (https://phabricator.wikimedia.org/T195814) (owner: Reedy) [23:01:46] (CR) Reedy: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/503091 (owner: Ejegg) [23:02:07] (CR) Ejegg: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/503091 (owner: Ejegg) [23:02:21] heh, beat me to it [23:02:38] (CR) jenkins-bot: DB settings default to null [extensions/ContributionTracking] (REL1_31) - https://gerrit.wikimedia.org/r/503138 (https://phabricator.wikimedia.org/T195814) (owner: Reedy) [23:04:05] (CR) jerkins-bot: [V: -1] Make monolog requirement match mediawiki [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/503091 (owner: Ejegg) [23:04:10] darn [23:04:12] let's see [23:04:28] Different errors :) [23:04:33] oh hey, that's getting closer! [23:04:38] So... I get those locally too [23:04:41] It's progress [23:04:50] (Abandoned) Reedy: Use DB_MASTER if $wgContributionTrackingDBuser === null [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/503137 (owner: Reedy) [23:04:54] and it's in a global fn [23:04:55] (Abandoned) Reedy: Use DB_MASTER if $wgContributionTrackingDBuser === null [extensions/ContributionTracking] (REL1_31) - https://gerrit.wikimedia.org/r/503139 (owner: Reedy) [23:05:08] 00:03:59 PHP Fatal error: Uncaught MWException: MustacheFormTest::tearDown() must call parent::tearDown() in /workspace/src/tests/phpunit/MediaWikiTestCase.php:134 [23:05:19] hmm, I guess we're probably not setting up the mock request well enough? [23:05:30] also lots of missing REQUEST_TIME_FLOAT [23:05:59] guessing the FauxRequest does something about that, and we're not using it some places where we should [23:06:22] Anyway, I think from here it's probably DonationInterface fixes. Thanks for all the help, Reedy! [23:06:30] Sweet :D [23:12:07] (PS1) Ejegg: Fake $_SERVER['REQUEST_TIME_FLOAT'] if not present [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/503143 [23:13:57] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/503145 [23:14:05] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/503145 (owner: Ejegg) [23:14:54] (CR) jerkins-bot: [V: -1] Fake $_SERVER['REQUEST_TIME_FLOAT'] if not present [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/503143 (owner: Ejegg) [23:15:02] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/503145 (owner: Ejegg) [23:20:59] (PS2) Ejegg: Various test fixes for DonationInterface on 1.31 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/503143 [23:23:39] (CR) jerkins-bot: [V: -1] Various test fixes for DonationInterface on 1.31 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/503143 (owner: Ejegg) [23:30:24] (PS3) Ejegg: Various test fixes for DonationInterface on 1.31 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/503143 [23:33:12] (CR) jerkins-bot: [V: -1] Various test fixes for DonationInterface on 1.31 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/503143 (owner: Ejegg) [23:41:20] (PS4) Ejegg: Various test fixes for DonationInterface on 1.31 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/503143 [23:43:48] (CR) jerkins-bot: [V: -1] Various test fixes for DonationInterface on 1.31 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/503143 (owner: Ejegg) [23:48:17] Fundraising-Backlog, Patch-For-Review: Write unit tests for the Silverpop export script - https://phabricator.wikimedia.org/T131770 (Ejegg) Open→Resolved a:Ejegg These exist! [23:48:57] Fundraising-Backlog: Random failure: mwext-donationinterfacecore-REL1_27-testextension-zend55 - https://phabricator.wikimedia.org/T154825 (Ejegg) Open→Resolved a:Ejegg We have moved on to PHP 7.0 and REL1_31. Closing [23:49:55] (PS5) Ejegg: Various test fixes for DonationInterface on 1.31 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/503143 [23:53:36] (CR) jerkins-bot: [V: -1] Various test fixes for DonationInterface on 1.31 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/503143 (owner: Ejegg) [23:59:09] (PS6) Ejegg: Various test fixes for DonationInterface on 1.31 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/503143