[00:01:30] (CR) jerkins-bot: [V: -1] Various test fixes for DonationInterface on 1.31 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/503143 (owner: Ejegg) [00:02:04] !log updated fundraising CiviCRM from 24b968b1f9 to 1bc1570967 [00:02:06] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [00:02:32] Fundraising Sprint Greps of Wrath, Fundraising-Backlog, Patch-For-Review: Inaccurate placement for the currency symbol (SEK) in Sweden Thank you letter - https://phabricator.wikimedia.org/T220192 (Ejegg) @CCogdill_WMF, @jrobell, this change is deployed. We should have subject lines without the amount... [00:11:23] (PS7) Ejegg: Various test fixes for DonationInterface on 1.31 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/503143 [00:24:24] fundraising-tech-ops, Operations, netops, ops-codfw: switch port configuration for frmon2001 - https://phabricator.wikimedia.org/T196557 (Papaul) Open→Resolved This is done , it can be close. [00:24:28] fundraising-tech-ops, Operations, Patch-For-Review: rack/setup/install Prometeuse/Grafana host frmon2001 for fr-tech - https://phabricator.wikimedia.org/T196476 (Papaul) [00:31:50] (PS6) Eileen: Update to civicrm 5.13 stock [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/500646 (https://phabricator.wikimedia.org/T218754) [00:31:52] (PS3) Eileen: WMF civicrm updates re-applied to 5.13 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/500647 [00:32:05] (CR) jerkins-bot: [V: -1] Update to civicrm 5.13 stock [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/500646 (https://phabricator.wikimedia.org/T218754) (owner: Eileen) [00:32:11] (CR) jerkins-bot: [V: -1] WMF civicrm updates re-applied to 5.13 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/500647 (owner: Eileen) [00:35:59] (PS7) Eileen: Update to civicrm 5.13 stock [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/500646 (https://phabricator.wikimedia.org/T218754) [00:36:01] (PS4) Eileen: WMF civicrm updates re-applied to 5.13 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/500647 [06:59:38] (CR) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/503214 (owner: L10n-bot) [10:16:57] (CR) Umherirrender: Update platform to PHP 7.0 (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/503141 (owner: Ejegg) [10:37:11] (PS1) Umherirrender: build: Updating mediawiki/mediawiki-codesniffer to 25.0.0 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/503290 [10:38:00] (CR) Umherirrender: build: Updating mediawiki/mediawiki-codesniffer to 25.0.0 (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/503290 (owner: Umherirrender) [10:39:40] (CR) jerkins-bot: [V: -1] build: Updating mediawiki/mediawiki-codesniffer to 25.0.0 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/503290 (owner: Umherirrender) [13:50:41] (Abandoned) D3r1ck01: CentralNoticeHooks: Bundle configuration vars into JS that needs it [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/502772 (https://phabricator.wikimedia.org/T219342) (owner: D3r1ck01) [13:51:50] Fundraising-Backlog: revise recurring SE pay-the-fee amount? - https://phabricator.wikimedia.org/T220824 (MBeat33) [15:08:24] (CR) Ejegg: "Fortunately, we don't have any HHVM in the payments pipeline! We've been using this 'platform' key to make sure vendor packages we prepare" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/503141 (owner: Ejegg) [15:08:46] fr-tech anyone want to review those DonationInterface test patches? [15:10:30] ejegg, will aim to look at them today. Just finishing up some bits on mepps' patch [15:10:38] thanks! [15:14:15] (CR) Umherirrender: [C: +1] "That sounds good" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/503141 (owner: Ejegg) [15:37:17] (CR) Mepps: "question on extension.json" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/503143 (owner: Ejegg) [15:45:03] (PS3) Ejegg: PaymentResult: redirect methods support data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/502879 (https://phabricator.wikimedia.org/T220512) [15:45:05] (PS3) Ejegg: Implement doPayment for Ingenico [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/502889 (https://phabricator.wikimedia.org/T220512) [15:57:03] (PS4) Ejegg: Forward-compatible js for legacy GlobalCollect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/502915 (https://phabricator.wikimedia.org/T220512) [15:57:05] (PS5) Ejegg: Flesh out Adyen doPayment with data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/502892 (https://phabricator.wikimedia.org/T220512) [15:58:49] (CR) Ejegg: "Hi mepps, thanks for the interest. Your question seems to have gotten lost in the mail, though" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/503143 (owner: Ejegg) [15:59:07] (CR) Mepps: Various test fixes for DonationInterface on 1.31 (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/503143 (owner: Ejegg) [15:59:17] (PS1) Jgleeson: Add getBanner() getter. Add exception handling to Edit action. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/503389 [15:59:43] hey mepps, when you run `composer phpcs` on CN do you get tons of errors? [16:01:52] (CR) jerkins-bot: [V: -1] Add getBanner() getter. Add exception handling to Edit action. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/503389 (owner: Jgleeson) [16:01:57] (CR) jerkins-bot: [V: -1] Add getBanner() getter. Add exception handling to Edit action. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/503389 (owner: Jgleeson) [16:02:25] (CR) Ejegg: Various test fixes for DonationInterface on 1.31 (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/503143 (owner: Ejegg) [16:02:36] answered, mepps ^^^ [16:05:52] jgleeson i don't see composer phpcs set up in CN [16:06:04] ah I was using it in the root mw [16:06:08] and passing in the CN path [16:06:23] looks like it's being called here https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-hhvm-docker/44665/console [16:06:35] and I've broken the rules :| [16:06:48] brb just gonna swap location for standup [16:12:38] ooh, failmail [16:13:34] Jeff_Green: / cwd anything going on with firewall or network at codfw frack? [16:15:12] haven't seen anything [16:15:34] looks like timeouts to ingenico [16:17:07] not sure how to test these requests exactly [16:17:33] seems likely it's a problem with that endpoint since we haven't seen anything else [16:17:42] if it's the firewall we should see the dropped traffic in the logs [16:18:05] yeah, looks like I can get an iframe loaded now, so it must have been a transient blip [16:18:25] cool [16:19:00] i see two phpcs errors jgleeson [16:19:14] (CR) Mepps: [C: +2] Various test fixes for DonationInterface on 1.31 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/503143 (owner: Ejegg) [16:19:14] looks like someone in Colombia tried a XSS attack on my oanda log page :) [16:19:27] jgleeson: heheh, now who would do that? [16:19:38] mepps, with my script or the CN one in general? I'm fixing mine atm [16:19:47] my ide styles are screwed again [16:19:51] cn in general [16:20:48] ejegg, clearly someone who likes the trololol song https://www.youtube.com/watch?v=2Z4m4lnjxkY [16:22:05] wow the place I've come to take standup from is really busy... and this is the place I usual come because it's quiet :( [16:23:17] (CR) Ejegg: [C: +2] Update platform to PHP 7.0 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/503141 (owner: Ejegg) [16:23:29] (CR) Ejegg: [C: +2] Make monolog requirement match mediawiki [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/503091 (owner: Ejegg) [16:25:13] thanks for the CR mepps! [16:26:46] (Merged) jenkins-bot: Make monolog requirement match mediawiki [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/503091 (owner: Ejegg) [16:26:48] (Merged) jenkins-bot: Update platform to PHP 7.0 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/503141 (owner: Ejegg) [16:26:50] (Merged) jenkins-bot: Various test fixes for DonationInterface on 1.31 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/503143 (owner: Ejegg) [16:27:45] (CR) Ejegg: [C: +1] "The code looks good, but I'd really like to see some kind of integration test that looks at the queue message." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/496351 (https://phabricator.wikimedia.org/T215462) (owner: XenoRyet) [16:38:49] (CR) Mepps: Add getBanner() getter. Add exception handling to Edit action. (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/503389 (owner: Jgleeson) [17:05:00] back soon [17:46:20] (PS2) Ejegg: Paypal forward-compatible JS, comments [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/502927 (https://phabricator.wikimedia.org/T220512) [17:46:22] (PS2) Ejegg: Forward-compatible JS for Ingenico Connect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/502930 (https://phabricator.wikimedia.org/T220512) [17:46:24] (PS4) Ejegg: WIP Donation API uses doPayment for all gateways [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/502923 (https://phabricator.wikimedia.org/T220512) [17:49:17] (CR) jerkins-bot: [V: -1] WIP Donation API uses doPayment for all gateways [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/502923 (https://phabricator.wikimedia.org/T220512) (owner: Ejegg) [18:03:59] (CR) Jforrester: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/496237 (owner: Umherirrender) [18:08:06] (CR) Jforrester: [C: +2] Use php null coalesce operator ?? [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/496237 (owner: Umherirrender) [18:08:46] (PS2) Jforrester: build: Updating mediawiki/mediawiki-codesniffer to 25.0.0 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/503290 (owner: Umherirrender) [18:15:08] (CR) Jforrester: [C: +2] build: Updating mediawiki/mediawiki-codesniffer to 25.0.0 (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/503290 (owner: Umherirrender) [18:24:50] (Merged) jenkins-bot: Use php null coalesce operator ?? [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/496237 (owner: Umherirrender) [18:24:52] (Merged) jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 25.0.0 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/503290 (owner: Umherirrender) [19:21:34] Jeff_Green / cwd can you tell me what request is made for check_gcsip ? [19:21:39] (PS5) Ejegg: Donation API uses doPayment for all gateways [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/502923 (https://phabricator.wikimedia.org/T220512) [19:21:51] sec [19:21:51] is that hitting the donation API on payments? [19:22:10] check_http -w 10 -c 120 --ssl -H ps.gcsip.com -u /wdl/wdl [19:22:13] I'm doing a refactor of that class, and I think the connection test should be a separate action [19:22:16] oho [19:22:23] it's an outbound request [19:22:53] ok, great, that weird path in the API isn't used at all then! [19:23:43] cool [19:24:32] (PS6) Ejegg: Donation API uses doPayment for all gateways [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/502923 (https://phabricator.wikimedia.org/T220512) [19:24:46] fr-tech OK, that whole chain of refactor patches should be ready to review ^^^ [19:25:13] hehe I read that as "chain reaction of patches" [19:25:17] The idea would be to deploy the forward-compatible js first, then wait a day or so, then the doPayment api [19:25:48] heh, 'chain reaction of patches' sounds like the last time I tried sewing up the holes in my jeans pockets [19:26:07] aww [19:27:00] heh, i finally took 'em to a tailor [19:32:09] ah hmmm for my dying jeans pockets I just kept loosing coins randomly [19:32:14] back a bit later! [19:43:11] (PS1) Ejegg: Post-donation-API-refactor cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/503450 (https://phabricator.wikimedia.org/T220512) [19:44:12] (PS4) Ejegg: PaymentResult: redirect methods support data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/502879 (https://phabricator.wikimedia.org/T220512) [19:44:14] (PS4) Ejegg: Implement doPayment for Ingenico [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/502889 (https://phabricator.wikimedia.org/T220512) [19:44:16] (PS5) Ejegg: Forward-compatible js for legacy GlobalCollect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/502915 (https://phabricator.wikimedia.org/T220512) [19:44:18] (PS6) Ejegg: Flesh out Adyen doPayment with data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/502892 (https://phabricator.wikimedia.org/T220512) [19:44:20] (PS3) Ejegg: Paypal forward-compatible JS, comments [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/502927 (https://phabricator.wikimedia.org/T220512) [19:44:22] (PS3) Ejegg: Forward-compatible JS for Ingenico Connect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/502930 (https://phabricator.wikimedia.org/T220512) [19:44:24] (PS7) Ejegg: Donation API uses doPayment for all gateways [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/502923 (https://phabricator.wikimedia.org/T220512) [19:44:26] (PS2) Ejegg: Post-donation-API-refactor cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/503450 (https://phabricator.wikimedia.org/T220512) [20:43:01] (PS13) XenoRyet: c_t ids from the sequence generator [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/496351 (https://phabricator.wikimedia.org/T215462) [20:45:22] (CR) jerkins-bot: [V: -1] c_t ids from the sequence generator [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/496351 (https://phabricator.wikimedia.org/T215462) (owner: XenoRyet) [20:47:51] (CR) XenoRyet: "So this version sets the global for the test, since I was just relying on it being set in my local environment and it fails without it. T" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/496351 (https://phabricator.wikimedia.org/T215462) (owner: XenoRyet) [20:49:33] (PS14) XenoRyet: c_t ids from the sequence generator [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/496351 (https://phabricator.wikimedia.org/T215462) [20:51:54] (CR) jerkins-bot: [V: -1] c_t ids from the sequence generator [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/496351 (https://phabricator.wikimedia.org/T215462) (owner: XenoRyet) [21:02:40] (CR) XenoRyet: "Weird, I don't get that failure locally, and I do get those errors both on master and with this branch. Looking." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/496351 (https://phabricator.wikimedia.org/T215462) (owner: XenoRyet) [21:34:00] so I figured out why my phpcs was giving me confusing reslts [21:34:07] on the mw install [21:34:30] "composer phpcs": "phpcs -p -s", [21:34:56] vagrant@mwdebian9:/vagrant/mediawiki$ which phpcs [21:35:13] vagrant/srv/civicrm-buildkit/bin/phpcs [21:36:10] looks like the composer script tries to call the local package in your path [21:36:15] and not /vendor/bin/.. [21:36:20] as I thought ? [21:36:56] or maybe composer resolves that to vendor/bin after failing to hit something in PATH [21:37:11] either way, calling /vendor/bin/phpcs directly worked [21:38:48] vagrant@mwdebian9:/vagrant/mediawiki$ ./vendor/bin/phpcs --version [21:38:48] PHP_CodeSniffer version 3.4.1 (stable) by Squiz (http://www.squiz.net) [21:38:48] vagrant@mwdebian9:/vagrant/mediawiki$ phpcs --version [21:38:48] PHP_CodeSniffer version 2.1.0 (stable) by Squiz (http://www.squiz.net) [21:42:33] (PS2) Jgleeson: Add getBanner() getter. Add exception handling to Edit action. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/503389 [22:15:14] PROBLEM - check_gcsip on payments2003 is CRITICAL: CRITICAL - Socket timeout after 121 seconds [22:15:14] PROBLEM - check_gcsip on payments2001 is CRITICAL: CRITICAL - Socket timeout after 121 seconds [22:18:14] RECOVERY - check_gcsip on payments2003 is OK: HTTP OK: HTTP/1.1 200 OK - 343 bytes in 0.244 second response time [22:18:14] RECOVERY - check_gcsip on payments2001 is OK: HTTP OK: HTTP/1.1 200 OK - 343 bytes in 0.225 second response time [22:35:21] hey fr-tech, I'm seeing some ingenico timeout failmail [22:35:42] yeah, seems related to ^^^^ check_gcsip [22:35:46] coinciding with the gcisp thingy? is that globalcollect [22:35:48] ditto [22:42:37] Fundraising-Backlog: Oanda API Bug - https://phabricator.wikimedia.org/T220859 (jgleeson) [22:43:03] Fundraising Sprint Greps of Wrath, Fundraising-Backlog: Oanda API Bug - https://phabricator.wikimedia.org/T220859 (jgleeson) [22:49:51] (CR) Jgleeson: Add getBanner() getter. Add exception handling to Edit action. (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/503389 (owner: Jgleeson) [22:55:14] PROBLEM - check_gcsip on payments2001 is CRITICAL: CRITICAL - Socket timeout after 121 seconds [22:55:14] PROBLEM - check_gcsip on payments2003 is CRITICAL: CRITICAL - Socket timeout after 121 seconds [22:55:40] cwd do we have the main cluster upgraded yet? [22:55:52] looks like codfw is having trouble talking to ingenico [22:56:39] but we're not seeing any check_gcsip problems from payments100* [22:58:14] RECOVERY - check_gcsip on payments2001 is OK: HTTP OK: HTTP/1.1 200 OK - 343 bytes in 0.218 second response time [22:58:14] RECOVERY - check_gcsip on payments2003 is OK: HTTP OK: HTTP/1.1 200 OK - 343 bytes in 0.237 second response time [22:58:28] ejegg, can you send the updated list of patches you have for review in your eod email please? sorry I didn't get around to any today I'll pick up on them first thing monday. I can't see them in the sprint btw [23:02:13] in other news fr-tech, dstrine, it does look like Google is making background requests from the expense form view-source:http://3.19.61.130/log.php but for the explanation to standup, it needs to reach about 50 requests in the 24hour window which would then roughly require about 220 copies of the document to exist for it to add up to 11k per day. Not unthinkable but not yet confirmed [23:03:23] have a great weekend fr-tech! [23:09:17] Fundraising Sprint Greps of Wrath, Fundraising-Backlog: Oanda API Bug - https://phabricator.wikimedia.org/T220859 (jgleeson) It looks like Google IS making background requests http://3.19.61.130/log.php {F28633461} [23:16:14] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 9 others: find another way to compile the donor list for... - https://phabricator.wikimedia.org/T118822 [23:28:01] (PS1) Ejegg: Mark redirects 'liberated' so we process return immediately [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/503532 (https://phabricator.wikimedia.org/T220512) [23:28:42] (Abandoned) Ejegg: Ingenico connect: Always redirect when using 3DS [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/502525 (https://phabricator.wikimedia.org/T220512) (owner: Ejegg) [23:30:46] (PS4) Ejegg: Use special form variant for redirect to hosted Connect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/499942