[12:02:28] (Abandoned) Jgleeson: Add getBanner() getter. Add exception handling to Edit action. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/503389 (owner: Jgleeson) [12:06:58] Fundraising Sprint Greps of Wrath, Fundraising-Backlog: Oanda API Bug - https://phabricator.wikimedia.org/T220859 (jgleeson) Google made ~48 background calls on 04/12/2019. If this is consistent daily, we'd need 220 versions of the form to exist to reach the ~11k request count. Not unthinkable. [13:27:02] (CR) Jgleeson: [C: +2] "Looks good to me." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/502879 (https://phabricator.wikimedia.org/T220512) (owner: Ejegg) [13:28:05] (Merged) jenkins-bot: PaymentResult: redirect methods support data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/502879 (https://phabricator.wikimedia.org/T220512) (owner: Ejegg) [13:51:06] (CR) Jgleeson: [C: +2] "Looking good to me. Test passing also." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/502889 (https://phabricator.wikimedia.org/T220512) (owner: Ejegg) [13:53:23] (Merged) jenkins-bot: Implement doPayment for Ingenico [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/502889 (https://phabricator.wikimedia.org/T220512) (owner: Ejegg) [13:57:03] (Abandoned) D3r1ck01: Exceptions: Move exceptions files to Exceptions directory [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/501903 (owner: D3r1ck01) [14:03:38] (CR) Jgleeson: [C: +2] "This looks good to me. I was initially wondering whether the '||' check would trip us up if both were present but it looks like that can n" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/502915 (https://phabricator.wikimedia.org/T220512) (owner: Ejegg) [14:17:31] thanks for all the CR jgleeson! [14:26:10] (Merged) jenkins-bot: Forward-compatible js for legacy GlobalCollect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/502915 (https://phabricator.wikimedia.org/T220512) (owner: Ejegg) [14:26:55] (CR) D3r1ck01: [C: +1] "LGTM! Let maintainers of the repo land this!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/497026 (owner: Umherirrender) [14:42:38] ah mepps, i forgot to mention that I've abandoned my CN patch pushed last week. I reviewed it again this morning and decided against refactoring the banner stuff into an over complication getter. [14:43:17] https://gerrit.wikimedia.org/r/#/c/503389/ [14:43:58] overcomplicated* [14:46:06] np ejegg|away [14:48:20] Fundraising-Backlog, Analytics: CentralNoticeImpression refined impressionEventSampleRate is int instead of double - https://phabricator.wikimedia.org/T217109 (Milimetric) ping @AndyRussG, can you confirm that it's ok to delete the old data? [15:23:20] ejegg|away, it's taking me a little longer to wrap my head around our adyen flow [15:23:39] and specifically the test, it feels like we might wanna check for errors and stuff too? [15:24:07] although as we're pre-populating the result, maybe we can skip that [15:27:31] curious also whether we need to check for order_id, as we do in the doTransaction test [15:27:36] will add comments to patch [16:15:35] jgleeson: sure, I can add a test for errors [16:33:06] lol [16:34:04] ejegg|nospoilers, was it out in the US last night? [16:37:58] * jgleeson groan. Google has made 48 background requests in the last 6 hours alone. [16:41:12] jgleeson: yeah, I can't read any news or Twitter till I get to it! [16:41:24] dstrine, I'm about to break for a few hours. Did you hear anything about when the key was gonna be reset with Oanda? [16:41:54] ahhh ejegg|nospoilers, it premieres here tonight. [16:51:49] fr-tech, breaking for a few hours. be back before backlog refinement. [17:30:41] (PS7) Ejegg: Flesh out Adyen doPayment with data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/502892 (https://phabricator.wikimedia.org/T220512) [17:33:03] (CR) jerkins-bot: [V: -1] Flesh out Adyen doPayment with data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/502892 (https://phabricator.wikimedia.org/T220512) (owner: Ejegg) [17:36:27] (PS8) Ejegg: Flesh out Adyen doPayment with data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/502892 (https://phabricator.wikimedia.org/T220512) [17:55:13] PROBLEM - check_puppetrun on frdev1001 is CRITICAL: CRITICAL: Puppet has 7 failures. Last run 7 minutes ago with 7 failures. Failed resources (up to 3 shown): Package[aide],Package[aide-common],Package[libssl1.0.0],Package[openssl] [18:00:13] PROBLEM - check_puppetrun on frdev1001 is CRITICAL: CRITICAL: Puppet has 7 failures. Last run 12 minutes ago with 7 failures. Failed resources (up to 3 shown): Package[aide],Package[aide-common],Package[libssl1.0.0],Package[openssl] [18:05:13] PROBLEM - check_puppetrun on frdev1001 is CRITICAL: CRITICAL: Puppet has 7 failures. Last run 3 minutes ago with 7 failures. Failed resources (up to 3 shown): Package[aide],Package[aide-common],Package[libssl1.0.0],Package[openssl] [18:10:13] PROBLEM - check_puppetrun on frdev1001 is CRITICAL: CRITICAL: Puppet has 7 failures. Last run 8 minutes ago with 7 failures. Failed resources (up to 3 shown): Package[aide],Package[aide-common],Package[libssl1.0.0],Package[openssl] [18:15:19] PROBLEM - check_puppetrun on frdev1001 is CRITICAL: CRITICAL: Puppet has 7 failures. Last run 13 minutes ago with 7 failures. Failed resources (up to 3 shown): Package[aide],Package[aide-common],Package[libssl1.0.0],Package[openssl] [18:20:13] PROBLEM - check_puppetrun on frdev1001 is CRITICAL: CRITICAL: Puppet has 7 failures. Last run 2 minutes ago with 7 failures. Failed resources (up to 3 shown): Package[aide],Package[aide-common],Package[libssl1.0.0],Package[openssl] [18:25:13] PROBLEM - check_puppetrun on frdev1001 is CRITICAL: CRITICAL: Puppet has 7 failures. Last run 41 seconds ago with 7 failures. Failed resources (up to 3 shown): Package[aide],Package[aide-common],Package[libssl1.0.0],Package[openssl] [18:26:28] ACKNOWLEDGEMENT - check_puppetrun on frdev1001 is CRITICAL: CRITICAL: Puppet has 7 failures. Last run 41 seconds ago with 7 failures. Failed resources (up to 3 shown): Package[aide],Package[aide-common],Package[libssl1.0.0],Package[openssl] Jeff_Green looking at apt-mark hold vs puppet vs jessie-backports issues [18:32:02] (CR) Ejegg: [C: +2] Adjust omnirecipient repair to reflect a daylight savings change. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/503542 (https://phabricator.wikimedia.org/T200240) (owner: Eileen) [18:33:59] (PS15) Ejegg: c_t ids from the sequence generator [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/496351 (https://phabricator.wikimedia.org/T215462) (owner: XenoRyet) [18:36:15] (CR) jerkins-bot: [V: -1] c_t ids from the sequence generator [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/496351 (https://phabricator.wikimedia.org/T215462) (owner: XenoRyet) [18:36:25] (Merged) jenkins-bot: Adjust omnirecipient repair to reflect a daylight savings change. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/503542 (https://phabricator.wikimedia.org/T200240) (owner: Eileen) [19:03:12] (CR) Ejegg: "Think I found the cause of the failures, XenoRyet" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/496351 (https://phabricator.wikimedia.org/T215462) (owner: XenoRyet) [19:12:54] (PS3) Ejegg: Bump required MW >= 1.30.0 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/493978 (https://phabricator.wikimedia.org/T217498) (owner: Reedy) [19:13:23] (PS16) XenoRyet: c_t ids from the sequence generator [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/496351 (https://phabricator.wikimedia.org/T215462) [19:15:58] (CR) jerkins-bot: [V: -1] c_t ids from the sequence generator [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/496351 (https://phabricator.wikimedia.org/T215462) (owner: XenoRyet) [19:17:41] (CR) XenoRyet: "Ok, that's got the errors taken care of, but still that failure that I'm not getting locally. Still trying to figure that out." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/496351 (https://phabricator.wikimedia.org/T215462) (owner: XenoRyet) [19:20:13] RECOVERY - check_puppetrun on frdev1001 is OK: OK: Puppet is currently enabled, last run 2 minutes ago with 0 failures [19:23:42] XenoRyet: I do get that failure locally [19:24:09] Interesting, I wonder what's different about my setup. [19:25:04] The comparison with $ddObj->getCleanTrackingData seems a little tautological, too [19:25:33] maybe just specify the exact array you expect in the test? [19:25:59] My theory there was that what went on the queue was what we get when we ask for tracking data, but I can change that. [19:26:32] also, you can use SourceFields::removeFromMessage if you want, to ignore the locally-set stuff [19:30:57] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 9 others: find another way to compile the donor list for... - https://phabricator.wikimedia.org/T118822 [19:31:14] cwd, Jeff_Green want to hop in the chat to talk about upgrading the main cluster? [19:56:00] fundraising-tech-ops: upgrade payments servers from Debian Jessie to Stretch - https://phabricator.wikimedia.org/T221036 (Jgreen) [19:59:49] fundraising-tech-ops: EPIC: migrate fundraising off of Debian Jessie - https://phabricator.wikimedia.org/T185013 (Jgreen) [19:59:52] fundraising-tech-ops: test and deploy payments on Debian Stretch/PHP7.0 - https://phabricator.wikimedia.org/T202290 (Jgreen) Open→Resolved We've worked out all the identified upgrade-related issues with the test cluster, and are ready to upgrade the main cluster. [20:11:19] PROBLEM - check_mysql on payments1003 is CRITICAL: Cant connect to local MySQL server through socket /var/run/mysqld/mysqld.sock (2 No such file or directory) [20:11:21] PROBLEM - check_payments_wiki on payments1003 is CRITICAL: HTTP CRITICAL: HTTP/1.1 500 Internal Server Error - string OK not found on https://payments1003.frack.eqiad.wmnet:443https://payments.wikimedia.org/index.php/Special:SystemStatus - 683 bytes in 0.065 second response time [20:16:19] RECOVERY - check_mysql on payments1003 is OK: Uptime: 26 Threads: 1 Questions: 1 Slow queries: 0 Opens: 17 Flush tables: 1 Open tables: 11 Queries per second avg: 0.038 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 [20:16:23] PROBLEM - check_payments_wiki on payments1003 is CRITICAL: HTTP CRITICAL: HTTP/1.1 500 Internal Server Error - string OK not found on https://payments1003.frack.eqiad.wmnet:443https://payments.wikimedia.org/index.php/Special:SystemStatus - 683 bytes in 0.052 second response time [20:21:19] PROBLEM - check_payments_wiki on payments1003 is CRITICAL: HTTP CRITICAL: HTTP/1.1 502 Bad Gateway - string OK not found on https://payments1003.frack.eqiad.wmnet:443https://payments.wikimedia.org/index.php/Special:SystemStatus - 384 bytes in 0.009 second response time [20:21:21] PROBLEM - check_puppetrun on payments1003 is CRITICAL: CRITICAL: Puppet has 21 failures. Last run 1 minute ago with 21 failures. Failed resources (up to 3 shown): Package[libapache2-mod-php],Package[libpam-systemd],Package[php-mbstring],Package[php-soap] [20:22:54] (CR) Ejegg: [C: +2] Bump required MW >= 1.30.0 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/493978 (https://phabricator.wikimedia.org/T217498) (owner: Reedy) [20:25:34] (CR) Ejegg: "Yeah, that shtml path could certainly live someplace else" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/503450 (https://phabricator.wikimedia.org/T220512) (owner: Ejegg) [20:26:13] PROBLEM - check_apache2 on payments1003 is CRITICAL: PROCS CRITICAL: 0 processes with command name apache2 [20:26:23] PROBLEM - check_payments_wiki on payments1003 is CRITICAL: HTTP CRITICAL: HTTP/1.1 502 Bad Gateway - string OK not found on https://payments1003.frack.eqiad.wmnet:443https://payments.wikimedia.org/index.php/Special:SystemStatus - 384 bytes in 0.008 second response time [20:26:23] PROBLEM - check_puppetrun on payments1003 is CRITICAL: CRITICAL: Puppet has 21 failures. Last run 4 minutes ago with 21 failures. Failed resources (up to 3 shown): Package[libapache2-mod-php],Package[libpam-systemd],Package[php-mbstring],Package[php-soap] [20:28:43] fr-tech I think I will take tomorrow off [20:29:55] need to get some stuff done here [20:31:13] RECOVERY - check_apache2 on payments1003 is OK: PROCS OK: 7 processes with command name apache2 [20:31:23] RECOVERY - check_payments_wiki on payments1003 is OK: HTTP OK: HTTP/1.1 200 OK - 417 bytes in 0.028 second response time [20:31:23] RECOVERY - check_puppetrun on payments1003 is OK: OK: Puppet is currently enabled, last run 12 seconds ago with 0 failures [20:31:48] shoot, what's up with the mysql server? [20:35:00] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 4 others: Iterate on DS fredge query - https://phabricator.wikimedia.org/T219646 (MBeat33) Thank... [20:44:57] (Merged) jenkins-bot: Bump required MW >= 1.30.0 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/493978 (https://phabricator.wikimedia.org/T217498) (owner: Reedy) [20:47:39] Fundraising-Backlog, fundraising-tech-ops, MediaWiki-extensions-DonationInterface: Can we bump DonationInterface's required MW version? - https://phabricator.wikimedia.org/T217498 (Reedy) Open→Resolved a:Reedy [20:47:43] (CR) Jgleeson: [C: +2] Flesh out Adyen doPayment with data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/502892 (https://phabricator.wikimedia.org/T220512) (owner: Ejegg) [20:51:19] PROBLEM - check_mysql on payments1003 is CRITICAL: Slave IO: Connecting Slave SQL: Yes Seconds Behind Master: (null) [20:52:59] Jeff_Green: is that expected ^^^ ? [20:53:34] yeah, I'm upgrading the payments servers and I didn't mute them for long enough [20:53:49] payments100x are not in play in any way for the live site [20:54:38] (Merged) jenkins-bot: Flesh out Adyen doPayment with data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/502892 (https://phabricator.wikimedia.org/T220512) (owner: Ejegg) [20:55:14] ok, cool. There are some other db-related failures at the same time, but I guess it's just a coincidence. Checking for bad queries [20:55:54] those are in the payments200x logs? [20:56:19] PROBLEM - check_mysql on payments1003 is CRITICAL: Slave IO: Connecting Slave SQL: Yes Seconds Behind Master: (null) [20:56:36] Jeff_Green: no, we're getting failmails from queue consumers [20:57:03] that doesn't talk to the paymentsdb does it? [20:57:45] no, just the main civi db [20:57:58] ACKNOWLEDGEMENT - check_mysql on payments1003 is CRITICAL: Slave IO: Connecting Slave SQL: Yes Seconds Behind Master: (null) Jeff_Green temporary casualty of OS upgrade [20:58:11] yeah I can't think of any way it could be related [20:58:26] hmm, only one long query, and it's the mailing data fix which only touches civicrm_mailing_provider_data [21:00:58] have a good evening fr-tech and enjoy GoT! [21:01:19] RECOVERY - check_mysql on payments1003 is OK: Uptime: 2017 Threads: 1 Questions: 2019 Slow queries: 0 Opens: 18 Flush tables: 1 Open tables: 12 Queries per second avg: 1.000 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 [21:03:20] (PS4) Ejegg: Paypal forward-compatible JS, comments [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/502927 (https://phabricator.wikimedia.org/T220512) [21:05:21] (CR) Ejegg: "Thanks jgleeson, cleaned up" (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/502927 (https://phabricator.wikimedia.org/T220512) (owner: Ejegg) [21:09:35] (CR) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/504111 (owner: L10n-bot) [21:11:17] PROBLEM - check_mysql on payments1003 is CRITICAL: Slave IO: Connecting Slave SQL: Yes Seconds Behind Master: (null) [21:13:29] (PS4) Ejegg: Forward-compatible JS for Ingenico Connect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/502930 (https://phabricator.wikimedia.org/T220512) [21:13:31] (PS8) Ejegg: Donation API uses doPayment for all gateways [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/502923 (https://phabricator.wikimedia.org/T220512) [21:16:28] PROBLEM - check_mysql on payments1003 is CRITICAL: Slave IO: Connecting Slave SQL: Yes Seconds Behind Master: (null) [21:20:50] (PS3) Ejegg: Post-donation-API-refactor cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/503450 (https://phabricator.wikimedia.org/T220512) [21:20:52] (PS2) Ejegg: Mark redirects 'liberated' so we process return immediately [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/503532 (https://phabricator.wikimedia.org/T220512) [21:21:23] PROBLEM - check_mysql on payments1003 is CRITICAL: Slave IO: Connecting Slave SQL: Yes Seconds Behind Master: (null) [21:26:17] PROBLEM - check_mysql on payments1003 is CRITICAL: Slave IO: Connecting Slave SQL: Yes Seconds Behind Master: (null) [21:31:23] PROBLEM - check_mysql on payments1003 is CRITICAL: Slave IO: Connecting Slave SQL: Yes Seconds Behind Master: (null) [21:36:23] RECOVERY - check_mysql on payments1003 is OK: Uptime: 4117 Threads: 1 Questions: 4165 Slow queries: 0 Opens: 18 Flush tables: 1 Open tables: 12 Queries per second avg: 1.011 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 [22:48:53] (PS1) Ejegg: Opting in reverses opt-out fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/504213 (https://phabricator.wikimedia.org/T218240)