[00:03:08] hmm, maybe CI is checking out the wrong branch of vendor for the mediawiki fr/REL1_31 tests? [00:03:25] guess we need some CI repo work after all [01:02:44] fundraising-tech-ops: test and deploy payments on Debian Stretch/PHP7.0 - https://phabricator.wikimedia.org/T202290 (Ejegg) [01:02:44] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 7 others: Upgrade PaymentsWiki to Mediawiki 1.31 (new LT... - https://phabricator.wikimedia.org/T184460 [03:38:19] PROBLEM - Host frbackup2001 is DOWN: PING CRITICAL - Packet loss = 100% [03:40:19] RECOVERY - Host frbackup2001 is UP: PING OK - Packet loss = 0%, RTA = 36.24 ms [13:24:54] Fundraising Sprint Greps of Wrath, Fundraising Sprint H 2019, Fundraising-Backlog: Oanda API Bug - https://phabricator.wikimedia.org/T220859 (jgleeson) This just got a little tricker. The output of rates data (columns) wasn't lining up the number of days between my $from and $to boundaries... so I ex... [14:06:28] Fundraising-Backlog, fundraising-tech-ops: ccogdill has new yubikey, need to update frdev server access - https://phabricator.wikimedia.org/T220647 (cwdent) Open→Resolved a:cwdent [14:43:16] fundraising-tech-ops: configure and install frav1002.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T221274 (ayounsi) [15:05:46] Fundraising Sprint Greps of Wrath, Fundraising Sprint H 2019, Fundraising-Backlog: Oanda API Bug - https://phabricator.wikimedia.org/T220859 (Ejegg) Yeah, let's fill the holes in the spreadsheet that way. We should also check to see if the rates updater job is mis-configured. Feels like we should be... [15:13:52] agreed re: getting friday and not Sunday point ejegg [15:13:58] that didn't look right to me [15:14:14] I think fx markets are closed over the weekend [15:14:19] apart from crypto [15:14:27] so the friday end of day should be available [15:16:41] (PS4) Ejegg: Add handling for relationship type already existing [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/502368 (owner: Eileen) [15:16:48] (CR) Ejegg: [C: +2] Add handling for relationship type already existing [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/502368 (owner: Eileen) [15:21:12] (Merged) jenkins-bot: Add handling for relationship type already existing [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/502368 (owner: Eileen) [15:25:07] (CR) Hashar: "Looking at the jobs:" [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/504607 (owner: Ejegg) [16:07:42] Fundraising-Backlog: New mobile iFrame errors - https://phabricator.wikimedia.org/T221385 (MBeat33) [16:07:51] Fundraising-Backlog: Unfindable donor-facing error ref #s - https://phabricator.wikimedia.org/T221386 (MBeat33) [16:08:00] Fundraising-Backlog: Fix email address autocorrect for valid SE email addresses - https://phabricator.wikimedia.org/T221387 (MBeat33) [16:13:14] more laptop fun. one of my usb ports has decided it no longer wants to work [16:28:39] jgleeson_: does rebooting fix the problem? [16:28:53] not tried yet [16:28:58] will give it a go after standup [16:28:59] Sometimes there's an issue with some subsystem [16:29:10] I think there's some way to restart just that bit [16:55:18] Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising Sprint H 2019, Fundraising-Backlog, Patch-For-Review: Create variants for fancy new opt in pages on payments wiki - https://phabricator.wikimedia.org/T218240 (CCogdill_WMF) Talked with Elliott today, he s... [17:03:10] Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising Sprint H 2019, Fundraising-Backlog, Patch-For-Review: Create variants for fancy new opt in pages on payments wiki - https://phabricator.wikimedia.org/T218240 (DStrine) Also from today, we know that the re... [17:52:51] (PS3) Ejegg: Shrink log check window to a month before audit date [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/504600 [17:53:05] AndyRussG: ^^^ [17:53:18] extracted the constant, and added more comment [17:53:37] there's a parent patch that'll need review too, which is just a var rename [17:55:39] (anyone else in fr-tech is also welcome to review, of course!) [17:55:59] ejegg: thx, chcecking it out [18:22:03] ejegg: where does wmf_common_date_add_days() live? [18:22:25] oh nvm found it [18:28:03] dstrine: the e-mail thing that you said gets into civi easily, that should be looked at, was the remind-me-later function in banners, right? or did I misunderstand? [18:30:55] AndyRussG: yeah remind me later [18:31:59] but AndyRussG I don't think CN has much info on that. RML from a banner goes to IBM then "something" imports those emails addresses from IBM into Civi [18:32:05] that second part is the important part [18:32:27] we don't know how it's making a civi record without a name [18:32:41] maybe it's putting junk in the name section. We don't know [18:35:00] dstrine: ah ok gotcha [18:35:30] yeah the only part I know about is how the banner sends it to silverpop, so that's not the important bit then [18:35:32] cstone: ^ [18:37:04] AndyRussG: cstone is there an easy way for us to look at a list of ways in which civi and IBM talk to one another? This would be a job that runs once a day or something? [18:37:28] you could then see how eileen set it up [18:37:30] :/ [18:38:57] dstrine heheh sounds like something that ejegg or eileen shouldn't tell us the answer to? [18:40:23] is there a way to set up the remind me later locally? [18:42:06] cstone lemme find the banner code, at least that might say something about what silverpop does with it, I guess? [18:44:08] cstone: AndyRussG another idea: is there a way to look up automatic activities in civi? We import data from ibm into civi about all email sends so this might be lumped into those. [18:44:42] * AndyRussG stares into the void of the unknown [18:45:50] lol in the sidebar in civi I have 2 administration links. one of them I don't have permissions for [18:49:16] there's a scheduled jobs list under system settings [18:53:58] cstone it looks like we're only using that for scheduled reminders...though ejegg do we know why process_smashpig_recurring isn't enabled? [18:54:05] Seddon: just noticed this info on meta is incorrect: "Note: Campaigns are not cached - rather, banners assigned to campaigns are cached." [18:54:11] oop ejegg|food for when you get back ^^ [18:54:26] campaigns are cached using the ResourceLoader cache schedule, so like 10 min IIRC [18:57:45] dstrine: can you identify offhand any campaigns that had remind-me-later in the banners? not finding any just yet [18:59:32] mepps oh shoot, it's disabled? [18:59:41] looks like it ejegg|food [18:59:42] argh [18:59:59] how long has that been the case [19:00:07] dstrine: okok found one [19:00:13] I mean nvm :) [19:00:31] last run january 3 ejegg [19:01:08] wtf? so no new ingenico recurring all this year?? [19:01:11] oh man [19:01:27] AndyRussG: caitlin said that italy had one but she doesn't see any of those in civi yet [19:01:35] woah that is a huge problem, how did that happen? [19:02:02] eek [19:02:12] dstrine: ok thanks, also eek [19:02:14] I just read the new ingenico recurring stuff [19:02:27] well turn it back on? [19:02:27] i wonder if they got disabled during an upgrade? [19:02:47] yeah, ejegg any reason i shouldn't just enable it right now? [19:03:30] MBeat: ^^^^ new ingenico recurring hasn't been on since january 3rd and we're thinking of turning it back on [19:03:49] in meeting [19:03:59] mepps: and ejegg we haven't used it that much so there aren't nearly as many people on it compared to old ingenico and paypal [19:04:20] mepps what's the commit message for the patch that disabled it? [19:04:39] this is also why we need regular metrics on this stuff from fr-online [19:05:15] ejegg i don't know, i saw this in the user interface, let me look if a patch disabled it [19:06:10] mepps ahhh, the process-control job isn't disabled? [19:06:25] we don't run anything via civi cron anymore [19:06:29] ohhh [19:06:49] so i'm confused why there's a greyed out option in scheduled jobs then [19:07:03] becuase ti looks like we had a scheduled job that ran in january but not since [19:08:24] ejegg ^^ [19:10:25] mepps it was running double at one point [19:10:43] we had to refund some double charges [19:11:34] so do we still need a civi scheduled job? i ask because it adds some confusion like my thinking it wasn't working/someone else could turn it on [19:11:53] dstrine ^ it looks like this was a misunderstanding and we think the job was running now [19:12:15] mepps we need the job to exist so we can call it via drush, yeah [19:12:31] ejegg ah, why doesn't it update the last run date then? [19:12:38] not sure [19:12:48] the process-control job is active? [19:13:05] looking now [19:13:59] is rg the alias for it? [19:14:39] it looks like it's enabled [19:14:49] that sounds like the old recurring globalcollect [19:15:03] cstone: here is how banners send e-mail data for remind-me-later functionality to silverpop: https://tools.wmflabs.org/paste/view/536a86db [19:15:13] the new one should have 'smashpig' in the yaml filename [19:15:15] www.pages04.net is a silverpop endpoint [19:16:18] ingenico_smashpig_job_runner appears enabled [19:16:19] the details of how the banner sends it are not important at this point, I think but if you want to see it happen, you can disable CSP warnings in your browser, open the network tab, the go to this URL https://meta.wikimedia.org/w/index.php?title=Fellowship_News/2012-09/Summary&banner=B1718_123100_en6C_dsk_p1_lg_dsn_decal4&uselang=en&force=1 [19:16:30] mepps ok, good stuff [19:16:33] then click on the button and enter an e-mail address [19:17:00] so in the form data B1718_123100_en6C_dsk_p1_lg_dsn_decal4 is the banner the request comes from [19:17:05] does that run multiple ingenico-related smashpig jobs ejegg? [19:17:56] no, just the recurring charge [19:21:44] hmm that doesn't look like it's using drush, should it ejegg? [19:25:21] cstone dstrine this the task? I guess I should put the above notes there? https://phabricator.wikimedia.org/T217710 [19:26:08] mepps what is it using? [19:28:04] AndyRussG: this one I thought? https://phabricator.wikimedia.org/T218240 [19:29:16] cstone: ah that also makes sense... really I have no idea... so I'll comment there? [19:29:36] looks like it, from dstrine's last coment there [19:39:05] (CR) AndyRussG: "Cool thanks!!! Just a few nit-picks about the comments." (3 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/504600 (owner: Ejegg) [19:39:15] ejegg: ^ [19:41:37] cstone: and AndyRussG the correct task is T218240 [19:41:38] T218240: Create variants for fancy new opt in pages on payments wiki - https://phabricator.wikimedia.org/T218240 [19:41:49] dstrine: okok th [19:41:53] x [19:45:27] ty dstrine hey all, what would turning the recurring back on look like to donors? three new charges? that might be alarming to them [19:46:33] MBeat: It would be new charges after a long break. They may have missed ~3 charges if this was truly down since January 3rd. [19:47:06] thanks, that’s easier to message [19:48:51] Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising Sprint H 2019, Fundraising-Backlog, Patch-For-Review: Create variants for fancy new opt in pages on payments wiki - https://phabricator.wikimedia.org/T218240 (AndyRussG) In case it's useful, here are deta... [19:57:32] dstrine, it's a holiday here tomorrow and Monday so I'm gonna do as much as I can on the expense form work before I finish up tonight. I think it will probably roll into tuesday but I'll leave notes on the ticket so that someone else can maybe pick it up if we need it quicker while I'm away [19:58:34] jgleeson_: ok I think everyone else will be full while you are out. Let's just keep touch on the progress [19:58:47] sure [19:59:44] gotta run to an appointment. [20:00:30] dstrine, MBeat we're trying to confirm that recurring hasn't run, it's not so clear [20:00:40] ty mepps [20:01:21] MBeat do you happen to know of any cids where there are definitely ingenico recurring contribs? [20:01:57] basically in civi it looks like the job hasn't run but it looks like is set up to run so i'm wondering if it's an issue with the scheduled job logs, or whether it actually hasn't run correctly [20:18:49] Fundraising-Backlog: CiviCRM Scheduled job log should reflect jobs run through drush - https://phabricator.wikimedia.org/T221404 (mepps) [20:32:34] (CR) Ejegg: "recheck" [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/504607 (owner: Ejegg) [20:34:37] sorry mepps i was on a call - do you still need CIDs? [20:35:26] MBeat: i think we're fine [20:35:33] ty [20:46:35] (CR) Ejegg: [C: +2] Add 'platform' to composer.json [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/504607 (owner: Ejegg) [20:48:35] (Merged) jenkins-bot: Add 'platform' to composer.json [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/504607 (owner: Ejegg) [20:51:35] (CR) jenkins-bot: Add 'platform' to composer.json [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/504607 (owner: Ejegg) [20:52:04] fundraising-tech-ops: configure and install frav1002.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T221274 (Jgreen) [20:52:06] fundraising-tech-ops: iptables policy for frav1002.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T221276 (Jgreen) Open→Resolved deployed and working [20:54:01] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/504984 [20:56:23] (CR) Ejegg: [C: +2] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/504984 (owner: Ejegg) [20:58:14] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/504984 (owner: Ejegg) [21:01:16] (CR) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/504984 (owner: Ejegg) [21:06:35] (PS1) Ejegg: WIP rebuild email forms in DonationInterface [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/504987 (https://phabricator.wikimedia.org/T218171) [21:09:18] (CR) jerkins-bot: [V: -1] WIP rebuild email forms in DonationInterface [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/504987 (https://phabricator.wikimedia.org/T218171) (owner: Ejegg) [21:10:38] fundraising-tech-ops: configure and install frav1002.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T221274 (Jgreen) frav1002 is up and running - aiderator is set up and seems to be working correctly - dmarc parser is set up and seems to be working correctly TBD: - confirm offhost backup job runs cor... [21:52:36] !log updated payments-wiki from aa8dad50e7 to 2f7cd8f195 [21:52:39] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:56:51] oh fooey, adyen's not working [21:58:41] !log rolled back payments-wiki to aa8dad50e7 [21:58:43] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:00:06] Fundraising Sprint Greps of Wrath, Fundraising Sprint H 2019, Fundraising-Backlog: Oanda API Bug - https://phabricator.wikimedia.org/T220859 (jgleeson) Ok, the master document now has historic date up to yesterday. https://docs.google.com/spreadsheets/d/1ys-6YCbmQKbeoNrwyj2uVAxKSGoYAdCptPLjMLmODj4/ed... [22:01:06] dstrine, the script to generate the master document with historic data is done and currently living on the ticket for now. The output is here https://docs.google.com/spreadsheets/d/1ys-6YCbmQKbeoNrwyj2uVAxKSGoYAdCptPLjMLmODj4/edit#gid=1943832082 [22:01:23] yay! congrats and thanks!!! [22:01:36] jgleeson_: so it's activelyupdating? [22:01:43] or will? [22:02:42] I'm looking at wiring in ejegg's daily updater code now [22:03:12] jgleeson_: do you see the triggers link? [22:03:29] I disabled the trigger on my original sheet cause it was failing once the key changed [22:04:01] this video show how: https://www.youtube.com/watch?v=LSDoRGimlEY [22:04:09] ah ok, thanks! [22:04:54] XenoRyet: any luck with that test on the contribution_tracking patch? [22:05:28] ok I might dig into that next week as it's probably not as simple as just dropping it in [22:05:48] I still don't know why I'm getting different errors. [22:05:58] ideally wanted to hand it over tonight with that part working dstrine but I don't think it's doable. Sorry man! [22:06:22] I'm having a few vagrant issues in the mean time though, NFS shares broke. [22:06:41] And I'm truthfully not 100% here today, not feeling as better as I'd hoped. [22:07:18] btw fr-tech, is friday/monday a holiday in the US? [22:09:01] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: harmonize currency & amount in TY emails - https://phabricator.wikimedia.org/T220636 (MBeat33) One other possible approach mentioned in the fr-tech/DS meeting yesterday would be forgoing the use of currency symbols entirely, in favor of the three-... [22:09:06] jgleeson_: monday is, but not tomorrow [22:09:24] ah ok [22:09:27] but in Colombia, today and tomorrow are holidays [22:10:44] (PS4) Ejegg: Shrink log check window to a month before audit date [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/504600 [22:10:51] AndyRussG: OK, comments updated again ^^^ [22:11:30] ejegg, the coffee shop I was in today were proud of the Colombian origins of their coffee beans. they had info about the place they were grown in, I meant to ask you if you knew the place on standup. I can't remember the name of it now, grrr. I'll get it next time I'm in :) [22:11:53] ahh, I actually still haven't gotten around to visiting the coffee region [22:13:25] I went to one cool coffee shop in cyprus that roasted the beans on one side of the room and served you the coffee on the other [22:13:48] although I guess it's not entirely safe to do the two things in the same shop :) [22:16:36] My mom owns a little coffee shop where they do their own roasting. It's in the same building, but admittedly not right there in the shop itself. [22:16:41] I think you can just make out the machine in this photo http://beanhaus.eu/#prettyPhoto[gallery]/11/ [22:17:10] although shop wasn't that tidy when I went in September, they had sacks bags of coffee beans all over the place [22:17:21] nice XenoRyet! [22:17:27] Ah yea, that's the roaster right out there with the customers. I'd not put it there myself. [22:18:06] That is one of the things, you do inevitably end up with big half open bags of beans in the room with the roaster. [22:18:16] ha :) [22:31:51] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: harmonize currency & amount in TY emails - https://phabricator.wikimedia.org/T220636 (CCogdill_WMF) You mean removing the symbol from the first sentence? Is that to reduce donor confusion? I'd prefer not to change that part unless you think we sho... [22:32:40] well heck, i'm not getting any similar error on my local when I try with the version I just deployed [22:34:23] ok dstrine ejegg, the auto-updating part is plumbed in. I've added the trigger ejegg to run daily at 1am. I ran it manually just now and watched it slowly but surely iterate across each row and drop in today's rates for day 108 of this year. https://docs.google.com/spreadsheets/d/1ys-6YCbmQKbeoNrwyj2uVAxKSGoYAdCptPLjMLmODj4/edit#gid=1943832082 [22:35:24] hmm the trigger seems to be tied specifically to my google account. Would be better if it was document specific [22:36:36] I won't post the link to the script on the ticket, as it contains our new API key hardcoded within it [22:37:00] I'll email it around to be reviewed [22:37:11] along with the master document script. [22:37:57] jgleeson_: nice! [22:38:24] jgleeson_: yay thanks! [22:38:36] jgleeson_: how are you still awake? [22:38:39] we're missing 107, which is due to me generating the document locally and not having last nights rates. I can add them in manually though as it's only one column so not too much trouble [22:38:57] ha dstrine, my 3 month old dictates my sleeping pattern [22:39:03] eek [22:39:06] this is early for me, 11:39pm [22:39:12] :P [22:39:17] on that note [22:39:20] have a good weekend fr-tech [22:39:24] seeya [22:39:24] bye for now! [22:39:33] oho, I think I only had errors with payments because I was trying to load the debug version [22:39:42] trying the deploy again [22:40:48] !log updated payments-wiki from aa8dad50e7 to 2f7cd8f195 [22:40:51] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:41:25] ahh, yeah, non-debug mode works! [22:42:13] hmm, but the donation was rejected [22:42:18] let's see what's up with that [22:43:06] ah, i see. trying again [22:45:56] and... old globalcollect is broken [22:46:03] ugh, rolling back again [22:46:20] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: harmonize currency & amount in TY emails - https://phabricator.wikimedia.org/T220636 (MBeat33) The sense I got was that inserting the symbol is part of what makes the back end more complicated; @Ejegg is that a fair summary? As it is now, do we u... [22:48:41] oh shoot, I see now [22:50:29] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/505002 [22:50:34] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/505002 (owner: Ejegg) [22:51:09] hmm, volume seems low enough just now that we could deploy it all at once [23:00:58] (Abandoned) Ejegg: PaymentTransactionResponse::setData allows append [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/499807 (owner: Ejegg) [23:01:33] (PS5) Ejegg: Use special form variant for redirect to hosted Connect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/499942 [23:03:44] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/505005 [23:06:17] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/505002 (owner: Ejegg) [23:06:55] (CR) Ejegg: [C: +2] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/505005 (owner: Ejegg) [23:07:11] (CR) jerkins-bot: [V: -1] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/505005 (owner: Ejegg) [23:08:44] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/505005 (owner: Ejegg) [23:10:30] !log updated payments-wiki from aa8dad50e7 to eb3d0f35de [23:10:36] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:11:36] (CR) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/505005 (owner: Ejegg) [23:27:12] well, things seem to be working OK this time around [23:29:01] AndyRussG: does the latest version of the patch look good to you? [23:29:10] https://gerrit.wikimedia.org/r/504600 [23:35:40] ejegg: looking [23:46:54] ejegg: lgtm! should I +1 or +2? Again, I can't test it anywhere [23:47:38] AndyRussG: +2 would be great! [23:48:28] (CR) AndyRussG: [C: +2] "Woohoo! Nice :) Apologies for the nittiness" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/504600 (owner: Ejegg) [23:48:35] done!