[00:01:19] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/507527 (owner: Eileen) [00:11:29] ejegg: just looking at populating old system cancel data - I see my query https://phabricator.wikimedia.org/T218616#5060284 [00:11:46] the thing is the first bit ‘I added an index’ - [00:12:10] I see it wasn’t a slow index to add - probably due to a relatively small table [00:12:25] if I add it should I drop it again afterwards? [00:19:38] (PS1) Eileen: Add Recurring Contribution pivot chart. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/507529 (https://phabricator.wikimedia.org/T218616) [00:19:50] (CR) jerkins-bot: [V: -1] Add Recurring Contribution pivot chart. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/507529 (https://phabricator.wikimedia.org/T218616) (owner: Eileen) [00:30:48] (PS2) Eileen: Add Recurring Contribution pivot chart. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/507529 (https://phabricator.wikimedia.org/T218616) [00:54:19] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MinervaNeue, Accessibility, and 2 others: Banner/CentralNotice should be child of `header` and not above it - https://phabricator.wikimedia.org/T205360 (Jseddon) Here are some mockups of this banner design with some common campaigns: Wiki... [02:03:33] (PS1) Eileen: Fix typo from 4660dd67a39c143a3244629b [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/507533 [02:04:13] If anyone is around that typo ^^^ is a no brainer to +2 but would save someone else having to find it - makes drush noisy no production impact [02:05:01] actually I’m gonna self-merge it’s so clear cut [02:06:10] (CR) Eileen: [C: +2] "Self-merging as" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/507533 (owner: Eileen) [02:10:22] (Merged) jenkins-bot: Fix typo from 4660dd67a39c143a3244629b [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/507533 (owner: Eileen) [02:40:42] (PS1) Eileen: Back-populate recurring cancel_reason. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/507534 (https://phabricator.wikimedia.org/T218616) [07:16:00] (CR) Eileen: "See civicrm/report/instance/153?reset=1&force=1 on gerrit for common sense checking the result" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/507534 (https://phabricator.wikimedia.org/T218616) (owner: Eileen) [07:16:09] (CR) Eileen: "See civicrm/report/instance/153?reset=1&force=1 for output" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/507529 (https://phabricator.wikimedia.org/T218616) (owner: Eileen) [07:21:54] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 9 others: Reduce recurring TY emails - https://phabricator.wikimedia.org/T213209 (jrobell) Thank... [09:46:24] (PS1) Eileen: [do not merge] recent apiv4 updates with some hacks for staging testing [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/507539 [09:47:41] (PS1) Eileen: [do not merge] url generator form wip [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/507540 [09:48:35] (CR) jerkins-bot: [V: -1] [do not merge] url generator form wip [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/507540 (owner: Eileen) [10:07:58] (PS2) Eileen: [do not merge] url generator form wip [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/507540 [10:08:46] (CR) jerkins-bot: [V: -1] [do not merge] url generator form wip [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/507540 (owner: Eileen) [10:09:12] (PS3) Eileen: [do not merge] url generator form wip [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/507540 [10:10:00] (CR) jerkins-bot: [V: -1] [do not merge] url generator form wip [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/507540 (owner: Eileen) [11:15:53] (PS4) Eileen: [do not merge] url generator form wip [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/507540 [11:16:46] (CR) jerkins-bot: [V: -1] [do not merge] url generator form wip [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/507540 (owner: Eileen) [11:36:17] (PS5) Eileen: [do not merge] url generator form wip [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/507540 [11:37:08] (CR) jerkins-bot: [V: -1] [do not merge] url generator form wip [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/507540 (owner: Eileen) [11:45:57] (PS6) Eileen: [do not merge] url generator form wip [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/507540 [11:46:46] (CR) jerkins-bot: [V: -1] [do not merge] url generator form wip [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/507540 (owner: Eileen) [12:02:43] (PS7) Eileen: [do not merge] url generator form wip [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/507540 [12:03:36] (CR) jerkins-bot: [V: -1] [do not merge] url generator form wip [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/507540 (owner: Eileen) [12:42:18] (PS8) Eileen: [do not merge] url generator form wip [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/507540 [12:43:11] (CR) jerkins-bot: [V: -1] [do not merge] url generator form wip [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/507540 (owner: Eileen) [12:54:29] (PS9) Eileen: [do not merge] url generator form wip [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/507540 [12:55:26] (CR) jerkins-bot: [V: -1] [do not merge] url generator form wip [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/507540 (owner: Eileen) [13:05:54] (PS1) Umherirrender: Add alias for special page EmailPreferences [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/507556 [14:12:43] hey fr-tech, anyone got anything that needs some review? [14:13:19] jgleeson: g'dafternoon! actually yeah one sec [14:14:21] jgleeson: https://phabricator.wikimedia.org/T221122 [14:14:30] thx in advance! [14:14:36] no rush, also :) [14:16:26] thanks AndyRussG, will take a look :) [14:17:52] brb [15:08:21] fr-tech: any news for scrum of scrums? [15:08:39] ejegg: nothin' here, thx! [15:38:49] Fundraising Sprint Hansel and grep -l, Fundraising Sprint It Came From Out of Scope, Fundraising-Backlog: 1-month update for privacy policy - https://phabricator.wikimedia.org/T220428 (Ejegg) So we tack this on the end of the existing 'donate_interface-informationsharing' string, right? That current... [15:46:33] AndyRussG: got a ping from performance on these two patches: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CentralNotice/+/506232/ and https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CentralNotice/+/506317/ [15:50:07] ejegg: gotcha thx! [15:50:19] yeah I'd seen the second one, but not the first [15:50:33] they have a few other smaller ones on the stove there, too [15:54:24] Fundraising Sprint Hansel and grep -l, Fundraising Sprint It Came From Out of Scope, Fundraising-Backlog: 1-month update for privacy policy - https://phabricator.wikimedia.org/T220428 (DStrine) @Ejegg Let's use the copy from @Pcoombe at the beginning and take out the last sentence "for more informati... [15:59:11] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 9 others: Reduce recurring TY emails - https://phabricator.wikimedia.org/T213209 (TSkaff) @Ejegg... [16:31:16] fr-tech, anyone want to knock out that text update? [16:31:23] looks like a bit of copy-pasting [16:31:44] and some deducing of which parts of translated messages are the last sentence [16:34:30] ejegg: meeting? [16:36:09] oops. be right there! [17:26:53] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: make sure Forget Me requests reach IBM - https://phabricator.wikimedia.org/T222287 (MBeat33) [17:30:38] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: make sure Forget Me requests reach IBM - https://phabricator.wikimedia.org/T222287 (MBeat33) [17:31:44] fr-tech it looks like ingenico added a new template for their hosted payments pages, specifically for iframes [17:32:06] it actually removes the stuff we're just setting to white-on-white now [17:34:19] Fundraising-Backlog, FR-Ingenico: set up and test new iframe setting for ingenico - https://phabricator.wikimedia.org/T222290 (DStrine) [17:37:03] ejegg: fr-tech I made a task but it's definitely not in the sprint. This isn't a priority right now. We'll talk about it next sprint planning [17:37:18] but still exciting [17:47:15] thanks dstrine [17:48:52] Fundraising-Backlog: New mobile iFrame errors - https://phabricator.wikimedia.org/T221385 (Ejegg) If the problem does have to do with virtual scrolling, T222290 should fix it [18:16:36] cstone: try using --languages= instead of just languages= [18:16:49] also, add -v -v afterward to get all the output [18:17:49] ejegg that is doing somthing! [18:17:57] great! [18:18:19] so do you see any warnings in the output? [18:21:20] cstone: ^^^ ? [18:22:06] i dont see anything that says warnings lots of Found 1 likely tokens "$amount" in rendered thank-you translation. [18:22:20] aha, so we have problems [18:22:33] specifically, with the on-wiki translations [18:22:56] so in general, I'll go in and fix those, then ask jrobell to set the fixed versions to 'published' [18:23:09] yeah, in https://meta.wikimedia.org/wiki/Fundraising/Translation/Thank_you_email_2018-10-01/de [18:23:24] you can see they're using [amount] in the first and last paragraphs [18:23:37] but the newly updated recurring paragraph in the middle uses $amount [18:24:25] want to split the pages? I'll start from the end of the language list and you can start with de [18:26:03] ah okay so the $amount needs to be [amount]? [18:27:36] yep yep [18:32:54] hmm, hebrew version is tricky to edit [18:33:29] Hi both! You can ask me to make those changes ... [18:34:14] tskaff: hi! Yeah, we're just seeing the amount variable as $amount instead of [amount] in a bunch of the translations [18:34:52] in the translate UI though they all seem to be $amount? [18:35:30] I think I just changed the hebrew version, but I'm not sure I followed the right steps for the translation [18:35:45] cstone oh weird, even in the source bits [18:36:04] so... where is that coming from - the en version of the full letter has the correct [amount] [18:36:23] cc-ing pcoombe in case he's around [18:36:35] cstone: also, let's look into updating the code to handle $amount [18:37:12] hmm hmm [18:37:15] or not? [18:37:42] ok, looking at the en version, we really don't have any $variables [18:39:00] tskaff: do you have any idea why, when we click on translate for any of the non-english versions, the english chunks have different variable syntax from the english text on https://meta.wikimedia.org/w/index.php?title=Fundraising/Translation/Thank_you_email_2018-10-01 ? [18:39:29] Do those english chunks live in a different page? [18:39:50] ooh, i see a tvar thing [18:39:56] i dont see anything different in the UI on the de page between the first $amount thats working and the second $amount thats not [18:40:08] I guess the tvar bit is messing with us [18:40:10] You mean here (for English)https://meta.wikimedia.org/w/index.php?title=Fundraising/Translation/Thank_you_email_2018-10-01&action=edit [18:40:13] ? [18:40:39] yeah, I guess the translated versions all end up with $variable [18:41:05] when they should keep the [variable] syntax that shows in the english version [18:41:30] Yeah tvar ... so confusing ... I understand this email is a weird mix of translate extension tags, minimal wiki markup, and some tags like [date] are processed by Civi [18:42:24] But just let me know which ones to update (like should every $amount tags be [amount]) and I'm happy to update! [18:43:10] tskaff: so, all the tokens in all languages should use the same syntax as English [18:43:23] all [variable], no $variable [18:43:31] That makes sense :) [18:43:44] and for example [given name] instead of $givenname [18:44:20] Ok let me take a look at 'em [18:44:57] Maybe we should scrap the tags? Those seem to make the existing token text disappear in the translation interface [18:45:47] hmm hmm hmm, ok, now i'm confused [18:46:34] So am I. Ah. So when you look at this page (english) tags are correct: https://meta.wikimedia.org/wiki/Fundraising/Translation/Thank_you_email_2018-10-01 [18:46:43] yep! [18:46:58] but when you view the translation, the tags are the $ variables: https://meta.wikimedia.org/w/index.php?title=Special:Translate&group=page-Fundraising%2FTranslation%2FThank+you+email+2018-10-01&action=page&filter=&language=de [18:47:07] (some of them) [18:47:07] maybe someone changed how works lately? [18:47:12] Blerg [18:47:18] srsly [18:47:26] So if I look at last year's [18:47:30] e.g. french [18:47:45] the variables look fine in 'read' mode [18:47:57] but when I go into 'translate', they're all $variable [18:48:18] jeez [18:48:51] I think I need some clarification from the language team [18:49:29] Maybe Peter has some background too? But happy to check w. Niklas [18:50:28] pcoombe: do you know if something has changed since last year re: tvars and [amount] vs $amount syntax? [18:53:59] (CR) Jgleeson: [C: +2] "Looking good! works as expected and the code looks clean :)" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/504388 (https://phabricator.wikimedia.org/T221122) (owner: AndyRussG) [18:54:30] fr-tech, sorry for arriving unfashionably late to standup earlier I got stuck in terrible traffic on the way home. [18:54:54] No worries. Being in southern california, traffic is something I deeply understand. [18:55:16] jgleeson: yeah no worries!!!!!! also thanks again for the review :) [18:55:28] np!! [18:56:05] nick jgleeson|baksoon [18:56:08] lol [19:12:00] Fundraising Sprint It Came From Out of Scope, Fundraising Sprint Navel Warfare, Fundraising Sprint Outie Inverter, Fundraising Sprint Prank Seatbelt, and 6 others: Import email-only contacts from 'remind me later' links into CiviCRM - https://phabricator.wikimedia.org/T160949 (DStrine) [19:12:50] Fundraising Sprint It Came From Out of Scope, Fundraising Sprint Navel Warfare, Fundraising Sprint Outie Inverter, Fundraising Sprint Prank Seatbelt, and 6 others: Import email-only contacts from 'remind me later' links into CiviCRM - https://phabricator.wikimedia.org/T160949 (DStrine) Let's turn... [19:23:24] Fundraising-Backlog, fundraising-tech-ops: Outage to reload triggers - https://phabricator.wikimedia.org/T222001 (CCogdill_WMF) Remind me--will this be affecting payments or only Civi? If only Civi, emails can run whenever. If payments, too, Fridays and Mondays are the best days for the email team. [19:34:55] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 5 others: Iterate on DS fredge query - https://phabricator.wikimedia.org/T219646 (DStrine) [19:35:59] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 5 others: Iterate on DS fredge query - https://phabricator.wikimedia.org/T219646 (DStrine) we ju... [19:43:40] (PS1) Umherirrender: Move files to match class name [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/507640 [19:53:03] (PS5) Ejegg: Support lots of country tlds for yahoo & microsoft mail [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449900 (https://phabricator.wikimedia.org/T221387) [20:23:17] Fundraising-Backlog: New mobile iFrame errors - https://phabricator.wikimedia.org/T221385 (MBeat33) #580856 is a UK donor on 5/1 using an ipad: //Each time l try to donate using my credit card, the area where the card details are inserted disappears. What could be the problem? I have used the same credit car... [20:31:44] (CR) jerkins-bot: [V: -1] Localisation updates from https://translatewiki.net. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/507660 (owner: L10n-bot) [20:32:08] (CR) jerkins-bot: [V: -1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/507668 (owner: L10n-bot) [20:32:10] (CR) jerkins-bot: [V: -1] Localisation updates from https://translatewiki.net. [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/507669 (owner: L10n-bot) [20:43:53] (Abandoned) Raimond Spekking: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/507434 (owner: L10n-bot) [20:44:25] (CR) Raimond Spekking: [V: +2 C: +2] "false positive" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/507660 (owner: L10n-bot) [20:45:41] (Abandoned) Raimond Spekking: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/507458 (owner: L10n-bot) [20:46:11] (CR) Raimond Spekking: [C: +2] "false positive" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/507668 (owner: L10n-bot) [20:46:41] (CR) Raimond Spekking: [V: +2 C: +2] "false positive" [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/507669 (owner: L10n-bot) [21:08:27] (CR) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/507669 (owner: L10n-bot) [21:21:43] Fundraising Sprint Ewoks Take Manhattan, Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising-Backlog: record failed payments - https://phabricator.wikimedia.org/T222220 (Ejegg) @CCogdill_WMF ah right, this ticket the 'where and how' that @Eileenmcnaughton and... [21:22:02] Fundraising Sprint Ewoks Take Manhattan, Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising-Backlog: record failed payments - https://phabricator.wikimedia.org/T222220 (Ejegg) I think for starters, we would only record failed payments for people with opt-in=1. [21:26:39] Fundraising Sprint Ewoks Take Manhattan, Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising-Backlog: record failed payments - https://phabricator.wikimedia.org/T222220 (CCogdill_WMF) Cool, that all sounds great! Is there any chance we can also satisfy this as... [21:30:14] Fundraising Sprint Ewoks Take Manhattan, Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising-Backlog: record failed payments - https://phabricator.wikimedia.org/T222220 (Eileenmcnaughton) @CCogdill_WMF I would open that as a new task or subtask to make sure it... [21:32:14] Fundraising-Backlog, fundraising-tech-ops: Outage to reload triggers - https://phabricator.wikimedia.org/T222001 (Eileenmcnaughton) @CCogdill_WMF it looks like Ops Do have another outage need so this should be able to be done then - @cwd @jgreen hopefully this is on your radar [21:34:35] (CR) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/507660 (owner: L10n-bot) [21:37:11] Fundraising Sprint Ewoks Take Manhattan, Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising-Backlog: Create separate email export file for emails gathered from failed attempts - https://phabricator.wikimedia.org/T222311 (CCogdill_WMF) p:Triage→Normal [21:39:05] Fundraising Sprint Ewoks Take Manhattan, Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising-Backlog: Create separate email export file for emails gathered from failed attempts - https://phabricator.wikimedia.org/T222311 (CCogdill_WMF) [21:39:24] Fundraising-Backlog: New mobile iFrame errors - https://phabricator.wikimedia.org/T221385 (Ejegg) @MBeat33, I'm really curious if these people are all using a feature to automatically fill in the fields, like a card stored in the browser or the feature that lets you take a picture of a card. [21:40:40] Fundraising-Backlog: Where and how to record opt-ins on payment attempts - https://phabricator.wikimedia.org/T220645 (CCogdill_WMF) Open→Declined Redundant (see T222220) [21:42:32] (CR) Ejegg: [C: +2] "This looks like a good start. If we want to refine the old cancels further, we can always take another look later." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/507534 (https://phabricator.wikimedia.org/T218616) (owner: Eileen) [21:43:04] ejegg: did you look at the resulting report on staging for the cancels? [21:43:36] not yet [21:43:38] I kinda wondered if the results ‘looked right’ [21:44:10] ok, looking now [21:45:20] hoping I didn’t remove the code from staging & break it... [21:46:29] hmm I might have [21:46:51] (Merged) jenkins-bot: Back-populate recurring cancel_reason. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/507534 (https://phabricator.wikimedia.org/T218616) (owner: Eileen) [21:48:29] there is an extended report for recurring available [21:48:38] seems to let me pick filters and columns [21:48:59] ejegg: yep 2 - one already deployed & one pivot in the new update - I just unbroke on staging - https://civicrm.frdev.wikimedia.org/civicrm/report/instance/153?reset=1 [21:49:03] hmm, though once I change the 'modified date' filter to 'last quarter' it gives me a WSOD [21:49:18] ah, cool, looking at that one [21:50:03] wat, how do we have 66 Amazon recurring records? [21:50:13] we never implemented that on the front end [21:50:37] so staging data is from install scripts [21:50:39] err, or... I guess we did implement the front end, but not the back end bit [21:50:44] & may not match live.... [21:50:52] since it could be from a wip version [21:51:02] huh [21:51:44] I mean - the staging data could be from the ‘backfill payment processor’ upgrade script [21:53:29] actually 89 on live - looking at one now [21:53:51] really old donations https://civicrm.frdev.wikimedia.org/civicrm/contact/view?reset=1&cid=3280189 [21:56:08] hmm more recently https://civicrm.frdev.wikimedia.org/civicrm/contact/view?reset=1&cid=25400110 [22:52:50] XenoRyet|food: or cstone: any questions about the contact_id and contact_hash additions to that form? [22:54:29] eh, not really. Got some mildly annoying vagrant stuff, but the id and hash stuff I think we have a handle on. [22:54:36] thanks for the digging, eileen! So I guess there must have been a glitch somewhere that let people sign up for recurring Amazon, though we still have no way to actually charge them [22:54:49] XenoRyet|food: want to pair up and knock it out right now? [22:55:31] yeah - some are not *that* old - but it all seems to indicate our changes are ok - if you are ok to +2 the report I’ll deploy both [22:56:09] eileen: oh sure, lemme just read over the code a bit more [22:57:42] so the move to getOptions is to make the extension use less internal methods and more API? [22:57:55] I'm just getting a few 'Cannot modify header information - headers already sent by...' type warnings, but it's not really blocking me. [22:58:12] XenoRyet: hmm, those usually mean there's a warning somewhere [22:58:20] can you tell what the underlying warning is? [22:58:24] something deprecated? [22:59:08] i.e. a warning besides that the headers have been sent [22:59:40] couple of notices the only other things, I think. [22:59:52] Notice: Did not find alias for special page [23:00:56] I'm not really blocked by it, and I think Jack had something similar too, so I can just ask him in the morning as well. [23:03:09] ejegg I was looking at creating some tests for it [23:03:26] XenoRyet: ah, ok, we need to add that alias [23:04:00] cstone: sounds good! [23:08:20] Fundraising Sprint Ewoks Take Manhattan, Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising-Backlog: Create separate email export file for emails gathered from failed attempts - https://phabricator.wikimedia.org/T222311 (Reedy) [23:09:58] XenoRyet and cstone: we can probably add that alias here: https://phabricator.wikimedia.org/diffusion/EDOI/browse/master/DonationInterface.alias.php [23:10:32] if anyone wants to add that I'll give it a quick +2 [23:11:00] Give me a second [23:12:35] Heh, that actually did clear up the header warnings too. Didn't expect that. [23:12:52] Anyway, patch incoming. [23:15:06] (PS1) XenoRyet: Add Alias for EmailPreferences Special Page [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/507719 (https://phabricator.wikimedia.org/T218171) [23:16:04] cstone: You were getting those notices too, yea? ^ [23:16:22] yeah I was [23:17:08] That patch fixes it. [23:17:11] nice [23:18:18] also, ppena has asked us to add a payment type to the Brazil BT form [23:18:27] should be another one-liner [23:18:46] (PS2) Ejegg: Add Alias for EmailPreferences Special Page [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/507719 (https://phabricator.wikimedia.org/T218171) (owner: XenoRyet) [23:18:51] (CR) Ejegg: [C: +2] Add Alias for EmailPreferences Special Page [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/507719 (https://phabricator.wikimedia.org/T218171) (owner: XenoRyet) [23:19:32] err, or might involve adding a logog [23:19:34] *logo [23:19:55] (Merged) jenkins-bot: Add Alias for EmailPreferences Special Page [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/507719 (https://phabricator.wikimedia.org/T218171) (owner: XenoRyet) [23:19:58] cstone: You want to take that one? Even with the logo it's still pretty quick and kind of a good part of the code to see. [23:20:06] sure [23:20:22] oh look, no, it's just reverting this patch: https://phabricator.wikimedia.org/rEDOI29238ff6b3305f19812419d423c0df633c0c6cd1 [23:20:29] or uncommenting those lines [23:20:34] Even easier then. [23:20:52] hah okay [23:24:43] ejegg is there a ticket for the brazil one? [23:25:18] cstone no, guess we could ask ppena to make one [23:26:34] hmm, seeing some deadlock-related insert failmails from a couple hrs ago and 30 min ago [23:27:06] fr-tech, everyone know how to kick those back into the pipeline? [23:27:21] it involves a url that ends in /damaged ... [23:28:00] Yep, I know that procedure. [23:28:02] ejegg does it need one? I just didn't know if there was one out there somewhere [23:28:45] cstone: By the numbers we should have one, but for such a small thing probably not totally necessary. Don't tell anyone you heard the scrummaster say that. [23:28:54] haha [23:29:07] cstone for stuff this trivial I'm inclined to skip it [23:29:11] ok [23:29:36] (PS1) Cstone: Add Santander for Brazil / Bank Transfer [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/507720 [23:30:05] oh did i mess up the yaml [23:30:51] (PS2) Cstone: Add Santander for Brazil / Bank Transfer [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/507720 [23:36:33] (CR) Ejegg: [C: +2] Add Santander for Brazil / Bank Transfer [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/507720 (owner: Cstone) [23:36:40] cool, looks good [23:37:53] (Merged) jenkins-bot: Add Santander for Brazil / Bank Transfer [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/507720 (owner: Cstone) [23:41:26] eileen: looks like your patch changes the default value for isSupportsContactTab from FALSE to TRUE [23:41:36] ejegg: yeah [23:41:51] I kinda figured that I’d do that & then fix the ones that don’t work [23:41:56] rather than opting them in one by one [23:41:57] ah, cool [23:42:22] I’m gonna configure some as tabs on staging to show MG in fortnightly since they could help with some things they have raised [23:42:45] I might find some that need fixing in the process [23:43:06] oh, cool [23:43:47] hmm, joinAddressFromContribution goes through the contact table, but it could actually skip that and just join on contribution.contact_id and address.contact_id, right? [23:44:12] oh no wait, it does do that [23:45:01] but the leftTable is still listed as civicrm_contact [23:45:04] yeah that was a patch someone submitted that I merged but yeah - there is an address specifically for the contribution as well as for the contact - for historical reasons [23:45:08] sorry, I can do this via gerrit [23:45:13] let me check [23:46:23] this was the PR https://github.com/eileenmcnaughton/nz.co.fuzion.extendedreport/pull/253 [23:46:43] oh you know what - that leftTable actually is not used [23:47:11] it seemed like the right thing to do when I created that spec but never got implemented [23:47:14] still I’ll fix [23:48:27] (CR) Ejegg: [C: +1] "Looks good overall, seems to work! Found a tiny formatting thing and a possibly-non-issue table name thing" (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/507529 (https://phabricator.wikimedia.org/T218616) (owner: Eileen) [23:48:45] ah, defintely-non-issue table name thing then [23:50:07] ejegg: I’ll merge this once tests pass https://github.com/eileenmcnaughton/nz.co.fuzion.extendedreport/pull/259 and then next update we’ll get the fix [23:51:13] ok, sounds good! [23:51:37] (PS3) Ejegg: Add Recurring Contribution pivot chart. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/507529 (https://phabricator.wikimedia.org/T218616) (owner: Eileen) [23:51:45] (CR) Ejegg: [C: +2] Add Recurring Contribution pivot chart. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/507529 (https://phabricator.wikimedia.org/T218616) (owner: Eileen) [23:52:17] ejegg: re the fredge report - do you want to add the fields & I review or vice versa? [23:53:04] eileen: you want to add 'em? [23:53:21] the ScoreName would follow the same convention as the other Score* filters [23:53:31] i.e. ScoreName => getScoreName [23:55:11] hmm so those are values in the filter field converted to columsn [23:55:50] and for the other, maybe something pretty => 'donation_interface_email_pattern_filter' [23:56:05] eileen yep, the filter_name field [23:57:23] (Merged) jenkins-bot: Add Recurring Contribution pivot chart. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/507529 (https://phabricator.wikimedia.org/T218616) (owner: Eileen) [23:58:09] err, => 'donation_interface_fraud_email_pattern' [23:58:10] ejegg: so those 2 things - but I’m just trying to interpret the other request [23:58:28] ie donation_interface_fraud_email_pattern' [23:59:03] (PS1) Eileen: Add Score name & also generic filter name filter [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/507722 (https://phabricator.wikimedia.org/T219646) [23:59:42] is that a new field [23:59:52] no, it's another value