[01:53:24] Fundraising Sprint It Came From Out of Scope, Fundraising-Backlog: Civi: create 'known fraudster' checkbox in CIDs - https://phabricator.wikimedia.org/T221688 (Eileenmcnaughton) Open→Resolved [09:11:32] Fundraising-Backlog: New mobile iFrame errors - https://phabricator.wikimedia.org/T221385 (Pcoombe) I was using Chrome on Android though. Haven't been able to test iOS. [10:56:18] Fundraising-Backlog, FR-Ingenico, Fr-backlog-cleanup-Q3_2017-18: TY page in ingenico iframe - https://phabricator.wikimedia.org/T176669 (Pcoombe) I tried adding that, but it gets blocked from working because the origin is different (TY page is on donate.wikimedia.org, parent page is on payments.wikim... [14:43:31] (CR) AndyRussG: Consolidate construction of campaign URLs (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/497223 (https://phabricator.wikimedia.org/T217565) (owner: AndyRussG) [14:51:50] (CR) AndyRussG: "Just a further note: The URL is not sent as part of the event because the pattern in EventBus is for that extension to obtain the URLs. Se" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/497223 (https://phabricator.wikimedia.org/T217565) (owner: AndyRussG) [14:55:40] (PS7) AndyRussG: Consolidate construction of campaign URLs [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/497223 (https://phabricator.wikimedia.org/T217565) [14:56:48] (PS4) AndyRussG: Add includefuture option to active campaigns API [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/504388 (https://phabricator.wikimedia.org/T221122) [14:57:12] ejegg: ^ [14:58:00] Sorry! It seems the memory of that tidbit had escaped my brain, probably dribbled out my ear at the night or something [14:59:04] Hi AndyRussG [14:59:31] ah, cool, I figured it would be used somewhere! [15:00:15] (PS8) Ejegg: Consolidate construction of campaign URLs [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/497223 (https://phabricator.wikimedia.org/T217565) (owner: AndyRussG) [15:00:24] (CR) Ejegg: [C: +2] Consolidate construction of campaign URLs [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/497223 (https://phabricator.wikimedia.org/T217565) (owner: AndyRussG) [15:00:41] (PS5) Ejegg: Add includefuture option to active campaigns API [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/504388 (https://phabricator.wikimedia.org/T221122) (owner: AndyRussG) [15:00:53] (PS6) Ejegg: Add includefuture option to active campaigns API [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/504388 (https://phabricator.wikimedia.org/T221122) (owner: AndyRussG) [15:01:11] oops, gerrit gave me a 500 error the first time i hit rebase [15:01:17] but it looks like it just did it twice [15:01:19] ejegg: :) thx! yeah next time I'll try less hard to obfuscate [15:01:54] hmmm [15:04:57] (CR) jerkins-bot: [V: -1] Consolidate construction of campaign URLs [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/497223 (https://phabricator.wikimedia.org/T217565) (owner: AndyRussG) [15:05:03] hrm? [15:05:21] (Merged) jenkins-bot: Consolidate construction of campaign URLs [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/497223 (https://phabricator.wikimedia.org/T217565) (owner: AndyRussG) [15:05:26] 1) Rollback with confirmation should offer a way to cancel rollbacks: [15:05:29] 15:04:49 element (".mw-rollback-link .jquery-confirmable-button-no") still not visible after 5000ms [15:05:40] that sounds like not a CN thing [15:06:35] still merged it [15:07:10] ejegg: yeah, I'm guessing it's some experimental CI feature that's tripping over a core thingy [15:07:41] so, probably less grave than the PHP syntax errors it missed [15:07:43] jk [15:08:38] Fundraising-Backlog, FR-Ingenico, Fr-backlog-cleanup-Q3_2017-18: TY page in ingenico iframe - https://phabricator.wikimedia.org/T176669 (Ejegg) Oh shoot, I didn't realize cross-origin framebusters are dead now! We do have some code on the result switcher to do this. To save an extra page request fo... [15:12:22] (CR) jenkins-bot: Consolidate construction of campaign URLs [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/497223 (https://phabricator.wikimedia.org/T217565) (owner: AndyRussG) [15:29:33] AndyRussG: so what do you know about packageFiles modules? [15:29:56] ejegg: not a darn thing... yet, I guess [15:30:16] got an clues? [15:30:26] looks like a naming convention thing? [15:31:04] hmm, modules get their own directory, with the main file in index.js [15:32:12] I know there is a more recent convention for a JS module providing a public api [15:32:14] using require() [15:32:34] looking at the commit message, it seems that has something to do with it? https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CentralNotice/+/506232/ [15:33:49] I can definitely get to that this afternoon and over the weekend btw... just wanted to finish a bit in the alerts thing now... [15:35:23] (CR) jenkins-bot: Add includefuture option to active campaigns API [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/504388 (https://phabricator.wikimedia.org/T221122) (owner: AndyRussG) [15:46:52] AndyRussG: so what's left for that? Looks like all your gerrit patches are merged [15:47:14] well, outside of FRUEC - should I go over those and get 'em out of limbo? [15:47:54] ejegg: for the alerts, the python bit that I've been banging against my skull for a while [15:48:14] ejegg yes I'd love to finally get FRUEC out! [15:48:16] oh right, with pywikibot [15:48:22] yeah arrrrghhh [15:48:35] friggin' config embedded in the actual code [15:48:48] how are you supposed to use that as a library?!!? [15:49:12] also thx eh!!! [15:59:40] Fundraising-Backlog, FR-Ingenico, Fr-backlog-cleanup-Q3_2017-18: TY page in ingenico iframe - https://phabricator.wikimedia.org/T176669 (Pcoombe) @ejegg Never mind, I got it working. Being cross-origin apparently stops the framed content from reading top.location.href, but not from setting it! This a... [16:07:26] howdy XenoRyet [16:09:14] Hi [16:09:36] Fundraising-Backlog, FR-Ingenico, Fr-backlog-cleanup-Q3_2017-18: TY page in ingenico iframe - https://phabricator.wikimedia.org/T176669 (Ejegg) Awesome, glad to hear it! I'll keep looking at the payments-wiki code to see if there's some error in how we're marking redirects, but it's great to have thi... [16:10:08] Fundraising-Backlog, FR-Ingenico, Fr-backlog-cleanup-Q3_2017-18: TY page in ingenico iframe - https://phabricator.wikimedia.org/T176669 (Ejegg) Open→Resolved a:Ejegg [16:33:59] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Review incoming patches 2019-05 - https://phabricator.wikimedia.org/T222463 (AndyRussG) [16:34:22] Fundraising Sprint It Came From Out of Scope, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Review incoming patches 2019-05 - https://phabricator.wikimedia.org/T222463 (AndyRussG) [16:36:47] (CR) Ejegg: [C: +2] Update platform to PHP 7.0 [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/505433 (owner: Umherirrender) [16:37:43] Fundraising Sprint It Came From Out of Scope, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Review incoming patches 2019-05 - https://phabricator.wikimedia.org/T222463 (DStrine) a:AndyRussG [17:00:17] (Merged) jenkins-bot: Update platform to PHP 7.0 [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/505433 (owner: Umherirrender) [17:01:23] (CR) jenkins-bot: Update platform to PHP 7.0 [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/505433 (owner: Umherirrender) [17:17:13] PROBLEM - check_puppetrun on frdb2001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 54 seconds ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-client] [17:22:13] PROBLEM - check_puppetrun on frdb2001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 5 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-client] [17:22:19] PROBLEM - check_puppetrun on frdb1002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 6 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-client] [17:23:30] (PS1) Ejegg: Privacy policy update notice - leave in place for 1 mo [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/507995 (https://phabricator.wikimedia.org/T220428) [17:24:54] (PS2) Ejegg: Privacy policy update notice - leave in place for 1 mo [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/507995 (https://phabricator.wikimedia.org/T220428) [17:27:13] PROBLEM - check_puppetrun on frdb2001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 4 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-client] [17:27:19] PROBLEM - check_puppetrun on frdb1002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 3 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-client] [17:32:13] RECOVERY - check_puppetrun on frdb2001 is OK: OK: Puppet is currently enabled, last run 55 seconds ago with 0 failures [17:32:19] RECOVERY - check_puppetrun on frdb1002 is OK: OK: Puppet is currently enabled, last run 1 minute ago with 0 failures [18:07:53] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 9 others: Reduce recurring TY emails - https://phabricator.wikimedia.org/T213209 (Pcoombe) @Ejeg... [18:15:11] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 9 others: Reduce recurring TY emails - https://phabricator.wikimedia.org/T213209 (TSkaff) Thank... [18:25:13] (CR) Cstone: "Looks good besides the two pt missing closing tags." (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/507995 (https://phabricator.wikimedia.org/T220428) (owner: Ejegg) [18:38:24] ejegg: this is the task for the main FRUEC script stuff: https://phabricator.wikimedia.org/T195594 [18:38:38] I'm trying to find jgleeson's comments somewhere or other, to figure out how far he got... [18:41:14] aaarg not finding it... [18:42:34] ejegg here are the notes. jgleeson's review notes are at the end. https://etherpad.wikimedia.org/p/fr_user_event_consumer_notes [18:43:15] In those review comments, the thing remaining to fix is on line 153, labelled "FIX!" [18:43:30] thanks AndyRussG [18:45:26] Fundraising-Backlog, Analytics, Analytics-EventLogging, Analytics-Kanban, and 3 others: Fix EventLogging schemas that use array for items type - https://phabricator.wikimedia.org/T218617 (Ottomata) Ok @chelsyx, our fix is out. Can you try changing the schema again? [18:49:52] ejegg|food: thank u! [18:51:26] I'm pretty sure there's some place comment where jack gave a general +2, though maybe it's another faulty bit in my memory [18:53:41] yay finaly finally got pywikibot jumping over the required hoops [18:53:48] sorry through the required hoops [18:54:17] * AndyRussG grumbles bitterly [19:11:21] Fundraising Sprint It Came From Out of Scope, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Review incoming patches 2019-05 - https://phabricator.wikimedia.org/T222463 (AndyRussG) [19:56:02] (PS3) Ejegg: Privacy policy update notice - leave in place for 1 mo [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/507995 (https://phabricator.wikimedia.org/T220428) [20:02:33] (CR) Cstone: [C: +2] "Looks good!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/507995 (https://phabricator.wikimedia.org/T220428) (owner: Ejegg) [20:29:37] (CR) XenoRyet: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/505686 (https://phabricator.wikimedia.org/T217710) (owner: Cstone) [20:34:12] (CR) jerkins-bot: [V: -1] WIP: Create new contact with just an email from opt-in. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/505686 (https://phabricator.wikimedia.org/T217710) (owner: Cstone) [20:41:50] (Merged) jenkins-bot: Privacy policy update notice - leave in place for 1 mo [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/507995 (https://phabricator.wikimedia.org/T220428) (owner: Ejegg) [20:59:47] Fundraising-Backlog, Analytics, Analytics-EventLogging, Analytics-Kanban, and 3 others: Fix EventLogging schemas that use array for items type - https://phabricator.wikimedia.org/T218617 (Ottomata) [23:28:48] Fundraising-Backlog: New mobile iFrame errors - https://phabricator.wikimedia.org/T221385 (MBeat33) #582733 5/3 Sweden //When writing the card no the numbers and page disappeared.// We're following up for details.