[00:04:20] Fundraising Sprint It Came From Out of Scope, Fundraising-Backlog: New Custom Fields for Target Smart Import - https://phabricator.wikimedia.org/T222559 (Eileenmcnaughton) a:Eileenmcnaughton [00:07:27] Fundraising Sprint It Came From Out of Scope, Fundraising Sprint Navel Warfare, Fundraising Sprint Outie Inverter, Fundraising Sprint Prank Seatbelt, and 6 others: Import email-only contacts from 'remind me later' links into CiviCRM - https://phabricator.wikimedia.org/T160949 (Eileenmcnaughton) @... [00:14:22] (PS4) Cstone: Create contact and opt-in from just email address. Log if we get an already existing email that is not tied to any contacts, but take no other action. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/506837 (https://phabricator.wikimedia.org/T217710) (owner: Mepps) [00:59:48] Fundraising Sprint It Came From Out of Scope, Fundraising Sprint Navel Warfare, Fundraising Sprint Outie Inverter, Fundraising Sprint Prank Seatbelt, and 6 others: Import email-only contacts from 'remind me later' links into CiviCRM - https://phabricator.wikimedia.org/T160949 (CCogdill_WMF) Sorry... [01:27:18] PROBLEM - check_missing_thank_yous on frdb1001 is CRITICAL: CRITICAL missing_thank_yous=2647 [critical =2000] [01:37:18] RECOVERY - check_missing_thank_yous on frdb1001 is OK: OK missing_thank_yous=900 [02:15:04] Fundraising Sprint It Came From Out of Scope, Fundraising Sprint Navel Warfare, Fundraising Sprint Outie Inverter, Fundraising Sprint Prank Seatbelt, and 6 others: Import email-only contacts from 'remind me later' links into CiviCRM - https://phabricator.wikimedia.org/T160949 (Eileenmcnaughton) @... [02:44:57] Fundraising Sprint It Came From Out of Scope, Fundraising-Backlog: New Custom Fields for Target Smart Import - https://phabricator.wikimedia.org/T222559 (NNichols) Fantastic! I was able to add the rest of the fields I needed. Thanks! [02:46:38] Fundraising Sprint It Came From Out of Scope, Fundraising Sprint Navel Warfare, Fundraising Sprint Outie Inverter, Fundraising Sprint Prank Seatbelt, and 6 others: Import email-only contacts from 'remind me later' links into CiviCRM - https://phabricator.wikimedia.org/T160949 (CCogdill_WMF) Ah, I... [02:57:30] Fundraising Sprint It Came From Out of Scope, Fundraising Sprint Navel Warfare, Fundraising Sprint Outie Inverter, Fundraising Sprint Prank Seatbelt, and 6 others: Import email-only contacts from 'remind me later' links into CiviCRM - https://phabricator.wikimedia.org/T160949 (Eileenmcnaughton) @... [04:16:29] Fundraising Sprint It Came From Out of Scope, Fundraising Sprint Navel Warfare, Fundraising Sprint Outie Inverter, Fundraising Sprint Prank Seatbelt, and 6 others: Import email-only contacts from 'remind me later' links into CiviCRM - https://phabricator.wikimedia.org/T160949 (CCogdill_WMF) Oh ok... [05:32:03] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 6 others: Iterate on DS fredge query - https://phabricator.wikimedia.org/T219646 (Eileenmcnaughto... [07:36:11] (PS5) Vedmaka Wakalaka: WIP in page preview draft [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/508720 [08:10:15] (PS6) Vedmaka Wakalaka: Adds in-page preview link to banner editor screen, uses LocalStorage as banner content transport to display unsaved version of a banner on a wiki page. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/508720 [08:10:57] (PS7) Vedmaka Wakalaka: Banner in-page preview mode [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/508720 [08:14:09] (CR) Vedmaka Wakalaka: "This change is ready for review." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/508720 (owner: Vedmaka Wakalaka) [12:00:22] Fundraising-Backlog, fundraising-tech-ops: check_bannerimpressions.py 'no entries' alerts after upgrading frdev1001 to stretch - https://phabricator.wikimedia.org/T222789 (Jgreen) [15:01:21] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 9 others: Reduce recurring TY emails - https://phabricator.wikimedia.org/T213209 (Ejegg) @TSkaff... [15:06:02] Nemo_bis: I wonder if we're using the best way to find the latest version of each translation in 'published' state [15:07:04] we're scanning the page review history [15:07:29] using a query for list 'logeventes' of type 'translationreview' on the parent page [15:08:33] looking for the latest with a matching language and new-state == 'published' [15:08:40] and getting that timestamp [15:09:00] then using the timestamp to get the revision of that language current at the time [15:09:10] is there something more straightforward? [15:14:57] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 9 others: Reduce recurring TY emails - https://phabricator.wikimedia.org/T213209 (Ejegg) @TSkaff... [15:29:02] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Civi SSL Certificate expired - https://phabricator.wikimedia.org/T222764 (cwdent) @RLewis your cert has 135 days left until expiration, did this just start happening? Are you using a different computer? [15:29:15] fr-tech: last call - any news for scrum of scrums? [15:30:07] Fundraising-Backlog, fundraising-tech-ops: check_bannerimpressions.py 'no entries' alerts after upgrading frdev1001 to stretch - https://phabricator.wikimedia.org/T222789 (Jgreen) Open→Resolved This was fixed by T222761 [15:42:28] oh weird, in debian testing/experimental, Firefox *ESR* is newer than regular Firefox [15:42:39] I had to go to ESR to get a version that supports Meet [15:43:44] ESR? [15:50:54] Extended support release [15:50:58] ah [15:51:02] which from the name sounds like it would be an older version [16:06:17] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Civi SSL Certificate expired - https://phabricator.wikimedia.org/T222764 (RLewis) @cwdent I know I thought it wasn't going to expire for a while. I did have to restart my laptop yesterday but that's it. Any ideas on what I can... [16:08:33] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 9 others: Reduce recurring TY emails - https://phabricator.wikimedia.org/T213209 (Nikerabbit) I... [16:22:20] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Civi SSL Certificate expired - https://phabricator.wikimedia.org/T222764 (cwdent) @rlewis restarting the browser is worth a try. If that doesn't work could you open the menu described here in browser prefs and see if you see t... [16:24:08] fundraising-tech-ops, Patch-For-Review: Install private Grafana/Promtheus instance in fundraising - https://phabricator.wikimedia.org/T215182 (cwdent) [16:24:15] fundraising-tech-ops, Operations, netops, Patch-For-Review: Revoke production prometheus fundraising access - https://phabricator.wikimedia.org/T217355 (cwdent) Open→Resolved [16:38:26] Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising Sprint Hansel and grep -l, Fundraising Sprint It Came From Out of Scope, and 2 others: Create variants for fancy new opt in pages on payments wiki - https://phabricator.wikimedia.org/T218240 (CCogdill_WMF) I... [17:16:45] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Civi SSL Certificate expired - https://phabricator.wikimedia.org/T222764 (RLewis) @cwdent yep that did the trick, thanks for the help. [17:19:38] fr-tech I'm going to grab some food before -talk [17:20:59] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Civi SSL Certificate expired - https://phabricator.wikimedia.org/T222764 (cwdent) Open→Resolved Great! [18:33:07] mepps and XenoRyet: are we meeting? [18:33:18] whoops, time warped again. BRT [18:33:50] did the same XenoRyet [18:39:40] looks like we still got the failmail from the run-job call fr-tech [18:40:04] anything more in the p_c log? [18:40:05] jgleeson: anything in the ogs? [18:40:10] *logs [18:41:47] huh, still no [18:43:07] hrm [18:44:17] are there maybe other difference with how other php command line stuff is run that would explicitify any implicit 0 error codes? [18:44:32] that is, maybe other php jobs are run under differently, under drush or whatever [18:44:55] and so those are automagically getting an explicit 0 error added by some php wrapper [18:45:15] but that this one isn't, or has a different wrapper, so the lack of an explicit "exit 0" would be what's borking? [18:45:39] sorry for the vagueness of the question, does it maybe make any sense? [18:49:03] maybe AndyRussG [18:49:10] makes sense* [18:55:42] AndyRussG: The most similar job is paypal_smashpig_job_runner [18:56:02] it's using the exact same SmashPig maintenance script [18:56:48] with (till we added the error display) the same command line options, except for the config node (use paypal settings instead of adyen settings) and the queue name (use jobs-paypal instead of jobs-adyen) [18:57:21] so it's a bit strange to see that job running just fine [18:57:58] only thing I can think of is that the paypal jobs don't involve making external API requests, so they run faster [18:58:35] let's see if the adyen job ever exits with non-zero code when it has an empty queue [19:01:37] anyway it sounds like at least there's no unreported and unkown php error? or who knows, I guess [19:01:56] did we confirm that the php flags actually cause more error info to be printed? [19:02:20] so far none of the '0 (0 successful)' jobs are in an email [19:02:44] AndyRussG: hmm, I guess we'd have to run them against a known error condition [19:12:29] (CR) Jforrester: [C: +2] ext.centralNotice.startUp: Convert to packageFiles module [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/506232 (https://phabricator.wikimedia.org/T193826) (owner: Krinkle) [19:13:57] (CR) Jforrester: [C: +2] Move kvStoreMaintenance to 'ext.centralNotice.startUp' [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/506317 (https://phabricator.wikimedia.org/T221805) (owner: Krinkle) [19:16:49] (Merged) jenkins-bot: ext.centralNotice.startUp: Convert to packageFiles module [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/506232 (https://phabricator.wikimedia.org/T193826) (owner: Krinkle) [19:16:55] (CR) Jforrester: [C: +2] ext.centralNotice.geoIP: Remove redundant variable, and use then() [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/497644 (owner: Krinkle) [19:19:31] (Merged) jenkins-bot: Move kvStoreMaintenance to 'ext.centralNotice.startUp' [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/506317 (https://phabricator.wikimedia.org/T221805) (owner: Krinkle) [19:21:56] (Merged) jenkins-bot: ext.centralNotice.geoIP: Remove redundant variable, and use then() [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/497644 (owner: Krinkle) [19:23:45] (CR) jenkins-bot: ext.centralNotice.startUp: Convert to packageFiles module [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/506232 (https://phabricator.wikimedia.org/T193826) (owner: Krinkle) [19:25:17] (PS9) Jforrester: CentralNoticeHooks: Bundle configuration vars into JS that needs it [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/502772 (https://phabricator.wikimedia.org/T219342) (owner: D3r1ck01) [19:26:07] (CR) Jforrester: "PS9: Manually rebased over similar patch changes." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/502772 (https://phabricator.wikimedia.org/T219342) (owner: D3r1ck01) [19:29:31] going to do a quick errand [19:30:15] (CR) Krinkle: [C: -1] CentralNoticeHooks: Bundle configuration vars into JS that needs it (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/502772 (https://phabricator.wikimedia.org/T219342) (owner: D3r1ck01) [19:30:30] (CR) jenkins-bot: Move kvStoreMaintenance to 'ext.centralNotice.startUp' [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/506317 (https://phabricator.wikimedia.org/T221805) (owner: Krinkle) [19:37:08] (CR) jenkins-bot: ext.centralNotice.geoIP: Remove redundant variable, and use then() [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/497644 (owner: Krinkle) [19:40:20] (CR) D3r1ck01: CentralNoticeHooks: Bundle configuration vars into JS that needs it (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/502772 (https://phabricator.wikimedia.org/T219342) (owner: D3r1ck01) [19:43:29] (PS10) Jforrester: CentralNoticeHooks: Bundle configuration var into startup module [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/502772 (https://phabricator.wikimedia.org/T219342) (owner: D3r1ck01) [19:46:33] (CR) D3r1ck01: CentralNoticeHooks: Bundle configuration var into startup module (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/502772 (https://phabricator.wikimedia.org/T219342) (owner: D3r1ck01) [19:46:35] (CR) Jforrester: CentralNoticeHooks: Bundle configuration var into startup module (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/502772 (https://phabricator.wikimedia.org/T219342) (owner: D3r1ck01) [19:47:43] (CR) Jforrester: CentralNoticeHooks: Bundle configuration var into startup module (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/502772 (https://phabricator.wikimedia.org/T219342) (owner: D3r1ck01) [19:49:58] (CR) D3r1ck01: CentralNoticeHooks: Bundle configuration var into startup module (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/502772 (https://phabricator.wikimedia.org/T219342) (owner: D3r1ck01) [19:55:48] Fundraising-Backlog, fundraising-tech-ops, Epic: epic: frtech onwiki documentation overhaul - https://phabricator.wikimedia.org/T209872 (DStrine) [19:59:20] (PS1) Krinkle: Document dependency on EventLogging [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/508905 [19:59:22] (PS1) Krinkle: Remove temporary EventLogging code-duplication [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/508906 [19:59:45] Fundraising Sprint Vestigial tails shoot from the hip, Fundraising-Backlog, Patch-For-Review: Is the Peru form working? Nov 13th - https://phabricator.wikimedia.org/T209379 (DStrine) Open→Declined [20:05:11] fundraising-tech-ops: move main fundraising puppet repo to gerrit - https://phabricator.wikimedia.org/T222840 (Jgreen) [20:15:12] Fundraising-Backlog, fundraising-tech-ops, Patch-For-Review: fix silverpop database updater not to crush the master database with long queries - https://phabricator.wikimedia.org/T157600 (DStrine) [20:18:55] that adyen problem has really got me stumped [20:22:12] Fundraising Sprint N*E*R*D, Fundraising Sprint ODB, Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog, and 4 others: Publishing translations for central notice banners fails - https://phabricator.wikimedia.org/T104774 (DStrine) a:cwdent→None [20:27:16] Fundraising-Backlog, Fr-Ingenico-integration_2017-18: Ingenico: iframe error IE 11.0 - 11/27 - https://phabricator.wikimedia.org/T210537 (DStrine) Open→Declined [20:27:34] Fundraising-Backlog, Fr-Ingenico-integration_2017-18: Ingenico: iframe error IE 11.0 - 11/27 - https://phabricator.wikimedia.org/T210537 (DStrine) closing. we have newer tasks with more info [20:41:24] (PS2) Krinkle: Remove temporary EventLogging code-duplication [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/508906 (https://phabricator.wikimedia.org/T214709) [20:42:29] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: Remove hacky EventLogging-duplicating code and use new lightweight EL facilities - https://phabricator.wikimedia.org/T214709 (Krinkle) I forgot that there there was a task for this. I've done this for one of your extensions at... [21:05:31] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 6 others: Iterate on DS fredge query - https://phabricator.wikimedia.org/T219646 (MBeat33) so fa... [21:44:12] Fundraising Sprint Window dressing is mostly olive oil, Fundraising Sprint XML ate my homework, Fundraising-Backlog: Investigate what we don't like about the recurring donation system - https://phabricator.wikimedia.org/T211056 (DStrine) Open→Declined [21:57:03] (PS1) Ejegg: Update platform in composer config, update packages [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/508947 [21:58:06] (CR) Ejegg: [C: +2] Update platform in composer config, update packages [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/508947 (owner: Ejegg) [22:07:33] (Merged) jenkins-bot: Update platform in composer config, update packages [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/508947 (owner: Ejegg) [22:07:53] (PS1) Ejegg: Update dependencies [wikimedia/fundraising/SmashPig/vendor] - https://gerrit.wikimedia.org/r/508948 [22:07:59] (CR) Ejegg: [C: +2] Update dependencies [wikimedia/fundraising/SmashPig/vendor] - https://gerrit.wikimedia.org/r/508948 (owner: Ejegg) [22:08:19] (CR) Ejegg: [V: +2 C: +2] Update dependencies [wikimedia/fundraising/SmashPig/vendor] - https://gerrit.wikimedia.org/r/508948 (owner: Ejegg) [22:08:55] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/508949 [22:09:47] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/508949 (owner: Ejegg) [22:10:33] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/508949 (owner: Ejegg) [22:14:38] !log disabled fundraising jobs for SmashPig update [22:14:40] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:15:33] !log updated SmashPig standalone install from 78b92b7fef to 88fd9650ec [22:15:35] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:17:16] well, paypal job runner works fine [22:17:20] turning 'em back on [22:20:49] !log re-enabled fundraising jobs [22:20:52] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:21:39] and... let's try pointing the adyen job back at the main smashpig codebase [22:25:52] hmph, no change [22:38:37] and the logger destructor gets called before the predis destructor [22:39:14] so it wouldn't make sense that the logger destructor is the problem, if we were getting to the predis destructor [22:49:56] ejegg: so no dice yet? [22:50:13] nuthin [22:53:40] ejegg got a sec for a tl;dr of what's been tried? [22:53:59] maybe we need an etherpad for this mystery? [22:54:53] sure! [22:55:30] shoot, I have to run shortly [22:55:38] but I'll drop some quick notes in an etherpad [22:56:22] https://etherpad.wikimedia.org/p/adyen-smashpig-failmail [22:59:44] ejegg|away: thx! yeah no rush on my end [23:33:21] sounds like a classic php ball of yarn [23:53:19] (PS1) Eileen: Alter option_group table to default to is_locked = 0 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/508961