[00:03:56] (PS2) Eileen: Alter option_group table to default to is_locked = 0 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/508961 [00:06:32] (PS3) Eileen: Alter option_group table to default to is_locked = 0 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/508961 (https://phabricator.wikimedia.org/T222559) [00:11:11] Fundraising Sprint It Came From Out of Scope, Fundraising Sprint Navel Warfare, Fundraising Sprint Outie Inverter, Fundraising Sprint Prank Seatbelt, and 6 others: Import email-only contacts from 'remind me later' links into CiviCRM - https://phabricator.wikimedia.org/T160949 (Eileenmcnaughton) @... [01:03:31] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Link mailing data to contacts imported from RML - https://phabricator.wikimedia.org/T222854 (Eileenmcnaughton) [02:18:39] Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising Sprint Hansel and grep -l, Fundraising Sprint It Came From Out of Scope, and 3 others: Civi recurring donation cancel metric request - https://phabricator.wikimedia.org/T218616 (Eileenmcnaughton) @MBeat33 @Pp... [02:41:14] (PS1) Eileen: Additional comments in cancel block [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/508969 (https://phabricator.wikimedia.org/T218616) [03:13:10] (PS10) Eileen: [do not merge] url generator form wip [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/507540 [03:14:13] (CR) jerkins-bot: [V: -1] [do not merge] url generator form wip [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/507540 (owner: Eileen) [06:04:08] Fundraising Sprint It Came From Out of Scope, Fundraising Sprint Navel Warfare, Fundraising Sprint Outie Inverter, Fundraising Sprint Prank Seatbelt, and 6 others: Import email-only contacts from 'remind me later' links into CiviCRM - https://phabricator.wikimedia.org/T160949 (CCogdill_WMF) Cool,... [10:03:27] Fundraising-Backlog, fundraising-tech-ops: Banner impression data not updating on frdev1001 - https://phabricator.wikimedia.org/T222706 (Pcoombe) Open→Resolved a:Pcoombe Looks fixed now, thanks! [14:07:12] PROBLEM - check_puppetrun on frdb2001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 6 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-client] [14:07:18] PROBLEM - check_puppetrun on frdb1002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 6 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-client] [14:12:12] PROBLEM - check_puppetrun on frdb2001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 2 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-client] [14:12:18] PROBLEM - check_puppetrun on frdb1002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 1 minute ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-client] [14:17:12] RECOVERY - check_puppetrun on frdb2001 is OK: OK: Puppet is currently enabled, last run 1 minute ago with 0 failures [14:17:18] RECOVERY - check_puppetrun on frdb1002 is OK: OK: Puppet is currently enabled, last run 1 minute ago with 0 failures [14:20:20] Jeff_Green, cwd looks like a few jobs couldn't connect to the frdb instances [14:20:43] jgleeson: just now? [14:20:54] jgleeson: I restarted mariadb on frdb1002 and frdev1001, it could be that [14:21:01] all i see is them adyens still [14:21:08] about 30 minutes ago [14:21:47] yeah I saw icinga messages here but they look slighter later [14:21:55] delay in the alerts maybe? [14:22:14] hmmm [14:22:30] the icinga alerts are just puppet related [14:22:32] or maybe unrelated [14:22:45] but yeah connection refused is weird [14:23:22] the adyen failmail is proving to be really tricky [14:23:22] PROBLEM - check_puppetrun on payments1002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 7 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-client] [14:24:20] jgleeson: yeah i stared at it for a while yesterday [14:24:41] i think process-control would be a good place to debug [14:24:52] jgleeson: have you looked at that code before? [14:26:09] yeah I dived into it a bit yesterday. I think we've ruled out an issue in the php layer and likely next steps would be recreating the failure locally [14:26:33] and seeing what the process-control subprocess is doing/seeing/returning [14:28:18] RECOVERY - check_puppetrun on payments1002 is OK: OK: Puppet is currently enabled, last run 4 minutes ago with 0 failures [14:28:54] jgleeson: +many to recreating the failure locally [14:30:14] although I guess that's dependant on whether or not it's environment related [14:41:31] the adyen job does not take more than a second or two [14:42:01] run-job exits... so i don't think it's a timeout [15:11:50] coincidentally, another job has just timed out attempting to export data [15:44:24] Fundraising-Backlog, Fr-CiviCRM-dedupe-FY2017/18: Civi dedupe: queries yielding http 500 errors or blank screens - https://phabricator.wikimedia.org/T222902 (MBeat33) [15:45:40] fundraising-tech-ops: EPIC: migrate fundraising off of Debian Jessie - https://phabricator.wikimedia.org/T185013 (Jgreen) [15:45:42] fundraising-tech-ops: upgrade frdev1001 to Debian Stretch - https://phabricator.wikimedia.org/T220452 (Jgreen) Open→Resolved [15:47:43] fundraising-tech-ops: upgrade civi1001 and mintaka to Stretch, possibly Buster - https://phabricator.wikimedia.org/T220453 (Jgreen) Open→Resolved a:Jgreen civi1001 is done [15:47:45] fundraising-tech-ops: EPIC: migrate fundraising off of Debian Jessie - https://phabricator.wikimedia.org/T185013 (Jgreen) [16:11:22] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MinervaNeue, Accessibility, and 2 others: Banner/CentralNotice should be child of `header` and not above it - https://phabricator.wikimedia.org/T205360 (Volker_E) @Jseddon Small comment, without having access to Nirzar's original designs. T... [16:24:45] (PS1) Jgleeson: WIP: Added support for the new 'employer' field being captured within the payments wiki employer form variant. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/509103 (https://phabricator.wikimedia.org/T219558) [16:38:10] (PS2) Jgleeson: Added support for the new 'employer' field [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/509103 (https://phabricator.wikimedia.org/T219558) [16:38:50] (PS3) Jgleeson: Added support for the new 'employer' field [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/509103 (https://phabricator.wikimedia.org/T219558) [17:11:04] Fundraising Sprint It Came From Out of Scope, Fundraising-Backlog: adyen failmail investigation - https://phabricator.wikimedia.org/T222912 (DStrine) [17:34:28] Fundraising Sprint It Came From Out of Scope, Fundraising-Backlog: adyen failmail investigation - https://phabricator.wikimedia.org/T222912 (Ejegg) some other notes here: https://etherpad.wikimedia.org/p/adyen-smashpig-failmail [17:50:15] (CR) Thiemo Kreuz (WMDE): [C: +2] Add mediawiki/mediawiki-codesniffer [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/505413 (https://phabricator.wikimedia.org/T170311) (owner: Umherirrender) [18:08:31] (Merged) jenkins-bot: Add mediawiki/mediawiki-codesniffer [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/505413 (https://phabricator.wikimedia.org/T170311) (owner: Umherirrender) [18:09:20] (CR) jenkins-bot: Add mediawiki/mediawiki-codesniffer [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/505413 (https://phabricator.wikimedia.org/T170311) (owner: Umherirrender) [18:30:56] Fundraising-Backlog, Patch-For-Review: Add phpcs to FundraisingEmailUnsubscribe - https://phabricator.wikimedia.org/T170311 (Umherirrender) Open→Resolved p:Triage→Normal a:Umherirrender [19:06:58] (PS7) XenoRyet: Opt-in Consumer handles contact ID and Hash [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/508401 (https://phabricator.wikimedia.org/T217710) [19:07:37] (CR) XenoRyet: "This PS gets the email functionality working properly, still need to address the points raised in the last round of review." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/508401 (https://phabricator.wikimedia.org/T217710) (owner: XenoRyet) [19:17:04] Fundraising-Backlog: New mobile iFrame errors - https://phabricator.wikimedia.org/T221385 (MBeat33) #584221 5/9 Malaysia I cannot key-in particulars in the creditcard/debitcard info paragragh...It just disappeared the moment I tried to #584030 5/9 I tried to donate but the section to enter my card details... [20:17:42] (PS8) XenoRyet: Opt-in Consumer handles contact ID and Hash [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/508401 (https://phabricator.wikimedia.org/T217710) [20:23:01] fr-tech: Ok the contact ID patch is ready for review: https://gerrit.wikimedia.org/r/508401. I think https://gerrit.wikimedia.org/r/506837 is ready to look at too, but since cstone, mepps, and I have all had our fingers in the code on that one, I guess someone besides we three should do the review. [20:24:30] And on that note, I'm gonna grab some lunch. [21:59:47] hey I just saw that mail from Pats - is it under control? [22:01:09] looks like it's to do with the staging environment, not prod. [22:02:27] XenoRyet|ish: ok that's not so urgent then [22:13:20] eileen: Though if you're around and looking for review to do, a couple of the civi side opt-in patches are ready. https://gerrit.wikimedia.org/r/508401 and https://gerrit.wikimedia.org/r/506837 specifically. [22:13:25] No worries if you're on other stuff though. [22:38:03] XenoRyet|ish: I'll take a look - were you going to add unit tests? [23:17:52] (CR) Eileen: "I added a few comments.. 2 of them are real issues as opposed to my ponderings - ie. the parentheses on the extraction in the hash checkin" (5 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/508401 (https://phabricator.wikimedia.org/T217710) (owner: XenoRyet) [23:18:16] XenoRyet|ish: I added some comments - do they make sense? [23:18:28] let me take a look [23:19:24] Yea, looks like useful stuff right off the bat. [23:19:52] This is kind of my first time playing with the api3 stuff, so it's all helpful advice. [23:21:06] Though on the location_type_id, locally it wasn't having a problem having everything be type 1, which is home. It added both just fine. [23:21:34] It might make more sense to set the rest to other anyway though, I suppose. [23:22:23] But yea, thanks for the review. I'll start looking into that stuff. [23:26:05] (CR) Eileen: "A couple of minor comments but mostly wondering about a test on this" (3 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/506837 (https://phabricator.wikimedia.org/T217710) (owner: Mepps)