[13:04:09] Fundraising-Backlog, donate.wikimedia.org: Create donate wiki form for endowment - https://phabricator.wikimedia.org/T222091 (Pcoombe) Open→Resolved http://donate.wikimedia.org/?addStyle=endowment&appeal=JimmyQuote&utm_medium=endowment&utm_campaign=XXXX&utm_source=YYYY Breaking that down: addSty... [13:07:51] Fundraising Tech Backlog, Fundraising-Backlog, donate.wikimedia.org: Look at using Lua for donatewiki - https://phabricator.wikimedia.org/T87669 (Pcoombe) Open→Resolved a:Pcoombe I've rewritten a few of the trickier templates to use Lua now. It does make the code much clearer, will probab... [13:14:52] (CR) Thiemo Kreuz (WMDE): [C: +1] "Looks sane, but I'm not sure if the test coverage in this extension is good enough to merge this without a manual test." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/492513 (owner: Umherirrender) [14:29:25] ejegg, do you think we're ok to leave the opt-in stuff as part of the unsubscribe code? I'm looking at it now and thinking about suggesting to generalise the naming or split it out [14:37:32] back later! [14:56:24] fr-tech I'm so frustrated by the adyen job I'm about to get rid of the SOAP API [15:01:19] Hmmm [15:50:13] heading to a library... [16:35:04] hi XenoRyet - did you see eileen's review on that patch? [16:35:14] Yep, working through it now. [16:42:56] (PS1) Ejegg: Remove Provincia Pagos [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/509890 (https://phabricator.wikimedia.org/T222977) [16:44:05] fr-tech got some dead simple payment method add/remove patches: https://gerrit.wikimedia.org/r/509528, https://gerrit.wikimedia.org/r/509890 [16:44:10] anyone able to review? [16:44:19] Yea, I can take a quick look. [16:45:31] (CR) XenoRyet: [C: +2] Enable dlocal form for UY / cash [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/509528 (https://phabricator.wikimedia.org/T222961) (owner: Ejegg) [16:48:21] (CR) XenoRyet: [C: +2] Remove Provincia Pagos [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/509890 (https://phabricator.wikimedia.org/T222977) (owner: Ejegg) [16:48:34] There you go ejegg [16:56:38] Fundraising Sprint It Came From Out of Scope, Fundraising-Backlog, FR-Astropay, Patch-For-Review: Please remove "Provincia Pagos" from Argentina cash options - https://phabricator.wikimedia.org/T222977 (DStrine) [16:57:12] Fundraising Sprint It Came From Out of Scope, Fundraising-Backlog, FR-Astropay, Patch-For-Review: RedPagos (cash) form in Uruguay fails to load with a fatal exception - https://phabricator.wikimedia.org/T222961 (DStrine) [16:57:56] thanks XenoRyet. There's one more tiny patch that's a parent to the UY / cash one [16:58:11] Oh, let me take a look at that as well. [16:58:24] https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/DonationInterface/+/509527/1 [17:00:51] I'm surprised that wasn't biting us all along! [17:01:17] Did PHP 5.X really let us get away with calling a static method on an interface? [17:01:42] That's what I was just looking at. I'm confused as to how this ever worked. [17:02:00] Anyway, new way looks good. [17:02:06] (CR) XenoRyet: [C: +2] Call getGlobal on class, not interface [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/509527 (https://phabricator.wikimedia.org/T222961) (owner: Ejegg) [17:05:20] (PS2) Ejegg: Call getGlobal on class, not interface [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/509527 (https://phabricator.wikimedia.org/T222961) [17:05:31] (PS3) Ejegg: Enable dlocal form for UY / cash [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/509528 (https://phabricator.wikimedia.org/T222961) [17:12:32] (Merged) jenkins-bot: Remove Provincia Pagos [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/509890 (https://phabricator.wikimedia.org/T222977) (owner: Ejegg) [17:12:55] (PS3) Ejegg: Call getGlobal on class, not interface [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/509527 (https://phabricator.wikimedia.org/T222961) [17:13:11] (PS4) Ejegg: Enable dlocal form for UY / cash [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/509528 (https://phabricator.wikimedia.org/T222961) [17:14:51] cstone: it looks like there are some fixes to the thank you letter templates up [17:15:08] do you want to try to run make-thank-you again? [17:17:06] ejegg nice it looks like it generated all of them except ca with a Found 1 likely tokens "[givenname]" in rendered thank-you translation. [17:19:26] ok, should be a simple fix [17:20:36] ah yeah looks like it just needs a space [17:22:26] I think I just fixed it, but someone with publish rights needs to change the state [17:22:43] it was correct in the first paragraph, just broken further down the page [17:29:07] (CR) Ejegg: [C: +2] "Re-applying XenoRyet's +2 to nudge jenkins" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/509527 (https://phabricator.wikimedia.org/T222961) (owner: Ejegg) [17:29:21] (CR) Ejegg: [C: +2] "Re-applying XenoRyet's +2 to nudge jenkins" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/509528 (https://phabricator.wikimedia.org/T222961) (owner: Ejegg) [17:31:02] tskaff or jrobell: Almost all of the new TY letter translations are looking good now! Just Catalan needs a nudge. I fixed a thing in the last paragraph, so it needs to be flipped back into the published state. [17:39:28] hmm, wonder if this has any bearing on our adyen issue? https://stackoverflow.com/questions/54602813/soapclient-silent-failure-due-to-bad-wsdl-cache [17:39:57] I guess we could try WDSL_CACHE_NONE for starters [17:40:11] since those jobs aren't making users wait [17:42:49] (PS1) Ejegg: Try turning off WSDL caching for Adyen [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/509899 [17:43:02] fr-tech anyone want to +2 that? ^^^ [17:43:07] sure ejegg [17:43:10] Thanks! [17:43:53] (CR) Jgleeson: [C: +2] Try turning off WSDL caching for Adyen [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/509899 (owner: Ejegg) [17:44:29] (Merged) jenkins-bot: Try turning off WSDL caching for Adyen [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/509899 (owner: Ejegg) [17:45:16] ejegg, do you think that might be causing it? [17:45:23] out of date wsdl? [17:46:18] jgleeson: no idea! SOAP / WSDL is a bit arcane to me [17:46:51] (Merged) jenkins-bot: Call getGlobal on class, not interface [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/509527 (https://phabricator.wikimedia.org/T222961) (owner: Ejegg) [17:46:55] (Merged) jenkins-bot: Enable dlocal form for UY / cash [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/509528 (https://phabricator.wikimedia.org/T222961) (owner: Ejegg) [17:46:56] Just looked like a way of eliminating one bit of processing [17:47:20] Fr-tech, anyone want practice deploying? [17:47:34] There's a SmashPig patch and a few DonationInterface patches ready to go [17:47:37] ah ok. SOAP was the default in financial services for some annoying reason so I used to spend more time with SOAP that I would have liked [17:47:47] oh fun [17:48:57] REST/HTTP seem to have taken over! [17:48:58] Adyen may have deprecated it... I was actually on my way to making a patch to use their new API when I saw the caching bit and figured I'd try the simplest thing first [17:49:48] I actually had an idea today to setup a comparable SOAP client locally and call it with process-control to see if there's something weird going on [17:49:53] maybe a php 7.2 thing [17:50:27] i tried locally with a sandbox payment [17:50:35] and got an exit code of sero [17:50:37] *zero [17:50:39] ah [17:50:42] :( [17:50:47] this bug doesn't wanna be found does it [17:50:54] sneaky thing! [17:51:36] another thought was to strip away the current job into a new file [17:51:51] fr-tech ok, i'mma go ahead and deploy that smashpig tweak [17:51:52] and introduce steps until we hit the buggy one [17:52:08] but that would on product, effectively commiting a WIP job [17:52:13] jgleeson: hmm, it's a bit hard to break up [17:52:16] production* [17:52:51] ejegg, I guessed an easy seam would be switching off the API outbound calls [17:52:58] or commenting out? [17:53:13] oh, and just not take the money? [17:53:49] hmmm that might not be what we want [17:54:28] I was thinking along the lines of a dry run [17:54:40] so we comment out / stub out the important stuff [17:54:51] but still simulate enough of the process to try and work out what section is at fault [17:55:18] it looks at this point like we can't recreate it anywhere else but live [17:55:21] yeah, that was my idea with switching out the SOAP API call for their new API [17:56:08] we're pretty well encapsulating it, at least [17:56:18] it's just adding another composer dependency [17:56:38] (which i'm ambivalent about) [17:57:28] (as they have their own http handler classes that work in a slightly different way from the ones we use for other api calls) [17:57:55] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/509906 [17:58:21] is the new service SOAP? [17:58:27] noap [17:58:28] and does it honour the current entities [17:58:31] lol [17:58:40] so that would be kinda a big job? [17:59:00] although maybe quicker than trying to undo the current [17:59:09] it does honor the current entities - it would be a way smaller change than for ingenico [17:59:27] even if we find the problem code, there's no guarantee we can fix it :| [17:59:35] also, we only make one important API call with adyen [17:59:39] 'capture' [17:59:48] oops, nother meeting [18:00:01] cool [18:01:39] woah fr-tech, is the deadline to complete reviews this friday? [18:01:47] Yea, I believe so. [18:01:54] argh, yep [18:02:05] wow I need to get cracking then [18:02:09] I haven't started yet [18:02:10] ditto [18:02:15] We contemplating creating a task for it and putting it in sprint so we all remember to devote the time to it. [18:02:44] I can do that later today if it seems like it would be helpful. [18:04:00] yeah that makes sense. will probably be worth rolling it into the new sprint tomorrow also [18:04:35] jgleeson and others, i recommend putting time on your calendar as a helpful way to remember [18:05:50] mepps, will do. it took me longer than I expected to complete them last year so I will start first thing tomorrow and just work through until they're complete [18:09:31] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/509906 (owner: Ejegg) [18:10:09] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/509906 (owner: Ejegg) [18:28:02] !log updated SmashPig standalone deploy 22b6982 Try turning off WSDL caching for Adyen [18:28:05] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [18:28:07] derp [18:28:24] well, gets the point across, I guess [18:28:47] don't have especially high hopes for that patch, but let's see... [18:32:59] log and commit messages are always so serious [18:34:06] errrrrrr so wait, have we not actually gotten any of those emails in the last 9 hours? [18:34:29] oh nvm, that's just how gmail groups them [18:34:45] i missed the new 'thread' [18:34:49] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 9 others: Reduce recurring TY emails - https://phabricator.wikimedia.org/T213209 (Ejegg) Thanks... [18:36:38] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/509913 [18:36:39] oh hey... that's at least one successful job run involving ProcessCaptureRequestJob that didn't send an email [18:36:40] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/509913 (owner: Ejegg) [18:37:10] * ejegg starts to hope this random thing will be all we need [18:37:16] lol [18:37:40] I think new array syntax next, if this doesn't work [18:37:44] :) [18:37:45] :P [18:39:00] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 9 others: Reduce recurring TY emails - https://phabricator.wikimedia.org/T213209 (TSkaff) Ah I s... [18:46:23] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/509919 [18:48:01] cstone: ok, looks like Catalan is ready to go too [18:51:04] (CR) jerkins-bot: [V: -1] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/509919 (owner: Ejegg) [18:52:14] ejegg ok cool they all updated [18:52:56] cstone: ok, so they want to update the subject lines as well [18:53:29] the subject line translator is currently pulling from a DonationInterface json file [18:53:32] but.... [18:54:09] it should be easy to fix so that we pull from another wiki title [18:55:07] cstone so in the thank_you module, you see the ThankYou.php and ThankYouSubject.php classes? [18:55:46] I think you're just going to want to make ThankYouSubject.php another subclass of RenderTranslatedPage, just with a different title [18:55:57] shouldn't even need much for substitutions [18:57:42] cstone lmk if you see any issues with that [18:57:55] ok looking at them now [18:58:24] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/509913 (owner: Ejegg) [18:59:55] oh dang, another ingenico audit parser timeout over the weekend [19:01:23] ejegg, do you know what's happening with that? [19:01:28] (CR) Ejegg: [C: +2] "recheck" [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/509919 (owner: Ejegg) [19:01:45] jgleeson: the audit parser timeout? not sure [19:03:03] yeah [19:03:14] I was thinking maybe the log searching [19:03:34] although the failmail has connection timeouts I think [19:03:34] right, that's what it was before [19:03:41] let me double check [19:04:16] ah no, I must be thinking of another failmail [19:05:43] on Friday there were a few failmails related to queue connection failures [19:06:56] ah that was it [19:14:59] well i'll be darned, did that cache thing actually work? [19:15:47] * jgleeson refreshes gmail as eyebrows rise [19:16:27] ejegg, time for the run-job test? [19:17:57] you do relaise that if this has fixed it the default answer no to ANY tricky bug (technical or not) going forward will be "have you cleared the WSDL cache?" [19:18:10] my cat is sick.. have you cleared the WSDL cache? [19:18:31] jgleeson: haha [19:19:36] jgleeson: i deployed it 50 minutes ago [19:19:48] and we haven't gotten a failmail since! [19:20:08] and it has indeed been processing those capture jobs [19:20:09] ejegg, I was assuming it was an hourly job? [19:20:14] oh rly! [19:20:18] jgleeson: ah, no, it runs every 3 minutes [19:20:37] it's trying to get the TY letters out in something close to real time [19:21:25] I guess we could run-job; echo $? [19:21:33] and then break out the champange if that shows 0 [19:23:12] champagne* [19:25:19] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/509919 (owner: Ejegg) [19:32:33] (CR) Jgleeson: "Reviewed this patch and nothing to add regards the code beyond what's already been posted." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/508401 (https://phabricator.wikimedia.org/T217710) (owner: XenoRyet) [19:37:49] (CR) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/509919 (owner: Ejegg) [19:55:52] Fundraising-Backlog: Create checklist for mediawiki upgrades - https://phabricator.wikimedia.org/T222734 (DStrine) Can we publish the checklist or release notes to collab every time we upgrade? [19:56:21] Fundraising-Backlog: Create checklist for civi upgrades - https://phabricator.wikimedia.org/T222733 (DStrine) Can we publish the checklist or release notes to collab every time we upgrade? [19:59:19] Fundraising-Backlog: Ask GlobalCollect to let us cancel status 600 transactions - https://phabricator.wikimedia.org/T114205 (DStrine) the new api might allow us to do this. we need to investigate this [20:00:55] Fundraising-Backlog, FR-Paypal, FR-Smashpig: PayPal unsupported message type: recurring_payment_outstanding_payment - https://phabricator.wikimedia.org/T219833 (DStrine) [20:01:55] Fundraising-Backlog, MediaWiki-Cache, MediaWiki-extensions-CentralNotice, Performance-Team (Radar): Mediawiki namespace pages, including CentralNotice banners, are slow to save - https://phabricator.wikimedia.org/T158084 (DStrine) Open→Resolved [20:02:43] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: Metaissue for data integrity in Civi - https://phabricator.wikimedia.org/T218251 (DStrine) [20:03:14] Fundraising-Backlog, Epic: [Epic] Revoke AWight fundraising privileges - https://phabricator.wikimedia.org/T168421 (DStrine) [20:05:59] Fundraising Sprint It Came From Out of Scope, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review, Technical-Debt (Deprecation): Deprecation warning from CentralNotice: OutputPage::parseInline - https://phabricator.wikimedia.org/T213978 (DStrine) [20:06:49] Fundraising Sprint It Came From Out of Scope, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review, and 2 others: Viewing Special:CentralNoticeBanners subpage can throw fatal BannerExistenceException - https://phabricator.wikimedia.org/T149240 (DStrine) [20:08:24] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Upstream our remaining Civi patches - https://phabricator.wikimedia.org/T217600 (Eileenmcnaughton) [20:14:33] Fundraising-Backlog: Create checklist for civi upgrades - https://phabricator.wikimedia.org/T222733 (Eileenmcnaughton) @DStrine - that's pretty much what the lists are at the bottom of that page - I feel like we use/add them reliably when it's an upgrade to Civi - but perhaps not when it's an ops upgrade tha... [20:29:43] !log updated payments-wiki from 6e0172bac3 to 8397ccf9cc [20:29:46] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:30:53] Fundraising Sprint It Came From Out of Scope, Fundraising-Backlog, FR-Astropay, MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Patch-For-Review: Please remove "Provincia Pagos" from Argentina cash options - https://phabricator.wikimedia.org/T222977 (Ejegg) OK, this is all set! [20:31:21] Fundraising Sprint It Came From Out of Scope, Fundraising-Backlog, FR-Astropay, MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Patch-For-Review: RedPagos (cash) form in Uruguay fails to load with a fatal exception - https://phabricator.wikimedia.org/T222961 (Ejegg) OK, this is deployed. Link in de... [20:40:24] (PS9) XenoRyet: Opt-in Consumer handles contact ID and Hash [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/508401 (https://phabricator.wikimedia.org/T217710) [20:43:23] jgleeson: any thoughts on how to make the employer field optional for the user? [20:44:07] oh shoot, did I make it mandatory on the patch? [20:44:37] the field does render with a 'required' attribute [20:45:05] and I think country_fields stuff has been required in validation as well [20:45:14] sorry, lemme test real quick [20:47:36] ah ejegg that will be an oversight due to copying the html from another element [20:47:51] I'm gonna jump on the test for that patch so I'll fix that too [20:52:45] (CR) XenoRyet: "Some inline responses." (4 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/508401 (https://phabricator.wikimedia.org/T217710) (owner: XenoRyet) [20:54:06] eileen: ^ There's the latest on that patch. I'm gonna go grab some food real fast, but I'll be back in a while. I left the sort of questions and whatnot as inline comments there, but we can talk more when I'm back too. [20:57:37] jgleeson: yeah, it'll be a bit tricky to get employer past validation [20:58:07] when it's not supplied? [20:58:26] oops yeah, i mean empty employer past validation [20:58:35] ah [20:58:52] hmmm maybe detect is variant is enabled and if so, check if field is null and drop it [21:00:01] specifically for one variant & one field? [21:00:21] Fundraising-Backlog: Create checklist for civi upgrades - https://phabricator.wikimedia.org/T222733 (mepps) I didn't know this existed! I need to add a link on the documentation homepage. [21:00:38] hmm that feesl like it might couple the field a little [21:01:41] Fundraising-Backlog: Create checklist for civi upgrades - https://phabricator.wikimedia.org/T222733 (mepps) @cwdent, @Eileenmcnaughton and I were just discussing that it might be helpful if we put up notes like those at the bottom of the collab page she linked for any time there is an outage. [21:01:46] actually you know I haven't tried submitting the variant form with the field blank [21:01:57] best would be a way to use the values in country_fields.yaml to indicate what's required and what's optional [21:01:59] does it still triggler the datavalidator method? [21:02:06] jgleeson: yeah [21:02:11] ah ok [21:02:58] one issue is that we're using the same function to get the list of fields to show as we are to get the list of fields to require in validation [21:03:24] so it'll be a bit of a change to the basics of our forms code [21:03:39] I was gonna say, the boolean type doesn't lend itself to optional [21:03:49] right [21:04:11] looks like we're not even doing anything with 'false' at this point [21:04:14] so we currently don't have any optional form fields visible ? [21:04:31] or optinal fields fullstop [21:04:31] right, nothing like that exists yet [21:04:36] ah ok [21:05:20] I'll have a think about it first thing and see if I can work it in without distrubring the current conventions [21:05:35] disturbing* [21:05:42] heh, current conventions might need a shake-up! [21:05:47] gotta jump off now, GoT time! [21:05:51] enjoy! [21:06:12] have a good rest of your day fr-tech! [21:09:48] (CR) Ejegg: "To make this new field optional, we'll probably want to add a getVisibleFields method that the form classes can use. We can use the values" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/507412 (https://phabricator.wikimedia.org/T219558) (owner: Jgleeson) [21:14:14] cstone: so, to test your changes to the email subject fix, you'd just add --generator=subject to the make-thank-you command [21:17:08] Hi ejegg, thanks for the RedPagos fix! I'll confirm w. Michael, but it sounds like we're ok to put LatAm up? [21:17:34] tskaff: payments-wiki should be all set for it! [21:18:25] MBeat a head's up that LatAm should be going up soon after I adjust the campaign settings. lmk if all's ok on your end! [21:18:45] thanks tskaff green light [21:18:55] Hooray! Thanks all [21:22:04] cstone: so I guess it's not /quite/ as simple as I thought to make the subject come from the same place [21:22:23] I tried out a subject generator that just sets a different title in the constructor [21:22:40] and it's getting

markup around it which we'd want to strip out [21:23:02] as well as the comment at the end which we don't need [21:24:34] ok, so we can override $this->add_template_info_comment to get rid of that comment [21:26:11] (CR) jerkins-bot: [V: -1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/510005 (owner: L10n-bot) [21:27:47] and.... $this->substitutions will let us get rid of the

tags [21:27:59] well shoot, I think I just did the work [21:31:32] (PS1) Ejegg: Thank you subject comes from wiki too [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510050 (https://phabricator.wikimedia.org/T167806) [21:31:36] cstone I think that'll do it ^^^ [21:35:33] Fundraising Sprint It Came From Out of Scope, Fundraising-Backlog, Patch-For-Review: Thank you email subject and body should be translated in same place - https://phabricator.wikimedia.org/T167806 (Ejegg) a:Ejegg [21:39:42] ejegg hey sorry went to get some food I'm back now [21:40:24] heh, ok [21:40:41] (PS1) Ejegg: Delete unused strings [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/510051 (https://phabricator.wikimedia.org/T167806) [21:47:01] heading out for dinner with a friend, might check back later [22:07:25] (CR) Eileen: Opt-in Consumer handles contact ID and Hash (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/508401 (https://phabricator.wikimedia.org/T217710) (owner: XenoRyet) [22:30:29] (CR) XenoRyet: Opt-in Consumer handles contact ID and Hash (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/508401 (https://phabricator.wikimedia.org/T217710) (owner: XenoRyet) [22:42:45] mepps: yt? got a sec to look at your CN patch, https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CentralNotice/+/501049/ ? [22:42:50] If it's late, no worries! [22:44:34] It looks great, it's just that I'd love to also see additional comments in the phpdoc for generateBannerEditForm() and getBannerPreviewEditLinks() mentioning that the methods shouldn't be called before the banner instance variable is set [22:46:32] If you agree and have time to add them this evening, that's great, if not, I'll still +2 before tomorrow so it can get on the train... sound good? [23:06:46] (PS10) XenoRyet: Opt-in Consumer handles contact ID and Hash [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/508401 (https://phabricator.wikimedia.org/T217710) [23:13:52] (PS1) AndyRussG: Update Schema:CentralNoticeBannerHistory version [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/510061 (https://phabricator.wikimedia.org/T218617) [23:14:35] fr-tech hey, anyone about for a quick +2 of a super-simple CN change? https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CentralNotice/+/510061/ [23:14:43] thanks in advance, no worries if not! [23:15:55] Yea, I can take a look in a minute here. [23:18:29] Fundraising Sprint It Came From Out of Scope, MediaWiki-extensions-CentralNotice: Update banner history EventLogging schema - https://phabricator.wikimedia.org/T223183 (AndyRussG) [23:18:55] (PS2) AndyRussG: Update Schema:CentralNoticeBannerHistory version [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/510061 (https://phabricator.wikimedia.org/T218617) [23:19:02] XenoRyet: cool beans, thanks much! [23:20:10] (CR) XenoRyet: [C: +2] Update Schema:CentralNoticeBannerHistory version [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/510061 (https://phabricator.wikimedia.org/T218617) (owner: AndyRussG) [23:20:50] Fundraising Sprint It Came From Out of Scope, MediaWiki-extensions-CentralNotice, Patch-For-Review: Update banner history EventLogging schema - https://phabricator.wikimedia.org/T223183 (AndyRussG) a:AndyRussG [23:21:20] XenoRyet: thanks!!! [23:21:38] No worries, you're welcome [23:21:59] :) [23:22:52] Fundraising Sprint It Came From Out of Scope, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review, and 2 others: Viewing Special:CentralNoticeBanners subpage can throw fatal BannerExistenceException - https://phabricator.wikimedia.org/T149240 (AndyRussG) a:mepps [23:28:44] (Merged) jenkins-bot: Update Schema:CentralNoticeBannerHistory version [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/510061 (https://phabricator.wikimedia.org/T218617) (owner: AndyRussG) [23:39:48] (CR) jenkins-bot: Update Schema:CentralNoticeBannerHistory version [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/510061 (https://phabricator.wikimedia.org/T218617) (owner: AndyRussG)