[01:35:22] (PS1) Eileen: Suppress e-notice when opted_out_timestamp is not set. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510288 (https://phabricator.wikimedia.org/T160949) [01:36:20] (PS1) Eileen: Alter option_group table to default to is_locked = 0 [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/510289 (https://phabricator.wikimedia.org/T222559) [01:36:46] (CR) Eileen: [C: +2] Alter option_group table to default to is_locked = 0 [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/510289 (https://phabricator.wikimedia.org/T222559) (owner: Eileen) [01:37:43] (Merged) jenkins-bot: Alter option_group table to default to is_locked = 0 [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/510289 (https://phabricator.wikimedia.org/T222559) (owner: Eileen) [01:38:51] (CR) jerkins-bot: [V: -1] Suppress e-notice when opted_out_timestamp is not set. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510288 (https://phabricator.wikimedia.org/T160949) (owner: Eileen) [01:39:53] !log civicrm revision changed from 5024c968ed to 4b6d569383, config revision is a099f13a55 [01:39:58] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:40:22] !log process control updated - omnigroupmember.load re-enabled [01:40:25] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:45:04] Fundraising Sprint It Came From Out of Scope, Fundraising Sprint James Bond: Licensed to Share, Fundraising-Backlog, Patch-For-Review: New Custom Fields for Target Smart Import - https://phabricator.wikimedia.org/T222559 (Eileenmcnaughton) Open→Resolved [03:24:42] Fundraising-Backlog: How do we update jenkins to php 7 - https://phabricator.wikimedia.org/T223348 (Eileenmcnaughton) [03:39:12] (Abandoned) Eileen: [do not merge] recent apiv4 updates with some hacks for staging testing [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/507539 (owner: Eileen) [04:21:54] (PS1) Ejegg: Fix TY test form [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510292 [04:23:54] (CR) Ejegg: [C: +2] "Looks good!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510265 (owner: Cstone) [04:28:55] (CR) Ejegg: [C: +2] "Contact layout editor looks good with these changes, nothing nefarious detected at a glance!" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/510263 (https://phabricator.wikimedia.org/T217909) (owner: Eileen) [04:29:13] (Merged) jenkins-bot: Separate out endowment specific text from thank you email. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510265 (owner: Cstone) [04:33:19] (Merged) jenkins-bot: Update CiviCRM apiv4 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/510263 (https://phabricator.wikimedia.org/T217909) (owner: Eileen) [04:35:36] (PS2) Ejegg: Update translated thank you content and subject for the 2018-10-01 thank you email. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510220 (https://phabricator.wikimedia.org/T213209) (owner: Cstone) [04:45:34] (CR) Ejegg: "Yay, tests pass after rebase! But... there are some dumb little things with HTML tags that don't align well with the template conditionals" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510220 (https://phabricator.wikimedia.org/T213209) (owner: Cstone) [05:59:22] (CR) Eileen: [C: +2] "OK let's go with it then - I was just still worried about that test - I tried to write it but am struggling with my .... laptop. Stuck rec" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/508401 (https://phabricator.wikimedia.org/T217710) (owner: XenoRyet) [06:04:05] (Merged) jenkins-bot: Opt-in Consumer handles contact ID and Hash [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/508401 (https://phabricator.wikimedia.org/T217710) (owner: XenoRyet) [07:30:34] (CR) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/510324 (owner: L10n-bot) [07:44:48] Fundraising-Backlog: How do we update jenkins to php 7 - https://phabricator.wikimedia.org/T223348 (Reedy) Are you asking for testing to be done on PHP7 (instead? only?) for this repo? And/or moving the "server" to using PHP7 too (or is the server already using PHP7)? [07:45:37] Fundraising-Backlog, Continuous-Integration-Config: How do we update jenkins to php 7 - https://phabricator.wikimedia.org/T223348 (Reedy) [08:20:55] Fundraising-Backlog, Continuous-Integration-Config: How do we update jenkins to php 7 - https://phabricator.wikimedia.org/T223348 (hashar) I think we went with php5.6 because production used Jessie / php5.6 hence why there is a composer job: `wikimedia-fundraising-crm-composer-php56-docker `. It should b... [08:21:00] Wikimedia-Fundraising-CiviCRM, Continuous-Integration-Infrastructure (Slipway): Migrate wikimedia-fundraising-civicrm to a Docker container - https://phabricator.wikimedia.org/T210287 (hashar) [08:21:02] Fundraising-Backlog, Continuous-Integration-Config: How do we update jenkins to php 7 - https://phabricator.wikimedia.org/T223348 (hashar) [08:41:42] Fundraising-Backlog, Continuous-Integration-Config: How do we update jenkins to php 7 - https://phabricator.wikimedia.org/T223348 (Eileenmcnaughton) @Reedy @hashar -our live server was recently upgraded so it's using php 7.0 so it would be good to get our tested onto it so we can start using different ph... [08:57:18] Fundraising-Backlog, Continuous-Integration-Config: Run wikimedia/fundraising/crm CI jobs on PHP7x, not PHP5x - https://phabricator.wikimedia.org/T223348 (Jdforrester-WMF) [12:45:30] (CR) Jgleeson: [C: +2] "Looks good! the patch fixes the error for me and existing tests passing." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510292 (owner: Ejegg) [12:46:53] (CR) Jgleeson: [C: +2] Delete unused strings [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/510051 (https://phabricator.wikimedia.org/T167806) (owner: Ejegg) [12:49:59] (Merged) jenkins-bot: Fix TY test form [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510292 (owner: Ejegg) [12:50:13] (Merged) jenkins-bot: Delete unused strings [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/510051 (https://phabricator.wikimedia.org/T167806) (owner: Ejegg) [13:27:37] (CR) Jgleeson: [C: -1] "This isn't working for me. I've suggested some rejigged code which got it working locally, check out inline comments." (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449900 (https://phabricator.wikimedia.org/T221387) (owner: Ejegg) [13:30:51] (CR) Jgleeson: [C: -1] "console log output:" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449900 (https://phabricator.wikimedia.org/T221387) (owner: Ejegg) [13:46:09] Fundraising Sprint Greps of Wrath, Fundraising Sprint Hansel and grep -l, Fundraising Sprint It Came From Out of Scope, Fundraising Sprint James Bond: Licensed to Share, and 2 others: Payments wiki form variant with employer field - https://phabricator.wikimedia.org/T219558 (jgleeson) a:jglees... [14:00:16] (PS2) Mepps: Null out some backfilled cancel reasons. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510258 (https://phabricator.wikimedia.org/T218616) (owner: Eileen) [14:00:20] (CR) Mepps: [C: +2] Null out some backfilled cancel reasons. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510258 (https://phabricator.wikimedia.org/T218616) (owner: Eileen) [14:05:47] (Merged) jenkins-bot: Null out some backfilled cancel reasons. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510258 (https://phabricator.wikimedia.org/T218616) (owner: Eileen) [14:19:50] back a little later [14:20:39] Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising Sprint Hansel and grep -l, Fundraising Sprint It Came From Out of Scope, and 2 others: Create variants for fancy new opt in pages on payments wiki - https://phabricator.wikimedia.org/T218240 (spatton) Thanks... [14:45:10] Fundraising-Backlog, fundraising-tech-ops: schedule ~15 minute payments outage to switch clusters from codfw to eqiad - https://phabricator.wikimedia.org/T222618 (Jgreen) We're planning for 2PM Thurs 5/16/2019. [14:58:55] Fundraising Sprint It Came From Out of Scope, Fundraising Sprint James Bond: Licensed to Share, Fundraising Sprint Navel Warfare, Fundraising Sprint Outie Inverter, and 7 others: Import email-only contacts from 'remind me later' links into CiviCRM - https://phabricator.wikimedia.org/T160949 (CCogd... [15:00:52] (PS2) Ejegg: Suppress e-notice when opted_out_timestamp is not set. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510288 (https://phabricator.wikimedia.org/T160949) (owner: Eileen) [15:04:33] (CR) jerkins-bot: [V: -1] Suppress e-notice when opted_out_timestamp is not set. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510288 (https://phabricator.wikimedia.org/T160949) (owner: Eileen) [15:09:28] fr-tech any news for scrum of scrums? [15:10:11] ejegg: nothing here, thanks! [15:20:06] Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising Sprint Hansel and grep -l, Fundraising Sprint It Came From Out of Scope, and 2 others: Create variants for fancy new opt in pages on payments wiki - https://phabricator.wikimedia.org/T218240 (CCogdill_WMF) Go... [16:22:10] ejegg: I can't revert just that change easily because other stuff depends on it [16:22:12] I think we could just switch wmf_deploy to the previous version before the new stuff was merged in [16:22:14] does that sound reasonable? [16:22:34] AndyRussG: yes, sounds good [16:22:40] ejegg: ok thanks [16:25:13] ejegg: seems that merge commits are hard to revert [16:25:47] ugh, yeah [16:27:04] oh boy: Reverting a merge commit declares that you will never want the tree changes brought in by [16:27:07] the merge. As a result, later merges will only bring in tree changes introduced by commits [16:27:10] that are not ancestors of the previously reverted merge. This may or may not be what you [16:27:13] want. [16:27:14] ejegg: so I think maybe we won't do anything on the master branch now, just return wmf_deploy to the previous state and make sure that's what's out [16:27:20] yeah that sounds heinous [16:27:56] so ^ no actual testing on the beta cluster, just revert the prod change before it goes out anywhere else, and also wherever it is currently out (test wiki and 1 or 2 other places IIRC) [16:54:06] ejegg: looks like it's not that hard to revert a merge and then re-merge later on [16:54:11] https://stackoverflow.com/questions/1078146/re-doing-a-reverted-merge-in-git [16:55:06] oh good! [16:55:24] https://stackoverflow.com/questions/11722533/rollback-a-git-merge/29110174 [16:55:42] wrt the doc you cited, "That statement is a bit harsh. You can definitely bring back those changes later, the trick is to revert the revert commit. " [16:55:48] heh, I'm getting deja vu reading that... Feel like we've had to do this in another repo [16:56:43] hmmm I don't think I have that memory [16:56:59] but I'm good at repressing those [17:01:04] I read that on standup after you mentioned it, I forgot to say [17:01:13] looks doable at least! [17:02:59] (PS1) AndyRussG: Revert "Merge branch 'master' into wmf_deploy" [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/510572 [17:05:03] (CR) AndyRussG: [C: +2] Revert "Merge branch 'master' into wmf_deploy" [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/510572 (owner: AndyRussG) [17:05:34] (PS1) XenoRyet: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/510573 [17:06:32] ejegg: the SWAT deploy is done and no one on ops seemed eager to help with this deploy, so we may have to do the prod deploy ourselves [17:06:53] The train is in 2 hours but hashar, who is driving the train today, is not around until a bit before then [17:07:41] I guess I'll get some coffee and then brush up on the doc for that... [17:07:45] AndyRussG: oh, we have to deploy a revert? [17:07:59] (CR) XenoRyet: [C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/510573 (owner: XenoRyet) [17:08:15] Or just update the cn pointer in the core wmf branch? [17:08:35] I think the revert is the correct [17:08:37] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/510573 (owner: XenoRyet) [17:09:15] there are scripts that automagically point the submodule to whatever the deploy branch is at [17:09:36] so we don't want those somehow running and overwriting the change [17:09:47] also a revert leaves the history clear about what happened [17:10:02] then later we can fix the issue in master, and in wmf_deploy, revert the revert before merging master in agian [17:10:13] how does that sound? [17:11:36] Hi [17:11:40] (Merged) jenkins-bot: Revert "Merge branch 'master' into wmf_deploy" [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/510572 (owner: AndyRussG) [17:11:46] Krinkle: hey! [17:12:15] Krinkle: I guess for now we opted to just revert the deploy that pushed out the changes [17:12:33] Sure [17:12:43] So the module that serves the file containing 'mw.util.getParamValue', does it have a dependency on 'mediawiki.util'? [17:13:40] Krinkle: yep [17:14:46] Indeed. I see it now. [17:14:49] Interesting. [17:17:29] I can reproduce it on beta with https://en.wikipedia.beta.wmflabs.org/wiki/Main_Page?debug=true&safemode=on with breakpoint on caught exceptions, that mw.util is undefined at that time. [17:17:33] mw.loader.moduleRegistry['ext.centralNotice.startUp'].dependencies is an empty array [17:18:30] so that's definitely suspicious [17:18:42] (CR) jenkins-bot: Revert "Merge branch 'master' into wmf_deploy" [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/510572 (owner: AndyRussG) [17:18:49] the startup module shows: [17:18:50] [ [17:18:51] "ext.centralNotice.startUp", [17:18:51] "08xa4hd" [17:18:51] ], [17:18:59] which means it isn't lost at run-time, but never there from the server [17:19:02] !log updated civicrm from 4b6d569383 to 7d3ef1f2ae [17:19:05] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [17:19:23] Krinkle: actually at one point it looked like other modules might not have been being found correctly, also [17:19:42] I'm not familiar enough with this to be sure, didn't dig that much there [17:19:52] I see other modules do generally have a non-empty dependency list. [17:20:04] so I'm assuming for now this is CN specific [17:21:52] Krinkle: ok, that's comforting, because it would mean that by reverting the CN deploy only things would work [17:22:16] the plan for right now is not to touch CN master, just go back to the previous working commit on the CN wmf_deploy branch [17:22:31] Yeah, that makes sense [17:22:39] and then fix the issue in master, then revert the revert on wmf_deploy and re-merge master [17:23:23] krinkle@deployment-deploy01:~$ mwscript eval.php --wiki enwiki [17:23:24] > var_dump($wgResourceModules['ext.centralNotice.startUp']); [17:23:24] array(5) { [17:23:24] ["localBasePath"]=> string(94) "/srv/mediawiki-staging/php-master/extensions/CentralNotice/resources/ext.centralNotice.startUp" [17:23:24] ["remoteExtPath"]=> string(49) "CentralNotice/resources/ext.centralNotice.startUp" [17:23:24] ["packageFiles"]=> array(3) { … } [17:23:24] ["dependencies"]=> array(2) { [0]=> string(28) "ext.centralNotice.choiceData" [1]=> string(14) "mediawiki.util" } [17:23:25] ["targets"]=> array(2) { [0]=> string(7) "desktop" [1]=> string(6) "mobile" [17:23:31] This looks fine as well [17:23:52] hmmm [17:24:08] maybe some circular dependency? or I imagine that's already checked for [17:24:18] fr-tech, are we delaying tech-talk? [17:24:44] I would assume yes, looks like the CN stuff is still being worked on. [17:25:09] > var_dump( $resourceLoader->getModule('ext.centralNotice.startUp')->getDependencies() ); [17:25:09] array(2) { [0]=> string(28) "ext.centralNotice.choiceData" [1]=> string(14) "mediawiki.util" } [17:25:16] also looks fine, so it's interpreted and registered correctly. [17:25:29] That basically leaves the filtering and validation later on in StartUp, but that hasn't changed in years. But we've found a bug! [17:25:39] but maybe* [17:26:02] cool, thanks [17:26:20] jgleeson fr-tech I think delaying makes sense... Though we could also screen share and follow on the prod deploy if anyone feels like it [17:26:44] That could be fun/useful [17:26:45] that sounds like something I'd like to watch [17:27:10] AndyRussG: Yes, indeed, a circular dependency. ext.centralNotice.startUp -> ext.centralNotice.choiceData -> ext.centralNotice.display -> ext.centralNotice.kvStore -> ext.centralNotice.startUp [17:27:10] Yea, me too. I'll join the hangout in a second. [17:27:48] Krinkle: ah fun! [17:28:03] this should have caused an error, checking lostash-beta now [17:28:04] fr-tech I'll be there in a few also then! [17:28:58] Krinkle: maybe it'd be easier to fix that quickly then? [17:29:10] Yeah, should be simple. Just need to decide how to structure it. [17:29:34] Krinkle: remember that choiceData has dynamic dependencies [17:29:48] The kvStoreMaintenance file used to be a dependency-free standalone file that was only used by centralNotice.startUp. But due to now being part of centralNotice.startUp itself, kvStore can't safely depend on it the way it previously did. [17:29:50] Yeah [17:31:00] Overall CN registers too many modules. So not sure if there's a preference over what the entry points logically are vs what internal code-structure boundaries are. In terms of entry point, as far as I know there are only two: The CN special page, and normal pages. [17:31:12] So that means in theory, 2 modules would suffice. Maybe 3 if there's shared common utils between them. [17:33:57] AndyRussG: Is there a task for this? [17:34:03] Krinkle: the proliferation of modules is because of the mixins [17:34:03] (the error from today) [17:34:10] not yet [17:40:03] Krinkle: I think we'll try to push out the revert as that's more of a certain fix for a short time frame, and then fix the dependency thing later [17:40:27] AndyRussG: The revert of the branch, or in-master? [17:40:38] I can get the dep fix done in a few more minutes I think [17:40:45] either way is fine, low prio [17:42:46] Krinkle: revert the deploy branch [17:42:49] then fix in master [17:43:04] If you'd like to try fixing it quickly and we can push to the beta cluster, that's also fun [18:07:37] (PS1) Krinkle: ext.centralNotice.kvStore: Move to its own directory [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/510584 (https://phabricator.wikimedia.org/T193826) [18:07:40] (PS1) Krinkle: ext.centralNotice.startUp: Fix circular dependency via kvStore [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/510585 [18:08:39] AndyRussG: Tried to balance keeping a minimal diff, and making the end result easy to comprehend. Went more towards the latter, so slightly bigger diff. Let me know if you have any questions :) [18:09:36] Krinkle: ok fantastic, thanks so much! [18:09:48] (PS2) Krinkle: ext.centralNotice.startUp: Fix circular dependency via kvStore [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/510585 [18:10:37] (PS3) Krinkle: ext.centralNotice.startUp: Fix circular dependency via kvStore [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/510585 [18:10:40] (CR) jerkins-bot: [V: -1] ext.centralNotice.startUp: Fix circular dependency via kvStore [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/510585 (owner: Krinkle) [18:11:47] (PS4) Krinkle: ext.centralNotice.startUp: Fix circular dependency via kvStore [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/510585 [18:11:54] (CR) Krinkle: "fixed lint errors" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/510585 (owner: Krinkle) [18:14:39] (CR) jerkins-bot: [V: -1] ext.centralNotice.startUp: Fix circular dependency via kvStore [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/510585 (owner: Krinkle) [18:15:31] (PS5) Krinkle: ext.centralNotice.startUp: Fix circular dependency via kvStore [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/510585 [18:22:12] AndyRussG: I've also filed https://phabricator.wikimedia.org/T223402 [18:22:24] so that we detect this in CI instead of only after deployment. [18:25:20] Fundraising-Backlog, FR-Civi-Planned-Giving, FR-Civi-Prospect: Dedupe on TargetSmart donors - https://phabricator.wikimedia.org/T223403 (NNichols) [18:26:56] Fundraising-Backlog, FR-Civi-Planned-Giving, FR-Civi-Prospect: Dedupe on TargetSmart donors - https://phabricator.wikimedia.org/T223403 (NNichols) [18:27:36] Fundraising-Backlog, FR-Civi-Planned-Giving, FR-Civi-Prospect: Dedupe on TargetSmart donors - https://phabricator.wikimedia.org/T223403 (NNichols) [18:28:31] Krinkle: thanks much!! [18:44:04] fr-tech Krinkle revert all deployed on production [18:45:23] thanks much, all!!!! [19:03:05] (PS6) Ejegg: Support lots of country tlds for yahoo & microsoft mail [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449900 (https://phabricator.wikimedia.org/T221387) [19:05:11] (CR) Ejegg: "Thanks jgleeson. The changes from PS6 also seem to do the trick." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449900 (https://phabricator.wikimedia.org/T221387) (owner: Ejegg) [19:09:20] Fundraising Sprint It Came From Out of Scope, Fundraising Sprint James Bond: Licensed to Share, Fundraising Sprint Navel Warfare, Fundraising Sprint Outie Inverter, and 7 others: Import email-only contacts from 'remind me later' links into CiviCRM - https://phabricator.wikimedia.org/T160949 (Eilee... [19:12:58] Fundraising-Backlog: Handle anomalous donations related to ID re-use - https://phabricator.wikimedia.org/T223409 (Ejegg) [19:18:07] Fundraising Sprint It Came From Out of Scope, Fundraising Sprint James Bond: Licensed to Share, Fundraising Sprint Navel Warfare, Fundraising Sprint Outie Inverter, and 7 others: Import email-only contacts from 'remind me later' links into CiviCRM - https://phabricator.wikimedia.org/T160949 (CCogd... [19:30:23] fr-tech all good with the train deploy, CN on prod is fine [19:30:31] Good to hear [19:30:37] Yeeee [19:30:38] great! [19:31:21] I guess a late smoke test is better than no smoke test [19:31:32] hmm, that group member fetch is failing pretty consistently [19:32:09] we should get some more automation on CN [20:13:05] (PS1) Ejegg: Reformat tracking.inc with drupal standard [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/510607 [20:13:07] (PS1) Ejegg: WIP switch for using contribution tracking queue [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/510608 (https://phabricator.wikimedia.org/T215463) [20:45:24] (CR) Eileen: [C: +2] Reformat tracking.inc with drupal standard [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/510607 (owner: Ejegg) [20:46:04] (Merged) jenkins-bot: Reformat tracking.inc with drupal standard [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/510607 (owner: Ejegg) [20:49:23] (PS1) Eileen: Submodule update: CiviCRM [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510611 (https://phabricator.wikimedia.org/T222226) [20:49:40] (CR) Eileen: [C: +2] Submodule update: CiviCRM [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510611 (https://phabricator.wikimedia.org/T222226) (owner: Eileen) [20:54:28] (Merged) jenkins-bot: Submodule update: CiviCRM [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510611 (https://phabricator.wikimedia.org/T222226) (owner: Eileen) [21:07:40] (PS1) Eileen: CiviCRM update to 5.13.4 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/510612 (https://phabricator.wikimedia.org/T222226) [21:13:58] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/510615 [21:17:32] (PS1) Eileen: Revert hacks to prevent slow login [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/510617 [21:17:40] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/510615 (owner: Eileen) [21:18:23] (Merged) jenkins-bot: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/510615 (owner: Eileen) [21:21:33] (Abandoned) Eileen: Revert hacks to prevent slow login [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/510617 (owner: Eileen) [21:23:43] !log civicrm revision changed from 7d3ef1f2ae to c69c6e2e6a, config revision is a099f13a55 [21:23:46] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:37:21] (CR) Ejegg: [C: +2] CiviCRM update to 5.13.4 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/510612 (https://phabricator.wikimedia.org/T222226) (owner: Eileen) [21:38:49] I just discovered I can marge things 'Work in Progress' in Gerrit - I'm guessint that pulls it out of 'imcoming reviews'? [21:41:00] eileen: it at least prevents it from being merged [21:42:31] (Merged) jenkins-bot: CiviCRM update to 5.13.4 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/510612 (https://phabricator.wikimedia.org/T222226) (owner: Eileen) [21:46:11] (PS1) Eileen: Submodule commit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510620 (https://phabricator.wikimedia.org/T222226) [21:46:30] (CR) Eileen: [C: +2] Submodule commit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510620 (https://phabricator.wikimedia.org/T222226) (owner: Eileen) [21:51:08] (Merged) jenkins-bot: Submodule commit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510620 (https://phabricator.wikimedia.org/T222226) (owner: Eileen) [21:54:44] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/510621 [21:55:27] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/510621 (owner: Eileen) [21:55:41] (Merged) jenkins-bot: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/510621 (owner: Eileen) [21:56:24] ejegg: it does take it out of 'Incoming reviews' - so we could use that to clean up incoming reviews down to ones that are actually wanting review [21:56:37] (I just tested by making one of yours wip) [21:56:41] oh, right on [21:56:58] (PS1) Ejegg: WIP Use new ifame variant for Ingenico [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/510622 (https://phabricator.wikimedia.org/T222290) [22:01:22] !log civicrm update - lost the commit versions but 5.13.4 release [22:01:25] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log