[00:48:32] (PS4) Ejegg: Fix Ingenico hosted checkout variants [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/510622 (https://phabricator.wikimedia.org/T222290) [03:18:25] Fundraising Sprint It Came From Out of Scope, Fundraising Sprint James Bond: Licensed to Share, Fundraising Sprint Navel Warfare, Fundraising Sprint Outie Inverter, and 7 others: Import email-only contacts from 'remind me later' links into CiviCRM - https://phabricator.wikimedia.org/T160949 (Eilee... [03:56:05] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Performance-Team (Radar): Reduce module registration overhead from CentralNotice - https://phabricator.wikimedia.org/T221805 (AndyRussG) [04:04:04] (CR) AndyRussG: "Hi! Thanks so much for working on this!!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/508720 (owner: Vedmaka Wakalaka) [04:06:25] Fundraising Sprint It Came From Out of Scope, Fundraising Sprint James Bond: Licensed to Share, Fundraising-Backlog: review live banner preview code - https://phabricator.wikimedia.org/T222658 (AndyRussG) Here's the comment I just added to the [[ https://gerrit.wikimedia.org/r/#/c/mediawiki/extension... [07:32:08] (PS1) Eileen: Apply drupal formatting to wmf_reports.modul [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/511636 [15:48:08] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Performance-Team (Radar): CentralNotice: Remove bannerController RL modules - https://phabricator.wikimedia.org/T224034 (AndyRussG) [16:21:06] (PS1) Ejegg: Add retry link on opt-in error [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/511748 (https://phabricator.wikimedia.org/T218240) [16:21:37] fr-tech ok, that's the second opt-in patch ready for review ^^^ [16:21:46] the first does client-side validation [16:21:57] and the second adds a retry link if there's a failure [16:22:13] ah, lemme indicate how to test it [16:25:36] oh, and rebase it on top of that other relevant patch [16:26:15] (PS2) Ejegg: Add retry link on opt-in error [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/511748 (https://phabricator.wikimedia.org/T218240) [16:26:23] there we go [16:29:33] (CR) Ejegg: [C: +2] Apply drupal formatting to wmf_reports.modul [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/511636 (owner: Eileen) [16:30:47] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: fix or remove freegeoipLookup module - https://phabricator.wikimedia.org/T224038 (AndyRussG) [16:34:10] (Merged) jenkins-bot: Apply drupal formatting to wmf_reports.modul [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/511636 (owner: Eileen) [16:34:20] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: fix or remove freegeoipLookup module - https://phabricator.wikimedia.org/T224038 (AndyRussG) [16:36:04] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: fix freegeoipLookup module and maybe integrate into other modules, or just remove it - https://phabricator.wikimedia.org/T224038 (AndyRussG) [16:47:27] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Performance-Team (Radar): Reduce module registration overhead from CentralNotice - https://phabricator.wikimedia.org/T221805 (AndyRussG) Of these modules, the following 7 modules are only used in the administration UI interface on Meta: - `e... [17:17:42] Fundraising-Backlog, Fr-CiviCRM-dedupe-FY2017/18: Civi dedupe: queries yielding http 500 errors or blank screens - https://phabricator.wikimedia.org/T222902 (MBeat33) Open→Resolved a:MBeat33 Janell confirmed that this has cleared up, and I'm no longer able to replicate. I am assuming this was... [17:48:52] Fundraising-Backlog, fundraising-tech-ops: Enable Content Security Policy on donate-wiki - https://phabricator.wikimedia.org/T223658 (Jgreen) [17:49:22] Fundraising-Backlog, fundraising-tech-ops: Enable Content Security Policy on donate-wiki - https://phabricator.wikimedia.org/T223658 (Jgreen) >>! In T223658#5198675, @DStrine wrote: > @Jgreen This look identical to the ticket referenced. can you give more info? You're right--I forgot to change the title... [17:55:05] fundraising-tech-ops: upgrade fundraising queue servers from Debian Jessie - https://phabricator.wikimedia.org/T221008 (Jgreen) [17:55:07] Fundraising-Backlog, fundraising-tech-ops: Redis queues should use a key prefix - https://phabricator.wikimedia.org/T216633 (Jgreen) [17:56:55] Fundraising-Backlog, fundraising-tech-ops: Redis queues should use a key prefix - https://phabricator.wikimedia.org/T216633 (Jgreen) I linked this to T221008 because we're talking about making this change at the same time as we upgrade the queue servers and redis, since we'll need downtime and empty queu... [18:05:17] (CR) XenoRyet: [C: +1] "Looks good. My only question is do we want to put some sort of error text in, or is the highlight all we were looking for here?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/511604 (https://phabricator.wikimedia.org/T218240) (owner: Ejegg) [18:08:48] Fundraising-Backlog, Recurring-Donations, FR-Email: Annual totals receipt thank you email for recurring donors - https://phabricator.wikimedia.org/T195907 (DStrine) [18:09:31] Fundraising-Backlog, fundraising-tech-ops, Recurring-Donations: Redirect old PayPal IPN URL to active listener - https://phabricator.wikimedia.org/T107384 (Jgreen) [18:10:46] Fundraising Sprint It Came From Out of Scope, Fundraising Sprint James Bond: Licensed to Share, MediaWiki-extensions-CentralNotice, Patch-For-Review: Update banner history EventLogging schema - https://phabricator.wikimedia.org/T223183 (AndyRussG) [18:16:06] Fundraising-Backlog, Analytics, Analytics-EventLogging, Analytics-Kanban, and 3 others: Fix EventLogging schemas that use array for items type - https://phabricator.wikimedia.org/T218617 (AndyRussG) @Nuria, @Ottomata, the update to version number for the CentralNoticeBannerHistory schema should h... [18:26:32] Fundraising-Backlog, Analytics, Analytics-EventLogging, Analytics-Kanban, and 3 others: Fix EventLogging schemas that use array for items type - https://phabricator.wikimedia.org/T218617 (Nuria) we can wait, really. it is important but not urgent. [18:27:59] Fundraising-Backlog, Analytics, Analytics-EventLogging, Analytics-Kanban, and 3 others: Fix EventLogging schemas that use array for items type - https://phabricator.wikimedia.org/T218617 (AndyRussG) >>! In T218617#5201986, @Nuria wrote: > we can wait, really. it is important but not urgent. Ok t... [18:40:40] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: contribs search timed out - https://phabricator.wikimedia.org/T208078 (MBeat33) Open→Resolved a:MBeat33 We no longer to keep the VPN on as much, so we're not seeing these related timeouts. [18:42:32] Fundraising-Backlog: RML email source yielding only email addresses - https://phabricator.wikimedia.org/T189612 (MBeat33) Open→Resolved a:MBeat33 Small issue, does not seem to be continuing, so Resolving this task. [18:46:43] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: New Civi credential for Engage: Stacey E - https://phabricator.wikimedia.org/T223940 (LeanneS) Approval granted! [19:35:01] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog, Epic: [Epic] Fundraising kafkatee changes - https://phabricator.wikimedia.org/T183978 (AndyRus... [19:36:28] Fundraising Sprint James Bond: Licensed to Share, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: review status of event logging - https://phabricator.wikimedia.org/T223323 (AndyRussG) See: T183978#5202071 [19:55:32] jgleeson I was going to ping you on a weekly time - do you think start of the week? e.g your Mon am ? [19:59:42] sure [19:59:45] actually [19:59:58] Mon/Tue I start later than usual [20:08:46] jgleeson: ah fair enough so maybe wed [20:09:12] It would be about 8pm my time [20:09:18] of 8.30 [20:25:18] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: New Civi credential for Engage: Stacey E - https://phabricator.wikimedia.org/T223940 (Jgreen) >>! In T223940#5198925, @Eileenmcnaughton wrote: > @LeanneS I think we normally need an email from Lisa authorising I sent Lisa an... [20:36:24] (CR) XenoRyet: [C: +2] "+2 as per discussion in standup that just the highlight is all that's wanted for now." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/511604 (https://phabricator.wikimedia.org/T218240) (owner: Ejegg) [20:36:33] (CR) XenoRyet: [C: +2] Add retry link on opt-in error [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/511748 (https://phabricator.wikimedia.org/T218240) (owner: Ejegg) [20:37:17] (Merged) jenkins-bot: Basic email validation for opt-in [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/511604 (https://phabricator.wikimedia.org/T218240) (owner: Ejegg) [20:37:28] (Merged) jenkins-bot: Add retry link on opt-in error [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/511748 (https://phabricator.wikimedia.org/T218240) (owner: Ejegg) [20:39:06] sure eileen, that's 9am for me I think [20:39:12] or 9:30am [20:39:17] either is good for me [20:39:27] brb! [21:15:20] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/511776 [21:15:35] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/511776 (owner: Ejegg) [21:16:20] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/511776 (owner: Ejegg) [21:18:31] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/511777 [21:19:24] (CR) Ejegg: [C: +2] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/511777 (owner: Ejegg) [21:21:14] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/511777 (owner: Ejegg) [21:27:24] Fundraising Sprint Hansel and grep -l, Fundraising Sprint It Came From Out of Scope, Fundraising-Backlog: iDEAL opt-ins not recording - https://phabricator.wikimedia.org/T221803 (Ladsgroup) [21:28:29] Fundraising Sprint Casino Royale With Cheese, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: Cancel button for recurring donations missing - https://phabricator.wikimedia.org/T215513 (Ladsgroup) [21:29:22] Fundraising Sprint Window dressing is mostly olive oil, Fundraising-Backlog: Send Endowment receipts through regular thank you email system - https://phabricator.wikimedia.org/T211230 (Ladsgroup) [21:30:23] Fundraising Sprint They Live, Fundraising Sprint USB stands for underhanded socket bureaucracy, Fundraising Sprint Vestigial tails shoot from the hip, Fundraising Sprint Window dressing is mostly olive oil, and 2 others: Undo bogus PayPal cancellations - https://phabricator.wikimedia.org/T206343 (... [21:31:03] Fundraising Sprint Naming Sprints Is Not Important, Fundraising Sprint Owls, Fundraising Sprint Pluto is still a planet, Fundraising Sprint Queue is pronounced GJif, and 2 others: Investigate why Ingenico donation did not recur on 6/14 - https://phabricator.wikimedia.org/T199331 (Ladsgroup) [21:33:10] Fundraising Sprint Ivory and eggshell white are the same color, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Rash of errors consuming donations queue - https://phabricator.wikimedia.org/T192977 (Ladsgroup) [21:35:39] !log updated payments-wiki from d5ef5ad067 to fa005a0640 [21:35:42] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:40:28] Fundraising-Backlog: Clicking "Cancel" inside the credit card iframe pushes donors out of the payment page - https://phabricator.wikimedia.org/T224063 (scervantes) [21:40:34] Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising Sprint Hansel and grep -l, Fundraising Sprint It Came From Out of Scope, and 3 others: Create variants for fancy new opt in pages on payments wiki - https://phabricator.wikimedia.org/T218240 (Ejegg) OK @CCogd... [22:05:28] (PS1) Jgleeson: WIP add optional form fields support [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/511785 (https://phabricator.wikimedia.org/T219558) [22:06:51] (PS3) Jgleeson: WIP: add employer field variant [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/507412 (https://phabricator.wikimedia.org/T219558) [22:07:05] Fundraising Sprint It Came From Out of Scope, Fundraising Sprint James Bond: Licensed to Share, MediaWiki-extensions-CentralNotice: Update banner history EventLogging schema - https://phabricator.wikimedia.org/T223183 (Ladsgroup) [22:07:42] ejegg, I made a start on the updates we chatted about but still got some left. I'm gonna jump on that tomorrow [22:07:51] both patches pushed ^ [22:07:52] (CR) jerkins-bot: [V: -1] WIP add optional form fields support [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/511785 (https://phabricator.wikimedia.org/T219558) (owner: Jgleeson) [22:08:47] catch you all tomorrow fr-tech! [22:09:50] (CR) jerkins-bot: [V: -1] WIP: add employer field variant [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/507412 (https://phabricator.wikimedia.org/T219558) (owner: Jgleeson) [22:29:16] (CR) Krinkle: "@Andy Okay, here's an alternate idea:" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/510585 (owner: Krinkle) [22:36:09] (CR) AndyRussG: "@Krinkle, sure, that sounds fine! Just I guess maybe also just include the key that produced the error in the warning?" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/510585 (owner: Krinkle) [22:52:00] Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising Sprint Hansel and grep -l, Fundraising Sprint It Came From Out of Scope, and 3 others: Create variants for fancy new opt in pages on payments wiki - https://phabricator.wikimedia.org/T218240 (CCogdill_WMF) Aw... [22:52:06] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Performance-Team (Radar): Reduce module registration overhead from CentralNotice - https://phabricator.wikimedia.org/T221805 (Krinkle) > [..] the following 7 modules are only used in the administration UI interface on Meta: [..] > > Maybe a fir... [23:15:43] Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising Sprint Hansel and grep -l, Fundraising Sprint It Came From Out of Scope, and 3 others: Create variants for fancy new opt in pages on payments wiki - https://phabricator.wikimedia.org/T218240 (MBeat33) This lo... [23:42:51] Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising Sprint Hansel and grep -l, Fundraising Sprint It Came From Out of Scope, and 3 others: Create variants for fancy new opt in pages on payments wiki - https://phabricator.wikimedia.org/T218240 (Ejegg) Good catc...