[00:47:15] (PS12) Eileen: [do not merge] url generator form wip [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/507540 [00:48:15] (CR) jerkins-bot: [V: -1] [do not merge] url generator form wip [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/507540 (owner: Eileen) [01:35:07] (PS1) Eileen: Revert "Remove another cache bypass" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/511795 [01:36:30] (PS1) Eileen: Drupal Security update [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/511796 [01:38:00] (CR) jerkins-bot: [V: -1] Drupal Security update [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/511796 (owner: Eileen) [01:39:28] (PS1) Eileen: Re-apply WMF patches [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/511797 [01:47:19] (PS1) Eileen: Remove old do not solicit field from wmf_donor [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/511798 [03:11:48] (PS1) Ejegg: Mustache flag to use spaces in helper args [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/511800 (https://phabricator.wikimedia.org/T218240) [13:33:37] Fundraising Sprint Hansel and grep -l, Fundraising Sprint It Came From Out of Scope, Fundraising Sprint James Bond: Licensed to Share, Fundraising-Backlog, Fr-CiviCRM-dedupe-FY2017/18: Civi dedupe: URL generator for dedupe searches - https://phabricator.wikimedia.org/T217909 (Maintenance_bot) [13:33:54] Fundraising Sprint Hansel and grep -l, Fundraising Sprint It Came From Out of Scope, Fundraising Sprint James Bond: Licensed to Share, Fundraising-Backlog, Fr-CiviCRM-dedupe-FY2017/18: Civi dedupe: merge screen upgrades - https://phabricator.wikimedia.org/T217903 (Maintenance_bot) [13:39:03] Fundraising Sprint It Came From Out of Scope, Fundraising Sprint James Bond: Licensed to Share, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Technical-Debt (Deprecation): Deprecation warning from CentralNotice: OutputPage::parseInline - https://phabricator.wikimedia.org/T213978 (Ma... [13:49:24] Fundraising Sprint They Live, Fundraising Sprint USB stands for underhanded socket bureaucracy, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Validate CentralNotice translatable message names/fix errors on messages with spaces - https://phabricator.wikimedia.org/T205478 (Maintenance_bot) [13:50:58] Fundraising Sprint James Bond: Licensed to Share, Fundraising-Analysis, Fundraising-Backlog, Analytics, MediaWiki-extensions-CentralNotice: CentralNoticeImpression occasionaly fails validation on device enum field - https://phabricator.wikimedia.org/T203597 (Ottomata) Thank you! [13:52:24] Fundraising-Backlog, Analytics, Analytics-EventLogging, Analytics-Kanban, and 3 others: Fix EventLogging schemas that use array for items type - https://phabricator.wikimedia.org/T218617 (Ottomata) Andy thank you! For this task, the blocker really was just editing the schema on meta.wikimedia.or... [14:37:29] tzag fr-tech [14:37:50] good afternoon jgleeson_ [14:37:55] :) [14:38:00] hows it goin mepps [14:38:17] not too bad jgleeson [14:38:20] how are you? [14:38:31] i need to return to AndyRussG's code review this morning [14:38:39] but haven't gotten my head in yet [14:39:02] I'm good thanks. I've found a reasonably priced coworking space that I'm working out of today. looks like it could be a winner, they also have free good coffee! [14:39:11] that's great jgleeson_! [14:39:43] yup, I'd all but given up [14:39:56] this place is £10 for 5 hours or £15 for the day [14:40:18] which is still expensive but cheaper than the others I've tried [14:40:40] I figure I drink about £6's worth of coffee [14:41:03] and for the improved seating with lumbar support, £4/£9 isn't a bad price [14:42:01] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, phan-taint-check-plugin: Add phan-taint-check-plugin to DonationInterface extension - https://phabricator.wikimedia.org/T202384 (Maintenance_bot) [14:44:57] is there a monthly rate jgleeson_? [14:46:10] Wikimedia-Fundraising: Localise most important DonationInterface messages to Latin American Spanish - https://phabricator.wikimedia.org/T199682 (Maintenance_bot) [14:46:48] mepps, yeah, they do a £50 a month deal where you get 4 full days and a few other bits so I'm gonna sign up to that [14:47:04] one day a week so far, and then up it as I need it [14:48:32] Fundraising Sprint Lactose is unusually tolerant, Fundraising Sprint Matt Damon to head up Space Force, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: donor data export tool for civi - https://phabricator.wikimedia.org/T196511 (Maintenance_bot) [14:51:23] jgleeson_ i'm getting distracted by this article this morning: https://slate.com/technology/2019/05/wikipedia-china-block-censorship-tiananmen-square.html [14:57:13] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Winter Wanderland, Fundraising-Backlog, FR-Amazon, MediaWiki-extensions-DonationInterface: Amazon gateway - crash on getCaptureDetails failiure? - https://phabricator.wikimedia.org/T182735 (Maintenance_bot) [14:58:30] mepps, yeah that's a pretty depressing article [14:59:15] I kinda feel like the state should realise that knowledge in general is above their purview [14:59:41] all states, including my own [15:00:32] mepps, this article distracted me yesterday for similar reasons https://www.thecanary.co/video/2019/05/18/former-ecuadorian-diplomat-on-his-countrys-treatment-of-julian-assange/ [15:01:09] the ecuadorian diplomat interviewed gives a brave and frank assessment of what's happening [15:01:30] my government, and our media, are treating it like a non-event [15:04:45] actually no, they're doing worse. They've tried to distract from the unethical imprisonment of a whistleblower journalist by exaggerating how "uncooperative" he was an "unhygienic" during his stay at the embassy. [15:05:03] and* [15:06:02] Fundraising Sprint It Came From Out of Scope, Fundraising Sprint James Bond: Licensed to Share, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, and 2 others: Viewing Special:CentralNoticeBanners subpage can throw fatal BannerExistenceException - https://phabricator.wikimedia.org/T149240 (... [15:07:12] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Release-Engineering-Team (Long-Lived-Branches), Spike, Wikimedia-Incident: Spike: Plan reforms of the CentralNotice deployment branch - https://phabricator.wikimedia.org/T136904 (Maintenance_bot) [15:18:51] Fundraising-Backlog: Using Civi Mail function in all activity types - https://phabricator.wikimedia.org/T224130 (NNichols) [15:29:46] mepps jgleeson_ ft-tech hi! [15:30:13] hey AndyRussG :) [15:30:16] hows it goin [15:30:36] jgleeson_ eh not toooo bad [15:30:49] got the kiddos off to school ok this morning [15:31:00] :) [15:31:08] I've gotta go and pickup my kiddo shortly [15:31:24] ah cool! how are all of you doing? [15:31:26] fr-tech any news for scrum of scrums? [15:31:31] not from me ejegg ! [15:31:36] hi btw :) [15:31:39] had some trouble prying Sofi away from Fortnite yesterday evening [15:31:46] ejegg: nothing here, thanks! [15:32:40] AndyRussG, Matilda has a cold so she's a little unsettled at the moment but hopefully it will clear up soon. Oscar is doin good, he's picked up over the last few weeks so we're happy about that [15:33:11] summer is making an apperance early around these parts so it cheers everyone up [15:33:19] including me :) [15:34:29] AndyRussG, ah Fortnite, I bet that's tough. I used to live in online games myself during my younger years so i can appreciate how gripping they are [15:35:49] jgleeson_ good to hear the mostly good news, hope Matilda gets better soon! [15:36:00] I still remember my dreams of being a pro-gamer! [15:36:16] Yeah... Sofi basically seems to do no homework and now has been making a fuss at the 45 minutes of reading I ask her and her sister to do [15:36:32] :\ [15:36:35] yesterday she started a new round of Fortnite just after I reminded her and her sister that it was time to go to sleep [15:36:42] and then tried to insist on finishing it [15:37:32] today hopefully I'll be able to have a better talk with her about it [15:37:39] fr-tech has anyone else set up centralnotice_changes_monitor locally? (other than AndyRussG ;) ) [15:38:05] she's also often in quite a bad mood when she comes back from her mom's place, which is not a great sign [15:38:43] mepps hey :) I think ejegg was trying but got stuck on the multi-wiki setup, since he was also doing FR + EventBus roles at once [15:38:51] not me mepps [15:39:24] got the multiwiki running now, just working on the eventbus role [15:39:43] ah cool! [15:39:44] oh shoot, gotta run before my parking expires [15:39:48] back soon! [15:40:28] cstone I think was trying with only the eventbus role? dunno if it finished provisioning over the course of the Hackathon..... [15:40:46] hah yeah let me see where it is I know I got to maybe the second step [15:41:11] so i was trying to create the sql tables (in vagrant) and got ERROR 1071 (42000) at line 2: Specified key was too long; max key length is 767 bytes [15:41:53] cstone ah cool! thx :) [15:42:29] mepps follwoing the first command here? https://www.mediawiki.org/wiki/User:AGreen_(WMF)/Draft:Dev_setup_for_centralnotice_changes_monitor#Database [15:42:39] mariadb -u cn_changes_monitor --password=cn_changes_monitor_pw cn_changes_monitor < sql/create_tables.sql [15:43:40] fr-tech if u do want to go over the changes monitor stuff in tech-talk today, it might be worth it to leave the setup aside for a bit and read over the python code some too... thx much again! [15:44:21] yes AndyRussG [15:45:23] mepps hummm maybe a typo crept into create_tables.sql since I've tried it... Lemme try agian [15:46:19] mepps: hummm works for me [15:47:27] mepps git status shows that your local create_tables.sql has no changes? [15:47:50] yup i've made no changes [15:48:03] really weird [15:49:24] mepps https://stackoverflow.com/questions/1814532/1071-specified-key-was-too-long-max-key-length-is-767-bytes [15:49:37] yeah reading that now [15:50:04] Maybe it's longer than 256 bytes because encoding? [15:50:29] mepps try locally adjusting the length of title down, say to 60 characters? [15:51:00] either that or commenting out the line that says UNIQUE KEY (title) [15:52:02] mepps oh hmmm the second response, maybe just 255 will work [15:52:28] Hi ejegg! I just got a request from DS to change a few confusing words in both of the Spanish language Thank You emails, but since our new version is nearly wrapped up, shall I do a fresh Phab task for it? [15:52:36] I guess Vagrant has the older mariadb as compared to what I have locally [15:52:55] tskaff: I think we can roll it in to the existing one [15:53:11] yeah AndyRussG 255 fixed it [15:53:15] mepps yay! [15:53:16] Cool; adding to the existing task, thanks! [16:01:28] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 10 others: Reduce recurring TY emails - https://phabricator.wikimedia.org/T213209 (TSkaff) Hi @E... [16:16:17] Fundraising Sprint Ivory and eggshell white are the same color, Fundraising Sprint Junebugs prefer July, Fundraising-Backlog, Patch-For-Review: Adapt ingress of CN data into Druid to EventLogging-based impression recording - https://phabricator.wikimedia.org/T186048 (AndyRussG) [16:33:24] mepps: yep one sec! [16:37:36] Fundraising Sprint Ivory and eggshell white are the same color, Fundraising Sprint Junebugs prefer July, Fundraising-Backlog, Patch-For-Review: Adapt ingress of CN data into Druid to EventLogging-based impression recording - https://phabricator.wikimedia.org/T186048 (AndyRussG) Somewhat related t... [16:42:58] Fundraising-Backlog, fundraising-tech-ops, FR-Ingenico: install nginx 1.14.1 from stretch-backports on payments servers, enable TLSv1.3 - https://phabricator.wikimedia.org/T222974 (Jgreen) Open→Declined Our current thinking is that this is unlikely to help with SSL negotiation failures, and w... [16:54:10] Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising Sprint Hansel and grep -l, Fundraising Sprint It Came From Out of Scope, and 3 others: Create variants for fancy new opt in pages on payments wiki - https://phabricator.wikimedia.org/T218240 (CCogdill_WMF) Do... [16:54:19] Fundraising Sprint James Bond: Licensed to Share, Fundraising-Backlog: SPIKE: Unsubscribes import decreasing in size over 2 days - https://phabricator.wikimedia.org/T223935 (DStrine) [16:54:55] Fundraising Sprint James Bond: Licensed to Share, Fundraising-Backlog: SPIKE: Unsubscribes import decreasing in size over 2 days - https://phabricator.wikimedia.org/T223935 (DStrine) adding to sprint. Someone should take some time to look into this. [16:56:56] Fundraising Sprint James Bond: Licensed to Share, Fundraising-Backlog: SPIKE: Unsubscribes import decreasing in size over 2 days - https://phabricator.wikimedia.org/T223935 (CCogdill_WMF) Awesome, thanks! [16:59:46] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-Email: Make unsubscribe work in EmailPreferences, delete Unsub extension - https://phabricator.wikimedia.org/T223330 (DStrine) [17:03:23] AndyRussG, the empanadas look tasty! [17:03:45] back for tech-talk [17:18:52] Fundraising-Backlog: Clicking "Cancel" inside the credit card iframe pushes donors out of the payment page - https://phabricator.wikimedia.org/T224063 (DStrine) Once the iframe has loaded, the user can still choose another card type. We have a cancel button so that the user can have the feeling of ending the... [17:19:21] Fundraising-Backlog, Epic: [Epic] Revoke AWight fundraising privileges - https://phabricator.wikimedia.org/T168421 (DStrine) [17:19:45] Fundraising-Backlog, Epic: [Epic] Revoke AWight fundraising privileges - https://phabricator.wikimedia.org/T168421 (DStrine) [17:23:16] fundraising-tech-ops: encrypt fundraising database client->server communication - https://phabricator.wikimedia.org/T170321 (Jgreen) [17:23:18] Fundraising-Backlog, fundraising-tech-ops, Epic: fundraising database improvements for 2018 - https://phabricator.wikimedia.org/T183138 (Jgreen) [17:35:17] Fundraising-Backlog, fundraising-tech-ops, Epic: fundraising database improvements for 2018 - https://phabricator.wikimedia.org/T183138 (Jgreen) p:High→Normal [17:51:29] (CR) Jforrester: [C: +2] Document dependency on EventLogging [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/508905 (owner: Krinkle) [17:57:02] ejegg|food: low priority process question re: T223660 did you have to look in logs for this info or did you find out through the console? [17:59:53] (Merged) jenkins-bot: Document dependency on EventLogging [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/508905 (owner: Krinkle) [18:03:18] dstrine: just looking at the screenshot in the ticket showed that the donor got redirected [18:03:51] if our initial API call fails (which is usually the case when MBeat can't find anything at the console) the error screenshot would have been on our site [18:08:49] ok thanks [18:39:01] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Availability (MediaWiki-MultiDC), Performance-Team (Radar), Wikimedia-production-error: CentralNotice must not query master on GET request (page views) - https://phabricator.wikimedia.org/T216287 (Krinkle) [18:41:53] fundraising-tech-ops: Build out Debian Buster test instances in virtualbox dev environment - https://phabricator.wikimedia.org/T218261 (Jgreen) build: done & prod-worthy siem: done & prod-worth [19:18:11] (PS1) Umherirrender: Add phan [extensions/LandingCheck] - https://gerrit.wikimedia.org/r/511956 [19:18:28] (CR) Umherirrender: "check experimental" [extensions/LandingCheck] - https://gerrit.wikimedia.org/r/511956 (owner: Umherirrender) [19:18:53] (CR) Jforrester: [C: +2] Remove temporary EventLogging code-duplication [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/508906 (https://phabricator.wikimedia.org/T214709) (owner: Krinkle) [19:26:35] (Merged) jenkins-bot: Remove temporary EventLogging code-duplication [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/508906 (https://phabricator.wikimedia.org/T214709) (owner: Krinkle) [20:44:27] (CR) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/511992 (owner: L10n-bot) [20:45:27] (PS1) Ejegg: Put initial filters where they can stop stuff [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/512044 (https://phabricator.wikimedia.org/T221377) [20:46:28] XenoRyet|food: ^^^ seems to do it, but it would be good to put some tests on that [20:46:37] I'll try writing one for each gateway [21:05:16] Fundraising Sprint It Came From Out of Scope, Fundraising Sprint James Bond: Licensed to Share, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Technical-Debt: Deprecation warning from CentralNotice: OutputPage::parseInline - https://phabricator.wikimedia.org/T213978 (Krinkle) [21:06:32] hmm, that placement in adyen's processDonorReturn looks wrong, but without it we fail other tests [21:06:40] maybe incomplete setup? [21:21:53] (PS2) Ejegg: WIP Put initial filters where they can stop stuff [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/512044 (https://phabricator.wikimedia.org/T221377) [21:24:39] (CR) jerkins-bot: [V: -1] WIP Put initial filters where they can stop stuff [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/512044 (https://phabricator.wikimedia.org/T221377) (owner: Ejegg) [21:29:45] hmm, let's see if I can split out the adyen bits [21:30:49] XenoRyet: what do you think about the general approach in that patch? [21:31:07] I guess I could leave the adyen stuff more or less alone for starters [21:32:11] Let me take a quick look [21:37:57] The main bit definitely looks good. My preference for lighter touches does want me to say leave adyen for alone for now and do it when it becomes necessary. [21:38:13] That said, the changes in adyen adapter look like they make sense. [21:38:43] hmm, let me see if I can get that split out [21:55:13] (PS3) Ejegg: WIP Put initial filters where they can stop stuff [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/512044 (https://phabricator.wikimedia.org/T221377) [21:55:31] ok, XenoRyet, that should get the filters actually filtering for GlobalCollect ^^^ [21:55:39] looking [22:00:50] (CR) XenoRyet: [C: +2] "Yep, that'll do the trick." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/512044 (https://phabricator.wikimedia.org/T221377) (owner: Ejegg) [22:01:12] oh hey, want me to take the 'wip' off the front of that ? :) [22:01:41] I'll add another patch with tests for Ingenico [22:01:46] (PS4) Ejegg: GC: Put initial filters where they can stop stuff [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/512044 (https://phabricator.wikimedia.org/T221377) [22:01:46] then move on to Adyen [22:04:00] Heh, should I suppose. [22:04:30] oh, and one more test for GC [22:05:45] Fundraising-Backlog: IBM segment data in Civi? - https://phabricator.wikimedia.org/T224190 (CCogdill_WMF) [22:07:39] (PS5) Ejegg: GC: Put initial filters where they can stop stuff [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/512044 (https://phabricator.wikimedia.org/T221377) [22:08:41] XenoRyet: ok, that's ready for a look. Will make another patch for each gateway [22:08:52] 10-4 [22:17:06] (PS1) Eileen: API v4 update [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/512057 [22:18:21] (PS1) Ejegg: Ingenico: tests for fail initial filters [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/512059 (https://phabricator.wikimedia.org/T221377) [22:21:31] (CR) XenoRyet: [C: +2] GC: Put initial filters where they can stop stuff [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/512044 (https://phabricator.wikimedia.org/T221377) (owner: Ejegg) [22:22:32] (Merged) jenkins-bot: GC: Put initial filters where they can stop stuff [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/512044 (https://phabricator.wikimedia.org/T221377) (owner: Ejegg) [22:22:45] (CR) XenoRyet: [C: +2] Ingenico: tests for fail initial filters [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/512059 (https://phabricator.wikimedia.org/T221377) (owner: Ejegg) [22:23:19] ejegg, XenoRyet, I've tested out the ingenico iframe/redirect variant code patch and can see the transformer modifying the processor_form value, should I also see any change to the forms? [22:23:48] (Merged) jenkins-bot: Ingenico: tests for fail initial filters [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/512059 (https://phabricator.wikimedia.org/T221377) (owner: Ejegg) [22:24:15] jgleeson the new form should look just like the old form, but without needing the tricks to fit. [22:24:46] So if you've clicked into a card entry field and hit tab a bunch of times, the new form shouldn't scroll out of sight [22:24:58] the main thing I was looking for versus when I reviewed was that the iframe variant didn't dump you on the payment selection form. [22:25:04] the old field had some links way down below the visible bit, set to white on white [22:25:18] got it [22:25:21] so hitting tab would focus on those and scroll the card entry bits out of sight [22:41:56] (CR) Ejegg: [C: +2] Revert "Remove another cache bypass" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/511795 (owner: Eileen) [22:42:06] (CR) Ejegg: [C: +2] API v4 update [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/512057 (owner: Eileen) [22:46:30] (Merged) jenkins-bot: Revert "Remove another cache bypass" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/511795 (owner: Eileen) [22:47:25] (Merged) jenkins-bot: API v4 update [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/512057 (owner: Eileen) [23:04:34] (CR) Jgleeson: [C: +1] "This worked for me. Although to get the tests passing, I had to set the wgIngenicoGatewayHostedFormVariants values to 100. Should the test" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/510622 (https://phabricator.wikimedia.org/T222290) (owner: Ejegg) [23:11:23] (PS1) Eileen: CiviCRM submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/512068 [23:16:16] (CR) Eileen: [C: +2] CiviCRM submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/512068 (owner: Eileen) [23:18:43] (CR) Ejegg: "The test are assuming the defaults, but I guess it would be good to explicitly set them!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/510622 (https://phabricator.wikimedia.org/T222290) (owner: Ejegg) [23:21:34] (Merged) jenkins-bot: CiviCRM submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/512068 (owner: Eileen) [23:23:11] (PS5) Ejegg: Fix Ingenico hosted checkout variants [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/510622 (https://phabricator.wikimedia.org/T222290) [23:25:34] (CR) jerkins-bot: [V: -1] Fix Ingenico hosted checkout variants [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/510622 (https://phabricator.wikimedia.org/T222290) (owner: Ejegg) [23:27:16] oops, hmm [23:29:04] (CR) Ejegg: [C: +2] Re-apply WMF patches [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/511797 (owner: Eileen) [23:29:26] XenoRyet: ok, ingenico connect payment is still good locally, trying old gc [23:29:59] Cool. I did run Ingenico Connect end to end locally, but another test never hurts. [23:33:09] ejegg: there is another one in that chain that needs +2 [23:33:14] also this one is trivial https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/511798/ [23:37:01] (PS2) Ejegg: Remove old do not solicit field from wmf_donor [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/511798 (owner: Eileen) [23:37:12] (CR) Ejegg: [C: +2] Remove old do not solicit field from wmf_donor [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/511798 (owner: Eileen) [23:42:21] (Merged) jenkins-bot: Remove old do not solicit field from wmf_donor [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/511798 (owner: Eileen) [23:43:28] thanks - just need this one +2 & I will deploy https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/drupal/+/511796/ [23:46:18] (CR) Ejegg: [C: +2] Drupal Security update [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/511796 (owner: Eileen) [23:46:26] yay [23:46:31] thanks eileen! [23:46:45] good to get them out - all minor but still [23:47:40] (CR) jerkins-bot: [V: -1] Drupal Security update [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/511796 (owner: Eileen) [23:47:42] (CR) jerkins-bot: [V: -1] Re-apply WMF patches [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/511797 (owner: Eileen) [23:50:49] dang, can't seem to get on the VPN to test with Globalcollect [23:51:11] ah, wrong yubikey :) [23:51:18] ok, testing GC now [23:55:04] shoot, am i using the wrong test creds? [23:56:26] (PS1) Eileen: Drupal submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/512072 [23:56:46] (CR) Eileen: [C: +2] Drupal submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/512072 (owner: Eileen) [23:57:05] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/511797 (owner: Eileen) [23:57:43] (CR) Eileen: [V: +2] Drupal Security update [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/511796 (owner: Eileen) [23:57:55] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/511797 (owner: Eileen)