[01:48:23] (PS1) Cstone: Update regex for elseifFirstnameAndLastname to handle more whitespace and tag combinations. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/512308 [08:15:13] (CR) Hashar: [C: +2] Add phan [extensions/LandingCheck] - https://gerrit.wikimedia.org/r/511956 (owner: Umherirrender) [08:20:07] (Merged) jenkins-bot: Add phan [extensions/LandingCheck] - https://gerrit.wikimedia.org/r/511956 (owner: Umherirrender) [11:50:03] (PS1) Jgleeson: WIP migration from bower to yarn for package management [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/512354 [11:52:05] (CR) jerkins-bot: [V: -1] WIP migration from bower to yarn for package management [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/512354 (owner: Jgleeson) [12:41:43] (CR) Hashar: "recheck" [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/511109 (owner: Umherirrender) [13:03:37] (CR) Hashar: [C: +1] "The string literal is a limitation of php-ast. Well spotted." [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/511109 (owner: Umherirrender) [13:48:40] (CR) Vedmaka Wakalaka: "> Patch Set 8:" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/508720 (owner: Vedmaka Wakalaka) [16:01:42] (PS7) Jgleeson: WIP add optional form fields support [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/511785 (https://phabricator.wikimedia.org/T219558) [17:16:05] (CR) Ejegg: [C: +2] "Looks good! Tried with a few languages locally and all seemed to be in order." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/512308 (owner: Cstone) [17:20:34] (Merged) jenkins-bot: Update regex for elseifFirstnameAndLastname to handle more whitespace and tag combinations. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/512308 (owner: Cstone) [18:20:41] (PS3) Cstone: Update translated thank you content and subject for the 2018-10-01 thank you email. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510220 (https://phabricator.wikimedia.org/T213209) [18:54:44] (PS2) Krinkle: ext.centralNotice.kvStore: Move to its own directory [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/510584 (https://phabricator.wikimedia.org/T193826) [18:54:48] (PS6) Krinkle: ext.centralNotice.startUp: Fix circular dependency via kvStore [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/510585 [19:09:08] cstone: heh, just noticed that the Japanese version starts with 'Hi' - is that commonly used ? [19:10:27] the linebreaks are looking fine in the text-only view of all the ones I've checked so far [19:20:41] hah I saw that in the japanese too, the old one had name+sama but I thought maybe it was a weird friendly translation? [19:20:47] random english is used [19:21:19] oh hmm, if I look at the source page it says '95% translated' [19:21:47] tskaff: looks like the very first sentence of the JA translation is left in English [19:21:56] https://meta.wikimedia.org/wiki/Fundraising/Translation/Thank_you_email_2018-10-01/ja [19:21:56] (PS7) Krinkle: ext.centralNotice.startUp: Fix circular dependency via kvStore [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/510585 [19:22:21] but I bet you can just copy the 'Hi' translation from the previous version [19:22:24] ahh i see it wasn't even translated at all then [19:23:01] Gah I forgot to update the subject line for Japanese--sorry about that; it's a new process for us. Can I do now? [19:23:11] sure, go for it [19:23:28] oh, the 'Hi $givenname' bit is also untranslated [19:25:00] Yeah that doesn't work in Japanese. Can we leave it blank? [19:26:44] Hmm it looks like there was a subject line published in Japanese--I updated it regardless and published but lmk if you need any further help on it! [19:30:50] tskaff: the previous TY letter had '$givenname 様' in there. cstone knows some Japanese - cstone, that last version was OK, right? [19:31:38] yeah thats the kanji for sama so like very polite way of addressing someone [19:34:08] So $givenname uses a person's first name and or translators told us we can't use that in Japanese as the appropriate greeting would need last name, so something like [lastname]さま ... [19:34:49] tskaff ah, in that case you can use {% last_name %} [19:35:12] Ah I don't think we knew this was an option! [19:35:51] (side note) tokens with {% %} are what ends up in the final massaged templates that civi stores [19:36:11] ooops [19:36:22] sorry, I mean {{ last_name }} [19:36:26] tskaff: ^^ [19:37:11] {% %} are indeed in the final massaged templates, but the percent-sign ones are for logic like the RecurringRestarted [19:37:42] {{ }} are the tokens in the final massaged template [19:41:31] Ok so I can enter {{ last_name }} into the extension? [19:41:36] yep yep [19:41:41] Sweet [19:42:08] at least I hope so! [19:42:33] ... or will wikitext parsing mess that up? [19:43:06] https://meta.wikimedia.org/wiki/Fundraising/Translation/Thank_you_email_2018-10-01/ja [19:43:15] I see a red Template:Last name [19:43:45] fwiw I saw a [family name] we'd used in the past; is this the same? [19:44:53] looks like we have logic for replacing both [last name] and [family name] to {{last name}} [19:45:06] sorry {{last_name}} [19:47:05] I tried {{last_name}} and get that red "Template:Last name" display but I tried [family name] and don't see anything concerning on my end. That said, I'm really not sure what it is! [19:50:02] tskaff: I just tested pulling down the one with [family name] and it correctly switched it to {{ last_name }}さま [19:51:46] ooh, nice one cstone [19:52:39] we should document these bits someplace :P [19:53:19] maybe at https://meta.wikimedia.org/wiki/Fundraising/Translation [19:55:20] Hrm ok so I tried {{ last_name }} and am still getting that red display. Is it something on my end? [19:55:40] tskaff cstone was saying [last name] or [family name] should work [19:55:53] Oh whoops [19:56:02] sorry i gave bad info! [19:56:21] So does it matter which one? I'd prefer [last name] if that's cool [19:56:27] either work [19:57:05] Looks good! [20:06:15] getting restless and it's sunny out. gonna bike for a little bit. cstone I'll keep an eye out for an update and will review it soon as I'm back indoors! [20:07:13] Fundraising-Backlog, Fr-CiviCRM-dedupe-FY2017/18: Civi: Upgrade permissions level for DS agent - https://phabricator.wikimedia.org/T224314 (MBeat33) [20:14:33] (PS1) Krinkle: ext.centralNotice.display: Convert to using packageFiles [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/512429 [20:14:35] (PS1) Krinkle: Remove 'wgCentralNoticeCategoriesUsingLegacy' from page view HTML [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/512430 (https://phabricator.wikimedia.org/T219342) [20:15:13] (PS2) Krinkle: ext.centralNotice.display: Convert to using packageFiles [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/512429 [20:15:18] (PS2) Krinkle: Remove 'wgCentralNoticeCategoriesUsingLegacy' from page view HTML [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/512430 (https://phabricator.wikimedia.org/T219342) [20:15:21] (CR) jerkins-bot: [V: -1] Remove 'wgCentralNoticeCategoriesUsingLegacy' from page view HTML [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/512430 (https://phabricator.wikimedia.org/T219342) (owner: Krinkle) [20:15:23] (CR) jerkins-bot: [V: -1] Remove 'wgCentralNoticeCategoriesUsingLegacy' from page view HTML [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/512430 (https://phabricator.wikimedia.org/T219342) (owner: Krinkle) [20:17:18] (CR) jerkins-bot: [V: -1] Remove 'wgCentralNoticeCategoriesUsingLegacy' from page view HTML [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/512430 (https://phabricator.wikimedia.org/T219342) (owner: Krinkle) [20:17:45] (CR) jerkins-bot: [V: -1] ext.centralNotice.display: Convert to using packageFiles [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/512429 (owner: Krinkle) [20:18:00] (CR) jerkins-bot: [V: -1] Remove 'wgCentralNoticeCategoriesUsingLegacy' from page view HTML [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/512430 (https://phabricator.wikimedia.org/T219342) (owner: Krinkle) [20:41:09] (PS4) Cstone: Update translated thank you content and subject for the 2018-10-01 thank you email. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510220 (https://phabricator.wikimedia.org/T213209) [20:51:15] hello again, from the beautiful biblioteca virgilio barco [20:58:39] i just googled it ejegg looks really cool [21:12:48] Fundraising Sprint James Bond: Licensed to Share, Fundraising-Backlog: SPIKE: Unsubscribes import decreasing in size over 2 days - https://phabricator.wikimedia.org/T223935 (Ejegg) So, we only keep on disk the last two files uploaded, and today's Unsubscribes file is bigger than yesterday's. Checking to... [21:29:47] cstone so far it's all looking good [21:30:25] cstone were you able to use the thank you test page locally to blast your local user with a copy of each language's letter? [21:31:31] hmm how would I do that? [21:32:05] go to /admin/config/thank_you/test on your civicrm url [21:32:19] (no /civicrm at the start, this is a drupal module thing) [21:34:41] ok i see the test then where do they end up? [21:35:02] it'll send emails to whatever address you put in for the recipient [21:35:10] not sure how your vagrant box is configured [21:35:16] ok cool [21:35:18] but it might only do local delivery [21:35:24] like to vagrant@localhost [21:36:02] then you might use a command-line mail client like alpine [21:38:38] ah yeah looks like vagrant logs them into a mail folder [21:38:58] ok, cool. [21:39:29] do the bits in that folder have the weird escaping like for apostrophes [21:39:32] ? [21:39:56] yeah [21:40:24] freaks out on Japanese too but I can see the

tags in the right place [21:43:58] heh, well that's something I guess [21:46:03] hmm, I forget, are we letting staging send emails anywhere? If so, that would be a nice way to see them in gmail. [21:46:18] cstone do you know how to get a random unmerged commit up on staging? [21:47:54] i do not [21:48:48] cstone so you just need to ssh into frdev1001 [21:49:00] and get into the civi dir in /srv [21:49:40] then you can just use git commands like the ones in the dropdown in the gerrit UI [21:50:02] you will probably have to use the 'anonymous https' version of the git command [21:50:20] since your private key isn't up on that box [21:50:51] ok [21:53:18] would i make a new branch with that then? [21:53:50] cstone no need [21:54:13] just getting the files to match the ones in that patch is enough [21:54:19] ok [21:55:22] then i could do the same email send from frdrev civi? [21:55:27] dev* [21:56:21] yeah, that's the thought. but i'm not sure if we even let frdev send email. cwd is that machine wired up to do that? I can imagine it might not be, so we don't spam people [21:56:29] it totally worked [21:56:39] well when i just tried the test to myself [21:57:19] oh, nice! [21:58:01] McTestersenさま [21:58:26] hehe [21:59:23] english and japanese look good [22:01:56] spanish (both versions) look fine too [22:16:14] i tested the others and en and ja with recurring text. With the recurring gmail is coloring some text purple but I'm not sure if that is just some gmail feature [22:17:54] yeah i think thats just gmail