[00:15:23] (CR) Ejegg: [C: +2] "These look good to me!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510220 (https://phabricator.wikimedia.org/T213209) (owner: Cstone) [00:19:48] (Merged) jenkins-bot: Update translated thank you content and subject for the 2018-10-01 thank you email. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510220 (https://phabricator.wikimedia.org/T213209) (owner: Cstone) [01:17:00] (PS1) Jforrester: Replace references to deprecated Squid config with modern CDN ones [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/512458 [01:18:25] (CR) jerkins-bot: [V: -1] Replace references to deprecated Squid config with modern CDN ones [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/512458 (owner: Jforrester) [01:27:46] (PS2) Jforrester: Replace references to deprecated Squid config with modern CDN ones [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/512458 [01:31:02] (CR) jerkins-bot: [V: -1] Replace references to deprecated Squid config with modern CDN ones [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/512458 (owner: Jforrester) [19:05:46] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog, Epic: [Epic] Fundraising kafkatee changes - https://phabricator.wikimedia.org/T183978 (AndyRus... [21:16:21] (PS9) Vedmaka Wakalaka: Banner in-page preview mode [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/508720 [21:25:58] (CR) Vedmaka Wakalaka: "> This feature is currently not working for me. It seems that this is because injectBannerHTML() is called before the jQuery ready event, " [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/508720 (owner: Vedmaka Wakalaka) [22:11:04] (PS3) Krinkle: ext.centralNotice.display: Convert to using packageFiles [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/512429 [22:11:11] (PS3) Krinkle: Remove 'wgCentralNoticeCategoriesUsingLegacy' from page view HTML [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/512430 (https://phabricator.wikimedia.org/T219342) [22:12:40] (CR) Krinkle: [C: -1] Use ?? to define default values for null property (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/512215 (owner: Umherirrender) [22:12:58] (CR) Krinkle: [C: -1] "Depending on how long it has been, it might not need it anymore." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/512215 (owner: Umherirrender) [22:13:03] (CR) jerkins-bot: [V: -1] Remove 'wgCentralNoticeCategoriesUsingLegacy' from page view HTML [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/512430 (https://phabricator.wikimedia.org/T219342) (owner: Krinkle) [22:13:58] (CR) jerkins-bot: [V: -1] Remove 'wgCentralNoticeCategoriesUsingLegacy' from page view HTML [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/512430 (https://phabricator.wikimedia.org/T219342) (owner: Krinkle) [22:20:15] (PS4) Krinkle: Remove 'wgCentralNoticeCategoriesUsingLegacy' from page view HTML [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/512430 (https://phabricator.wikimedia.org/T219342)