[00:48:25] eileen: yep [01:02:21] ok cool [07:00:09] (PS3) Amire80: Split apihelp messages to a separate file [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/509575 (https://phabricator.wikimedia.org/T189982) [19:26:21] (CR) Krinkle: [C: -1] Use ?? to define default values for null property (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/512215 (owner: Umherirrender) [19:41:33] (CR) AndyRussG: "Looks great! Smoke tests fine, too..." (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/510585 (owner: Krinkle) [20:02:51] (PS1) AndyRussG: Update Schema:CentralNoticeImpression version [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/512759 (https://phabricator.wikimedia.org/T203597) [20:07:40] fr-tech hey, anyone about for a quick +2? https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CentralNotice/+/512759/ [20:08:18] AndyRussG: I can get it for you [20:08:49] (CR) Cstone: [C: +2] Update Schema:CentralNoticeImpression version [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/512759 (https://phabricator.wikimedia.org/T203597) (owner: AndyRussG) [20:16:44] (Merged) jenkins-bot: Update Schema:CentralNoticeImpression version [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/512759 (https://phabricator.wikimedia.org/T203597) (owner: AndyRussG) [20:18:13] cstone_: woohoo thanks much! :) [20:20:21] (CR) AndyRussG: "Thanks @Cstone!!!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/512759 (https://phabricator.wikimedia.org/T203597) (owner: AndyRussG) [20:22:28] np AndyRussG [20:24:16] (CR) jenkins-bot: Update Schema:CentralNoticeImpression version [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/512759 (https://phabricator.wikimedia.org/T203597) (owner: AndyRussG) [20:26:01] :) [20:26:34] Fundraising Sprint James Bond: Licensed to Share: CentralNotice: Deploy accumulated changes (2019-05-27) - https://phabricator.wikimedia.org/T224444 (AndyRussG) [20:50:28] Fundraising Sprint Lactose is unusually tolerant, Fundraising Sprint Matt Damon to head up Space Force, Fundraising Sprint Naming Sprints Is Not Important, Fundraising Sprint Owls, and 8 others: Write a specification for mapping banner/landing page impressi... - https://phabricator.wikimedia.org/T196563 [20:58:15] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Performance-Team (Radar): Reduce module registration overhead from CentralNotice - https://phabricator.wikimedia.org/T221805 (AndyRussG) > another issue here is the modernization of CN RL modules, as regards file structure and the way the JS AP... [21:04:09] Fundraising Sprint It Came From Out of Scope, Fundraising Sprint James Bond: Licensed to Share, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Review incoming patches 2019-05 - https://phabricator.wikimedia.org/T222463 (AndyRussG) [21:10:49] Fundraising Sprint James Bond: Licensed to Share, Fundraising-Analysis, Fundraising-Backlog, Analytics, MediaWiki-extensions-CentralNotice: CentralNoticeImpression occasionaly fails validation on device enum field - https://phabricator.wikimedia.org/T203597 (Maintenance_bot) [23:34:28] (PS1) Eileen: Fix failure of 'find duplicates for these contacts' [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/512786 [23:35:04] (PS2) Eileen: Fix failure of 'find duplicates for these contacts' [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/512786