[02:45:41] (PS2) Eileen: Dedupe url generator & batch mark excluded. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/512996 (https://phabricator.wikimedia.org/T217909) [02:46:38] (CR) jerkins-bot: [V: -1] Dedupe url generator & batch mark excluded. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/512996 (https://phabricator.wikimedia.org/T217909) (owner: Eileen) [02:47:19] Fundraising Sprint King Kong vs. Mozilla, Fundraising-Backlog, Fr-CiviCRM-dedupe-FY2017/18: Civi: Upgrade permissions level for DS agent - https://phabricator.wikimedia.org/T224314 (Eileenmcnaughton) a:Eileenmcnaughton [02:49:25] (PS1) Eileen: Limit parameter not passed to criteria query [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/513024 (https://phabricator.wikimedia.org/T217909) [02:54:40] (PS3) Eileen: Dedupe url generator & batch mark excluded. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/512996 (https://phabricator.wikimedia.org/T217909) [02:56:01] (CR) jerkins-bot: [V: -1] Dedupe url generator & batch mark excluded. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/512996 (https://phabricator.wikimedia.org/T217909) (owner: Eileen) [04:21:34] (PS4) Eileen: Dedupe url generator & batch mark excluded. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/512996 (https://phabricator.wikimedia.org/T217909) [04:24:47] (CR) jerkins-bot: [V: -1] Dedupe url generator & batch mark excluded. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/512996 (https://phabricator.wikimedia.org/T217909) (owner: Eileen) [04:30:37] (PS5) Eileen: Dedupe url generator & batch mark excluded. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/512996 (https://phabricator.wikimedia.org/T217909) [04:31:21] (CR) jerkins-bot: [V: -1] Dedupe url generator & batch mark excluded. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/512996 (https://phabricator.wikimedia.org/T217909) (owner: Eileen) [10:08:35] welcome to CET/~GMT awight :) [10:09:04] actually I guess it's CEST [12:31:57] (PS9) Jgleeson: add optional form fields behaviour [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/511785 (https://phabricator.wikimedia.org/T219558) [12:31:58] (PS11) Jgleeson: add employer field variant [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/507412 (https://phabricator.wikimedia.org/T219558) [12:32:35] (CR) Jgleeson: add optional form fields behaviour (3 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/511785 (https://phabricator.wikimedia.org/T219558) (owner: Jgleeson) [15:20:19] hi fr-tech, any news for scrum of scrums? [15:25:01] ejegg: maybe ask if anyone has any ideas about the issue Seddon came across yesterday? [15:25:31] ejegg: in a few minutes I'll send you the task link, k? [15:26:28] sure thing AndyRussG [15:28:23] Fundraising-Backlog, Fr-backlog-cleanup-Q3_2017-18, MediaWiki-extensions-CentralNotice: CentralNotice: Use only one cookie library - https://phabricator.wikimedia.org/T133434 (Krinkle) Note that `mediawiki.cookie` uses `jquery.cookie` underneath. So this won't reduce JS payload. Basically, if you ne... [15:31:09] Fundraising-Backlog, Fr-CentralNotice-Translation-Bugs, MediaWiki-extensions-CentralNotice: CentralNotice: Saving banners with translatable messages may time out - https://phabricator.wikimedia.org/T224598 (AndyRussG) [15:31:17] ejegg: https://phabricator.wikimedia.org/T224598 [15:31:51] thx! [15:32:02] AndyRussG are we meeting? [15:48:38] Fundraising-Backlog, Fr-CentralNotice-Translation-Bugs, MediaWiki-extensions-CentralNotice: CentralNotice: Saving banners with translatable messages may time out - https://phabricator.wikimedia.org/T224598 (Ejegg) Potentially related commit (deployed a couple weeks before first instance of this bug,... [16:15:07] Fundraising Sprint Hansel and grep -l, Fundraising Sprint It Came From Out of Scope, Fundraising Sprint James Bond: Licensed to Share, Fundraising Sprint King Kong vs. Mozilla, Fundraising-Backlog: Opt-in numbers in IBM not as expected - https://phabricator.wikimedia.org/T219401 (XenoRyet) a:... [16:26:56] Fundraising Sprint It Came From Out of Scope, Fundraising Sprint James Bond: Licensed to Share, Fundraising Sprint King Kong vs. Mozilla, Fundraising-Backlog: review live banner preview code - https://phabricator.wikimedia.org/T222658 (AndyRussG) More stuff also commented in Gerrit: >> make in... [16:51:50] (CR) Ejegg: [C: +2] "Looks great! One nitpick, but I'll submit a follow-on patch for it." (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/511785 (https://phabricator.wikimedia.org/T219558) (owner: Jgleeson) [16:53:37] (CR) Ejegg: [C: +2] "Looks good!" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/507412 (https://phabricator.wikimedia.org/T219558) (owner: Jgleeson) [16:55:31] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/513160 [16:55:34] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/513160 (owner: Ejegg) [16:56:34] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/513163 [17:00:26] (CR) jerkins-bot: [V: -1] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/513163 (owner: Ejegg) [17:22:28] (Merged) jenkins-bot: add optional form fields behaviour [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/511785 (https://phabricator.wikimedia.org/T219558) (owner: Jgleeson) [17:24:36] (Merged) jenkins-bot: add employer field variant [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/507412 (https://phabricator.wikimedia.org/T219558) (owner: Jgleeson) [17:24:38] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/513160 (owner: Ejegg) [17:25:06] (CR) Ejegg: [C: +2] "recheck" [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/513163 (owner: Ejegg) [17:30:09] PROBLEM - check_impression_logs on alnitak is CRITICAL: CRITICAL landingpage-impressions.+.json.log rotated 240 min ago [critical = 240] [17:30:32] hrmph [17:30:56] i guess we have an especially small amount of banner impressions getting impressed? [17:31:58] izzat so? [17:32:46] (CR) Ejegg: [C: +2] "Oops, just noticed a regression in adyen & astropay related to their overriding getRequiredFields. They'll now need to override getFormFie" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/511785 (https://phabricator.wikimedia.org/T219558) (owner: Jgleeson) [17:33:39] usually that thing not rotating means there's nothing to rotate [17:34:26] Fundraising-Backlog, Continuous-Integration-Config: Run wikimedia/fundraising/crm CI jobs on PHP7x, not PHP5x - https://phabricator.wikimedia.org/T223348 (hashar) That is blocked on migrating the Jenkins job toward a Docker container (T210287). I haven't had the opportunity to jump on that horse yet unfo... [17:35:09] PROBLEM - check_impression_logs on alnitak is CRITICAL: CRITICAL landingpage-impressions.+.json.log rotated 245 min ago [critical = 240] [17:39:02] Wikimedia-Fundraising-CiviCRM, Continuous-Integration-Infrastructure (Slipway): Migrate wikimedia-fundraising-civicrm to a Docker container - https://phabricator.wikimedia.org/T210287 (hashar) The job is defined in integration/config.git in `jjb/wm-fundraising.yaml`. It got written by/with @awight and @... [17:40:09] PROBLEM - check_impression_logs on alnitak is CRITICAL: CRITICAL landingpage-impressions.+.json.log rotated 250 min ago [critical = 240] [17:42:38] ACKNOWLEDGEMENT - check_impression_logs on alnitak is CRITICAL: CRITICAL landingpage-impressions.+.json.log rotated 250 min ago [critical = 240] Jeff_Green known [17:48:33] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/513163 (owner: Ejegg) [17:55:47] Fundraising-Backlog, Fr-CentralNotice-Translation-Bugs, MediaWiki-extensions-CentralNotice: CentralNotice: Saving banners with translatable messages may time out - https://phabricator.wikimedia.org/T224598 (Nikerabbit) It looks like MessageIndexRebuildJob is being run in-request, also rebuilding cach... [18:35:43] (PS1) Ejegg: Tiny fixes for optional field behavior [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/513183 (https://phabricator.wikimedia.org/T219558) [18:45:51] (PS1) Ejegg: Move requiredFields overrides to config [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/513184 (https://phabricator.wikimedia.org/T219558) [18:46:10] fr-tech if we can merge those two ^^^^ we should be able to deploy the employer field thing [18:52:25] (PS2) Umherirrender: Use ?? to define default values for null property [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/512215 [18:52:32] (CR) Umherirrender: Use ?? to define default values for null property (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/512215 (owner: Umherirrender) [18:58:54] (CR) Thiemo Kreuz (WMDE): [C: +2] Use ?? to define default values for null property [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/512215 (owner: Umherirrender) [19:02:26] (CR) Jforrester: [C: -1] Replace references to deprecated Squid config with modern CDN ones [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/512458 (owner: Jforrester) [19:04:06] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Improve robustness of forgetme with regards to silverpop - https://phabricator.wikimedia.org/T212382 (DStrine) Open→Resolved [19:05:31] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Ingenico recurring failing due to lack of unique merchant id - https://phabricator.wikimedia.org/T212734 (DStrine) Open→Declined [20:02:10] (Merged) jenkins-bot: Use ?? to define default values for null property [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/512215 (owner: Umherirrender) [20:02:56] hey fr-tech the new ingenico iframe is out and is the default at the moment, right? [20:03:05] so fr-online won't have to do anything for their test tomorrow? [20:03:50] Yea, it's out. Nothing required from fr-online. [20:11:54] yeah cool just wanted to be sure [20:13:25] (CR) jenkins-bot: Use ?? to define default values for null property [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/512215 (owner: Umherirrender) [20:19:09] (CR) XenoRyet: [C: +2] Tiny fixes for optional field behavior [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/513183 (https://phabricator.wikimedia.org/T219558) (owner: Ejegg) [20:19:11] (CR) XenoRyet: [C: +2] Move requiredFields overrides to config [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/513184 (https://phabricator.wikimedia.org/T219558) (owner: Ejegg) [20:22:40] thanks XenoRyet|ish [20:35:17] !log updated payments-wiki from 332aaa96e2 to 45b73e7749 [20:35:20] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:50:11] RECOVERY - check_impression_logs on alnitak is OK: OK [20:52:58] (PS1) Ejegg: Make 'emailExplain' default behavior [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/513208 (https://phabricator.wikimedia.org/T218730) [20:53:36] fr-tech I pulled that one into sprint because it'll let the banner team use the employer variant in more places ^^^ [20:53:58] should be pretty minor if anyone wants to review [20:55:25] Fundraising-Backlog, Continuous-Integration-Config: Run wikimedia/fundraising/crm CI jobs on PHP7x, not PHP5x - https://phabricator.wikimedia.org/T223348 (Eileenmcnaughton) @hashar do you have a sense of when - ie. is this something that might happen next quarter or is that unrealistic? [20:55:44] I'll take a look if Marek gives me another minute [20:59:03] ejegg: do you want to catch up on hangout about the dedupe screen stuff [21:01:13] eileen: sure! [21:01:25] now? or in a bit? [21:01:27] how bout the daily autopsy meet link? [21:01:30] now works for me [21:01:37] if this cafe's wifi is up to it [21:01:38] ok cool [21:04:29] (PS1) Umherirrender: Move api modules, special pages and pagers into includes folder [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/513210 [21:05:51] (PS2) Umherirrender: Move api modules, special pages and pagers into includes folder [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/513210 [21:08:08] (CR) Ejegg: [C: +2] Limit parameter not passed to criteria query [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/513024 (https://phabricator.wikimedia.org/T217909) (owner: Eileen) [21:12:40] (Merged) jenkins-bot: Limit parameter not passed to criteria query [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/513024 (https://phabricator.wikimedia.org/T217909) (owner: Eileen) [21:19:58] (PS6) Eileen: Dedupe url generator & batch mark excluded. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/512996 (https://phabricator.wikimedia.org/T217909) [21:21:03] (CR) jerkins-bot: [V: -1] Dedupe url generator & batch mark excluded. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/512996 (https://phabricator.wikimedia.org/T217909) (owner: Eileen) [21:28:49] (PS1) Ejegg: Hide 'mark non-duplicate' button until things are found [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/513219 [21:28:59] (Merged) jenkins-bot: Tiny fixes for optional field behavior [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/513183 (https://phabricator.wikimedia.org/T219558) (owner: Ejegg) [21:29:19] (Merged) jenkins-bot: Move requiredFields overrides to config [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/513184 (https://phabricator.wikimedia.org/T219558) (owner: Ejegg) [21:30:18] (CR) jerkins-bot: [V: -1] Hide 'mark non-duplicate' button until things are found [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/513219 (owner: Ejegg) [21:31:48] (PS1) Eileen: Add afform extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/513221 (https://phabricator.wikimedia.org/T217909) [21:32:46] (CR) Ejegg: [C: +2] Add afform extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/513221 (https://phabricator.wikimedia.org/T217909) (owner: Eileen) [21:35:37] (PS7) Eileen: Dedupe url generator & batch mark excluded. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/512996 (https://phabricator.wikimedia.org/T217909) [21:37:13] (Merged) jenkins-bot: Add afform extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/513221 (https://phabricator.wikimedia.org/T217909) (owner: Eileen) [21:37:42] (PS8) Eileen: Dedupe url generator & batch mark excluded. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/512996 (https://phabricator.wikimedia.org/T217909) [21:38:32] (CR) jerkins-bot: [V: -1] Dedupe url generator & batch mark excluded. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/512996 (https://phabricator.wikimedia.org/T217909) (owner: Eileen) [21:39:37] (PS9) Eileen: Dedupe url generator & batch mark excluded. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/512996 (https://phabricator.wikimedia.org/T217909) [21:40:34] (CR) jerkins-bot: [V: -1] Dedupe url generator & batch mark excluded. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/512996 (https://phabricator.wikimedia.org/T217909) (owner: Eileen) [21:43:37] (PS10) Eileen: Dedupe url generator & batch mark excluded. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/512996 (https://phabricator.wikimedia.org/T217909) [21:44:26] (CR) jerkins-bot: [V: -1] Dedupe url generator & batch mark excluded. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/512996 (https://phabricator.wikimedia.org/T217909) (owner: Eileen) [21:44:58] (PS11) Eileen: Dedupe url generator & batch mark excluded. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/512996 (https://phabricator.wikimedia.org/T217909) [22:07:53] (CR) XenoRyet: [C: +2] Make 'emailExplain' default behavior [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/513208 (https://phabricator.wikimedia.org/T218730) (owner: Ejegg) [22:08:57] (Merged) jenkins-bot: Make 'emailExplain' default behavior [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/513208 (https://phabricator.wikimedia.org/T218730) (owner: Ejegg) [22:38:21] (Abandoned) Eileen: [do not merge] url generator form wip [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/507540 (owner: Eileen) [23:19:25] (PS19) Vedmaka Wakalaka: Banner live preview [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/497611 (https://phabricator.wikimedia.org/T208125) [23:21:30] (PS10) Vedmaka Wakalaka: Banner in-page preview mode [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/508720 [23:27:11] (PS11) Vedmaka Wakalaka: Banner in-page preview mode [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/508720 [23:33:56] (PS12) Vedmaka Wakalaka: Banner in-page preview mode [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/508720