[00:39:18] (CR) Jforrester: [C: +2] "Manually verified as OK." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/514603 (owner: L10n-bot) [02:22:26] (PS1) Eileen: Remove call to retrieve cachedMergeInfo when updating the url [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/514640 [02:41:46] (PS1) Eileen: Switch to controller as syntax [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/514641 (https://phabricator.wikimedia.org/T217903) [06:23:26] (PS1) Eileen: Minor formatting improvement in deduper [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/514653 (https://phabricator.wikimedia.org/T217903) [06:45:52] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510288 (https://phabricator.wikimedia.org/T160949) (owner: Eileen) [06:49:14] (CR) jerkins-bot: [V: -1] Suppress e-notice when opted_out_timestamp is not set. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510288 (https://phabricator.wikimedia.org/T160949) (owner: Eileen) [12:19:51] (PS1) Thiemo Kreuz (WMDE): Fix CentralNoticeCampaignChange hook not passign expected arrays [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/514703 (https://phabricator.wikimedia.org/T225195) [12:33:33] (CR) Awight: [C: +1] "I think this makes sense, but maybe the `null` return value was intentional?" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/514703 (https://phabricator.wikimedia.org/T225195) (owner: Thiemo Kreuz (WMDE)) [12:58:17] Fundraising Sprint James Bond: Licensed to Share, Fundraising Sprint King Kong vs. Mozilla, Fundraising-Backlog: SPIKE: Unsubscribes import decreasing in size over 2 days - https://phabricator.wikimedia.org/T223935 (jgleeson) hmm something isn't right, either the query above isn't what we want? or th... [13:20:05] (CR) jerkins-bot: [V: -1] Fix CentralNoticeCampaignChange hook not passign expected arrays [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/514703 (https://phabricator.wikimedia.org/T225195) (owner: Thiemo Kreuz (WMDE)) [13:55:45] (CR) Ottomata: [C: +1] Fix CentralNoticeCampaignChange hook not passign expected arrays [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/514703 (https://phabricator.wikimedia.org/T225195) (owner: Thiemo Kreuz (WMDE)) [14:09:20] Fundraising-Backlog: Civi not allowing me to capture Employer Information on Summary Screen - https://phabricator.wikimedia.org/T225215 (NNichols) [14:38:17] (CR) AndyRussG: [C: -2] "> The way this code was arranged caused it to pass null whenever one of the two settings arrays is empty. I find this suprising and unexpe" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/514703 (https://phabricator.wikimedia.org/T225195) (owner: Thiemo Kreuz (WMDE)) [14:57:51] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Security: CentralNotice banner preview: follow-up improvements - https://phabricator.wikimedia.org/T225101 (AndyRussG) [15:01:16] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Security: CentralNotice banner preview: follow-up improvements - https://phabricator.wikimedia.org/T225101 (AndyRussG) > SpecialBannerLoader 68-69: check with security about how we're reflecting POSTed content back. Any need for sanitization? A... [15:35:44] Fundraising Sprint James Bond: Licensed to Share, Fundraising Sprint King Kong vs. Mozilla, Fundraising-Backlog: SPIKE: Unsubscribes import decreasing in size over 2 days - https://phabricator.wikimedia.org/T223935 (Ejegg) Hi @jgleeson, that query looks pretty good, but there are a few other fields t... [16:14:32] Fundraising Sprint King Kong vs. Mozilla, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Re-add fields to Silverpop export - https://phabricator.wikimedia.org/T170972 (CCogdill_WMF) Er, weird! I sent this reply via email yesterday morning but it looks like it didn't post:... [16:24:14] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Release-Engineering-Team (Long-Lived-Branches), Spike, Wikimedia-Incident: Spike: Plan reforms of the CentralNotice deployment branch - https://phabricator.wikimedia.org/T136904 (greg) This is done, yes? [16:25:24] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Release-Engineering-Team (Long-Lived-Branches), Spike, Wikimedia-Incident: Spike: Plan reforms of the CentralNotice deployment branch - https://phabricator.wikimedia.org/T136904 (AndyRussG) >>! In T136904#5240957, @greg wrote: > This is... [16:28:10] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Release-Engineering-Team (Long-Lived-Branches), Spike, Wikimedia-Incident: Spike: Plan reforms of the CentralNotice deployment branch - https://phabricator.wikimedia.org/T136904 (greg) Open→Resolved a:thcipriani [16:28:44] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Security: CentralNotice banner preview: follow-up improvements - https://phabricator.wikimedia.org/T225101 (AndyRussG) Further comments on patch set 19 of https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CentralNotice/+/497611/ (619cd382... [16:30:33] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Security: CentralNotice banner preview: follow-up improvements - https://phabricator.wikimedia.org/T225101 (AndyRussG) Suggested UI changes (https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CentralNotice/+/497611/ PS 19 and https://gerri... [16:33:50] (Abandoned) Thiemo Kreuz (WMDE): Fix CentralNoticeCampaignChange hook not passign expected arrays [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/514703 (https://phabricator.wikimedia.org/T225195) (owner: Thiemo Kreuz (WMDE)) [18:01:46] Fundraising-Backlog: Update addressee address for major gifts contacts failed with code 1 - https://phabricator.wikimedia.org/T225241 (XenoRyet) [18:04:28] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: WMF code trying to insert child rows after parent rows rolled back - https://phabricator.wikimedia.org/T225242 (Ejegg) [19:16:57] cstone: the minfraud update definitely wasn't part of the security fixes, but it seems like it's not going to affect how we use it at all [19:17:28] I just +2ed your vendor repo patch. If it doesn't V+2 / merge automatically, feel free to apply that yourself [19:17:43] ok thanks! [19:48:01] was it getting a -1 from jenkins what you were talking about there ejegg? [20:00:47] oh shoot [20:00:52] wonder what that's about [20:00:59] i've got a meeting, unfortunately [20:01:11] XenoRyet: can you help cstone figure out why her vendor patch is failing? [20:06:45] cstone: What's going on now? [20:07:25] i was updating the vendor directory and it failed the jenkins tests, there was just a comment on the patch from someone else [20:08:00] https://gerrit.wikimedia.org/r/#/c/mediawiki/vendor/+/514861/ [20:08:16] this one, i need to afk for a few though I'll be back in 10ish minutes [20:08:49] ok, I'll see what I can figure out in the mean time. [20:38:45] XenoRyet: sorry I'm back now that took longer than it should have [20:38:59] No worries. [20:39:04] Stuff usually does [20:39:16] My banner raises a Content Security Warning, only in plwiki. Is this a known issue? https://pl.wikipedia.org/w/index.php?title=Wikipedia:Strona_g%C5%82%C3%B3wna&banner=CS_Test5 [20:39:46] Anyway, like James said it's looking for wmfFramework and not finding it. I don't know why that should be though. [20:41:05] maybe just try a recheck, see if it was just a fluke. [20:41:17] That would be weird, but probably wouldn't hurt to check. [20:43:24] Oh, looks like he may have done that since I last reloaded and it still failed. [20:43:57] yeah is that where that 2nd one came from? [20:44:08] I'm guessing [20:44:26] Not sure it was him or how he triggered it, but it is a second failure. [20:48:31] I'm kind of at a loss here. [20:56:38] fr-tech: Anybody else got an idea about why jenkins wouldn't be able to find a file like that? [21:00:33] hmm it looks like the last two updates before mine also failed but i guess it doesnt save the output ? i cant see why they failed [21:01:19] https://gerrit.wikimedia.org/r/#/c/mediawiki/vendor/+/499260/ [21:09:33] I thought I saw one from jforrester that went through yesterday. [21:09:47] https://gerrit.wikimedia.org/r/#/c/mediawiki/vendor/+/514531/ [21:11:23] Weird that the output isn't saved either. It should be. [21:11:28] ah i was looking at the ones on the fundraising branch [21:11:41] That might be the better place to look anyway though. [21:13:50] Looks like ejegg ended up just removing the -1 and applying a V2 and C2 himself. [21:14:15] I'm a little wary of doing that here without knowing what error he was getting around and whether or not it's the same as what we're getting here. [21:15:11] Looks like it's happening on all the patches though. [21:19:12] Yea, everything in there has those tests failing, but missing the logs for why, and has ejegg|afk manually verifying and merging it. [21:19:17] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi not allowing me to capture Employer Information on Summary Screen - https://phabricator.wikimedia.org/T225215 (DStrine) [21:19:43] (CR) jerkins-bot: [V: -1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/514914 (owner: L10n-bot) [21:42:13] cstone: Sorry, got destracted by some other work for a bit there. [21:42:30] no worries [21:43:18] But yea, I'm not sure what to do here. Do you have a sense of how critical the update is? [21:44:05] i think just it was released today and ejegg just wanted to do it as soon as possible but not super critical? [21:44:36] If that's the case, I think maybe we wait for him to come back online tomorrow. I'm guessing he's on a plane right now. [21:45:09] I feel like just manually adding the V2 is going to end up being the right move, but I'm pretty uncomfortable doing that without knowing why or what will break if it goes wrong. [21:45:16] ah yeah i agree i dont want to force without knowing why [21:45:23] force it* [21:45:47] So yea, I guess put it in your end of day email and he'll see it if he comes on before you do tomorrow. [21:45:56] yeah sounds good [21:46:09] We should probably also look into why those error logs aren't getting saved. Seems like we should have those. [21:47:53] is it like a time thing since the last one was in march? [21:48:17] Maybe, but that doesn't seem consistent with what happens in other projects. [21:49:45] I thought I saw one a lot older than that in donation interface, but maybe it is just a different setting. [21:49:54] I wonder if they get more permanently archived somewhere. [21:52:10] Fundraising Sprint King Kong vs. Mozilla, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Re-add fields to Silverpop export - https://phabricator.wikimedia.org/T170972 (Eileenmcnaughton) @DStrine @Ejegg we only grab fiscal due to MG requirements - we could add calendar year... [21:52:53] Are there any documenation on how to avoid "Content Security Policy" issues when creating banners? I'm confused about why they appear on just some languages. [22:33:25] (CR) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/514905 (owner: L10n-bot) [23:24:36] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Release-Engineering-Team, Security: CentralNotice setting a surprising content security policy in production - https://phabricator.wikimedia.org/T225261 (AndyRussG) Indeed this should be fixed... The point of this was to warn people testing... [23:46:35] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Release-Engineering-Team, Security: CentralNotice setting a surprising content security policy in production - https://phabricator.wikimedia.org/T225261 (Jdforrester-WMF) Specifically, this was found by @notconfusing on https://pl.wikipedia... [23:47:57] (PS1) Awight: Don't use composer-merge-plugin for vendor [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/514986 [23:50:31] (CR) jerkins-bot: [V: -1] Don't use composer-merge-plugin for vendor [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/514986 (owner: Awight)