[00:00:41] (PS2) Awight: Don't use composer-merge-plugin for vendor [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/514986 [00:00:44] (PS1) Awight: Update packages for node 10 / npm 6 [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/514987 (https://phabricator.wikimedia.org/T222406) [00:01:23] (CR) Awight: "This is a backport from master, needed for tests to pass." [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/514987 (https://phabricator.wikimedia.org/T222406) (owner: Awight) [00:02:24] (CR) Jforrester: "As the author of this patch, can confirm this makes things work and is a no-op from a production POV (it also doesn't change things for th" [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/514987 (https://phabricator.wikimedia.org/T222406) (owner: Awight) [00:02:49] (CR) jerkins-bot: [V: -1] Don't use composer-merge-plugin for vendor [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/514986 (owner: Awight) [00:04:11] (CR) jerkins-bot: [V: -1] Update packages for node 10 / npm 6 [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/514987 (https://phabricator.wikimedia.org/T222406) (owner: Awight) [00:04:45] (CR) Jforrester: "I'd need to migrate the CI job quibble-donationinterface-REL1_31-php70-docker to node10; I held back because I wanted it make sure FR-tech" [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/514987 (https://phabricator.wikimedia.org/T222406) (owner: Awight) [00:07:42] (CR) Awight: "> I'd need to migrate the CI job quibble-donationinterface-REL1_31-php70-docker" [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/514987 (https://phabricator.wikimedia.org/T222406) (owner: Awight) [00:41:47] (CR) Jforrester: "An alternative would be to cherry-pick I9473e0213c07." [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/514987 (https://phabricator.wikimedia.org/T222406) (owner: Awight) [03:55:58] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Release-Engineering-Team, Security: CentralNotice setting a surprising content security policy in production - https://phabricator.wikimedia.org/T225261 (notconfusing) I find the CSP error happening diferently on different language Wikis.... [03:57:42] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Release-Engineering-Team, Security: CentralNotice setting a surprising content security policy in production - https://phabricator.wikimedia.org/T225261 (notconfusing) Am I correct in thinking that CentralNotice banners that are displayed o... [04:13:52] (CR) Ejegg: [C: +2] Remove call to retrieve cachedMergeInfo when updating the url [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/514640 (owner: Eileen) [04:18:19] (Merged) jenkins-bot: Remove call to retrieve cachedMergeInfo when updating the url [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/514640 (owner: Eileen) [04:29:12] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: WMF code trying to insert child rows after parent rows rolled back - https://phabricator.wikimedia.org/T225242 (Ejegg) Note: the latest FK violation was on an insert to the 'gift data' fields, referencing a rolled-back contribution. Earlier work may hav... [04:55:44] (CR) Raimond Spekking: [C: +2] "false positive" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/514914 (owner: L10n-bot) [05:02:17] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Release-Engineering-Team, Security: CentralNotice setting a surprising content security policy in production - https://phabricator.wikimedia.org/T225261 (Ejegg) @notconfusing yep, you are correct. This CSP is only applied on a forced banner... [05:07:25] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Security: CentralNotice banner preview: follow-up improvements - https://phabricator.wikimedia.org/T225101 (AndyRussG) Comments on patch set 13 of https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CentralNotice/+/508720/ (5de28b87c8): -... [05:37:49] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Security: CentralNotice banner preview: follow-up improvements - https://phabricator.wikimedia.org/T225101 (AndyRussG) I've edited the previous comments to indicate the importance of each issue, as follows: {icon stop color=red} Needs to be ad... [12:39:16] (PS1) Hashar: Jenkins job validation (DO NOT SUBMIT) [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/515052 [12:39:43] (CR) jerkins-bot: [V: -1] Jenkins job validation (DO NOT SUBMIT) [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/515052 (owner: Hashar) [12:41:30] (Restored) Hashar: Jenkins job validation (DO NOT SUBMIT) [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/81470 (owner: Hashar) [12:41:33] (PS4) Hashar: Jenkins job validation (DO NOT SUBMIT) [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/81470 [12:44:45] (Abandoned) Hashar: Jenkins job validation (DO NOT SUBMIT) [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/81470 (owner: Hashar) [12:48:33] (PS1) Hashar: Default tox to run python2 [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/515054 [12:49:01] (CR) jerkins-bot: [V: -1] Default tox to run python2 [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/515054 (owner: Hashar) [12:52:19] (PS1) Hashar: Delete tox test env and pin flake8 [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/515055 [12:52:43] (CR) jerkins-bot: [V: -1] Delete tox test env and pin flake8 [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/515055 (owner: Hashar) [12:54:03] (PS2) Hashar: Default tox to run python2 [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/515054 [12:55:39] (Abandoned) Hashar: Jenkins job validation (DO NOT SUBMIT) [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/515052 (owner: Hashar) [16:06:40] (PS1) Cstone: Merge remote-tracking branch 'origin/REL1_31' into fundraising/REL1_31 and update vendor. [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/515110 [16:26:10] (PS1) Ejegg: WIP render recurring upsell [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/515114 (https://phabricator.wikimedia.org/T216562) [16:28:18] (CR) jerkins-bot: [V: -1] WIP render recurring upsell [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/515114 (https://phabricator.wikimedia.org/T216562) (owner: Ejegg) [16:41:57] (PS2) Ejegg: WIP render recurring upsell [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/515114 (https://phabricator.wikimedia.org/T216562) [16:44:23] (CR) jerkins-bot: [V: -1] WIP render recurring upsell [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/515114 (https://phabricator.wikimedia.org/T216562) (owner: Ejegg) [16:47:51] (CR) Ejegg: "recheck" [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/514987 (https://phabricator.wikimedia.org/T222406) (owner: Awight) [17:35:42] (CR) Ejegg: [C: +2] Merge remote-tracking branch 'origin/REL1_31' into fundraising/REL1_31 and update vendor. [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/515110 (owner: Cstone) [17:37:26] ok cstone, here's hoping ^^^ merges fast [17:41:17] (Merged) jenkins-bot: Merge remote-tracking branch 'origin/REL1_31' into fundraising/REL1_31 and update vendor. [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/515110 (owner: Cstone) [17:46:45] woo ejegg what would be next then? [18:10:01] cstone: just the deploy on frpm [18:10:09] and keeping an eye on the logs [18:18:49] ejegg this one would be payments wiki right? [18:18:53] yep yep [18:20:52] What is the process of adding a campaign, does one add the campaign first and then update the calendar, or vice versa? [18:21:05] That is, for a central notice campaign. [18:21:41] Seddon / AndyRussG : do you know the etiquette there? ^^^^ [18:22:51] !log Update payments-wiki revision changed from c6c7bbf71e to 75abd71cc1 [18:22:56] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [18:23:22] ejegg do I need to do something with composer? [18:23:33] cstone you already did it! [18:23:44] hah okay [18:23:46] that was how you updated the files in vendor, right? [18:24:05] yeah [18:24:10] cool! [18:24:17] So let's just check that it's still working [18:27:24] are the other things you usually test besides a donation? [18:29:42] Ooh, I suppose we could test the opt-out form [18:30:18] shoot, meeting time [19:19:12] notconfusing: hmm I don't know... Really should check with Seddon, but my guess is that if you do both around the same time, it should be ok...? [19:53:44] ok, let's see what's going wrong with the node tests [20:17:32] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: fredge query yielding '502 bad gateway' error - https://phabricator.wikimedia.org/T224742 (MBeat33) Small batches are today getting the 503 gateway error, so maybe this could be pulled into one of the next sprints? [20:17:39] fr-tech for those interested in testing, I'm chatting in #wikimedia-releng now about updating our js style checker [20:17:50] we're still using jshint for DonationInterface [20:17:57] and it's quite obsolete [20:46:34] (PS1) Jforrester: build: Modernise linters to latest [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/515166 [21:05:58] (CR) Ejegg: [C: +2] "Thanks, Jforrester!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/515166 (owner: Jforrester) [21:07:18] (Merged) jenkins-bot: build: Modernise linters to latest [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/515166 (owner: Jforrester) [21:12:19] PROBLEM - check_procs on frdb1001 is CRITICAL: PROCS CRITICAL: 1135 processes [21:17:19] RECOVERY - check_procs on frdb1001 is OK: PROCS OK: 212 processes [21:27:50] AndyRussG: thanks, I'll try that. [21:41:31] Fundraising-Backlog: Republish donor TY email - edits to ru, es - https://phabricator.wikimedia.org/T225332 (TSkaff) [21:47:10] (PS1) Ejegg: Ignore hosted CSS, fix easy problems [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/515183 [21:47:31] fr-tech ^^^ would be nice to merge before any of that CSS gets touched [21:47:47] We've been a bit behind on our style checking [21:48:01] That patch really does just touch the easy problems [21:48:38] i.e. just whitespace, hex code lenght, and leading zeros on decimals [21:48:57] I left the exceptions in place for tricky stuff like getting rid of !important [21:49:04] and even duplicate selectors [21:51:56] ejegg this is from the new style checker? [21:54:10] cstone: yep! [21:54:45] James_F added the new style checker with tons of exceptions to the rules [21:54:54] nice to see all that whitespace be uniform [21:55:01] yeah, definitely! [21:55:42] cstone: when I review patches that are mostly whitespace changes, i use git log -p -w [21:55:55] the -w makes it ignore the whitespace changes [21:56:00] ah nice [21:56:07] so you can focus on the more substantial things [21:56:22] hmm, I guess it still does show added blank lines [21:56:32] there's probably another switch the ignore those [21:58:25] *to ignore [22:02:56] (CR) Cstone: [C: +2] Ignore hosted CSS, fix easy problems [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/515183 (owner: Ejegg) [22:06:24] (Merged) jenkins-bot: Ignore hosted CSS, fix easy problems [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/515183 (owner: Ejegg) [22:06:51] thanks cstone! [22:07:07] ok, now I'll get back to work on rendering that upsell... [22:09:33] (PS2) Ejegg: Variants starting with 'upsell' mean recurrable payment [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/514344 (https://phabricator.wikimedia.org/T216560) [22:09:35] (PS4) Ejegg: Add supportsRecurringUpsell and showRecurringUpsell [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/514351 (https://phabricator.wikimedia.org/T216560) [22:09:37] (PS3) Ejegg: WIP render recurring upsell [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/515114 (https://phabricator.wikimedia.org/T216562) [22:11:48] hmm, this almost feels like a good time to fix how the Mustache renderer gets its data [22:12:26] i.e. not having a reference to the gateway or page objects [23:32:57] (PS4) Ejegg: Render recurring upsell [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/515114 (https://phabricator.wikimedia.org/T216562) [23:32:59] (PS1) Ejegg: Common base for result pages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/515246 (https://phabricator.wikimedia.org/T216562) [23:41:19] (PS5) Ejegg: Render recurring upsell (USD only) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/515114 (https://phabricator.wikimedia.org/T216562) [23:47:05] (CR) Jforrester: build: Modernise linters to latest (7 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/515166 (owner: Jforrester) [23:47:19] (CR) Jforrester: "Oops, sorry, my explanatory comments were stuck in draft. :-)" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/515166 (owner: Jforrester) [23:52:12] (PS6) Ejegg: WIP: Render recurring upsell (USD only) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/515114 (https://phabricator.wikimedia.org/T216562) [23:55:49] (CR) Jforrester: "+1" [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/514987 (https://phabricator.wikimedia.org/T222406) (owner: Awight)