[02:13:22] (PS2) Ejegg: phpunit 6 support [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/516628 (owner: Eileen) [02:14:37] (CR) Ejegg: [C: +2] "Doc improvements look good, and the switch to namespaced \TestCase seems to be supported by forward-compatibility shims in PHPUnit 4.8.35+" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/516628 (owner: Eileen) [02:19:25] (Merged) jenkins-bot: phpunit 6 support [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/516628 (owner: Eileen) [02:22:18] (CR) Ejegg: "Looks good, just need to get rid of the 'use' statement at the top of that file to pass lint." (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/516960 (owner: XenoRyet) [02:31:34] (CR) Ejegg: "Oops, I guess AstroPayTest::testAntiFraudFilters and GlobalCollectTest::testGetOrderstatusPostProcessFraud need updates too. Should just b" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/516960 (owner: XenoRyet) [02:52:57] Fundraising Sprint Land before Timeouts, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Smashpig, and 2 others: Add India-specific payment methods across our pipeline - https://phabricator.wikimedia.org/T224514 (Ejegg) [14:41:31] jgleeson: sorry about the mess with the organization_name field. Looks like it is only shown in the UI for organization-type contacts. [14:44:55] ahhh [14:45:08] ok maybe we need to think about a new home for the field? [14:47:22] ejegg, how frequently does frdev1001 mysql update? [14:47:27] jgleeson: yeah :( [14:47:41] jgleeson the civicrm db there is pretty up to date [14:47:57] looks like he used 'WMFTesting', not 'WMFTest' [14:47:58] I'm running `select id from civicrm_contact where organization_name = 'WMFTest'` and getting no results [14:48:03] ahh [14:48:09] I just searched for organization_name <> '' order by id desc [14:48:18] since we don't add orgs very frequently [14:48:20] got it [14:48:23] and it was the most recent one [14:48:45] so it's getting stored fine, we just would need to export via SQL [14:49:05] not the worst thing in the world, but yeah, would be easier to make it visible via normal Civi means [14:49:27] I wonder how much work would be involved in adding a new read-only form field on civi contact? [14:49:51] jgleeson not much, there should be plenty of examples of it [14:50:10] the custom fields in the wmf_donor table are mostly read-only [14:50:59] see wmf_civicrm_update_7024 for example [14:51:14] that function creates a whole bunch of fields in that group [14:51:20] (in wmf_civicrm.install) [14:51:36] then to map to that field, we've got a convenience function [14:52:04] wmf_civicrm_get_custom_field_name [14:52:41] actually [14:52:50] so you'd say $employerFieldName = wmf_civicrm_get_custom_field_name('employer_name', 'wmf_donor'); [14:53:00] could we just make the existing organization_name field visible on the contact page, for this use-case? [14:53:02] then just add $employerFieldName => $value [14:53:11] jgleeson: I was looking into how to do that [14:53:18] and it would definitely be a core hack [14:54:07] ah ok. I'm not familiar with civiform but I was kinda hoping it was just a line of html calling an already inscope array key [14:54:14] civi forms* [14:55:38] oh weird, looks like current_employer should default to using that field under certain circumstances [14:55:55] that would explain my test [14:56:03] if I look at Contact/Page/View/Summary.php lines 251-257 [14:56:05] https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/509103/3/sites/all/modules/wmf_civicrm/tests/phpunit/ImportMessageTest.php [14:56:33] jgleeson: oh right, maybe with the contact layout editor? [14:56:40] let's see if that lets us do it! [14:59:02] oh wait, sorry, what were you suggesting with civiform? [14:59:27] sorry I corrected that, I walk talking more generally about forms in civi [14:59:36] not idea if civiform is a thing [14:59:40] no8 [14:59:43] ... [14:59:45] no* [15:02:02] ohh, that block in Summary.php only applies if they have an employer_id set as well [15:02:11] seems a bit denormalized [15:06:00] so the contact layout editor looks like it makes organization_name available, not sure if it has internal logic to filter out things that are supposed to be org-only when showing individual contacts [15:07:44] hmm, i should make a 'beta testers' group to target the layout to, so we don't mess with other people's workflow [15:08:00] jgleeson have you played with the contact layout editor yet? [15:08:06] nope [15:08:28] It's under Administer->customize data and screens->contact summary layouts [15:08:51] should be safe to mess with it on the frdev civi instance [15:09:21] so, if we add our own contact records to a 'beta testers' group [15:09:50] we can then create a contact layout that is only shown to us [15:10:58] ah I see [15:11:01] that civi instance runs off the civicrm_dev db, (only updated via manual restore), so it won't have Sam's test contact [15:11:29] I guess I could inject one [15:11:31] for testing [15:11:54] yep, we should at least be able to use the drush trick to get a sql prompt as the civi user! [15:13:08] interestig, so we have frdev db's, frdev staging db's, and a separate db for frdev civi? [15:13:43] ahh, the _dev db is also known as staging [15:14:15] yeah, so for civi we have `civicrm` and `civicrm_dev` [15:14:17] the 'civicrm' db with no suffix is a replica of the real thing, updated in realtime [15:14:25] but the instance of civi is using a different one to those 2? [15:15:32] no, staging civicrm ui uses civicrm_dev and drupal_dev [15:15:41] ahh [15:23:18] ejegg Do you remember if we have a task somewhere for removing the old banner (not campaign) mixin system? [15:23:51] Just wanna add a TODO with a task number here while beautifying SpecialBannerLoader [15:24:09] I can't find such a task anyway... [15:25:58] AndyRussG: I remember talking about it, but I don't think I've seen a task [15:27:28] ejegg: K Imma make one, yeee? [15:30:22] yee [15:31:25] jgleeson oops, dev_civicrm is the staging db name - civicrm_dev doesn't exist [15:34:16] got it [15:34:19] thanks [15:37:07] jgleeson ok, I made a 'Layout Beta Testers' group [15:37:20] and I think I added our contacts to it [15:37:22] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Remove unused banner mixin feature - https://phabricator.wikimedia.org/T225831 (AndyRussG) [15:39:40] hmm, I'm trying to save new blocks but I don't see them in the list [15:40:35] And the dropdown for contact type won't let me select anything other than 'organization' [15:40:56] hmmm [15:41:04] I can't see any mention of groups [15:41:29] not sure if signs of the layout editor being in development, or if our staging env is in a weird state [15:41:31] I see two layouts [15:41:43] yeah, I haven't saved mine yet [15:41:47] ah ok [15:43:21] jgleeson see the 'Show' and 'To' metadata for those layouts? [15:43:29] 'Show' is a contact type, and 'To' is a group [15:43:40] yu[ [15:43:41] yup [15:43:44] ah ok [15:44:01] I see it now [15:45:06] I see test for jack [15:45:28] but nothing happens when I click or drag that label [15:45:31] hmm, saving is also taking forever [15:45:39] I can see Summary is selected [15:45:41] ok, so 'test for jack' looks like a custom tab [15:45:42] and the employer block [15:46:29] i was trying to create a custom info block like the list down the right hand side [15:47:52] Oh, I guess it did save earlier, it just didn't show it [15:48:16] so now I see it, but it's unavailable because it's got org fields [15:48:28] and the contact layout is targeted to individuals [15:48:31] hmph [15:48:45] they really do filter it out [15:49:01] so if this isn't going to help us, what else is available? [15:50:46] how much pain are we talking about adding customisation to the Summary.php view [15:51:03] can we "layer" changes to templates in civi? [15:51:22] or does it encourage all that type of thing be managed within the admin console [15:52:13] reading https://docs.civicrm.org/dev/en/latest/framework/templates/customizing/ [15:52:24] The methods on this page are of historical interest and may be helpful in understanding legacy code, but overriding templates and php files is strongly discouraged for any new customisations. These approaches need attention whenever you upgrade and will cause a range of problems from subtle to major if you forget about them. [15:52:25] As CiviCRM evolves, the recommended ways of customizing it change. The current preferred method is to Create an Extension to implement Hooks and use the API. If you can't find a way to use existing hooks to accomplish what you want, discuss it on StackExchange or Chat. It may be appropriate to add a new hook to core. [15:52:25] (It is possible to override templates and php in an extension, but you face the same problems when it comes to upgrading - don't do it!) [15:52:56] oh right, hooks! [15:53:15] that sounds promising [15:54:09] hook_civicrm_summary [15:54:12] https://docs.civicrm.org/dev/en/latest/hooks/hook_civicrm_buildForm/ [15:54:29] actually it's not a form is it [15:54:49] oh cool [15:54:49] summary would be enough if all they want to do is view it [15:55:04] this looks promising [15:55:18] :) [15:56:15] so civicrm hooks are added by creating a global fn ending with the appropriate name [15:56:45] e.g. our wmf_civicrm_civicrm_merge [15:57:00] the 'wmf_civicrm' is from our module name [15:57:18] and the 'civicrm_merge' means it will fire on the civicrm_merge hook [15:57:35] so you could add a wmf_civicrm_civicrm_summary [15:58:02] got it - just reading this also https://docs.civicrm.org/dev/en/latest/hooks/usage/extension/ [15:59:09] Fundraising Sprint Greps of Wrath, Fundraising Sprint Hansel and grep -l, Fundraising Sprint It Came From Out of Scope, Fundraising Sprint James Bond: Licensed to Share, and 3 others: Payments wiki form variant with employer field - https://phabricator.wikimedia.org/T219558 (jgleeson) Resolved... [15:59:39] Fundraising Sprint Greps of Wrath, Fundraising Sprint Hansel and grep -l, Fundraising Sprint It Came From Out of Scope, Fundraising Sprint James Bond: Licensed to Share, and 4 others: Payments wiki form variant with employer field - https://phabricator.wikimedia.org/T219558 (jgleeson) [16:00:17] bookmarked that and pulled the employer stuff back into the sprint (to be confirmed by dstrine). I've gotta pop out breifly to pickup Oscar but will be back soon. Thanks for all the help on this ejegg ! [16:01:26] jgleeson: ok I've read the email but not back scroll. I'm working through some email. Let's chat at standup. [16:01:36] sure [16:01:38] back soon! [16:31:56] fr-tech, anyone else having issues joining the call? [16:32:06] google is spinning for me saying "still trying to get in" [17:19:19] Fundraising Sprint Land before Timeouts, Fundraising-Backlog, FR-Ingenico: shut down old ingenico form - https://phabricator.wikimedia.org/T225839 (DStrine) [17:19:47] Fundraising Sprint Land before Timeouts, Fundraising-Backlog, FR-Ingenico: shut down old ingenico form - https://phabricator.wikimedia.org/T225839 (DStrine) a:Ejegg [17:51:36] Fundraising-Backlog: Track stats for opt-in page - https://phabricator.wikimedia.org/T225844 (CCogdill_WMF) p:Triage→Unbreak! [17:53:53] Fundraising-Backlog: Track stats for opt-in page - https://phabricator.wikimedia.org/T225844 (CCogdill_WMF) [20:10:46] (PS1) Ejegg: Allow overriding built-in yaml files without variant [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/517130 (https://phabricator.wikimedia.org/T225839) [21:58:22] (PS2) Ejegg: Allow overriding built-in yaml files without variant [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/517130 (https://phabricator.wikimedia.org/T225839) [22:16:58] (PS1) Ejegg: Add more debug logging to filters [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/517146 [22:17:19] XenoRyet: ^^^ might also help get to the bottom of things [22:17:50] also, i left a couple comments on your patch to always send the antifraud queue message [22:19:13] PS1 of that local config patch had a copypaste error, but PS2 works fine for me [22:19:25] easiest way to test was to add the opt_in field to US [22:35:35] (CR) XenoRyet: [C: +2] "Yep, agree about the uselessness of that debugarray, this is better." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/517146 (owner: Ejegg) [22:39:15] (Merged) jenkins-bot: Add more debug logging to filters [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/517146 (owner: Ejegg) [23:04:10] (PS3) Ejegg: Variants starting with 'upsell' mean recurrable payment [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/514344 (https://phabricator.wikimedia.org/T216560) [23:06:00] (PS5) Ejegg: Add supportsRecurringUpsell and showRecurringUpsell [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/514351 (https://phabricator.wikimedia.org/T216560) [23:06:02] (PS2) Ejegg: Common base for result pages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/515246 (https://phabricator.wikimedia.org/T216562) [23:06:04] (PS2) Ejegg: Add 'variant' to session fields, add test [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/516454 (https://phabricator.wikimedia.org/T216562) [23:06:06] (PS8) Ejegg: Render recurring upsell (USD only) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/515114 (https://phabricator.wikimedia.org/T216562) [23:06:08] (PS1) Ejegg: Consult session for variant [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/517149 (https://phabricator.wikimedia.org/T216562) [23:06:10] (PS1) Ejegg: Move ui_modules handling to Mustache class [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/517150 (https://phabricator.wikimedia.org/T216562) [23:10:45] XenoRyet: I'mma actually push that debug logging patch to prod [23:11:08] (CR) jerkins-bot: [V: -1] Render recurring upsell (USD only) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/515114 (https://phabricator.wikimedia.org/T216562) (owner: Ejegg) [23:11:33] (CR) jerkins-bot: [V: -1] Move ui_modules handling to Mustache class [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/517150 (https://phabricator.wikimedia.org/T216562) (owner: Ejegg) [23:11:50] oops, what's the holdup there? [23:12:54] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/517151 [23:13:07] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/517151 (owner: Ejegg) [23:13:48] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/517151 (owner: Ejegg) [23:17:19] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/517152 [23:19:25] (CR) Ejegg: [C: +2] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/517152 (owner: Ejegg) [23:21:18] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/517152 (owner: Ejegg) [23:23:53] !log updated payments-wiki from 75abd71cc1 to 79d1822644 [23:23:57] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:27:10] (CR) XenoRyet: [C: +2] "Yep, code looks good, and works a treat." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/517130 (https://phabricator.wikimedia.org/T225839) (owner: Ejegg) [23:27:54] (Merged) jenkins-bot: Allow overriding built-in yaml files without variant [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/517130 (https://phabricator.wikimedia.org/T225839) (owner: Ejegg) [23:30:28] XenoRyet: yeah, just a logging change. [23:48:34] (PS1) Ejegg: Disable personal info fields when opening iframes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/517153 (https://phabricator.wikimedia.org/T201962) [23:52:28] (PS4) Ejegg: Variants starting with 'upsell' mean recurrable payment [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/514344 (https://phabricator.wikimedia.org/T216560) [23:52:29] (PS6) Ejegg: Add supportsRecurringUpsell and showRecurringUpsell [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/514351 (https://phabricator.wikimedia.org/T216560) [23:52:31] (PS3) Ejegg: Common base for result pages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/515246 (https://phabricator.wikimedia.org/T216562) [23:52:33] (PS3) Ejegg: Add 'variant' to session fields, add test [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/516454 (https://phabricator.wikimedia.org/T216562) [23:52:35] (PS2) Ejegg: Consult session for variant [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/517149 (https://phabricator.wikimedia.org/T216562) [23:52:37] (PS2) Ejegg: Move ui_modules handling to Mustache class [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/517150 (https://phabricator.wikimedia.org/T216562) [23:52:39] (PS9) Ejegg: Render recurring upsell (USD only) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/515114 (https://phabricator.wikimedia.org/T216562) [23:53:15] (PS5) Ejegg: Variants starting with 'upsell' mean recurrable payment [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/514344 (https://phabricator.wikimedia.org/T216560) [23:53:17] (PS7) Ejegg: Add supportsRecurringUpsell and showRecurringUpsell [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/514351 (https://phabricator.wikimedia.org/T216560) [23:53:19] (PS4) Ejegg: Common base for result pages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/515246 (https://phabricator.wikimedia.org/T216562) [23:53:21] (PS4) Ejegg: Add 'variant' to session fields, add test [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/516454 (https://phabricator.wikimedia.org/T216562) [23:53:23] (PS3) Ejegg: Consult session for variant [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/517149 (https://phabricator.wikimedia.org/T216562) [23:53:25] (PS3) Ejegg: Move ui_modules handling to Mustache class [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/517150 (https://phabricator.wikimedia.org/T216562) [23:53:38] (PS10) Ejegg: Render recurring upsell (USD only) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/515114 (https://phabricator.wikimedia.org/T216562) [23:53:49] wheee [23:56:51] (CR) jerkins-bot: [V: -1] Move ui_modules handling to Mustache class [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/517150 (https://phabricator.wikimedia.org/T216562) (owner: Ejegg) [23:56:54] (CR) jerkins-bot: [V: -1] Render recurring upsell (USD only) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/515114 (https://phabricator.wikimedia.org/T216562) (owner: Ejegg)