[00:06:19] <wikibugs>	 (PS1) Eileen: Move actual creation of wmf_donor fields to update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518846 (https://phabricator.wikimedia.org/T170972)
[00:06:20] <wikibugs>	 (PS1) Eileen: Move creation of wmf_donor fields to update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518847 (https://phabricator.wikimedia.org/T170972)
[00:08:06] <wikibugs>	 (PS1) Eileen: Show php storm we care [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518849
[00:08:37] <wikibugs>	 (CR) jerkins-bot: [V: -1] Move actual creation of wmf_donor fields to update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518846 (https://phabricator.wikimedia.org/T170972) (owner: Eileen)
[00:08:48] <wikibugs>	 (CR) jerkins-bot: [V: -1] Move creation of wmf_donor fields to update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518847 (https://phabricator.wikimedia.org/T170972) (owner: Eileen)
[00:10:27] <wikibugs>	 (CR) jerkins-bot: [V: -1] Show php storm we care [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518849 (owner: Eileen)
[00:13:35] <wikibugs>	 (PS2) Eileen: Move actual creation of wmf_donor fields to update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518846 (https://phabricator.wikimedia.org/T170972)
[00:16:11] <wikibugs>	 (PS2) Eileen: Move creation of wmf_donor fields to update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518847 (https://phabricator.wikimedia.org/T170972)
[00:16:17] <wikibugs>	 (PS2) Eileen: Show php storm we care [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518849
[00:16:53] <wikibugs>	 (PS1) Eileen: Remove update to is_x_donor fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518850 (https://phabricator.wikimedia.org/T170972)
[00:18:52] <wikibugs>	 (PS1) Eileen: Remove label tweak on is_x_donor fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518851 (https://phabricator.wikimedia.org/T170972)
[00:54:15] <wikibugs>	 (CR) Ejegg: [C: +2] Remove old wmf_donor instantiation file [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518839 (https://phabricator.wikimedia.org/T170972) (owner: Eileen)
[00:54:59] <wikibugs>	 (CR) Ejegg: [C: +2] Comment block [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518841 (owner: Eileen)
[00:59:23] <wikibugs>	 (Merged) jenkins-bot: Remove old wmf_donor instantiation file [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518839 (https://phabricator.wikimedia.org/T170972) (owner: Eileen)
[00:59:53] <wikibugs>	 (Merged) jenkins-bot: Comment block [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518841 (owner: Eileen)
[01:00:56] <wikibugs>	 (CR) Ejegg: [C: +1] "Thanks for debloating the install file! Looks like we can get rid of one of one of the fn calls inside the install function now." (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518844 (owner: Eileen)
[01:02:39] <wikibugs>	 (CR) Ejegg: [C: +1] "Works great, mighta caught some copypasta in a comment." (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518846 (https://phabricator.wikimedia.org/T170972) (owner: Eileen)
[01:04:34] <wikibugs>	 (CR) Ejegg: [C: +2] Move creation of wmf_donor fields to update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518847 (https://phabricator.wikimedia.org/T170972) (owner: Eileen)
[01:04:45] <wikibugs>	 (CR) Ejegg: [C: +2] ":)" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518849 (owner: Eileen)
[01:07:02] <wikibugs>	 (CR) Ejegg: [C: +2] Remove update to is_x_donor fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518850 (https://phabricator.wikimedia.org/T170972) (owner: Eileen)
[01:07:06] <wikibugs>	 (CR) Ejegg: [C: +2] Remove label tweak on is_x_donor fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518851 (https://phabricator.wikimedia.org/T170972) (owner: Eileen)
[01:08:45] <wikibugs>	 (PS3) Ejegg: Add India support with dlocal. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518790 (https://phabricator.wikimedia.org/T224514) (owner: Cstone)
[01:08:57] <wikibugs>	 (CR) Ejegg: [C: +2] "Looks good!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518790 (https://phabricator.wikimedia.org/T224514) (owner: Cstone)
[01:09:48] <wikibugs>	 (CR) Ejegg: [C: -1] "caught a typo on the RuPay code" (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/518762 (https://phabricator.wikimedia.org/T224514) (owner: Cstone)
[01:13:58] <wikibugs>	 (Merged) jenkins-bot: Add India support with dlocal. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518790 (https://phabricator.wikimedia.org/T224514) (owner: Cstone)
[01:16:38] <wikibugs>	 (PS2) Eileen: Convert gift data custom group to being declared in update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518844
[01:17:27] <wikibugs>	 (CR) Eileen: "thanks ejegg - ironically I did do a 'lazy-look' for which call I could remove but I got bored or distracted or something - gone now." (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518844 (owner: Eileen)
[01:19:31] <wikibugs>	 (PS3) Ejegg: Convert gift data custom group to being declared in update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518844 (owner: Eileen)
[01:19:34] <wikibugs>	 (PS3) Eileen: Move actual creation of wmf_donor fields to update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518846 (https://phabricator.wikimedia.org/T170972)
[01:19:56] <wikibugs>	 (CR) Eileen: "tha 'ol pasta - fixed now" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518846 (https://phabricator.wikimedia.org/T170972) (owner: Eileen)
[01:20:11] <wikibugs>	 (CR) Ejegg: [C: +2] Convert gift data custom group to being declared in update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518844 (owner: Eileen)
[01:20:52] <eileen>	 thanks ejegg - that was super quick
[01:21:01] <wikibugs>	 (PS4) Ejegg: Move actual creation of wmf_donor fields to update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518846 (https://phabricator.wikimedia.org/T170972) (owner: Eileen)
[01:21:13] <wikibugs>	 (CR) Ejegg: [C: +2] Move actual creation of wmf_donor fields to update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518846 (https://phabricator.wikimedia.org/T170972) (owner: Eileen)
[01:21:17] <wikibugs>	 (PS3) Ejegg: Move creation of wmf_donor fields to update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518847 (https://phabricator.wikimedia.org/T170972) (owner: Eileen)
[01:21:24] <wikibugs>	 (PS3) Ejegg: Show php storm we care [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518849 (owner: Eileen)
[01:21:30] <wikibugs>	 (PS2) Ejegg: Remove update to is_x_donor fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518850 (https://phabricator.wikimedia.org/T170972) (owner: Eileen)
[01:21:37] <wikibugs>	 (PS2) Ejegg: Remove label tweak on is_x_donor fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518851 (https://phabricator.wikimedia.org/T170972) (owner: Eileen)
[01:21:46] <ejegg>	 (rebase cascade)
[01:22:59] <eileen>	 lol
[01:23:14] <eileen>	 yeah I need to do a few more but I think I'll wait for them to merge first
[01:23:39] <eileen>	 I think we can stop creating is_x_donor fields altogether now & add the new desired ones
[01:24:17] <eileen>	 I'm actually kinda happy to be doing this because it feels really useful &  I'll also do the handful of new ones MG asked for
[01:25:16] <wikibugs>	 (Merged) jenkins-bot: Convert gift data custom group to being declared in update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518844 (owner: Eileen)
[01:26:13] <ejegg>	 eileen: right on!
[01:26:27] <ejegg>	 yeah, nice well-defined task, this!
[01:26:28] <wikibugs>	 (Merged) jenkins-bot: Move actual creation of wmf_donor fields to update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518846 (https://phabricator.wikimedia.org/T170972) (owner: Eileen)
[01:26:48] <eileen>	 ejegg: yeah - sometimes it's nice to work on something with a clear path
[01:26:51] <wikibugs>	 (Merged) jenkins-bot: Move creation of wmf_donor fields to update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518847 (https://phabricator.wikimedia.org/T170972) (owner: Eileen)
[01:27:09] <eileen>	 (even if it wasn't that clear from the original phab / before I asked at Leesburg)
[01:27:23] <eileen>	 that we would be adding new calculated fields
[01:33:07] <wikibugs>	 (CR) Ejegg: [C: -1] "Submethods file needs a few little tweaks." (4 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/518746 (https://phabricator.wikimedia.org/T224514) (owner: Cstone)
[01:42:04] <wikibugs>	 (CR) Ejegg: [C: -1] "Vagrant patch to add India form links is here: https://gerrit.wikimedia.org/r/518859 Unfortunately I think you need to destroy and rebuild" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/518746 (https://phabricator.wikimedia.org/T224514) (owner: Cstone)
[01:43:31] <wikibugs>	 (PS1) Eileen: Move remaining wmf_donor fields over to update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518864 (https://phabricator.wikimedia.org/T170972)
[01:46:23] <eileen>	 ejegg: what do you think I should do about is_x_donor fields - remove them from the trigger & disable the fields & maybe drop the disabled do_not_solicit as a peace offering for not actually deleting the fields? Although maybe even that is scope sprawl
[01:46:47] <eileen>	 since I did create https://phabricator.wikimedia.org/T226461
[01:47:10] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Cleanup old custom fields - https://phabricator.wikimedia.org/T226461 (Eileenmcnaughton)
[01:48:14] <ejegg>	 If we drop the do_not_solicit, we'd mark all those donors opt_out?
[01:50:46] <ejegg>	 ohhh, right, we moved that field over to communications
[01:51:11] <ejegg>	 yeah, bitofa scope creep, but should be deletable
[01:52:41] <eileen>	 yeah we don't have an existing delete field fn - I think the api requires the data be deleted first
[01:52:44] <wikibugs>	 (PS1) Ejegg: Remove unused join [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/518866
[01:52:53] <ejegg>	 oh, really?
[01:53:53] <wikibugs>	 (CR) Eileen: [C: +2] "Yep - not used!" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/518866 (owner: Ejegg)
[01:53:54] <ejegg>	 Anyway, if you feel like it's super-quick to clean them up, might be worth it just to reduce visual overload
[01:54:27] <wikibugs>	 (Merged) jenkins-bot: Remove unused join [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/518866 (owner: Ejegg)
[01:54:42] <eileen>	 yeah - I'll try the field adds now & maybe test a delete on staging & see
[01:54:51] <ejegg>	 rockin!
[01:55:01] <ejegg>	 gotta head out. have a good rest of your day!
[01:55:11] <eileen>	 so ejegg  you don't think we should have a period of 'disabled
[01:55:20] <eileen>	 ' before we delete the is_x_donor fields?
[01:55:37] <eileen>	 have a good evening
[01:55:41] <ejegg>	 eileen: we already dropped them from the export, right?
[01:55:52] <ejegg>	 I guess we could ask if anyone's using them in reports first
[01:55:54] <eileen>	 Pretty sure
[01:56:14] <ejegg>	 k, cool. cya!
[01:58:16] <wikibugs>	 Fundraising-Backlog: remove or deactivate Casey Dentinger's civicrm user - https://phabricator.wikimedia.org/T226434 (Eileenmcnaughton) boo
[02:01:05] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Turn on Redis, Functional locks - https://phabricator.wikimedia.org/T222002 (Eileenmcnaughton) @DStrine Can we prioritise this - it's about 20 minutes work + being aware of it at the team level & having a plan to revert if anything weird happens. Would...
[02:13:56] <wikibugs>	 (PS1) Eileen: Add new fields for calendar year totals [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518867 (https://phabricator.wikimedia.org/T170972)
[02:21:46] <wikibugs>	 (CR) Eileen: "marked WIP while I performance test & test triggers etc" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518867 (https://phabricator.wikimedia.org/T170972) (owner: Eileen)
[02:22:13] <wikibugs>	 (PS1) Eileen: Add additional requested major gift fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518868
[02:22:28] <wikibugs>	 (CR) Eileen: "marked WIP while I performance test & test triggers etc" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518868 (owner: Eileen)
[02:24:35] <wikibugs>	 (CR) jerkins-bot: [V: -1] Add additional requested major gift fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518868 (owner: Eileen)
[02:30:16] <wikibugs>	 (PS1) Eileen: Add calculated fields to update script [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518870
[02:32:03] <wikibugs>	 (CR) jerkins-bot: [V: -1] Add calculated fields to update script [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518870 (owner: Eileen)
[02:58:09] <wikibugs>	 (CR) AndyRussG: [C: +2] "Yay!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/512430 (https://phabricator.wikimedia.org/T219342) (owner: Krinkle)
[02:58:53] <wikibugs>	 Fundraising Sprint It Came From Out of Scope, Fundraising Sprint James Bond: Licensed to Share, Fundraising Sprint King Kong vs. Mozilla, Fundraising Sprint Land before Timeouts, and 2 others: CentralNotice: Review incoming patches 2019-05 - https://phabricator.wikimedia.org/T222463 (AndyRussG)
[03:01:15] <wikibugs>	 Fundraising Sprint It Came From Out of Scope, Fundraising Sprint James Bond: Licensed to Share, Fundraising Sprint King Kong vs. Mozilla, Fundraising Sprint Land before Timeouts, and 2 others: CentralNotice: Review incoming patches 2019-05 - https://phabricator.wikimedia.org/T222463 (AndyRussG)
[03:01:41] <wikibugs>	 (Merged) jenkins-bot: Remove 'wgCentralNoticeCategoriesUsingLegacy' from page view HTML [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/512430 (https://phabricator.wikimedia.org/T219342) (owner: Krinkle)
[03:07:07] <wikibugs>	 (CR) jenkins-bot: Remove 'wgCentralNoticeCategoriesUsingLegacy' from page view HTML [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/512430 (https://phabricator.wikimedia.org/T219342) (owner: Krinkle)
[03:44:06] <wikibugs>	 (PS1) AndyRussG: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/518872
[03:44:40] <wikibugs>	 (CR) AndyRussG: [C: +2] Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/518872 (owner: AndyRussG)
[03:48:32] <wikibugs>	 (Merged) jenkins-bot: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/518872 (owner: AndyRussG)
[03:54:30] <wikibugs>	 (CR) jenkins-bot: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/518872 (owner: AndyRussG)
[05:39:54] <wikibugs>	 (CR) Raimond Spekking: [C: +2] "false positive" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/518560 (owner: L10n-bot)
[06:09:14] <wikibugs>	 (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510288 (https://phabricator.wikimedia.org/T160949) (owner: Eileen)
[10:12:54] <wikibugs>	 (PS1) Fomafix: Remove redundant closure for all packageFiles with own directory [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/518951 (https://phabricator.wikimedia.org/T50886)
[10:14:04] <wikibugs>	 (CR) Fomafix: "> @Fomafix, which closures?" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/512429 (owner: Krinkle)
[10:47:34] <wikibugs>	 (PS5) Amire80: Split apihelp messages to a separate file [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/509575 (https://phabricator.wikimedia.org/T189982)
[14:41:58] <wikibugs>	 (PS6) Ejegg: Variants starting with 'upsell' mean recurrable payment [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/514344 (https://phabricator.wikimedia.org/T216560)
[14:42:00] <wikibugs>	 (PS8) Ejegg: Add supportsRecurringUpsell and showRecurringUpsell [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/514351 (https://phabricator.wikimedia.org/T216560)
[14:42:02] <wikibugs>	 (PS5) Ejegg: Common base for result pages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/515246 (https://phabricator.wikimedia.org/T216562)
[14:42:04] <wikibugs>	 (PS5) Ejegg: Add 'variant' to session fields, add test [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/516454 (https://phabricator.wikimedia.org/T216562)
[14:42:06] <wikibugs>	 (PS4) Ejegg: Consult session for variant [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/517149 (https://phabricator.wikimedia.org/T216562)
[14:42:09] <wikibugs>	 (PS5) Ejegg: Move ui_modules handling to Mustache class [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/517150 (https://phabricator.wikimedia.org/T216562)
[14:42:11] <wikibugs>	 (PS12) Ejegg: Render recurring upsell (USD only) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/515114 (https://phabricator.wikimedia.org/T216562)
[14:52:10] <wikibugs>	 (PS5) Cstone: Adding India support with dlocal. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/518762 (https://phabricator.wikimedia.org/T224514)
[15:23:36] <ejegg>	 jgleeson: I added 4 queries to the botton of the list on the etherpad, each query looking at a specific field that could land someone on the unsubscribe list
[15:23:53] <jgleeson>	 thanks!
[15:24:09] <ejegg>	 but... running them turns up a very small number of contacts
[15:24:17] <jgleeson>	 :(
[15:24:25] <ejegg>	 so what else could be happening?
[15:24:36] <jgleeson>	 hmmm
[15:25:11] <ejegg>	 my first thought was deletions, or email addresses changing to be the same
[15:25:12] <jgleeson>	 I'm just gonna check my emails to see where I got up to getting access to the IBM console
[15:25:51] <ejegg>	 but since we use the logs to opt out any old email that's not on the opt-in list, that wouldn't do it
[15:27:53] <ejegg>	 hmm, I guess it could be new donations from people whose email address was in the logs, but not associated with a current donor
[15:28:21] <ejegg>	 that is, a person gave years ago with xxx@example.com
[15:28:22] <jgleeson>	 that many?
[15:28:35] <jgleeson>	 I would expect that maybe with a few hundred
[15:28:36] <ejegg>	 yeah, it's a stretch
[15:28:40] <jgleeson>	 but not the figures we're seeing
[15:28:55] <jgleeson>	 is it possible the file export is just incorrect
[15:28:56] <ejegg>	 shoot, we really need to see the specific addresses
[15:30:05] <ejegg>	 we can review the queries
[15:30:16] <jgleeson>	 I wonder if it cut short
[15:30:22] <ejegg>	 oh, let's see if the job logs say how many rows each file should have
[15:31:23] <ejegg>	 yes!
[15:31:54] <ejegg>	 ok, let's see if those numbers jibe with what the import logs on IBM's side are saying
[15:36:00] <ejegg>	 so in the p-c log archive dir on the civi host, i ran this:
[15:36:03] <ejegg>	 bzgrep -A1 'unsubscribe data' */silverpop_emails_build_export_files*
[15:37:13] <ejegg>	 and for the past month, it looks like every day the file is a little bit bigger
[15:38:22] <ejegg>	 shoot, though that doesn't cover May 16-18
[15:38:32] <ejegg>	 lessee, does frlog have p-c logs back that far?
[15:39:08] <jgleeson>	 looking also
[15:39:13] <ejegg>	 yes!
[15:40:33] <ejegg>	 ok, so it DOES show a drop
[15:41:02] <ejegg>	 but it's a drop from what looks like an artificially elevated number
[15:41:36] <ejegg>	 on 5/14 the count is 2249056, up a little bit from the day before
[15:41:46] <jgleeson>	 ah I see
[15:41:48] <ejegg>	 then on 5/15 it jumps to 2310926
[15:41:54] <jgleeson>	 hmm
[15:42:26] <ejegg>	 weird weird weird
[15:42:42] <ejegg>	 what happens with the other export file those three days?
[15:43:54] <ejegg>	 wow, it also jumps in size
[15:45:15] <ejegg>	 adds like 800k rows between 5/15 and 5/16
[15:45:19] <ejegg>	 what the heck?
[15:45:36] <ejegg>	 do we really have that many new contacts?
[15:45:45] <ejegg>	 some kind of import?
[15:47:26] <ejegg>	 jgleeson: select count(*) from civicrm_contact where created_date BETWEEN '2019-05-14' and '2019-05-20';
[15:49:11] <ejegg>	 also, look at 'sql queries' on https://frmon.frdev.wikimedia.org/d/Pq1YNMviz/fundraising-overview?orgId=1&from=1557827319373&to=1558367319373
[15:49:23] <ejegg>	 something big was happening that week
[15:52:00] <jgleeson>	 yeah
[15:52:13] <jgleeson>	 select DATE_FORMAT(created_date, "%c-%d-%Y"), count(*) from civicrm_contact where created_date BETWEEN '2019-05-14' and '2019-05-20' GROUP BY DATE_FORMAT(created_date, "%c-%d-%Y");
[15:53:05] <jgleeson>	 although would a surge in new accounts explain a declining subscriber rate?
[15:53:20] <jgleeson>	 unsubsriber rate*
[15:54:40] <ejegg>	 hmm, if they're new accounts with donations, and they have an email that was only on the unsub list due to NOT having a donation, that could do it
[15:55:34] <ejegg>	 ooh, but they don't seem to be from donations: select count(*) from civicrm_contribution where receive_date between '2019-05-14' and '2019-05-20';
[15:55:37] <jgleeson>	 although wouldn't we see these specific accounts moving from 0 to 1 for the flags we've identified in the log tables
[15:55:43] <ejegg>	 are these the 'remind me later' contacts?
[15:56:17] <ejegg>	 jgleeson the queries I did were for specific records going from 1 to 0
[15:56:35] <ejegg>	 while the silverpop export does its own merge by email
[15:57:48] <jgleeson>	 yeah donations drop off significantlt that period
[15:57:52] <jgleeson>	 significantly
[16:02:52] <ejegg>	 ok, looks like the new contacts are indeed remind-me-later imports
[16:04:03] <ejegg>	 so the surge in account creation ends on the 17th
[16:04:46] <ejegg>	 hmm
[16:07:27] <ejegg>	 ok, so the unsubs file had a temporary spike during those imports, but went back to normal when the imports finished
[16:07:59] <ejegg>	 could it be due to the new contacts being merged into existing contacts?
[16:09:25] <ejegg>	 hmm, can't imagine how, if the new contacts are mostly just email addresses
[16:09:32] <ejegg>	 so they wouldn't be merged on other data
[16:11:40] <jgleeson>	 hmmm
[16:11:55] <jgleeson>	 I've gotta go pickup oscar
[16:11:58] <jgleeson>	 back soon!
[16:12:18] <ejegg>	 oh hey
[16:12:31] <ejegg>	 It's the sheer volume
[16:12:40] <ejegg>	 we're not stopping the import while we calculate the exports
[16:13:06] <ejegg>	 and we do our selects for the include table a while before we do our selects for the excludes table
[16:13:18] <ejegg>	 let's see just how much before
[16:14:54] <ejegg>	 an hour and 47 minutes before
[16:15:11] <ejegg>	 and let's see how many contacts were imported during that hour and 47 minutes
[16:17:50] <ejegg>	 hmm, 50k for the import on 5/17
[16:18:47] <ejegg>	 that actually explains most of it!
[16:30:39] <wikibugs>	 Fundraising Sprint James Bond: Licensed to Share, Fundraising Sprint King Kong vs. Mozilla, Fundraising Sprint Land before Timeouts, Fundraising-Backlog, Patch-For-Review: SPIKE: Unsubscribes import decreasing in size over 2 days - https://phabricator.wikimedia.org/T223935 (Ejegg) I think I h...
[16:32:32] <dstrine>	 ejegg:  I just saw your update on the task. are we still messing up remind me later people or was this a one-time bug?
[16:35:08] <ejegg>	 dstrine: It'll happen again the next time we import 2 million ppl in 3 days :)
[16:35:32] <ejegg>	 But I think we've imported the whole existing backlog
[16:36:53] <ejegg>	 so, ppl still do land on the opt-out list for one day when they're created between about 6 am UTC and 7:50 am UTC
[16:37:09] <ejegg>	 then the next day they're on the normal export
[16:38:23] <dstrine>	 ejegg:  ok but that's not how we've been treating remind me later people right? We'll still have to fix this?
[16:38:28] <ejegg>	 we could shrink that window to 10 minutes just by reordering the query
[16:38:48] <ejegg>	 dstrine all those remind-me-later people are now being exported correctly
[16:39:25] <ejegg>	 it's just that we were importing so many during those three days that a large chunk fell into that time window and were on the wrong list for one day
[16:39:52] <dstrine>	 ah sorry I'm putting this together. It was due to the traget smart import or another import?
[16:40:05] <ejegg>	 remind-me-later imports
[16:40:24] <ejegg>	 target smart is all updates, but remind-me-later actually created 2 million new email-only contact records
[16:40:33] <ejegg>	 all over the course of 3 days
[16:40:53] <ejegg>	 the rate seems to have been highest on the 16th
[16:41:02] <dstrine>	 I'm confused at how we got so many over 3 days.
[16:41:17] <dstrine>	 we weren't running any big campaigns
[16:41:31] <dstrine>	 how else could that have happened?
[16:41:41] <ejegg>	 I think these were all ppl who added their email in IBM over the big english campaign
[16:41:51] <ejegg>	 and so ccogdill was able to email them to remind them later
[16:41:57] <ejegg>	 but we never had a record in civi
[16:42:18] <ejegg>	 untill eileen made the job to import them from IBM
[16:42:24] <dstrine>	 oooh so they hadn't been contacted until may. wow I didn't know that happened
[16:42:52] <ejegg>	 well, they existed in IBM, so presumably ccogdill was able to remind them while big english was still on
[16:42:53] <wikibugs>	 Fundraising-Backlog: remove or deactivate Casey Dentinger's civicrm user - https://phabricator.wikimedia.org/T226434 (Jgreen) >>! In T226434#5281020, @Eileenmcnaughton wrote: > boo  Indeed boo.
[16:43:09] <dstrine>	 ugh I feel like I keep getting confused. Eileen imported all these?
[16:43:19] <dstrine>	 I'm wondering if there was a task... looking
[16:43:21] <ejegg>	 yeah, let's see where the task is
[16:44:03] <ejegg>	 hmm, this is a related task: T222854
[16:44:03] <stashbot>	 T222854: Link mailing data to contacts imported from RML - https://phabricator.wikimedia.org/T222854
[16:44:41] <ejegg>	 T160949 seems to be it
[16:44:41] <stashbot>	 T160949: Import email-only contacts from 'remind me later' links into CiviCRM - https://phabricator.wikimedia.org/T160949
[16:45:37] <ejegg>	 yeah, comments in May correspond to the jump in civi records and the anomolous spike in unsubscribes
[16:47:41] <dstrine>	 ok cool. thanks
[16:54:52] <wikibugs>	 Fundraising Sprint James Bond: Licensed to Share, Fundraising Sprint King Kong vs. Mozilla, Fundraising Sprint Land before Timeouts, Fundraising-Backlog, Patch-For-Review: SPIKE: Unsubscribes import decreasing in size over 2 days - https://phabricator.wikimedia.org/T223935 (CCogdill_WMF) So d...
[16:58:15] <cstone>	 ejegg do I need to do something special to get the new logos to load on my local install, i can see them there in the files but they won't load in the browser
[16:59:03] <XenoRyet>	 cstone: You're on vagrant, right?
[16:59:20] <cstone>	 yeah
[16:59:21] <XenoRyet>	 The quick workaround is to put them in the main mediawiki folder as well, not just mediawiki-fr
[16:59:29] <cstone>	 ahh okay i think i remember that
[16:59:35] <XenoRyet>	 yea, it's that bug again.
[16:59:36] <cstone>	 thanks!
[17:00:40] <wikibugs>	 Fundraising Sprint James Bond: Licensed to Share, Fundraising Sprint King Kong vs. Mozilla, Fundraising Sprint Land before Timeouts, Fundraising-Backlog, Patch-For-Review: SPIKE: Unsubscribes import decreasing in size over 2 days - https://phabricator.wikimedia.org/T223935 (Ejegg) Oh darn! Th...
[17:10:41] <wikibugs>	 fundraising-tech-ops: replace backup4001 with a new machine at codfw named frbackup2001 - https://phabricator.wikimedia.org/T161903 (RobH)
[17:40:39] <wikibugs>	 (PS1) Ejegg: Fix mistaken opt-out of records created during export [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/519079 (https://phabricator.wikimedia.org/T223935)
[17:41:13] <wikibugs>	 (CR) jerkins-bot: [V: -1] Fix mistaken opt-out of records created during export [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/519079 (https://phabricator.wikimedia.org/T223935) (owner: Ejegg)
[17:42:42] <ejegg>	 oops
[17:43:26] <ejegg>	 ah, incomplete test setup
[17:44:42] <wikibugs>	 Fundraising-Backlog: Elliott: estimate old tasks - https://phabricator.wikimedia.org/T226548 (DStrine)
[17:45:02] <wikibugs>	 Fundraising Sprint Window dressing is mostly olive oil, Fundraising Sprint XML ate my homework, Fundraising-Backlog, FR-Ingenico, Patch-For-Review: Make an ingenicio variant with separate page instead of iframe - https://phabricator.wikimedia.org/T209413 (XenoRyet)
[17:46:02] <wikibugs>	 Fundraising Sprint Vestigial tails shoot from the hip, Fundraising-Backlog, FR-Ingenico, Patch-For-Review: Ingenico iframe sizing issue? - https://phabricator.wikimedia.org/T208351 (XenoRyet)
[17:47:29] <wikibugs>	 Fundraising-Backlog: Eileen: estimate old tasks - https://phabricator.wikimedia.org/T226549 (DStrine)
[17:48:32] <wikibugs>	 Fundraising-Backlog: Maggie: estimate old tasks - https://phabricator.wikimedia.org/T226550 (DStrine)
[17:49:24] <wikibugs>	 Fundraising-Backlog: Andy: estimate old tasks - https://phabricator.wikimedia.org/T226552 (DStrine)
[18:00:04] <wikibugs>	 (PS2) Ejegg: Fix mistaken opt-out of records created during export [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/519079 (https://phabricator.wikimedia.org/T223935)
[18:00:34] <wikibugs>	 (CR) jerkins-bot: [V: -1] Fix mistaken opt-out of records created during export [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/519079 (https://phabricator.wikimedia.org/T223935) (owner: Ejegg)
[18:11:10] <wikibugs>	 (PS3) Ejegg: Fix mistaken opt-out of records created during export [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/519079 (https://phabricator.wikimedia.org/T223935)
[18:11:42] <wikibugs>	 (CR) jerkins-bot: [V: -1] Fix mistaken opt-out of records created during export [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/519079 (https://phabricator.wikimedia.org/T223935) (owner: Ejegg)
[18:19:27] <wikibugs>	 Fundraising Sprint Land before Timeouts, Fundraising-Backlog, FR-dlocal, Epic: Create form for India in dlocal using new required fields - https://phabricator.wikimedia.org/T225639 (DStrine)
[18:26:56] <jgleeson>	 fr-tech the meet and greet with Rick Spencer is clashing with retro tonight for me, would it be ok just to have both sessions open?
[18:27:10] <jgleeson>	 I figure I won't be asking much in the meet & greet
[18:27:13] <mepps>	 ditto jgleeson i was just noticing that
[18:27:35] <wikibugs>	 (PS4) Ejegg: Fix mistaken opt-out of records created during export [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/519079 (https://phabricator.wikimedia.org/T223935)
[18:27:44] <jgleeson>	 nice work ejegg !
[18:27:49] <mepps>	 XenoRyet what are your thoughts? I was just going to skip retro but it's an issue if no one goes
[18:28:10] <XenoRyet>	 Given the offsite, the retro will probably be short.  We could just start after the meet and greet is over.
[18:28:44] <XenoRyet>	 Run a little long if necessary.
[18:28:53] <XenoRyet>	 That sound ok to everyone?  dstrine?
[18:30:21] <dstrine>	 XenoRyet:  well we really won't hav any time for retro then
[18:30:46] <dstrine>	 but I'm ok if we can all try our best to cram sprint planning into about 30 minutes
[18:31:51] <XenoRyet>	 I think I am ok with just skipping retro entirely this week, we did do a lot of retro-like stuff at the offsite.
[18:32:34] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Adding fields to Activity Search page - https://phabricator.wikimedia.org/T226560 (RLewis)
[18:32:35] <dstrine>	 ok
[18:32:46] <XenoRyet>	 I'll adjust the invite to the new start time.
[18:33:06] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Adding fields to Activity Search page - https://phabricator.wikimedia.org/T226560 (DStrine) a:DStrine→None
[18:34:19] <mepps>	 fr-tech there's also a meet & greet during standup tomorrow that i'll likely to go to, is anyone else going?
[18:34:46] <mepps>	 also did anyone go to the one for scott noteboom?
[18:35:07] <jgleeson>	 I'll have to attend the one that clashes with standup as the other timeslot is too late for me
[18:36:24] <XenoRyet>	 Moving standup tomorrow should be fine, yea?
[20:23:36] <wikibugs>	 Fundraising Sprint It Came From Out of Scope, Fundraising Sprint James Bond: Licensed to Share, Fundraising Sprint King Kong vs. Mozilla, Fundraising Sprint Land before Timeouts, and 2 others: Civi dedupe: CID range + lifetime$ possible to combine? - https://phabricator.wikimedia.org/T204878 (Eile...
[20:23:47] <wikibugs>	 Fundraising Sprint Hansel and grep -l, Fundraising Sprint It Came From Out of Scope, Fundraising Sprint James Bond: Licensed to Share, Fundraising Sprint King Kong vs. Mozilla, and 3 others: Civi dedupe: merge screen upgrades - https://phabricator.wikimedia.org/T217903 (Eileenmcnaughton) Open...
[20:24:00] <wikibugs>	 Fundraising Sprint Hansel and grep -l, Fundraising Sprint It Came From Out of Scope, Fundraising Sprint James Bond: Licensed to Share, Fundraising Sprint King Kong vs. Mozilla, and 3 others: Civi dedupe: URL generator for dedupe searches - https://phabricator.wikimedia.org/T217909 (Eileenmcnaughto...
[20:24:14] <wikibugs>	 Fundraising Sprint King Kong vs. Mozilla, Fundraising Sprint Land before Timeouts, Fundraising-Backlog, Fr-CiviCRM-dedupe-FY2017/18: Civi: Upgrade permissions level for DS agent - https://phabricator.wikimedia.org/T224314 (Eileenmcnaughton) Open→Resolved
[20:28:07] <wikibugs>	 Fundraising Sprint It Came From Out of Scope, Fundraising Sprint James Bond: Licensed to Share, Fundraising Sprint King Kong vs. Mozilla, Fundraising Sprint Land before Timeouts, and 2 others: CentralNotice: Review incoming patches 2019-05 - https://phabricator.wikimedia.org/T222463 (AndyRussG) ...
[20:28:40] <wikibugs>	 Fundraising Sprint Land before Timeouts, Fundraising-Backlog: re check ip velocity filter on api calls - https://phabricator.wikimedia.org/T225636 (DStrine) Open→Resolved
[20:28:47] <wikibugs>	 Fundraising Sprint Land before Timeouts, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice tests failing due to deprecated ResourceLoader constructor - https://phabricator.wikimedia.org/T225688 (AndyRussG) Open→Resolved
[20:28:56] <wikibugs>	 Fundraising-Backlog, FR-Email: List all emails that may have been mistakenly opted out - https://phabricator.wikimedia.org/T226571 (Ejegg)
[20:29:02] <wikibugs>	 Fundraising Sprint Land before Timeouts, Fundraising-Backlog: re check ip velocity filter on api calls - https://phabricator.wikimedia.org/T225636 (DStrine) We added some instrumentation that should help detect this the next time it happens.
[20:32:50] <wikibugs>	 Fundraising-Backlog: Epic: Tracking stats for opt-in page - https://phabricator.wikimedia.org/T225844 (DStrine)
[20:34:10] <wikibugs>	 Fundraising-Backlog: add tacking to opt in page - https://phabricator.wikimedia.org/T226572 (DStrine)
[20:34:25] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Create CiviCRM naming convention rule: In general, records should not begin with "The" - https://phabricator.wikimedia.org/T122592 (Eileenmcnaughton) @LeanneS @NNichols I think we can close this!
[20:35:17] <wikibugs>	 Fundraising-Backlog, FR-Email: List all emails that may have been mistakenly opted out - https://phabricator.wikimedia.org/T226571 (CCogdill_WMF) Thanks, @Ejegg!  A related question has been bumping around in my mind: which contacts *were* considered opted out and are no longer? I.e. were there *on hold*...
[20:36:07] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: [EPIC] dedupe exact matches - https://phabricator.wikimedia.org/T133807 (Eileenmcnaughton) Open→Resolved a:Eileenmcnaughton nothing left on this
[20:36:47] <wikibugs>	 Fundraising-Backlog: add tacking to opt in page - https://phabricator.wikimedia.org/T226572 (DStrine)
[20:37:14] <wikibugs>	 Fundraising-Backlog: add tacking to opt in page - https://phabricator.wikimedia.org/T226572 (CCogdill_WMF) Assuming 'the variant of the page' = utm_source, yes! In other words, we need to track our 3 main utms: utm_medium utm_campaign utm_source  In terms of priority, utm_source is all I really need to start...
[20:38:30] <wikibugs>	 Fundraising-Backlog: Andy: estimate old tasks - https://phabricator.wikimedia.org/T226552 (DStrine)
[20:38:39] <wikibugs>	 Fundraising-Backlog: Maggie: estimate old tasks - https://phabricator.wikimedia.org/T226550 (DStrine)
[20:38:45] <wikibugs>	 Fundraising-Backlog: Eileen: estimate old tasks - https://phabricator.wikimedia.org/T226549 (DStrine)
[20:38:54] <wikibugs>	 Fundraising-Backlog: Elliott: estimate old tasks - https://phabricator.wikimedia.org/T226548 (DStrine)
[20:43:39] <wikibugs>	 Fundraising-Backlog, fundraising Sprint M 2019: add tacking to opt in page - https://phabricator.wikimedia.org/T226572 (DStrine)
[20:43:41] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising Sprint M 2019: Adding fields to Activity Search page - https://phabricator.wikimedia.org/T226560 (DStrine)
[20:43:43] <wikibugs>	 Fundraising-Backlog, fundraising Sprint M 2019: Andy: estimate old tasks - https://phabricator.wikimedia.org/T226552 (DStrine)
[20:43:45] <wikibugs>	 Fundraising-Backlog, fundraising Sprint M 2019: Maggie: estimate old tasks - https://phabricator.wikimedia.org/T226550 (DStrine)
[20:43:47] <wikibugs>	 Fundraising-Backlog, fundraising Sprint M 2019: Eileen: estimate old tasks - https://phabricator.wikimedia.org/T226549 (DStrine)
[20:43:49] <wikibugs>	 Fundraising-Backlog, fundraising Sprint M 2019: Elliott: estimate old tasks - https://phabricator.wikimedia.org/T226548 (DStrine)
[20:43:51] <wikibugs>	 Fundraising-Backlog, fundraising Sprint M 2019, MediaWiki-extensions-CentralNotice: Review Campaign Fallback - https://phabricator.wikimedia.org/T226344 (DStrine)
[20:43:53] <wikibugs>	 Fundraising-Backlog, fundraising Sprint M 2019: remove or deactivate Casey Dentinger's civicrm user - https://phabricator.wikimedia.org/T226434 (DStrine)
[20:43:55] <wikibugs>	 Fundraising Sprint Land before Timeouts, Fundraising-Backlog, fundraising Sprint M 2019, FR-dlocal, Epic: Create form for India in dlocal using new required fields - https://phabricator.wikimedia.org/T225639 (DStrine)
[20:43:57] <wikibugs>	 Fundraising Sprint Land before Timeouts, Fundraising-Backlog, fundraising Sprint M 2019: Rename Field in IBM export - https://phabricator.wikimedia.org/T225544 (DStrine)
[20:43:59] <wikibugs>	 Fundraising Sprint Land before Timeouts, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising Sprint M 2019: Exporting list for TargetSmart - https://phabricator.wikimedia.org/T225446 (DStrine)
[20:44:02] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising Sprint M 2019: Civi: fredge query yielding '502 bad gateway' error - https://phabricator.wikimedia.org/T224742 (DStrine)
[20:44:03] <wikibugs>	 Fundraising Sprint King Kong vs. Mozilla, Fundraising Sprint Land before Timeouts, Fundraising-Backlog, fundraising Sprint M 2019, and 3 others: CentralNotice banner preview: follow-up improvements - https://phabricator.wikimedia.org/T225101 (DStrine)
[20:44:06] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising Sprint M 2019: Turn on Redis, Functional locks - https://phabricator.wikimedia.org/T222002 (DStrine)
[20:44:08] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising Sprint M 2019, FR-Civi-Planned-Giving, and 2 others: New total fields needed for MG prospecting - https://phabricator.wikimedia.org/T222958 (DStrine)
[20:44:10] <wikibugs>	 Fundraising Sprint Greps of Wrath, Fundraising Sprint Hansel and grep -l, Fundraising Sprint It Came From Out of Scope, Fundraising Sprint James Bond: Licensed to Share, and 5 others: Payments wiki form variant with employer field - https://phabricator.wikimedia.org/T219558 (DStrine)
[20:44:12] <wikibugs>	 Fundraising Sprint King Kong vs. Mozilla, Fundraising Sprint Land before Timeouts, Fundraising-Backlog, fundraising Sprint M 2019, FR-dlocal: Break out tasks for India form through dlocal - https://phabricator.wikimedia.org/T211155 (DStrine)
[20:44:14] <wikibugs>	 Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 13 others: Reduce recurring TY emails - https://phabricator.wikimedia.org/T213209 (DStrine)
[20:44:16] <wikibugs>	 Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Karma chameleons hide amongst us, Fundraising Sprint King Kong vs. Mozilla, and 17 others: New scripts to ingress data fro... - https://phabricator.wikimedia.org/T195594
[20:44:18] <wikibugs>	 Fundraising Sprint James Bond: Licensed to Share, Fundraising Sprint King Kong vs. Mozilla, Fundraising Sprint Land before Timeouts, Fundraising-Backlog, and 2 others: SPIKE: Unsubscribes import decreasing in size over 2 days - https://phabricator.wikimedia.org/T223935 (DStrine)
[20:44:20] <wikibugs>	 Fundraising Sprint King Kong vs. Mozilla, Fundraising Sprint Land before Timeouts, Fundraising-Backlog, fundraising Sprint M 2019, and 3 others: Implement Ingenico recurring up sell - https://phabricator.wikimedia.org/T216560 (DStrine)
[20:44:22] <wikibugs>	 Fundraising Sprint King Kong vs. Mozilla, Fundraising Sprint Land before Timeouts, Fundraising-Backlog, fundraising Sprint M 2019, and 3 others: Render recurring upsell on result switcher - https://phabricator.wikimedia.org/T216562 (DStrine)
[20:44:25] <wikibugs>	 Fundraising Sprint King Kong vs. Mozilla, Fundraising Sprint Land before Timeouts, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Add calendar year totals fields to CiviCRM & export ? some? of them to silverpop - https://phabricator.wikimedia.org/T170972 (DStrine)
[20:44:27] <wikibugs>	 Fundraising Sprint Land before Timeouts, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising Sprint M 2019, and 5 others: Add India-specific payment methods across our pipeline - https://phabricator.wikimedia.org/T224514 (DStrine)
[20:44:30] <wikibugs>	 Fundraising Sprint Lactose is unusually tolerant, Fundraising Sprint Land before Timeouts, Fundraising Sprint Matt Damon to head up Space Force, Fundraising Sprint Naming Sprints Is Not Important, and 10 others: Write a specification for mapping banner/land... - https://phabricator.wikimedia.org/T196563
[20:44:32] <wikibugs>	 Fundraising Sprint Lactose is unusually tolerant, Fundraising Sprint Land before Timeouts, Fundraising Sprint Matt Damon to head up Space Force, Fundraising Sprint Naming Sprints Is Not Important, and 10 others: DB schemas (production changes and test DB) a... - https://phabricator.wikimedia.org/T196564
[20:44:34] <wikibugs>	 Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Land before Timeouts, Fundraising Sprint Owls, and 12 others: Queries and maybe scripts to verify equivalence of data in n... - https://phabricator.wikimedia.org/T198752
[20:58:48] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Create CiviCRM naming convention rule: In general, records should not begin with "The" - https://phabricator.wikimedia.org/T122592 (NNichols) Yep!  Thanks Eileen
[21:09:12] <ejegg>	 hi fr-tech, does anyone have time to do some code review?
[21:09:16] <jgleeson>	 fr-tech, I'm gonna deploy the latest on master to civicrm. The list of what's been added vs what's on deployment currently is longer than usual so if you see anything that shouldn't go out, shout at me and I'll hold off. Here's a list of  the commits that will go out https://etherpad.wikimedia.org/p/sdfasdasdf
[21:09:45] <XenoRyet>	 ejegg:  What needs reviewing?
[21:09:49] <AndyRussG>	 ejegg: I could try some...
[21:10:17] <ejegg>	 XenoRyet: there's the stuff to get donors to convert to recurring
[21:10:34] <XenoRyet>	 Ok, I started looking at that a bit yesterday.  I'll keep going.
[21:10:39] <ejegg>	 and then there's this one to fix the issue with people being put on the unsubscribe list:
[21:10:54] <ejegg>	 https://gerrit.wikimedia.org/r/519079
[21:11:23] <ejegg>	 AndyRussG: ^^^ might be easier to review without needing a lot of context
[21:11:27] <ejegg>	 (or maybe not)
[21:12:22] <ejegg>	 AndyRussG: there's a slightly longer explanation here: https://phabricator.wikimedia.org/T223935#5283109
[21:14:22] <AndyRussG>	 ejegg: cool! thanks much, I'll take a look and will reach out if I'm very confused
[21:16:02] <ejegg>	 thanks so much!
[21:17:36] <ejegg>	 jgleeson: OK, so I see some build stuff, some of eileen's refactoring of old wmf_civicrm install functions, and a couple of little tweaks to the new de-duper
[21:17:54] <ejegg>	 plus cstone's patch to add new payment instruments for India
[21:18:06] <ejegg>	 all of that looks fine to deploy
[21:18:37] <jgleeson>	 thanks ejegg, I chatted through the stuff eileen added with her. All looks good to go. Thanks for the confirmation!
[21:20:28] <jgleeson>	 oh noes, gerrit is down
[21:20:29] <jgleeson>	 https://gerrit.wikimedia.org/r/
[21:21:16] <jgleeson>	 who'd be best to speak to? releng or operations
[21:21:45] <ejegg>	 I'd take a look in releng's channel to see if they're already talking about it
[21:22:03] <jgleeson>	 yeah looks like some talk a little earlier
[21:22:04] <ejegg>	 yep, looks like they're restarting it
[21:22:22] <jgleeson>	 back
[21:22:26] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops: Need SSL client certificate to access civi and dash - https://phabricator.wikimedia.org/T226211 (Jgreen) cert generated and sent
[21:22:45] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops: Need SSL client certificate to access civi and dash - https://phabricator.wikimedia.org/T226211 (Jgreen) p:Triage→Normal
[21:23:17] <wikibugs>	 (PS1) Jgleeson: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/519147
[21:23:40] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops: investigate which civi job is creating/deleting tables right during the nightly database backups - https://phabricator.wikimedia.org/T225022 (Jgreen) Something got adjusted (?) because the problem has ceased.
[21:25:14] <wikibugs>	 (CR) Jgleeson: [C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/519147 (owner: Jgleeson)
[21:25:54] <wikibugs>	 (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/519147 (owner: Jgleeson)
[21:30:26] <jgleeson>	 !log updating civicrm from 5c02e62d6e to 98fd34417d
[21:30:30] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log
[21:33:24] <wikibugs>	 Fundraising Sprint King Kong vs. Mozilla, Fundraising Sprint Land before Timeouts, Fundraising-Backlog, FR-dlocal: Break out tasks for India form through dlocal - https://phabricator.wikimedia.org/T211155 (DStrine) Open→Declined
[21:42:19] <wikibugs>	 Fundraising-Backlog, Continuous-Integration-Config: Phan job fails on CI for mediawiki/core fundraising/REL1_31 - https://phabricator.wikimedia.org/T226156 (Jgreen)
[21:45:09] <wikibugs>	 Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising Sprint Hansel and grep -l, Fundraising-Backlog, and 2 others: Search for name and org name in a 'the-agnositc way' in Civi - https://phabricator.wikimedia.org/T115536 (Eileenmcnaughton)
[21:45:10] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Create CiviCRM naming convention rule: In general, records should not begin with "The" - https://phabricator.wikimedia.org/T122592 (Eileenmcnaughton) Open→Resolved a:Eileenmcnaughton
[21:46:30] <wikibugs>	 Fundraising Sprint Men In Slack, Fundraising-Backlog: add tracking to opt in page - https://phabricator.wikimedia.org/T226572 (DStrine)
[21:57:39] <jgleeson>	 hmm interesting
[21:58:59] <jgleeson>	 I was just trying to find the donation spatton used to a few weeks back to test out the employer field variant and it looks like that account is marked as deleted so it won't show up on a report with civi. Is there a way to include contacts with 'is_deleted=1' via the UI?
[21:59:09] <jgleeson>	 fr-tech^
[22:00:06] <jgleeson>	 ideally I wanted to link Sam to a page saying "... and here's the report URL to you previous donation including an employer name"
[22:00:23] <jgleeson>	 I guess I could make my own test donation
[22:00:28] <jgleeson>	 yeah I'll do that
[22:02:46] <wikibugs>	 Fundraising-Backlog, FR-Email: List all emails that may have been mistakenly opted out - https://phabricator.wikimedia.org/T226571 (Ejegg) @CCogdill_WMF it occurs to me that the main nightly mailing list export includes everyone that should not be opted out.  The only issue I can see with using that list...
[22:03:07] <eileen>	 tech talk now?
[22:04:34] <wikibugs>	 Fundraising Sprint James Bond: Licensed to Share, Fundraising Sprint King Kong vs. Mozilla, Fundraising Sprint Land before Timeouts, Fundraising Sprint Men In Slack, and 2 others: SPIKE: Unsubscribes import decreasing in size over 2 days - https://phabricator.wikimedia.org/T223935 (DStrine) We ar...
[22:04:44] <ejegg>	 jgleeson did that contact get merged into another?
[22:05:05] <jgleeson>	 ah maybe
[22:05:21] <jgleeson>	 I already submitted a new donation which I'll use instead
[22:05:32] <ejegg>	 Oh dang, do merges nuke the org name on individual contacts because it's not supposed to be used?
[22:06:24] <jgleeson>	 it looks like the original org name is on the single deleted contact I can find
[22:07:15] <jgleeson>	 is there an is merged flag somewhere?
[22:07:31] <ejegg>	 jgleeson I think there's an activity with a link
[22:07:39] <eileen>	 ug that seems possible
[22:07:48] <ejegg>	 We talked about adding a link to the header
[22:07:56] <ejegg>	 but I don't think that happened
[22:08:14] <eileen>	 we can fix it so it doesn't lose it on merge but it's tricky code & if I go into that code I'd like to pull in related issues
[22:08:48] <jgleeson>	 I'm regretting my estimate on this piece of work...
[22:08:56] <jgleeson>	 dstrine, ^
[22:09:21] <dstrine>	 jgleeson:  lol which task?
[22:09:33] <dstrine>	 you can change it :)
[22:09:51] <jgleeson>	 employer field, it looks like contact merges lose employer names
[22:09:59] <jgleeson>	 is that what you mean eileen ejegg ?
[22:10:13] <jgleeson>	 employer names = organization_name
[22:10:36] <jgleeson>	 dstrine, the infinity symbol is feeling appropriate at this point
[22:10:37] <dstrine>	 ejegg:  eileen  jgleeson  I thought we were going to use a custom field just for this test?
[22:10:51] <ejegg>	 we're in the tech talk jgleeson
[22:10:56] <jgleeson>	 ah sorry
[22:11:07] <eileen>	 can discuss this issue in there jgleeson
[22:11:15] <jgleeson>	 sure will join
[22:11:25] <ejegg>	 dstrine for a minute it looked like eileen had a simple way to keep it in the field we already have it in
[22:11:29] <jgleeson>	 I don't have calendar invite for that one
[22:11:37] <ejegg>	 but it looks like there are more issue
[22:11:44] <ejegg>	 oh no!
[22:11:52] <ejegg>	 Ah, guess cause it's super late there
[22:12:03] <jgleeson>	 I can join for 5
[22:12:06] <wikibugs>	 Fundraising-Backlog, FR-Email: List all emails that may have been mistakenly opted out - https://phabricator.wikimedia.org/T226571 (CCogdill_WMF) Hmm, I guess I could do all of this with what we have in IBM. I could create a copy of the main database in silverpop and then purge all the people who have op...
[22:12:08] <jgleeson>	 if it's not interrupting
[22:13:31] <dstrine>	 ejegg:  eileen  let me know if you need feedback from me. We need to let the online team know either way if  this works or not
[22:13:51] <dstrine>	 they want to run a test tomorrow but we can tell them to hold off
[22:13:52] <eileen>	 ok dstrine
[22:14:24] <dstrine>	 I also have a hard stop in 45 minutes but I'll be on about 2 hours later
[22:18:06] <jgleeson>	 discussing now dstrine on call
[22:22:00] <wikibugs>	 Fundraising Sprint Land before Timeouts, Fundraising Sprint Men In Slack, Fundraising-Backlog, FR-dlocal, Epic: Create form for India in dlocal using new required fields - https://phabricator.wikimedia.org/T225639 (Ppena) UPDATE ON India TOS: Dlocal’s Legal team approved my mockup for the TOS...
[22:23:31] <jgleeson>	 dstrine, when do they wanna run it tomorrow?
[22:24:47] <dstrine>	 jgleeson:  15 utc
[22:42:22] <XenoRyet>	 dstrine: For the record, we're working on the fix in tech-talk now.
[22:43:24] <dstrine>	 ok thanks for the note. and if it's late for people and we really cant fix it we can just tell fr-online
[22:48:59] <wikibugs>	 (PS1) Jgleeson: Added support for mapping 'employer' value to civicrm custom field 'Employer_Name' [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/519151 (https://phabricator.wikimedia.org/T219558)
[22:52:50] <eileen>	 dstrine: we think we are oK for the one hour test tomorrow - there will be outstanding tasks but non-blocking
[22:53:15] <eileen>	 (ie transferring existing data, ensuring custom field is on dev envs, reloading triggers -)
[22:53:24] <eileen>	 & also possible report tweak
[22:54:01] <eileen>	 possible no existing data
[22:54:02] <wikibugs>	 (CR) jerkins-bot: [V: -1] Added support for mapping 'employer' value to civicrm custom field 'Employer_Name' [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/519151 (https://phabricator.wikimedia.org/T219558) (owner: Jgleeson)
[22:57:20] <wikibugs>	 (PS2) Jgleeson: Added support for mapping 'employer' value to civicrm custom field 'Employer_Name' [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/519151 (https://phabricator.wikimedia.org/T219558)
[22:57:52] <wikibugs>	 (PS3) Jgleeson: Added support for mapping 'employer' value to civicrm custom field 'Employer_Name' [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/519151 (https://phabricator.wikimedia.org/T219558)
[22:58:59] <dstrine>	 eileen:  so will they see the employer data in the civi ui? if so in which field?
[22:59:23] <eileen>	 new custom field 'Employer Name' under 'Communications'
[22:59:34] <dstrine>	 ok great, thanks!
[22:59:57] <eileen>	 for MG people Nora is probably gonna need to review their screen layout to put it in the right place
[23:00:19] <eileen>	 I think others have non-customised contact summaries so it will be in the custom field sections
[23:01:45] <eileen>	 dstrine: also we won't have logging enabled for the new field until we have an outage for ops to reload but I feel that's ok
[23:01:54] <dstrine>	 eileen:  ok great. this doesn't need to be the final version. If this is a good test, they will want to build this out more and have the donor select an employer from a list or something. so this won't be the final field
[23:02:47] <wikibugs>	 Fundraising Sprint Greps of Wrath, Fundraising Sprint Hansel and grep -l, Fundraising Sprint It Came From Out of Scope, Fundraising Sprint James Bond: Licensed to Share, and 6 others: Payments wiki form variant with employer field - https://phabricator.wikimedia.org/T219558 (Eileenmcnaughton) Fro...
[23:03:13] <eileen>	 Ok - we can see if the civi structure needs to change or not for that
[23:03:22] <dstrine>	 ok I gotta run. Thanks all!
[23:21:39] <wikibugs>	 Fundraising Sprint Greps of Wrath, Fundraising Sprint Hansel and grep -l, Fundraising Sprint It Came From Out of Scope, Fundraising Sprint James Bond: Licensed to Share, and 6 others: Payments wiki form variant with employer field - https://phabricator.wikimedia.org/T219558 (jgleeson) @Eileenmcna...
[23:26:09] <wikibugs>	 Fundraising Sprint Greps of Wrath, Fundraising Sprint Hansel and grep -l, Fundraising Sprint It Came From Out of Scope, Fundraising Sprint James Bond: Licensed to Share, and 6 others: Payments wiki form variant with employer field - https://phabricator.wikimedia.org/T219558 (Eileenmcnaughton) tha...